[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

labath added a comment. Do you need someone to commit this for you? (I can probably do that tomorrow) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119548/new/ https://reviews.llvm.org/D119548 ___ lldb-c

[Lldb-commits] [PATCH] D120100: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

labath added a comment. In D120100#3332433 , @JDevlieghere wrote: > In D120100#3331656 , @labath wrote: > >> I'm not sure how we ended up with the .i files in the first place, but maybe >> a good solution to thi

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

labath added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/debug_loc.s:28-29 # CHECK: Variable{{.*}}, name = "x0", {{.*}}, scope = parameter, location = # CHECK-NEXT: [0x, 0x0001): DW_OP_reg5 RDI # CHECK-NEXT: [0x00

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

serge-sans-paille added a comment. In D120195#943 , @MaskRay wrote: > It'd be good to test `-DLLVM_ENABLE_MODULES=on` build. Sure, I'll add that to my local test setup. > Some files get pure new headers. That's expected. It happens a lot when some

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

serge-sans-paille added a comment. In D120195#942 , @MaskRay wrote: > before: 1065515095 > after: 1065629059 > > An increase? Ooopsie, a typo :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12019

[Lldb-commits] [PATCH] D120101: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

clayborg added inline comments. Comment at: lldb/source/Commands/CommandObjectRegexCommand.h:47 + /// matched with replacements[1] and not replacements[0]. + static std::string SubstituteVariables( + llvm::StringRef input, clayborg wrote: > Do we want a "E

[Lldb-commits] [PATCH] D120101: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

clayborg added inline comments. Comment at: lldb/source/Commands/CommandObjectRegexCommand.h:47 + /// matched with replacements[1] and not replacements[0]. + static std::string SubstituteVariables( + llvm::StringRef input, Do we want a "Expected" as the re