[Lldb-commits] [PATCH] D119915: Replace use of double underscore in identifiers

shafik created this revision. shafik added reviewers: labath, aprantl. shafik requested review of this revision. Identifiers with `__` anywhere are reserved. I picked this up via the `bugprone-reserved-identifier` clang-tidy check but `-Wreserved-identifier` will also flag these uses as well.

[Lldb-commits] [PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

shafik added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4647 +const bool UsePointerValue) { + assert(CGM.getCodeGenOpts().hasReducedDebugInfo()); + assert(!LexicalBlockStack.empty() && "Region stack mismatch, s

[Lldb-commits] [PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

shafik updated this revision to Diff 409056. shafik marked 5 inline comments as done. shafik added a comment. Addressed comments on SmallVector size and fixed test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119178/new/ https://reviews.llvm.org/D119178 Files: clang/lib/CodeGen/CGD

[Lldb-commits] [PATCH] D119857: [lldb] Don't rely on unsigned integer wrapping in PutRawBytes and PutBytesAsRawHex8

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG920146316da1: [lldb] Don't rely on wrapping in PutRawBytes/PutBytesAsRawHex8 (authored by JDevlieghere). Herald added a project: LLDB. Repository:

[Lldb-commits] [lldb] 9201463 - [lldb] Don't rely on wrapping in PutRawBytes/PutBytesAsRawHex8

Author: Jonas Devlieghere Date: 2022-02-15T20:38:25-08:00 New Revision: 920146316da1e55017d46cfd62be783419da03d5 URL: https://github.com/llvm/llvm-project/commit/920146316da1e55017d46cfd62be783419da03d5 DIFF: https://github.com/llvm/llvm-project/commit/920146316da1e55017d46cfd62be783419da03d5.d

[Lldb-commits] [PATCH] D119857: [lldb] Don't rely on unsigned integer wrapping in PutRawBytes and PutBytesAsRawHex8

JDevlieghere updated this revision to Diff 409135. JDevlieghere added a comment. - Add unit test for edge case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119857/new/ https://reviews.llvm.org/D119857 Files: lldb/source/Utility/Stream.cpp lldb/unittests/Utility/StreamTest.cpp In

[Lldb-commits] [PATCH] D119857: [lldb] Don't rely on unsigned integer wrapping in PutRawBytes and PutBytesAsRawHex8

shafik added a comment. Do we have a test that covers this edge case? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119857/new/ https://reviews.llvm.org/D119857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

ilya-nozhkin updated this revision to Diff 409091. ilya-nozhkin edited the summary of this revision. ilya-nozhkin added a comment. Herald added a subscriber: mgrang. Implemented the approach suggested by @labath. I.e. now the target's hijacking listener is activated before `Process::Launch`. The

[Lldb-commits] [PATCH] D119831: [lldb] Add support for a "system-wide" lldbinit file

clayborg added a comment. This looks good to me. Just a few things to possibly think about: - Maybe we would want addition system init files for different workflows and then we would start lldb with a new option like "lldb --workflow qemu" and it would load the system ".lldbinit-qemu" init file

[Lldb-commits] [PATCH] D119857: [lldb] Don't rely on unsigned integer wrapping in PutRawBytes and PutBytesAsRawHex8

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119857/new/ https://reviews.llvm.org/D119857 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] b7e7a98 - [lldb] Check max_size before resizing DataBufferHeap

Author: Jonas Devlieghere Date: 2022-02-15T13:58:35-08:00 New Revision: b7e7a982e93db82ebd7fc08bb9614468f8c0e1e5 URL: https://github.com/llvm/llvm-project/commit/b7e7a982e93db82ebd7fc08bb9614468f8c0e1e5 DIFF: https://github.com/llvm/llvm-project/commit/b7e7a982e93db82ebd7fc08bb9614468f8c0e1e5.d

[Lldb-commits] [PATCH] D119831: [lldb] Add support for a "system-wide" lldbinit file

wallace added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:256 void SourceInitFileHome(CommandReturnObject &result, bool is_repl); + void SourceSystemInitFile(CommandReturnObject &result); JDevlieghere wrote: > `SourceInit

[Lldb-commits] [PATCH] D119797: Fix race condition when launching and attaching.

wallace added a comment. I agree with labath. Specially because I wouldn't like the user having aborted debug sessions if their setup takes longer than 10 seconds to get the process ready, which I imagine might happen with android or oculus devices using custom launch configs. What about using

[Lldb-commits] [PATCH] D119797: Fix race condition when launching and attaching.

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:545 + } + const useconds_t usleep_interval = 250 * 1; // 250 ms internal + const useconds_t count = (seconds * 1000 * 1000)/usleep_interval; Is this a typo? It should be 1000 i

[Lldb-commits] [PATCH] D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests

emaste added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90876/new/ https://reviews.llvm.org/D90876 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D119831: [lldb] Add support for a "system-wide" lldbinit file

jingham added a comment. LGTM. I agree with Jonas about keeping the naming consistent. I find it easier to spot the differentiating bits in a series of function names if they are at the beginning or the end, but that's a very mild preference. Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

jingham added a comment. In D119548#3321936 , @labath wrote: > In D119548#3321397 , @ilya-nozhkin > wrote: > >> In D119548#3321357 , @jingham >> wrote: >> >>> SBTarget.L

[Lldb-commits] [lldb] 6459fdf - [lldb] Fix uninitialized variable in EvaluateExpressionOptions

Author: Jonas Devlieghere Date: 2022-02-15T09:40:09-08:00 New Revision: 6459fdf9a8e9e8c2e06eaa42a6eda6079665c596 URL: https://github.com/llvm/llvm-project/commit/6459fdf9a8e9e8c2e06eaa42a6eda6079665c596 DIFF: https://github.com/llvm/llvm-project/commit/6459fdf9a8e9e8c2e06eaa42a6eda6079665c596.d

[Lldb-commits] [PATCH] D119857: [lldb] Don't rely on unsigned integer wrapping in PutRawBytes and PutBytesAsRawHex8

JDevlieghere added inline comments. Comment at: lldb/source/Utility/Stream.cpp:360 ByteDelta delta(*this); + if (src_byte_order == eByteOrderInvalid) Intentional newline for consistency with `Stream::PutRawBytes` above. CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D119857: [lldb] Don't rely on unsigned integer wrapping in PutRawBytes and PutBytesAsRawHex8

JDevlieghere created this revision. JDevlieghere added reviewers: labath, kastiglione, mib. JDevlieghere requested review of this revision. I was looking at `Stream::PutRawBytes` and thought I spotted a bug because both looks are using `i < src_len` as the loop condition despite them iterating "i

[Lldb-commits] [PATCH] D119831: [lldb] Add support for a "system-wide" lldbinit file

JDevlieghere added a comment. This is in line with the existing ways of sourcing init files in LLDB and has all the things we discussed in the RFC. I left few nits but this all looks good to me. I'll hold off on accepting so it continues to show up in the other reviewer's queue.

[Lldb-commits] [PATCH] D119723: Cleanup LLVMDWARFDebugInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG290e48234282: Cleanup LLVMDWARFDebugInfo (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D119723?vs=408418&id=4

[Lldb-commits] [PATCH] D119723: Cleanup LLVMDWARFDebugInfo

MaskRay accepted this revision. MaskRay added subscribers: hubert.reinterpretcast, Kai. MaskRay added a comment. This revision is now accepted and ready to land. > Plus llvm/Support/Errc.h not included by a bunch of > llvm/DebugInfo/DWARF/DWARF*.h files You may check whether we can just get rid

[Lldb-commits] [PATCH] D119831: [lldb] Add support for a "system-wide" lldbinit file

labath created this revision. labath added reviewers: JDevlieghere, jingham, clayborg, wallace. Herald added a subscriber: mgorny. labath requested review of this revision. Herald added a project: LLDB. This patch adds introduces a new kind of an lldbinit file. Unlike the lldbinit in the home dire

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

labath added a comment. In D119548#3321397 , @ilya-nozhkin wrote: > In D119548#3321357 , @jingham wrote: > >> SBTarget.Launch calls Target::Launch. That sets up a hijacker for the "stop >> at the first instruct

[Lldb-commits] [PATCH] D119797: Fix race condition when launching and attaching.

labath added a comment. Instead of polling, would it be possible for the event handler thread to send a notification (through a condition variable, std::future, etc.), and have the main thread wait for that? But in general, avoiding flipping the modes back and forth seems like a good idea.

[Lldb-commits] [lldb] 290e482 - Cleanup LLVMDWARFDebugInfo

Author: serge-sans-paille Date: 2022-02-15T09:16:03+01:00 New Revision: 290e482342826ee4c65bd6d2aece25736d3f0c7b URL: https://github.com/llvm/llvm-project/commit/290e482342826ee4c65bd6d2aece25736d3f0c7b DIFF: https://github.com/llvm/llvm-project/commit/290e482342826ee4c65bd6d2aece25736d3f0c7b.d

[Lldb-commits] [PATCH] D119046: Add a repeat command option for "thread backtrace --count N".

labath added a comment. I've fixed the synchronization code in f8d42c55ec6e9 . Based on my experiments, lldb reports still reports a stop reason for suspended threads (regardless of the platform), so the code should expect `c

[Lldb-commits] [lldb] f8d42c5 - [lldb] Fix thread syncrhonization TestThreadBacktraceRepeat

Author: Pavel Labath Date: 2022-02-15T08:58:39+01:00 New Revision: f8d42c55ec6e9c8778533d0b45bfa39753d0e63d URL: https://github.com/llvm/llvm-project/commit/f8d42c55ec6e9c8778533d0b45bfa39753d0e63d DIFF: https://github.com/llvm/llvm-project/commit/f8d42c55ec6e9c8778533d0b45bfa39753d0e63d.diff