[Lldb-commits] [PATCH] D118972: Increase preallocated buffer for scanning the process objc classes

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. lldb allocates a buffer in the inferior, and runs an expression to fill it with information

[Lldb-commits] [PATCH] D118953: [lldb] Improve RichManglingContext ergonomics (NFC)

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Nice, thanks! One of your patches will need to be rebased depending on which one goes in first (this one or https://reviews.llvm.org/D118814). CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Symbol/Symtab.cpp:388-389 // Only register functions that have a base name. rmc.ParseFunctionBaseName(); llvm::StringRef base_name = rmc.GetBufferRef(); if (base

[Lldb-commits] [PATCH] D118953: [lldb] Improve RichManglingContext ergonomics (NFC)

JDevlieghere created this revision. JDevlieghere added a reviewer: clayborg. JDevlieghere requested review of this revision. Have the different `::Parse.*` methods return the demangled string directly instead of having to go through `::GetBufferRef`. https://reviews.llvm.org/D118953 Files: l

[Lldb-commits] [lldb] 8682947 - [LLDB][NativePDB] terminal entry has lower precedence than new entry

Author: Zequan Wu Date: 2022-02-03T15:41:26-08:00 New Revision: 8682947d24e1f623fad30e1261e1a3de59a36f28 URL: https://github.com/llvm/llvm-project/commit/8682947d24e1f623fad30e1261e1a3de59a36f28 DIFF: https://github.com/llvm/llvm-project/commit/8682947d24e1f623fad30e1261e1a3de59a36f28.diff LOG

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

clayborg added a comment. LGTM if the RichManglingContext isn't actually demangling the string anyway, no need to force it to do so and cache the results. Comment at: lldb/source/Symbol/Symtab.cpp:388-389 // Only register functions that have a base name. rmc.ParseFunctio

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

zequanwu added a comment. In D118866#3294695 , @stella.stamenova wrote: > Thanks! > > It looks like there's a failure that was previously hidden by the unexpected > passes: > > https://lab.llvm.org/buildbot/#/builders/83/builds/14781 > > It seems like i

[Lldb-commits] [lldb] ac73e12 - [LLDB] remove an extra register enum on windows x64

Author: Zequan Wu Date: 2022-02-03T14:12:24-08:00 New Revision: ac73e12ee0ec9b6118def9150d490843047f58e0 URL: https://github.com/llvm/llvm-project/commit/ac73e12ee0ec9b6118def9150d490843047f58e0 DIFF: https://github.com/llvm/llvm-project/commit/ac73e12ee0ec9b6118def9150d490843047f58e0.diff LOG

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

stella.stamenova added a comment. Thanks! It looks like there's a failure that was previously hidden by the unexpected passes: https://lab.llvm.org/buildbot/#/builders/83/builds/14781 It seems like it's been in all of the previous builds as well, but it was not reported separately for some re

[Lldb-commits] [lldb] 607ffa5 - [LLDB] Fix window bot failure

Author: Zequan Wu Date: 2022-02-03T11:27:48-08:00 New Revision: 607ffa5515b9cd9c9c951dacbe4c403b52aa6bdb URL: https://github.com/llvm/llvm-project/commit/607ffa5515b9cd9c9c951dacbe4c403b52aa6bdb DIFF: https://github.com/llvm/llvm-project/commit/607ffa5515b9cd9c9c951dacbe4c403b52aa6bdb.diff LOG

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

This revision was automatically updated to reflect the committed changes. Closed by commit rG607ffa5515b9: [LLDB] Fix window bot failure (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118866/new/ https://reviews.llvm.org/D1188

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

stella.stamenova added inline comments. Comment at: lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py:46 @skipIfTargetAndroid() # debuggerd interferes with this test on Android @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr247

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

zequanwu added inline comments. Comment at: lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py:46 @skipIfTargetAndroid() # debuggerd interferes with this test on Android @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")

[Lldb-commits] [PATCH] D118866: [LLDB] Fix window bot failure

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM, I think there might be a couple more places to remove the xfail, but otherwise ship it! Comment at: lldb/test/API/functionalities/inferior-crashin

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

JDevlieghere updated this revision to Diff 405698. JDevlieghere added a comment. **Before** Memory usage: 280MB Benchmark 1: ./bin/lldb -n Slack -o quit Time (mean ± σ): 4.829 s ± 0.518 s[User: 4.012 s, System: 0.208 s] Range (min … max):4.624 s … 6.294 s10 runs **Af

[Lldb-commits] [lldb] 359a2de - [lldb] Fix windows&mac builds for c34698a811b13

Author: Pavel Labath Date: 2022-02-03T18:06:55+01:00 New Revision: 359a2deb6fc4a982bd513bc5fb3faeac0cb648ef URL: https://github.com/llvm/llvm-project/commit/359a2deb6fc4a982bd513bc5fb3faeac0cb648ef DIFF: https://github.com/llvm/llvm-project/commit/359a2deb6fc4a982bd513bc5fb3faeac0cb648ef.diff

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

JDevlieghere abandoned this revision. JDevlieghere added a comment. Thanks Pavel. I should've dug a little deeper in the rich mangling context. After giving it a second look I think you're absolutely right and we can drop this patch in favor of D118814 . CHANG

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

JDevlieghere updated this revision to Diff 405657. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. The symbol table index is the only caller to `DemangleWithRichManglingInfo`, so I removed the optional argument. Based on Pavel's observations in D118812

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

labath added a comment. In D118812#3292884 , @labath wrote: > And extracting the name this way will also save us from having to another > parse of the demangled name (to extract the base name), so it's double > goodness. I don't think the actual extract

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

labath added a comment. In D118812#3291109 , @dblaikie wrote: > (ie: what's the longest name that could be produced by a 10k long mangled > name? and see if that's worth having another cutoff for) I can create a 1MB demangled

[Lldb-commits] [PATCH] D118812: [lldb] Add a setting to skip long mangled names

labath added a comment. In D118812#3291954 , @JDevlieghere wrote: > In D118812#3291482 , @dblaikie > wrote: > >> In D118812#3291303 , @jingham >> wrote: >> >>> In D1188

[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

labath added a comment. I haven't been following the pointer authentication work very much, but I am somewhat surprised that this part is done in lldb-server. I would have expected that lldb would strip these tags before the address makes it's way over here (I'm pretty sure it needs to do that