[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 added a comment. In D117928#3262874 , @jingham wrote: > Ah, I think your confusion is that you missed the “Remote” part of all the > classes in lldb that start with “GDB”. They are so called because they use > the “gdb remote serial protocol” t

[Lldb-commits] [PATCH] D117259: [lldb] Allow aliases to aliases of raw input commands

This revision was automatically updated to reflect the committed changes. Closed by commit rGb95150418fb6: [lldb] Allow aliases to aliases of raw input commands (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117259/new/ htt

[Lldb-commits] [lldb] b951504 - [lldb] Allow aliases to aliases of raw input commands

Author: Dave Lee Date: 2022-01-21T17:57:34-08:00 New Revision: b95150418fb6e2d22a0bd84abcdc1f3cc7e5a0bf URL: https://github.com/llvm/llvm-project/commit/b95150418fb6e2d22a0bd84abcdc1f3cc7e5a0bf DIFF: https://github.com/llvm/llvm-project/commit/b95150418fb6e2d22a0bd84abcdc1f3cc7e5a0bf.diff LOG:

[Lldb-commits] [PATCH] D117259: [lldb] Allow aliases to aliases of raw input commands

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. What an excellent test! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117259/new/ https://reviews.llvm.org/D117259

[Lldb-commits] [PATCH] D117259: [lldb] Allow aliases to aliases of raw input commands

kastiglione updated this revision to Diff 402143. kastiglione edited the summary of this revision. kastiglione added a comment. use Jim's testing improvement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117259/new/ https://reviews.llvm.org/D117259

Re: [Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

Ah, I think your confusion is that you missed the “Remote” part of all the classes in lldb that start with “GDB”. They are so called because they use the “gdb remote serial protocol” to communicate with the debug monitor, not because they have anything to do with gdb the debugger. That’s a pr

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 added a comment. In D117928#3262710 , @jingham wrote: > I guess we're just all confused that you are mentioning GDB at all, and the > only thing I could think of is gdbserver, since that's the only way anything > GDB could get mixed with anything

[Lldb-commits] [PATCH] D117259: [lldb] Allow aliases to aliases of raw input commands

jingham added a comment. That tests that we made the alias, but not that it actually works. If you did something like: command alias start_with_two expr -- 2 command alias add_two start_with_two + then add_two 3 should produce 5, which would be easy to test for. Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D117259: [lldb] Allow aliases to aliases to command-regex

kastiglione updated this revision to Diff 402132. kastiglione added a comment. add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117259/new/ https://reviews.llvm.org/D117259 Files: lldb/source/Commands/CommandObjectCommands.cpp lldb/tes

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

mgorny added a comment. I'm sorry but I don't understand what you're talking about. Could you explain how are you running tests? Is there some way we can reproduce the problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117928/new/ https://revi

[Lldb-commits] [lldb] 58ee14e - [lldb] Fix timer logging inverted quiet condition

Author: Dave Lee Date: 2022-01-21T15:34:07-08:00 New Revision: 58ee14e29e98384bba6d2e1c1789b7f8e3060d24 URL: https://github.com/llvm/llvm-project/commit/58ee14e29e98384bba6d2e1c1789b7f8e3060d24 DIFF: https://github.com/llvm/llvm-project/commit/58ee14e29e98384bba6d2e1c1789b7f8e3060d24.diff LOG:

[Lldb-commits] [PATCH] D117837: [lldb] Fix timer logging inverted quiet condition

This revision was automatically updated to reflect the committed changes. Closed by commit rG58ee14e29e98: [lldb] Fix timer logging inverted quiet condition (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117837/new/ https:/

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

jingham added a comment. In D117928#3262708 , @ljmf00 wrote: > In D117928#3262689 , @jingham wrote: > >> In D117928#3262656 , @JDevlieghere >> wrote: >> >>> Why are we di

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 added a comment. In D117928#3262689 , @jingham wrote: > In D117928#3262656 , @JDevlieghere > wrote: > >> Why are we disabling a lldb test because of a bug in GDB? > > Maybe somebody is running the lldb tes

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 added a comment. In D117928#3262656 , @JDevlieghere wrote: > Why are we disabling a lldb test because of a bug in GDB? Because GDB is used on systems that don't implement a `RegisterContext`. I added an inline comment about Darwin and Windows XF

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

jingham added a comment. In D117928#3262656 , @JDevlieghere wrote: > Why are we disabling a lldb test because of a bug in GDB? Maybe somebody is running the lldb testsuite with gdbserver? If so, we should make an xfail category for gdbserver and xfail

[Lldb-commits] [PATCH] D117707: [lldb] [Platform] Support synthesizing siginfo_t

mgorny updated this revision to Diff 402116. mgorny added a comment. Implemented FreeBSD. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117707/new/ https://reviews.llvm.org/D117707 Files: lldb/bindings/interface/SBPlatform.i lldb/include/lldb/API/SBPlatform.h lldb/include/lldb/AP

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

JDevlieghere added a comment. Why are we disabling a lldb test because of a bug in GDB? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117928/new/ https://reviews.llvm.org/D117928 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D117707: [lldb] [Platform] Support synthesizing siginfo_t

mgorny updated this revision to Diff 402113. mgorny added a comment. Add tests for FreeBSD (no implementation yet). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117707/new/ https://reviews.llvm.org/D117707 Files: lldb/bindings/interface/SBPlatform.i lldb/include/lldb/API/SBPlatfor

[Lldb-commits] [PATCH] D117707: [lldb] [Platform] Support synthesizing siginfo_t

mgorny updated this revision to Diff 402110. mgorny added a comment. Turn `PlatformLinuxTest` into a more generic `PlatformSiginfoTest`, to improve code reuse between platforms. Start preparing for testing FreeBSD. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117707/new/ https://revie

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 added inline comments. Comment at: lldb/test/Shell/Register/x86-mm-xmm-write.test:1-2 # XFAIL: system-darwin # XFAIL: system-windows + Maybe those XFAILs are related to this too. Can anyone test this on those systems, if you have a CPU with AVX extensio

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 created this revision. ljmf00 added a project: LLDB. Herald added subscribers: JDevlieghere, pengfei. ljmf00 requested review of this revision. Herald added a subscriber: lldb-commits. This patch disables the following tests on non-AVX machines: - `lldb-shell :: Register/x86-64-write.test`

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

JDevlieghere updated this revision to Diff 402104. JDevlieghere added a comment. "memory": { "strings": { "bytesTotal": 3145728, "bytesUnused": 1088812, "bytesUsed": 2056916 } }, CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117914/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

JDevlieghere added a comment. In D117914#3262467 , @kastiglione wrote: > I find "Unallocated" ambiguous. To the Allocator, maybe it's not, but to VM > it is. What about Total/Used/Unused? Note that the docs for `BytesAllocated` > say it can be used to

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

kastiglione added a comment. I find "Unallocated" ambiguous. To the Allocator, maybe it's not, but to VM it is. What about Total/UsedUnused? Note that the docs for `BytesAllocated` say it can be used to calculated "wasted" space. /// How many bytes we've allocated. /// /// Used so that we

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

JDevlieghere updated this revision to Diff 402093. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. Put string statistics under memory: "memory": { "strings": { "bytesAllocated": 2056916, "bytesTotal": 3145728, "bytesUnallocated": 1088812 }

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

JDevlieghere added inline comments. Comment at: lldb/source/Target/Statistics.cpp:228 {"modules", std::move(json_modules)}, + {"strings", string_stats.ToJSON()}, {"totalSymbolTableParseTime", symtab_parse_time}, clayborg wrote: > "constStrings"

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

clayborg added a comment. I do like the direction of this patch BTW! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117490/new/ https://reviews.llvm.org/D117490 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

clayborg added inline comments. Comment at: lldb/include/lldb/Utility/Log.h:57 + /// }; + using MaskType = uint32_t; + JDevlieghere wrote: > Didn't this all start with Greg wanting to make this a `uint64_t`? yes, uint64_t please! Comment at:

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

clayborg added inline comments. Comment at: lldb/include/lldb/Utility/ConstString.h:415-416 +size_t GetBytesWasted() const { return total_memory - bytes_allocated; } +size_t total_memory; +size_t bytes_allocated; + }; CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

clayborg added inline comments. Comment at: lldb/source/Target/Statistics.cpp:72 + obj.try_emplace("bytesAllocated", stats.GetBytesAllocated()); + obj.try_emplace("bytesWasted", stats.GetBytesWasted()); + return obj; Maybe "bytesUnallocated" instead of "bytesW

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. nice CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117914/new/ https://reviews.llvm.org/D117914 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/ConstString.h:409 /// in memory. static size_t StaticMemorySize(); I purposely didn't use this function for the reasons explained in the summary. It seems like a few classes im

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, labath. JDevlieghere requested review of this revision. Add statistics about the memory usage of the string pool. I'm particularly interested in the memory used by the allocator, i.e. the number of bytes actually used by

[Lldb-commits] [PATCH] D117707: [lldb] [Platform] Support synthesizing siginfo_t

mgorny updated this revision to Diff 402055. mgorny added a comment. Update following instrumentation changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117707/new/ https://reviews.llvm.org/D117707 Files: lldb/bindings/interface/SBPlatform.i lldb/include/lldb/API/SBPlatform.h

[Lldb-commits] [PATCH] D117707: [lldb] [Platform] Support synthesizing siginfo_t

mgorny updated this revision to Diff 402043. mgorny added a comment. Simplify the tests to use dotted member notation for field lookup. Make the test utility generate exact test code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117707/new/ https://reviews.llvm.org/D117707 Files: l

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

shafik added a comment. This is a nice refactor, I am curious was there a motivating bug or issue for this change or just refactoring? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117490/new/ https://reviews.llvm.org/D117490

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/Log.h:57 + /// }; + using MaskType = uint32_t; + Didn't this all start with Greg wanting to make this a `uint64_t`? Comment at: lldb/include/lldb/Utility/Logging.h:19-5

[Lldb-commits] [lldb] e9211e0 - Remove dependency from raw_ostream on

Author: serge-sans-paille Date: 2022-01-21T15:17:39+01:00 New Revision: e9211e03937751ab75bbb34e38acc330b85fb0d8 URL: https://github.com/llvm/llvm-project/commit/e9211e03937751ab75bbb34e38acc330b85fb0d8 DIFF: https://github.com/llvm/llvm-project/commit/e9211e03937751ab75bbb34e38acc330b85fb0d8.d

[Lldb-commits] [lldb] 75e164f - [llvm] Cleanup header dependencies in ADT and Support

Author: serge-sans-paille Date: 2022-01-21T13:54:49+01:00 New Revision: 75e164f61d391979b4829bf2746a5d74b94e95f2 URL: https://github.com/llvm/llvm-project/commit/75e164f61d391979b4829bf2746a5d74b94e95f2 DIFF: https://github.com/llvm/llvm-project/commit/75e164f61d391979b4829bf2746a5d74b94e95f2.d

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger updated this revision to Diff 401947. lassefolger added a comment. rebase patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114627/new/ https://reviews.llvm.org/D114627 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Sym

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

labath marked 4 inline comments as done. labath added a comment. This should be ready for a full review now. Comment at: lldb/include/lldb/Utility/Logging.h:15 -// Log Bits specific to logging in lldb -#define LIBLLDB_LOG_PROCESS (1u << 1) -#define LIBLLDB_LOG_THREAD (1u << 2)

[Lldb-commits] [PATCH] D117490: [lldb] Log prototype

labath updated this revision to Diff 401909. labath added a comment. Herald added a subscriber: emaste. Do this for real Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117490/new/ https://reviews.llvm.org/D117490 Files: lldb/include/lldb/Interpre

[Lldb-commits] [PATCH] D117299: [lldb] Ignore non-address bits in "memory find" arguments

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/test/API/linux/aarch64/tagged_memory_access/TestAArch64LinuxTaggedMemoryAccess.py:83 +# Then that the location found does not display the tag bits. +self.assertN

[Lldb-commits] [PATCH] D117299: [lldb] Ignore non-address bits in "memory find" arguments

DavidSpickett updated this revision to Diff 401904. DavidSpickett added a comment. Fix "to to" in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117299/new/ https://reviews.llvm.org/D117299 Files: lldb/source/Commands/CommandObjectMemory