[Lldb-commits] [lldb] e69a3d1 - [lldb] [gdb-remote] Support client fallback for servers without reg defs

Author: Michał Górny Date: 2022-01-17T22:31:49+01:00 New Revision: e69a3d18f48bc0d81b5dd12e735a2ec898ce64d4 URL: https://github.com/llvm/llvm-project/commit/e69a3d18f48bc0d81b5dd12e735a2ec898ce64d4 DIFF: https://github.com/llvm/llvm-project/commit/e69a3d18f48bc0d81b5dd12e735a2ec898ce64d4.diff

[Lldb-commits] [PATCH] D116896: [lldb] [gdb-remote] Support client fallback for servers without reg defs

This revision was automatically updated to reflect the committed changes. Closed by commit rGe69a3d18f48b: [lldb] [gdb-remote] Support client fallback for servers without reg defs (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D117490: [lldb] Log prototype

labath created this revision. labath requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D117490 Files: lldb/include/lldb/Interpreter/ScriptedInterface.h lldb/include/lldb/Uti

[Lldb-commits] [PATCH] D117474: [lldb] Make StatsDuration thread-safe

labath created this revision. labath added a reviewer: clayborg. Herald added a subscriber: arphaman. labath requested review of this revision. Herald added a project: LLDB. std::chrono::duration types are not thread-safe, and they cannot be concurrently updated from multiple threads. Currently, w

[Lldb-commits] [PATCH] D117076: [lldb/Plugins] Fix ScriptedThread IndexID reporting

labath added a comment. That is a step in the right direction, but ideally we shouldn't by introducing new functions with double return values (value in the "real" result + error through a by-ref argument, or vice versa). We have llvm::Expected for that, and (thread id issue aside) this is actu

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

labath added a comment. Unifying the two paths by making turning the other reference into an owned one is a step in the right direction, but it is not enough, as StructuredPythonObject expects a *borrowed* reference. So, instead of fixing things, you've made both code paths leak. :) I've creat

[Lldb-commits] [PATCH] D117462: [lldb/python] Use PythonObject in LLDBSwigPython functions

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:284 +return StructuredData::ObjectSP(new StructuredPythonObject( +PythonObject(PyRefType::Borrowed, m_py_obj))); } fixed a leak here ===

[Lldb-commits] [PATCH] D117462: [lldb/python] Use PythonObject in LLDBSwigPython functions

labath created this revision. labath added reviewers: JDevlieghere, mib. labath requested review of this revision. Herald added a project: LLDB. Return our PythonObject wrappers instead of raw PyObjects (obfuscated as void *). This ensures that ownership (reference counts) of python objects is aut

[Lldb-commits] [PATCH] D114722: [LLDB] Fix Python GIL-not-held issues

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6598575f4bc: [LLDB] Fix Python GIL-not-held issues (authored by rwgk, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114722/new/ https

[Lldb-commits] [lldb] a659857 - [LLDB] Fix Python GIL-not-held issues

Author: Ralf Grosse-Kunstleve Date: 2022-01-17T10:32:19+01:00 New Revision: a6598575f4bc20f9a01c2bced2d0b1ff14d7576f URL: https://github.com/llvm/llvm-project/commit/a6598575f4bc20f9a01c2bced2d0b1ff14d7576f DIFF: https://github.com/llvm/llvm-project/commit/a6598575f4bc20f9a01c2bced2d0b1ff14d757