[Lldb-commits] [PATCH] D117259: [lldb] Allow aliases to aliases to command-regex

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Should this have a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117259/new/ https://reviews.llvm.org/D117259 ___

[Lldb-commits] [PATCH] D116853: [CMake][LLDB] Resolve install conflict when `LLDB_BUILD_FRAMEWORK=ON`

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks reasonable. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116853/new/ https://reviews.llvm.org/D116853 ___ lldb-co

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1441ffe6a6da: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom (authored by kastiglione). Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [lldb] 1441ffe - [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

Author: Dave Lee Date: 2022-01-13T16:37:49-08:00 New Revision: 1441ffe6a6da90e9c4800914eb0005b1087aa5d2 URL: https://github.com/llvm/llvm-project/commit/1441ffe6a6da90e9c4800914eb0005b1087aa5d2 DIFF: https://github.com/llvm/llvm-project/commit/1441ffe6a6da90e9c4800914eb0005b1087aa5d2.diff LOG:

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione marked 2 inline comments as done. kastiglione added a comment. thanks @clayborg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117237/new/ https://reviews.llvm.org/D117237 ___ lldb-commits mai

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione updated this revision to Diff 399835. kastiglione added a comment. add @clayborg's improvements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117237/new/ https://reviews.llvm.org/D117237 Files: lldb/docs/use/python-reference.rst ll

[Lldb-commits] [PATCH] D117259: [lldb] Allow aliases to aliases to command-regex

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a subscriber: jeroen.dobbelaere. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Allow users to create aliases which invoke aliases to comman

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rZORG38ab06456f73: [lldb] Run the test suite in verbose mode (authored by JDevlieghere). Herald added a reviewer: gkistanova. Repository: rZORG LLVM

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

This revision was automatically updated to reflect the committed changes. Closed by commit rG049ae93097c0: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D104886?vs=399390&id=399810#toc Reposi

[Lldb-commits] [lldb] 049ae93 - [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

Author: Jonas Devlieghere Date: 2022-01-13T15:27:38-08:00 New Revision: 049ae93097c0c6f7cef6294f16c7f6de9138cd6d URL: https://github.com/llvm/llvm-project/commit/049ae93097c0c6f7cef6294f16c7f6de9138cd6d DIFF: https://github.com/llvm/llvm-project/commit/049ae93097c0c6f7cef6294f16c7f6de9138cd6d.d

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

clayborg added inline comments. Comment at: lldb/docs/use/python-reference.rst:598 if __name__ == '__main__': # Create a new debugger instance in your module if your module # can be run from the command line. When we run a script from We need to

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

mib marked 3 inline comments as done. mib added a comment. In D117071#3241300 , @labath wrote: > Continuing the discussion from the other patch, I've made some comments about > who I think owns various objects going around in this patch. They should be

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

mib marked 9 inline comments as done. mib added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:49 + void *instance_obj = nullptr; + if (script_object) labath wrote: > This is when things start to get fuzzy, as this functi

[Lldb-commits] [lldb] f00cd23 - Revert "Revert "[LLDB][NativePDB] Add support for inlined functions""

Author: Zequan Wu Date: 2022-01-13T14:00:24-08:00 New Revision: f00cd23caed5f920495bcae2055f4c478d8383d6 URL: https://github.com/llvm/llvm-project/commit/f00cd23caed5f920495bcae2055f4c478d8383d6 DIFF: https://github.com/llvm/llvm-project/commit/f00cd23caed5f920495bcae2055f4c478d8383d6.diff LOG

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

JDevlieghere accepted this revision. JDevlieghere added a comment. Ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117237/new/ https://reviews.llvm.org/D117237 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117237/new/ https://reviews.llvm.org/D117237 _

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104886/new/ https://reviews.llvm.org/D104886 ___ lldb-commits mail

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb5ea132d2ee: [lldb] Add long help to `crashlog` (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117165/new/ https://reviews.llvm.o

[Lldb-commits] [lldb] cb5ea13 - [lldb] Add long help to `crashlog`

Author: Dave Lee Date: 2022-01-13T11:09:40-08:00 New Revision: cb5ea132d2eee8f83207633794256939dd8d8082 URL: https://github.com/llvm/llvm-project/commit/cb5ea132d2eee8f83207633794256939dd8d8082 DIFF: https://github.com/llvm/llvm-project/commit/cb5ea132d2eee8f83207633794256939dd8d8082.diff LOG:

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione added inline comments. Comment at: lldb/docs/use/python-reference.rst:586 the module is loaded allowing you to add whatever commands you want into the -current debugger. Note that this function will only be run when using the LLDB -command command script import, it w

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione updated this revision to Diff 399731. kastiglione added a comment. updates from reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117237/new/ https://reviews.llvm.org/D117237 Files: lldb/docs/use/python-reference.rst lldb/exa

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione updated this revision to Diff 399729. kastiglione added a comment. restore `if __name__ == '__main__'` example Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117237/new/ https://reviews.llvm.org/D117237 Files: lldb/docs/use/python-ref

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

labath added a comment. Continuing the discussion from the other patch, I've made some comments about who I think owns various objects going around in this patch. They should be read in the control-flow order (which happens to coincide with how they appear in the source code), not in the order

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

JDevlieghere added inline comments. Comment at: lldb/docs/use/python-reference.rst:586 the module is loaded allowing you to add whatever commands you want into the -current debugger. Note that this function will only be run when using the LLDB -command command script import, it

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione added inline comments. Comment at: lldb/docs/use/python-reference.rst:586 the module is loaded allowing you to add whatever commands you want into the -current debugger. Note that this function will only be run when using the LLDB -command command script import, it w

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione updated this revision to Diff 399724. kastiglione added a comment. fix a few more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117237/new/ https://reviews.llvm.org/D117237 Files: lldb/docs/use/python-reference.rst lldb/examples/da

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

jingham added inline comments. Comment at: lldb/docs/use/python-reference.rst:586 the module is loaded allowing you to add whatever commands you want into the -current debugger. Note that this function will only be run when using the LLDB -command command script import, it will

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

kastiglione created this revision. kastiglione added reviewers: jingham, JDevlieghere, clayborg. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Update examples and docs to demonstrate using `__lldb_init_module` instead of the i

[Lldb-commits] [PATCH] D117139: [lldb] Copy ScriptedInterface object instance to a new StructuredData object

labath added a comment. Yes, you can't "turn" a void* into a shared_ptr because the shared pointer would not know how to delete the pointed object. However, you can create a pointer which is /aliased/ to a void* and use that for something. That said, I am (still) not sure if that is what you r

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

JDevlieghere accepted this revision. JDevlieghere added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117165/new/ https://reviews.llvm.org/D117165 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117165/new/ https://reviews.llvm.org/D117165 _

[Lldb-commits] [PATCH] D117139: [lldb] Copy ScriptedInterface object instance to a new StructuredData object

mib added a comment. > I've never considered that 🤯 I'll update D117071 > to turn the `void*` into > `std::shared_ptr`. I tried doing that (see attached patch below) but it doesn't work because even though the `StructuredData::Generic` is created with a `PyOb

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:1236-1240 +def __lldb_init_module(debugger, internal_dict): +debugger.HandleCommand( +'command script add -c lldb.macosx.crashlog.Symbolicate crashlog') +debugger.HandleCommand(

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

kastiglione added a comment. > Can you see if also adding a "get_short_help" gets rid of that dopey: Good call, it worked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117165/new/ https://reviews.llvm.org/D117165

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

kastiglione updated this revision to Diff 399701. kastiglione added a comment. Add get_short_help, and add missing changes that should have been part of original diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117165/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

stella.stamenova added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:73 +#if defined(_WIN32) +// Don't mess with the signal handlers on Windows. Were these not used on Windows at all before? CHANGES SIN

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

mib added a comment. In D117071#3238816 , @JDevlieghere wrote: > Never thought I'd ask someone to merge two patches, but I think it might make > reviewing easier if you merge D117139 into > this patch. :-) Done ^^ >

[Lldb-commits] [PATCH] D117139: [lldb] Copy ScriptedInterface object instance to a new StructuredData object

mib added a comment. In D117139#3240631 , @labath wrote: > In D117139#3240564 , @mib wrote: > >> In D117139#3240436 , @labath wrote: >> >>> I'd like to remind everyone of

[Lldb-commits] [PATCH] D117139: [lldb] Copy ScriptedInterface object instance to a new StructuredData object

labath added a comment. In D117139#3240564 , @mib wrote: > In D117139#3240436 , @labath wrote: > >> I'd like to remind everyone of a not-very-widely-known, but incredibly nifty >> feature of std::shared_ptr, call

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

mib updated this revision to Diff 399662. mib edited the summary of this revision. mib added a comment. Address @JDevlieghere comment by merging D117139 into D117071 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] cf7bfd6 - [lldb][AArch64] Remove armv8.3-a flag from tagged memory read test

Author: David Spickett Date: 2022-01-13T14:25:18Z New Revision: cf7bfd6d059e58263594858e21b5547acabae568 URL: https://github.com/llvm/llvm-project/commit/cf7bfd6d059e58263594858e21b5547acabae568 DIFF: https://github.com/llvm/llvm-project/commit/cf7bfd6d059e58263594858e21b5547acabae568.diff LOG

[Lldb-commits] [PATCH] D117139: [lldb] Copy ScriptedInterface object instance to a new StructuredData object

mib abandoned this revision. mib added a comment. Following @JDevlieghere's request, the patch will be merged with D117071 since it makes more sense to have both changes together. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett updated this revision to Diff 399654. DavidSpickett added a comment. - Fix bug where the previous end address was checked for non-address bits even when the user gave a new address. - Added testing for that situation. - Added a comment to explain that non-address bits in the start/b

[Lldb-commits] [PATCH] D117139: [lldb] Copy ScriptedInterface object instance to a new StructuredData object

mib added a comment. In D117139#3240436 , @labath wrote: > I'd like to remind everyone of a not-very-widely-known, but incredibly nifty > feature of std::shared_ptr, called "aliasing". It allows one to create a > shared_ptr which points to one object, b

[Lldb-commits] [PATCH] D117139: [lldb] Copy ScriptedInterface object instance to a new StructuredData object

labath added a comment. I'd like to remind everyone of a not-very-widely-known, but incredibly nifty feature of std::shared_ptr, called "aliasing". It allows one to create a shared_ptr which points to one object, but deletes a completely different object when it goes out of scope. It works like

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett added inline comments. Comment at: lldb/source/Target/Process.cpp:5891 + // is at or beyond the end of mappable memory. + !(abi && (abi->FixDataAddress(range_end) != range_end))); DavidSpickett wrote: > omjavaid wrote: > > Just to confir

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett added inline comments. Comment at: lldb/source/Target/Process.cpp:5891 + // is at or beyond the end of mappable memory. + !(abi && (abi->FixDataAddress(range_end) != range_end))); omjavaid wrote: > Just to confirm this assumes range base

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1668 +if (argc > 1 || (argc == 0 && load_addr == LLDB_INVALID_ADDRESS) || +(abi && (abi->FixDataAddress(load_addr) != load_addr))) { result.AppendErrorWithFormat("'%s'

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e74e5e9e3b9: [lldb] [llgs] Implement qXfer:siginfo:read (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[Lldb-commits] [lldb] 1e74e5e - [lldb] [llgs] Implement qXfer:siginfo:read

Author: Michał Górny Date: 2022-01-13T11:24:36+01:00 New Revision: 1e74e5e9e3b903af568de834deab29fa342c665a URL: https://github.com/llvm/llvm-project/commit/1e74e5e9e3b903af568de834deab29fa342c665a DIFF: https://github.com/llvm/llvm-project/commit/1e74e5e9e3b903af568de834deab29fa342c665a.diff

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1987 +NativeProcessLinux::GetSiginfo() const { + siginfo_t siginfo; + Status error = GetSignalInfo

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/MemoryTagMap.h:29 + /// Non-null pointer to a memory tag manager. + MemoryTagMap(const MemoryTagManager *manager); + JDevlieghere wrote: > If the pointer should be non-null, then shou