[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

jingham added a comment. If adding the short help doesn't fix this, I'm fine with this change as is. We can go down the getting rid of that placeholder rabbit hole at some other time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117165/new/ http

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

jingham added a comment. Oops, forgot to include the "why requesting changes..." Can you see if also adding a "get_short_help" gets rid of that dopey: For more information run 'help crashlog' Expects 'raw' input (see 'help raw-input'.) line? It's getting added as the placeholder text in Co

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

jingham requested changes to this revision. jingham added inline comments. This revision now requires changes to proceed. Comment at: lldb/examples/python/crashlog.py:1236-1240 +def __lldb_init_module(debugger, internal_dict): +debugger.HandleCommand( +'command script

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:1236-1240 +def __lldb_init_module(debugger, internal_dict): +debugger.HandleCommand( +'command script add -c lldb.macosx.crashlog.Symbolicate crashlog') +debugger.HandleCommand(

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

kastiglione updated this revision to Diff 399517. kastiglione added a comment. refer to the debugger parameter, not lldb.debugger Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117165/new/ https://reviews.llvm.org/D117165 Files: lldb/examples/pyt

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

omjavaid added a comment. Apologies for late response!!! Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1668 +if (argc > 1 || (argc == 0 && load_addr == LLDB_INVALID_ADDRESS) || +(abi && (abi->FixDataAddress(load_addr) != load_addr))) { result.Appen

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

kastiglione added a comment. Herald added a subscriber: JDevlieghere. The output of `help crashlog` is: (lldb) help crashlog For more information run 'help crashlog' Expects 'raw' input (see 'help raw-input'.) Syntax: crashlog Usage: crashlog [options] [FILE ...] Symbolicate o

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Convert the `crashlog` command to be implemented as a class. The `Symbolicate` function is switched to a c

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1987 +NativeProcessLinux::GetSiginfo() const { + siginfo_t siginfo; + Status error = GetSignalInfo(GetCurrentThreadID(), &siginfo); labath wrote: > I'd be better

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

mgorny updated this revision to Diff 399478. mgorny marked 4 inline comments as done. mgorny added a comment. Implemented the requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117113/new/ https://reviews.llvm.org/D117113 Files: lldb/include/lldb/Host/common/NativeProce

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

JDevlieghere added a comment. Never thought I'd ask someone to merge two patches, but I think it might make reviewing easier if you merge D117139 into this patch. :-) If I understand the patch correctly, you're getting the underlying `PyObject` out of the `Py

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/MemoryTagMap.h:29 + /// Non-null pointer to a memory tag manager. + MemoryTagMap(const MemoryTagManager *manager); + If the pointer should be non-null, then should this take a referenc

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

mib added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:51 + if (script_object) +instance_obj = script_object->GetValue(); + Instead of re-assigning `m_script_object_sp` with `script_object` directly, we get the python

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

mib updated this revision to Diff 399426. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117071/new/ https://reviews.llvm.org/D117071 Files: lldb/examples/python/scripted_process/scripted_process.py lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp lldb/source/Plugins/Process

[Lldb-commits] [lldb] 1f53dd1 - [CODE OWNERS] Add wallace as code owner

Author: Walter Erquinigo Date: 2022-01-12T12:36:30-08:00 New Revision: 1f53dd1f23870a27123c50f4fe955e9c31a19634 URL: https://github.com/llvm/llvm-project/commit/1f53dd1f23870a27123c50f4fe955e9c31a19634 DIFF: https://github.com/llvm/llvm-project/commit/1f53dd1f23870a27123c50f4fe955e9c31a19634.di

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

mib updated this revision to Diff 399413. mib added a reviewer: labath. mib added a comment. Update after abandoning D117065 for D117139 . To create the ScriptedThread, we pass a `StructuredData::Object*` that contains a borr

[Lldb-commits] [PATCH] D117065: [lldb/Plugins] Fix ScriptedInterface object ptr use-after-free

mib abandoned this revision. mib added a comment. Abandoning this in favor of D117139 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117065/new/ https://reviews.llvm.org/D117065 __

[Lldb-commits] [PATCH] D117139: [lldb] Copy ScriptedInterface object instance to a new StructuredData object

mib created this revision. mib added reviewers: labath, JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds the ability to pass a pointer of a script object instance to initialize a ScriptedInterface instead of ha

[Lldb-commits] [PATCH] D117070: [lldb/Plugins] Move ScriptedThreadInterface to ScriptedThread

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I was slightly confused by the description, but IIUC this moves the interface into the scripted thread instance. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D117068: [lldb/Plugins] Add ScriptedProcess::GetThreadsInfo interface

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks straightforward. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117068/new/ https://reviews.llvm.org/D117068 ___

[Lldb-commits] [PATCH] D117065: [lldb/Plugins] Fix ScriptedInterface object ptr use-after-free

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedThreadPythonInterface.cpp:54 + m_object_instance = static_cast( + new StructuredPythonObject(ret_val)); labath wrote: > labath wrote: > > This doesn't so

[Lldb-commits] [PATCH] D114722: [LLDB] Fix Python GIL-not-held issues

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:277-285 + if (_Py_IsFinalizing()) { +// Leak m_py_obj rather than

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

JDevlieghere updated this revision to Diff 399390. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104886/new/ https://reviews.llvm.org/D104886 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp lldb/test/API/iohandler/sigint/TestIOHandlerPythonREPLSigint.p

[Lldb-commits] [lldb] 8fec756 - [lldb] Disable one more watchpoint test on Windows

Author: Stella Stamenova Date: 2022-01-12T08:55:48-08:00 New Revision: 8fec756c0b54f8720b746b103ac277b5a153dff7 URL: https://github.com/llvm/llvm-project/commit/8fec756c0b54f8720b746b103ac277b5a153dff7 DIFF: https://github.com/llvm/llvm-project/commit/8fec756c0b54f8720b746b103ac277b5a153dff7.di

[Lldb-commits] [lldb] 10bc336 - Revert "[LLDB][NativePDB] Add support for inlined functions"

Author: Stella Stamenova Date: 2022-01-12T08:53:19-08:00 New Revision: 10bc3362a1a8a3df2660bf65db0ec1ccab646e1b URL: https://github.com/llvm/llvm-project/commit/10bc3362a1a8a3df2660bf65db0ec1ccab646e1b DIFF: https://github.com/llvm/llvm-project/commit/10bc3362a1a8a3df2660bf65db0ec1ccab646e1b.di

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

labath added inline comments. Comment at: lldb/include/lldb/Host/common/NativeProcessProtocol.h:195-198 + virtual llvm::Expected> + GetSiginfo() const { +return llvm::make_error(); + } I think it would be more natural/consistent to have this function on a

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

mib added a subscriber: labath. mib added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:332 +lldb::ThreadSP thread_sp = +std::make_shared(*this, error, *val->GetAsGeneric()); + @labath This is why I switched to

[Lldb-commits] [PATCH] D117103: [lldb] [Process/FreeBSD] Set current thread ID on events

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a1ce35d7e7f: [lldb] [Process/FreeBSD] Set current thread ID on events (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [lldb] 9a1ce35 - [lldb] [Process/FreeBSD] Set current thread ID on events

Author: Michał Górny Date: 2022-01-12T15:40:13+01:00 New Revision: 9a1ce35d7e7fdfa6d45fb24abc3ad30e8eb6c6f4 URL: https://github.com/llvm/llvm-project/commit/9a1ce35d7e7fdfa6d45fb24abc3ad30e8eb6c6f4 DIFF: https://github.com/llvm/llvm-project/commit/9a1ce35d7e7fdfa6d45fb24abc3ad30e8eb6c6f4.diff

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. Implement the qXfer:siginfo:read that is used to read the siginfo_t (extended signal information) for the current thread. This is cu

[Lldb-commits] [PATCH] D115662: [lldb][DWARF] Remove duplicate DIE type assignment

labath added a comment. I am sorry for the delay. This is quite messy so it took me a while to form an opinion on this. I think option one would be the best choice. Doing it there means the these would get set in a central place (that is still fairly near the place where the type is being const

[Lldb-commits] [PATCH] D117065: [lldb/Plugins] Fix ScriptedInterface object ptr use-after-free

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedThreadPythonInterface.cpp:54 + m_object_instance = static_cast( + new StructuredPythonObject(ret_val)); labath wrote: > This doesn't sound right. This object (

[Lldb-commits] [PATCH] D114722: [LLDB] Fix Python GIL-not-held issues

labath updated this revision to Diff 399302. labath added a comment. This just fixes the style issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114722/new/ https://reviews.llvm.org/D114722 Files: lldb/source/Plugins/ScriptInterpreter/Python

[Lldb-commits] [PATCH] D114722: [LLDB] Fix Python GIL-not-held issues

labath commandeered this revision. labath edited reviewers, added: rupprecht; removed: labath. labath added a reviewer: mib. labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:277-285 + if (_Py_IsFinalizing()) { +

[Lldb-commits] [PATCH] D117103: [lldb] [Process/FreeBSD] Set current thread ID on events

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LG, though I wouldn't say this is just "convenience". I'd say this is the expected behaviour, and it just happens that the lldb client does not mind if we do not do that. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D117103: [lldb] [Process/FreeBSD] Set current thread ID on events

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Set the current thread ID to the thread where an event happened. As a result, e.g. when a signal is delivered to a thread other than the first one, the respective T packet r

[Lldb-commits] [lldb] 3fd9c90 - [lldb][AArch64] Correct top nibble setting in memory tag read tests

Author: David Spickett Date: 2022-01-12T12:28:13Z New Revision: 3fd9c90bdc04df451d9bb348450b5ad424c822c6 URL: https://github.com/llvm/llvm-project/commit/3fd9c90bdc04df451d9bb348450b5ad424c822c6 DIFF: https://github.com/llvm/llvm-project/commit/3fd9c90bdc04df451d9bb348450b5ad424c822c6.diff LOG

[Lldb-commits] [PATCH] D117076: [lldb/Plugins] Fix ScriptedThread IndexID reporting

labath added a comment. It seems to me like the ScriptedThread class would benefit from using the fallible constructor idiom. If you move all the potentially failing operations (initialization of the ScriptedThreadInterface instance?) into a (public) `static Expected Create(...)` method, then t

[Lldb-commits] [PATCH] D117065: [lldb/Plugins] Fix ScriptedInterface object ptr use-after-free

labath requested changes to this revision. labath added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedThreadPythonInterface.cpp:54 + m_object_instance = static_cast( + new StructuredPythonOb

[Lldb-commits] [PATCH] D107140: [lldb] Add option to show memory tags in memory read output

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107140/new/ https://reviews.llvm.org/D107140 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

DavidSpickett marked 2 inline comments as done. DavidSpickett added a comment. ping! Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:160 + // we must use an untagged address. + MemoryRegionInfo::RangeType range(RemoveNonAddressBits(addr), len);

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112825/new/ https://reviews.llvm.org/D112825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D117004: [lldb] Don't print "Command Options Usage:" for an alias with no options

This revision was automatically updated to reflect the committed changes. Closed by commit rG091e760cd398: [lldb] Don't print "Command Options Usage:" for an alias with no options (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] 091e760 - [lldb] Don't print "Command Options Usage:" for an alias with no options

Author: David Spickett Date: 2022-01-12T10:07:38Z New Revision: 091e760cd39848f3c41900b5104b3d92028d91b4 URL: https://github.com/llvm/llvm-project/commit/091e760cd39848f3c41900b5104b3d92028d91b4 DIFF: https://github.com/llvm/llvm-project/commit/091e760cd39848f3c41900b5104b3d92028d91b4.diff LOG

[Lldb-commits] [PATCH] D117004: [lldb] Don't print "Command Options Usage:" for an alias with no options

DavidSpickett added a comment. > I also think this function is pretty confusing to read. Enough that I decided not to attempt to unpick it for this bug! I also wondered how the quit command actually worked so thanks for solving that mystery. I'll go with this as is but if I get a chance I'll tr