[Lldb-commits] [lldb] 51fd157 - Remove duplicate forward declarations (NFC)

2022-01-08 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2022-01-08T11:56:42-08:00 New Revision: 51fd157635e11f7024dedf1d3a2a4c173f718b76 URL: https://github.com/llvm/llvm-project/commit/51fd157635e11f7024dedf1d3a2a4c173f718b76 DIFF: https://github.com/llvm/llvm-project/commit/51fd157635e11f7024dedf1d3a2a4c173f718b76.diff L

[Lldb-commits] [PATCH] D116863: [lldb] Remove anon struct from frame-var-anon-unions test

2022-01-08 Thread Dave Lee via Phabricator via lldb-commits
kastiglione updated this revision to Diff 398349. kastiglione added a comment. once more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116863/new/ https://reviews.llvm.org/D116863 Files: lldb/test/API/lang/cpp/frame-var-anon-unions/TestFrameVar

[Lldb-commits] [PATCH] D116863: [lldb] Remove anon struct from frame-var-anon-unions test

2022-01-08 Thread Dave Lee via Phabricator via lldb-commits
kastiglione updated this revision to Diff 398348. kastiglione added a comment. clarify commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116863/new/ https://reviews.llvm.org/D116863 Files: lldb/test/API/lang/cpp/frame-var-anon-unions

[Lldb-commits] [PATCH] D116863: [lldb] Remove anon struct from frame-var-anon-unions test

2022-01-08 Thread Dave Lee via Phabricator via lldb-commits
kastiglione created this revision. kastiglione added reviewers: JDevlieghere, jingham, aprantl. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test for anonymous unions seems off. It tests the following: union { //

[Lldb-commits] [lldb] 930f3c6 - Revert "[lldb] Set result error state in 'frame variable'"

2022-01-08 Thread Dave Lee via lldb-commits
Author: Dave Lee Date: 2022-01-08T09:35:13-08:00 New Revision: 930f3c625e0277c4a28e66f79df7d8ad0de258e5 URL: https://github.com/llvm/llvm-project/commit/930f3c625e0277c4a28e66f79df7d8ad0de258e5 DIFF: https://github.com/llvm/llvm-project/commit/930f3c625e0277c4a28e66f79df7d8ad0de258e5.diff LOG:

[Lldb-commits] [PATCH] D116461: [lldb] Remove ProcessStructReader from NSStringSummaryProvider (NFC)

2022-01-08 Thread Dave Lee via Phabricator via lldb-commits
kastiglione updated this revision to Diff 398341. kastiglione added a comment. give name to synthetic child Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116461/new/ https://reviews.llvm.org/D116461 Files: lldb/source/Plugins/Language/ObjC/NSStr

[Lldb-commits] [PATCH] D116461: [lldb] Remove ProcessStructReader from NSStringSummaryProvider (NFC)

2022-01-08 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added a comment. To add more context, `ProcessStructReader` is used in only a few places, and none seem like they should truly need it. This was a low hanging fruit. Something I don't understand about this code is why it the objc metadata is incomplete. The class is known, but not i

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

2022-01-08 Thread Dave Lee via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2c7d10c41278: [lldb] Set result error state in 'frame variable' (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116788/new/ https:/

[Lldb-commits] [lldb] 2c7d10c - [lldb] Set result error state in 'frame variable'

2022-01-08 Thread Dave Lee via lldb-commits
Author: Dave Lee Date: 2022-01-08T08:50:17-08:00 New Revision: 2c7d10c41278181e3e45c68f28b501cd95193a8a URL: https://github.com/llvm/llvm-project/commit/2c7d10c41278181e3e45c68f28b501cd95193a8a DIFF: https://github.com/llvm/llvm-project/commit/2c7d10c41278181e3e45c68f28b501cd95193a8a.diff LOG: