[Lldb-commits] [PATCH] D116625: [lldb] [debugserver] Simplify handling of arch specific files

mstorsjo created this revision. mstorsjo added reviewers: labath, JDevlieghere, jasonmolenda, clayborg. Herald added subscribers: kristof.beyls, mgorny. mstorsjo requested review of this revision. Herald added a project: LLDB. There are no duplicates among the include files, and all the source fil

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5b6e30ed3ac: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115

[Lldb-commits] [lldb] d5b6e30 - [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

Author: Zequan Wu Date: 2022-01-04T13:50:24-08:00 New Revision: d5b6e30ed3acad794dd0aec400e617daffc6cc3d URL: https://github.com/llvm/llvm-project/commit/d5b6e30ed3acad794dd0aec400e617daffc6cc3d DIFF: https://github.com/llvm/llvm-project/commit/d5b6e30ed3acad794dd0aec400e617daffc6cc3d.diff LOG

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115062/new/ https://reviews.llvm.org/D115062 ___

Re: [Lldb-commits] [lldb] ee4b462 - [lldb] Fix a warning

Hi Shafik, Let's loop in Saleem here, the author of f1585a4b47cc9c08c9a4c10058597f4b7468c227. Do we need to worry about a case where ReadPointerFromMemory, called at PlatformWindows.cpp:379, returns LLDB_INVALID_ADDRESS without setting status to Fail? I am guessing that could theoretically happe

[Lldb-commits] [PATCH] D116547: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

david-salinas created this revision. Herald added subscribers: luke957, abrachet, ormris, foad, dang, jdoerfert, phosek, kerbowa, usaxena95, pengfei, s.egerton, asbirlea, mstorsjo, lebedev.ri, kadircet, rupprecht, arphaman, steven_wu, mgrang, simoncook, fedor.sergeev, hiraditya, krytarowski, ari

[Lldb-commits] [PATCH] D116547: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

smeenai requested changes to this revision. smeenai added a comment. This revision now requires changes to proceed. Herald added a subscriber: JDevlieghere. This doesn't seem like a correct revert. What command are you using to generate this? `git revert` is what you should be using, e.g. git

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 marked 4 inline comments as done. Ericson2314 added inline comments. Comment at: llvm/CMakeLists.txt:75 set(LLVM_ENABLE_PROJECTS "" CACHE STRING - "Semicolon-separated list of projects to build (${LLVM_KNOWN_PROJECTS}), or \"all\".") + "Semicolon-separated l

[Lldb-commits] [PATCH] D116224: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

ldionne commandeered this revision. ldionne added a reviewer: david-salinas. ldionne added a comment. Yeah, I think you messed something up with your git commands. I'm going to commandeer and abandon this revision to get it out of the libc++ review queue since it's been 10 days since this has be

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396972. Ericson2314 added a comment. Remove off topic bits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: llvm/CMakeLists.txt llvm/cmake/modules/AddLL

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396872. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is used

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

mstorsjo added inline comments. Comment at: llvm/CMakeLists.txt:75 set(LLVM_ENABLE_PROJECTS "" CACHE STRING - "Semicolon-separated list of projects to build (${LLVM_KNOWN_PROJECTS}), or \"all\".") + "Semicolon-separated list of projects to build (${LLVM_KNOWN_PROJECTS})

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396846. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is used

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 marked 2 inline comments as done. Ericson2314 added a comment. Mark some old threads done. Comment at: llvm/cmake/modules/CMakeLists.txt:3 -set(LLVM_INSTALL_PACKAGE_DIR lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm) +set(LLVM_INSTALL_PACKAGE_DIR lib${LLVM_LIBDIR_SUFFIX}/cma

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396831. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is used

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396825. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is used

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396824. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is used

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 reopened this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. I guess reopening is the better way to redo after revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.ll

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396822. Ericson2314 added a comment. Big rebase and cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: llvm/CMakeLists.txt llvm/cmake/modules/AddL

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

Quuxplusone added inline comments. Comment at: libcxx/docs/index.rst:220 * `libc++abi Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `libcxx-commits Mailing List`_ -

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

MaskRay added inline comments. Comment at: libcxx/docs/index.rst:220 * `libc++abi Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `libcxx-commits Mailing List`_ -

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ksyx added inline comments. Comment at: libcxx/docs/index.rst:220 * `libc++abi Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `libcxx-commits Mailing List`_

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

MaskRay added inline comments. Comment at: lld/docs/_templates/indexsidebar.html:3-4 lld bugs should be reported at the - LLVM https://bugs.llvm.org/";>Bugzilla. + LLVM https://github.com/llvm/llvm-project/issues/";>Issues. ChuanqiXu wrote: > MaskRay wrote:

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu updated this revision to Diff 396737. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Drop the change in lld. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clan

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu added inline comments. Comment at: llvm/utils/gn/secondary/clang/include/clang/Config/BUILD.gn:10 output = "$target_gen_dir/config.h" values = [ +"BUG_REPORT_URL=https://github.com/llvm/llvm-project/issues/";, xbolva00 wrote: > This url should

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:539 -To report bugs, please visit . +To report bugs, please visit . -

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

xbolva00 added inline comments. Comment at: llvm/utils/gn/secondary/clang/include/clang/Config/BUILD.gn:10 output = "$target_gen_dir/config.h" values = [ +"BUG_REPORT_URL=https://github.com/llvm/llvm-project/issues/";, This url should redirect to github

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

MaskRay added inline comments. Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:539 -To report bugs, please visit . +To report bugs, please visit . https://github.com/llvm/llvm-project/l

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu marked 14 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/www/c_status.html:75-76 -The https://bugs.llvm.org/";>LLVM bug tracker contains a -Clang C component that tracks known bugs with Clang's language +The https://github.com/llvm/llvm-pr

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu updated this revision to Diff 396627. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clang/docs

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu updated this revision to Diff 396589. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clang/docs

[Lldb-commits] [PATCH] D72326: [clang-format] Add option to explicitly specify a config file

zwliew updated this revision to Diff 396579. zwliew added a comment. Fixed rebase and diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: clang/docs/ClangFormat.rst clang/docs/ClangFormatStyleO

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

MaskRay added inline comments. Comment at: libcxx/docs/index.rst:220 * `libc++abi Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `libcxx-commits Mailing List`_ -

[Lldb-commits] [PATCH] D72326: [clang-format] Add option to explicitly specify a config file

zwliew added a comment. Herald added a subscriber: JDevlieghere. Oh no...I'm so sorry. Didn't mean to cause this large diff. Trying to fix it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 __

[Lldb-commits] [PATCH] D72326: [clang-format] Add option to explicitly specify a config file

zwliew updated this revision to Diff 396578. zwliew added a comment. Herald added subscribers: llvm-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, arjunp, sdasgup3, luke957, asavonic, jeroen.dobbelaere, wenzhicui, wrengr, Chia-hungDuan, armkevincheng, ormris, foad, eric-k256,

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

MaskRay added a subscriber: jhenderson. MaskRay added a comment. @jhenderson Comment at: libunwind/docs/index.rst:101 * `LLVM Homepage `_ -* `LLVM Bugzilla `_ +* `LLVM Issues `_ * `cfe-co

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

Quuxplusone accepted this revision. Quuxplusone added a comment. Tweaked English wording throughout. LGTM with all these modifications made. Orthogonally, it does occur to me that one might save a //lot// of this churn (and also the next time the bug tracker moves, e.g. if we go from GitHub to

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ldionne accepted this revision as: libc++, libunwind. ldionne added a comment. Libc++ and libunwind changes LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu marked 7 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/www/c_status.html:76 +The https://bugs.llvm.org/";>LLVM bug tracker and +https://github.com/llvm/llvm-project/issues/";>LLVM Issues contain +a Clang C component that tracks known bugs

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu updated this revision to Diff 396498. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clang/docs/CommandGuide/clang.rst clang/www/c_status

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

asl requested changes to this revision. asl added a comment. This revision now requires changes to proceed. Will you please check the comments and reword everything using proper terminology and new things we're having on GitHub? Comment at: clang/www/c_status.html:76 +The http

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu updated this revision to Diff 396509. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clang/docs/CommandGuide/clang.rst clang/www/c_status

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

MaskRay added inline comments. Herald added a subscriber: JDevlieghere. Comment at: llvm/docs/DeveloperPolicy.rst:64 +.. FIXME: Edit for LLVM Issues in Github. + You can drop this and let others fix this paragraph. Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu created this revision. ChuanqiXu added reviewers: aaron.ballman, asl. Herald added subscribers: libcxx-commits, ormris, arphaman, mgorny. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: MaskRay. Herald added a project: libunwind. Herald added a reviewer: libunwin

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

asl requested changes to this revision. asl added a subscriber: tstellar. asl added a comment. This revision now requires changes to proceed. Thanks for doing this! I added few notes on the way. Comment at: clang/www/c_status.html:76 +The https://bugs.llvm.org/";>LLVM bug track

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 396338. Ericson2314 added a comment. 1. Updating D99484 : Use `GNUInstallDirs` to support custom installation dirs. # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subj

[Lldb-commits] [PATCH] D116224: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

Mordante requested changes to this revision. Mordante added a comment. This revision now requires changes to proceed. This revision reverts more than intended. Since it now touches libcxx directory it requires libc++ approval. Please reduce the revert to the intended scope. Repository: rG LLV

[Lldb-commits] [PATCH] D116224: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

david-salinas created this revision. Herald added subscribers: luke957, abrachet, ormris, foad, dang, jdoerfert, phosek, kerbowa, usaxena95, pengfei, s.egerton, asbirlea, mstorsjo, lebedev.ri, kadircet, rupprecht, arphaman, steven_wu, mgrang, simoncook, fedor.sergeev, hiraditya, krytarowski, ari

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall added a comment. In D114251#3197713 , @davrec wrote: > One other thought: can we add diagnostic notes using this new information, > e.g. This sounds plausible, though I didn't want to extend the scope of this patch further. I'm also not sure

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1600db19d63: [AST] Add UsingType: a sugar type for types found via UsingDecl (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 395434. sammccall added a comment. Herald added a reviewer: shafik. Fix ASTImporter, add test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114251/new/ https://reviews.llvm.org/D114251 Files: clang-tools-

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

davrec added a comment. `throughUsingDecl` seems like a good solution, though I defer to regular ASTMatchers users. One other thought: can we add diagnostic notes using this new information, e.g. struct A1 { protected: using IntType = char; }; struct A2 { protected: using I

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 394806. sammccall added a comment. Fix serialization (found with msan) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114251/new/ https://reviews.llvm.org/D114251 Files: clang-tools-extra/clang-tidy/google/

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 394780. sammccall added a comment. Make hasDeclaration look through UsingType, and throughUsingDecl work on UsingType too. This is more ergonomic, more similar to existing behavior that matchers rely on, and similar in spirit to DeclRefExpr. Repository:

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall added a comment. Having done some out-of-tree testing, it seems this silently breaks enough ASTMatchers that it'll be hard to get it to stick. (We don't strictly need to block on out-of-tree failures, but I'm pretty sure a lot of stuff in-tree is broken too, and the out-of-tree users

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 394648. sammccall added a comment. Fix QualTypeNames bug that showed up in external testing. (Now covered by a unittest added separately) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114251/new/ https://revi

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 394553. sammccall marked an inline comment as done. sammccall added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. update lldb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 394666. sammccall added a comment. TypePrinter prints UsingTypes with their underlying qualifiers by default. Fix qualifier bug in QualTypeNames Add a bit more detail to AST dump (UsingShadow) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. I split out D115568 D115569 D115570 from this. I think it is better to start from the outside and work back inward, so the LLVM-only commit that previously came

[Lldb-commits] [PATCH] D115566: Quote some more destination paths with variables

Ericson2314 updated this revision to Diff 393645. Ericson2314 added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, lldb-commits, sstefan1, jvesely. Herald added projects: LLDB, LLVM. 1. Updating D115566 : Quote some more

[Lldb-commits] [PATCH] D115566: Quote some more destination paths with variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGddcc02dbcc47: Quote some more destination paths with variables (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D115566: Quote some more destination paths with variables

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. This looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115566/new/ https://reviews.llvm.org/D115566 _

[Lldb-commits] [PATCH] D115544: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

Ericson2314 added a comment. Sorry for this new build failure. I think I found the culprit and fixed it with https://reviews.llvm.org/D115553 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115544/new/ https://reviews.llvm.org/D115544 _

[Lldb-commits] [PATCH] D115544: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

Ericson2314 added a comment. I see a build failure in https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ and think I know how to fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115544/new/ https://reviews.llvm.org/D115544 _

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 393575. Ericson2314 added a comment. Herald added a subscriber: sdasgup3. Rebase after landing parent diff again, take 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99

[Lldb-commits] [PATCH] D115544: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

Ericson2314 added a comment. This pre-merge build failure is in the ASAN tests and thus seems entirely unrelated, so I cam going to land this is and watch careful as instructed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115544/new/ https://rev

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

mib added a comment. In D100810#3186066 , @Ericson2314 wrote: > I tried again without lld in the list of enable projects, in case it that > made a difference to force it to use ld64 more, but it still worked. Hi @Ericson2314, I tried reproducing the fa

[Lldb-commits] [PATCH] D115544: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

Ericson2314 created this revision. Herald added subscribers: ormris, jvesely, steven_wu, hiraditya, mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, LLDB, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits, lldb-commits, cfe-commits. This reve

[Lldb-commits] [PATCH] D115544: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG492de35df443: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. (authored by Ericson2314). Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D115331: [llvm] Add null-termination capability to SmallVectorMemoryBuffer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0262c2394f4: [llvm] Add null-termination capability to SmallVectorMemoryBuffer (authored by jansvoboda11). Changed prior to commit: https://revie

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added a comment. @mib Can you help me reproduce? I ran cmake -G Ninja .. -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_INSTALL_PREFIX="$HOME/tmp/out" -DLLDB_TEST_USER_ARGS="--arch;x86_64;--build-dir;$HOME/tmp/out/lldb-test-build.noindex;-t;--env;TERM=vt100" '-DLLDB_ENABLE_PYTHON=On'

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added a comment. I tried again without lld in the list of enable projects, in case it that made a difference to force it to use ld64 more, but it still worked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.l

[Lldb-commits] [PATCH] D115331: [llvm] Add null-termination capability to SmallVectorMemoryBuffer

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: shafik. Herald added a reviewer: rupprecht. Herald added a reviewer: jhenderson.

[Lldb-commits] [PATCH] D115331: [llvm] Add null-termination capability to SmallVectorMemoryBuffer

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, except I'd prefer the `#include`s be changed separately since that cleanup seems unrelated to this change. Comment at: lldb/unittests/Expression/CppModuleConfi

[Lldb-commits] [PATCH] D114699: Fixed a memory leak in the PDLToPDLInterp RootOrderingTest.

mehdi_amini added inline comments. Comment at: mlir/unittests/Conversion/PDLToPDLInterp/RootOrderingTest.cpp:37 + ~RootOrderingTest() { +for (int i = 0; i < 4; ++i) + v[i].getDefiningOp()->destroy(); bondhugula wrote: > bondhugula wrote: > > You need to

[Lldb-commits] [PATCH] D114699: Fixed a memory leak in the PDLToPDLInterp RootOrderingTest.

sfuniak abandoned this revision. sfuniak added a comment. Herald added a subscriber: JDevlieghere. Messed up a rebase, will submit a new diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114699/new/ https://reviews.llvm.org/D114699 _

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

kasper81 added a comment. Hi Luis, are you planning on adding plugin architecture support (in `lldb/source/Plugins/Architecture`) as part of this work? Comment at: lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp:1152 + triple.getArch() == llvm::Triple::riscv6

[Lldb-commits] [PATCH] D114699: Fixed a memory leak in the PDLToPDLInterp RootOrderingTest.

sfuniak updated this revision to Diff 390477. sfuniak added a comment. Herald added subscribers: cfe-commits, llvm-commits, libcxx-commits, lldb-commits, Sanitizers, luke957, asavonic, carlosgalvezp, armkevincheng, foad, jsmolens, eric-k256, frasercrmck, dang, martong, kerbowa, csigg, luismarque

[Lldb-commits] [PATCH] D106339: Add support to generate Sphinx DOCX documentation

ldionne removed projects: libc++, libunwind. ldionne removed reviewers: libunwind, libc++, ldionne. ldionne added a comment. Herald added projects: libc++, libunwind. Herald added a reviewer: libc++. Herald added a reviewer: libunwind. Removing from the runtimes review queue -- please ping me dire

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. Fix pushed to https://reviews.llvm.org/D114207 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. Isolated example: template struct span {}; auto make_span() { using T = int; return span(); } void WontCompile() { span s1 = make_span(); } https://godbolt.org/z/rjd6Y6f9d testcc:9:13: error: no viable conversion from 'span' to 'span'

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

thakis added a comment. > So, some notes: > > - We should probably also do an AKA on the type diff. > - Chromium should use a clearer name for that typedef perhaps? Though calling > the first template parameter of span as `T` is common, maybe a better name > here would be `element_type`. > > Hav

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3139129 , @lkail wrote: > Hi we found regression in our internal tests. It compiles with clang-13.0.0 > https://godbolt.org/z/3abGrcf7o and gcc https://godbolt.org/z/K9oj3Grs1, but > fails with clang-trunk https://go

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

lkail added a comment. Hi we found regression in our internal tests. It compiles with clang-13.0.0 https://godbolt.org/z/3abGrcf7o and gcc https://godbolt.org/z/K9oj3Grs1, but fails with clang-trunk https://godbolt.org/z/1Tehxa1x9. Is it an intended change? If so, do we have to document this?

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

hans added a comment. Sorry, the attached file is here: F20424768: a.ii Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 __

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

hans added a comment. > I am not sure how to reproduce this. Attaching preprocessed source. With Clang built at 508aa4fe0c82b3b409e2e194d591ee6d665c8623 it reproduces for me like this: $ clang++ -c /tmp/a.ii ../../base/containers/span_unittest.cc:11:13: error: no viable conversion from 'sp

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3137375 , @hans wrote: >> I am not sure how to reproduce this. > > Attaching preprocessed source. With Clang built at > 508aa4fe0c82b3b409e2e194d591ee6d665c8623 it reproduces for me like this: > > $ clang++ -c /tmp/

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3135461 , @hans wrote: > We're seeing a diagnostic change in Chromium which looks funny. For the > following code (span<> is our own class): > > the diagnostic changes from: > > fatal error: no viable conversio

[Lldb-commits] [PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c484f11d355: [llvm] Add a SFINAE template parameter to DenseMapInfo (authored by rriddle). Changed prior to commit: https://reviews.llvm.org/D113

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

hans added a comment. We're seeing a diagnostic change in Chromium which looks funny. For the following code (span<> is our own class): int WontCompile() { const std::vector v; span s = make_span(v); } the diagnostic changes from: fatal error: no viable conversion from 'span' to

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM from the libc++ perspective. Unsubscribing to reduce spam, please ping me on Discord if you need further input. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

rriddle updated this revision to Diff 387386. rriddle added a comment. Herald added subscribers: lldb-commits, hiraditya. Herald added a project: LLDB. resolve comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113641/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. FYI this is a minimal repro taken from Martin's preprocessed source (Thanks!): template struct a { using b = const float; }; template using d = typename a::b; template void e(d *, c) {} template void e(typename a::b *, int); Repository: rG LLVM Github

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov reopened this revision. mizvekov added a comment. Reverting for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 ___ lldb-commits mailing list lldb

Re: [Lldb-commits] [lldb] 6438a52 - Revert "[clang] retain type sugar in auto / template argument deduction"

Oops, my bad! The reason for reverting this is that this is a recent commit, and there are reports of breakage building libANGLE which have not been investigated. See https://reviews.llvm.org/D110216 for details / future developments. Thanks! On Mon, Nov 15, 2021 at 12:33 AM David Blaikie wrot

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mstorsjo added a comment. In D110216#3130193 , @mizvekov wrote: > In D110216#3130184 , @mstorsjo > wrote: > >> Do you happen to know what's going on here? The files mentioned are >> https://code.qt.io/cgit/qt/qt

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3130184 , @mstorsjo wrote: > Do you happen to know what's going on here? The files mentioned are > https://code.qt.io/cgit/qt/qtbase.git/tree/src/3rdparty/angle/src/libANGLE/renderer/d3d/d3d11/ResourceManager11.cpp?h=

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

RobRich999 added a comment. Hit libANGLE in Chromium today, too. https://bugs.chromium.org/p/chromium/issues/detail?id=1270154 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mstorsjo added a comment. This broke building ANGLE as part of Qt 5.15 for a mingw target, with the following error: ../../../3rdparty/angle/src/libANGLE/renderer/d3d/d3d11/ResourceManager11.cpp:532:38: error: explicit instantiation of 'allocate' does not refer to a function template, varia

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. Okay, libcxx pipeline passes, disregarding the clang-format failure for pre-existing badness in those files, which would need to be fixed separately or else git loses track of the rename. The AIX failures also seem completely unrelated. Repository: rG LLVM Github Mo

  1   2   >