[Lldb-commits] [PATCH] D116094: Add support for a version 2 of "main bin spec" Mach-O LC_NOTE in corefiles, handle specifications with a slide value

jasonmolenda updated this revision to Diff 395800. jasonmolenda added a comment. Update patch to address Jonas' feedback. Most of the changes in this update are to TestFirmwareCorefiles.py, cleaning its structure up given how the test has grown over time. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D116136: [lldb] Add UTF-8 char basic type

ljmf00 added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:750 eBasicTypeUnsignedWChar, + eBasicTypeChar8, eBasicTypeChar16, Does the order of the enum matter here? Since this is part of the public API it might break something externa

[Lldb-commits] [PATCH] D116136: [lldb] Add UTF-8 char basic type

ljmf00 created this revision. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A UTF-8 Basic type should be exposed the same way we have UTF-16 and UTF-32 basic types Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[Lldb-commits] [PATCH] D112564: [lldb] Add support for UTF-8 unicode formatting

ljmf00 added a comment. @labath I found the missing part, DumpTypeValue depends on lldb::Format and eFormatUnicode8 case should be added there too. I added tests and also changed the patch message. Can you re-review? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112564/new/ https://re

[Lldb-commits] [PATCH] D112564: [lldb] Add support for UTF-8 unicode formatting

ljmf00 updated this revision to Diff 395777. ljmf00 retitled this revision from "[lldb] Add support for custom char8_t types with different name" to "[lldb] Add support for UTF-8 unicode formatting". ljmf00 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D115570: [lldb] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. Thanks, @compnerd! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115570/new/ https://reviews.llvm.org/D115570 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] 9531146 - [lldb] Use `GNUInstallDirs` to support custom installation dirs.

Author: John Ericson Date: 2021-12-22T00:28:53Z New Revision: 95311468997160401c027e3bad3b14a391c1ead6 URL: https://github.com/llvm/llvm-project/commit/95311468997160401c027e3bad3b14a391c1ead6 DIFF: https://github.com/llvm/llvm-project/commit/95311468997160401c027e3bad3b14a391c1ead6.diff LOG:

[Lldb-commits] [PATCH] D115570: [lldb] Use `GNUInstallDirs` to support custom installation dirs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG953114689971: [lldb] Use `GNUInstallDirs` to support custom installation dirs. (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11557

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115951/new/ https://reviews.llvm.org/D115951 _

[Lldb-commits] [PATCH] D116094: Add support for a version 2 of "main bin spec" Mach-O LC_NOTE in corefiles, handle specifications with a slide value

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A few small nits but the change itself looks sound to me. LGTM. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:7052 + if (image.load_a

[Lldb-commits] [PATCH] D116094: Add support for a version 2 of "main bin spec" Mach-O LC_NOTE in corefiles, handle specifications with a slide value

jasonmolenda created this revision. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. The Mach-O corefiles have a "main bin spec" LC_NOTE which allows the corefile creator to specify a binary's UUID, load address, and type