[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg marked 6 inline comments as done. clayborg added a comment. Pavel: I fixed all issues you identified. Let me know if there is anything else you would like to see changed. Comment at: lldb/source/Host/common/FileSystem.cpp:523 + Status error; + if (IsDirectory(path))

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg updated this revision to Diff 394442. clayborg marked an inline comment as done. clayborg added a comment. Changes: - Updated Symtab class to not have to work around not having an object file and created a test with an object file - Don't use hack to encode Symbol bitfield values. - Rem

[Lldb-commits] [lldb] 9c7fbc3 - [lldb] Introduce a FreeBSDKernel plugin for vmcores

Author: Michał Górny Date: 2021-12-14T22:07:20+01:00 New Revision: 9c7fbc3f9b05b3249468ef6aeacaf71841b5cfe3 URL: https://github.com/llvm/llvm-project/commit/9c7fbc3f9b05b3249468ef6aeacaf71841b5cfe3 DIFF: https://github.com/llvm/llvm-project/commit/9c7fbc3f9b05b3249468ef6aeacaf71841b5cfe3.diff

[Lldb-commits] [lldb] f4abf28 - [lldb] Update the PDB tests to pass with the VS2019 toolset

Author: Stella Stamenova Date: 2021-12-14T13:06:07-08:00 New Revision: f4abf28c0a0ba2226379a1b1926a7c36d75265e9 URL: https://github.com/llvm/llvm-project/commit/f4abf28c0a0ba2226379a1b1926a7c36d75265e9 DIFF: https://github.com/llvm/llvm-project/commit/f4abf28c0a0ba2226379a1b1926a7c36d75265e9.di

[Lldb-commits] [PATCH] D115482: [lldb] Update the PDB tests to pass with the VS2019 toolset

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf4abf28c0a0b: [lldb] Update the PDB tests to pass with the VS2019 toolset (authored by stella.stamenova). Repository: r

[Lldb-commits] [PATCH] D113605: [lldb][NFC] Fix documentation for EncodingDataType

ljmf00 added inline comments. Comment at: lldb/include/lldb/Symbol/Type.h:69 enum EncodingDataType { +/// Invalid encoding eEncodingInvalid, teemperor wrote: > nit: LLVM comments end in a period. Fixed on push. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D113605: [lldb][NFC] Fix documentation for EncodingDataType

This revision was automatically updated to reflect the committed changes. Closed by commit rG1695dd175242: [lldb][NFC] Fix documentation for EncodingDataType (authored by ljmf00). Changed prior to commit: https://reviews.llvm.org/D113605?vs=386362&id=394345#toc Repository: rG LLVM Github Mon

[Lldb-commits] [lldb] 1695dd1 - [lldb][NFC] Fix documentation for EncodingDataType

Author: Luís Ferreira Date: 2021-12-14T20:13:30Z New Revision: 1695dd17524264a199d3731afe8e786bd1ce58c8 URL: https://github.com/llvm/llvm-project/commit/1695dd17524264a199d3731afe8e786bd1ce58c8 DIFF: https://github.com/llvm/llvm-project/commit/1695dd17524264a199d3731afe8e786bd1ce58c8.diff LOG:

[Lldb-commits] [PATCH] D115698: [lldb] Check if language is supported before creating a REPL instance

This revision was automatically updated to reflect the committed changes. Closed by commit rG100863ccd8d4: [lldb] Check if language is supported before creating a REPL instance (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [lldb] 100863c - [lldb] Check if language is supported before creating a REPL instance

Author: Jonas Devlieghere Date: 2021-12-14T12:05:35-08:00 New Revision: 100863ccd8d41091f90749ba76d91f6dfafdde57 URL: https://github.com/llvm/llvm-project/commit/100863ccd8d41091f90749ba76d91f6dfafdde57 DIFF: https://github.com/llvm/llvm-project/commit/100863ccd8d41091f90749ba76d91f6dfafdde57.d

[Lldb-commits] [lldb] efefc4e - [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

Author: Luís Ferreira Date: 2021-12-14T19:31:18Z New Revision: efefc4ee3b25ca180e3be84491f19218d995c788 URL: https://github.com/llvm/llvm-project/commit/efefc4ee3b25ca180e3be84491f19218d995c788 DIFF: https://github.com/llvm/llvm-project/commit/efefc4ee3b25ca180e3be84491f19218d995c788.diff LOG:

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGefefc4ee3b25: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h (authored by ljmf00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://rev

[Lldb-commits] [PATCH] D115736: [lldb] (Semi-automatically) format .swig files

mib accepted this revision. mib added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115736/new/ https://reviews.llvm.org/D115736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D115736: [lldb] (Semi-automatically) format .swig files

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115736/new/ https://reviews.llvm.org/D115736 ___

[Lldb-commits] [PATCH] D115662: [lldb][DWARF] Remove duplicate DIE type assignment

labath added a comment. In D115662#3192651 , @ljmf00 wrote: > In D115662#3192064 , @labath wrote: > >> I don't have any issues with this per se, but you may want to sync up with >> @zequanwu, as his D115308

[Lldb-commits] [PATCH] D115662: [lldb][DWARF] Remove duplicate DIE type assignment

ljmf00 added a comment. In D115662#3192064 , @labath wrote: > I don't have any issues with this per se, but you may want to sync up with > @zequanwu, as his D115308 tries to delete > the second instance. Maybe he can

[Lldb-commits] [lldb] 76c876e - Revert "[lldb] Introduce a FreeBSDKernel plugin for vmcores"

Author: Michał Górny Date: 2021-12-14T18:17:54+01:00 New Revision: 76c876e7e6ef1271846a92cbea59c62b8f12ed47 URL: https://github.com/llvm/llvm-project/commit/76c876e7e6ef1271846a92cbea59c62b8f12ed47 DIFF: https://github.com/llvm/llvm-project/commit/76c876e7e6ef1271846a92cbea59c62b8f12ed47.diff

[Lldb-commits] [PATCH] D114911: [lldb] Introduce a FreeBSDKernel plugin for vmcores

This revision was automatically updated to reflect the committed changes. Closed by commit rGaedb328a4dc9: [lldb] Introduce a FreeBSDKernel plugin for vmcores (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [lldb] aedb328 - [lldb] Introduce a FreeBSDKernel plugin for vmcores

Author: Michał Górny Date: 2021-12-14T18:03:38+01:00 New Revision: aedb328a4dc9cb48ee3cf3198281649ea2c4f532 URL: https://github.com/llvm/llvm-project/commit/aedb328a4dc9cb48ee3cf3198281649ea2c4f532 DIFF: https://github.com/llvm/llvm-project/commit/aedb328a4dc9cb48ee3cf3198281649ea2c4f532.diff

[Lldb-commits] [PATCH] D115736: [lldb] (Semi-automatically) format .swig files

labath created this revision. labath added reviewers: JDevlieghere, mib. labath requested review of this revision. Herald added a project: LLDB. I've found my recent ventures into the swig land painful because of the strange way they are formatted. This patch attempts to alleviate future headaches

[Lldb-commits] [lldb] ebb6bb7 - [lldb/python] Plug SBStructuredData leaks

Author: Pavel Labath Date: 2021-12-14T17:02:24+01:00 New Revision: ebb6bb725eadd57a0f7995fff17774020f6f0389 URL: https://github.com/llvm/llvm-project/commit/ebb6bb725eadd57a0f7995fff17774020f6f0389 DIFF: https://github.com/llvm/llvm-project/commit/ebb6bb725eadd57a0f7995fff17774020f6f0389.diff

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. The patch is slightly larger than I would prefer for a through review, but here's my first pass at it. I appreciate the difficulties in bootstrapping something like this incrementall

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115324/new/ https://reviews.llvm.org/D115324 _

[Lldb-commits] [PATCH] D114911: [lldb] Introduce a FreeBSDKernel plugin for vmcores

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Seems reasonable. I mean, there are a lot of things that are less than ideal, but none of this is substantially worse than what we have already, and you've done a pretty good job explaining wh

[Lldb-commits] [PATCH] D115126: [LLDB] Add unit tests for Editline keyboard shortcuts

labath added inline comments. Comment at: lldb/include/lldb/Host/Editline.h:392-393 + + friend class EditlineKeyboardBindingTest_MultiLineEditlineKeybindings_Test; + friend class EditlineKeyboardBindingTest_SingleLineEditlineKeybindings_Test; }; nealsid wrote:

[Lldb-commits] [PATCH] D115662: [lldb][DWARF] Remove duplicate DIE type assignment

labath added subscribers: zequanwu, labath. labath added a comment. I don't have any issues with this per se, but you may want to sync up with @zequanwu, as his D115308 tries to delete the second instance. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D115723: [lldb] Fix ABIMacOSX_arm64::PrepareTrivialCall logging

augusto2112 abandoned this revision. augusto2112 added a comment. Looks like this was already fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115723/new/ https://reviews.llvm.org/D115723 ___ lldb-co

[Lldb-commits] [PATCH] D115723: [lldb] Fix ABIMacOSX_arm64::PrepareTrivialCall logging

augusto2112 created this revision. Herald added subscribers: pengfei, kristof.beyls. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Make the logging message print ABIMacOSX_arm64 instead of ABISysV_x86_64. Repository: rG LL