[Lldb-commits] [PATCH] D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. Much better. Just some better patterns that you could follow. Read my comments. Besides that, now you can unify the tests across libcxx and libstdcpp Comment at:

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. could you share a screenshot of how this looks like? And thanks for doing this!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113400/new/ ht

[Lldb-commits] [PATCH] D110804: Add a new command "target metrics".

wallace added a comment. is this going to be abandoned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110804/new/ https://reviews.llvm.org/D110804 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] 0f2a7f2 - [debugserver] Put building for arm64e behind a CMake flag

Author: Jonas Devlieghere Date: 2021-11-08T21:01:43-08:00 New Revision: 0f2a7f2955cc632846ed8cd17865d887795eb0b3 URL: https://github.com/llvm/llvm-project/commit/0f2a7f2955cc632846ed8cd17865d887795eb0b3 DIFF: https://github.com/llvm/llvm-project/commit/0f2a7f2955cc632846ed8cd17865d887795eb0b3.d

[Lldb-commits] [PATCH] D113445: Support looking up absolute symbols

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113445/new/ https://reviews.llvm.org/D113445 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

rupprecht created this revision. rupprecht added reviewers: labath, teemperor. Herald added a reviewer: shafik. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This reverts commit 3bf96b0329be554c67282b0d7d8da6a864b9e38f

[Lldb-commits] [PATCH] D113445: Support looking up absolute symbols

aprantl created this revision. aprantl added reviewers: jasonmolenda, jingham, JDevlieghere. aprantl requested review of this revision. The Swift stdlib uses absolute symbols in the dylib to communicate feature flags to the process. LLDB's expression evaluator needs to be able to find them. This

[Lldb-commits] [PATCH] D113330: [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in breakpad.

zequanwu updated this revision to Diff 385657. zequanwu marked an inline comment as done. zequanwu added a comment. add argument comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113330/new/ https://reviews.llvm.org/D113330 Files: lldb/inc

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Hi Ted, sorry for not getting back to you earlier on this, yes this looks unintentional to me and I think this change is good. Nice test case. Thanks for the ping. Repository:

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

ted added a comment. @jasonmolenda friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112931/new/ https://reviews.llvm.org/D112931 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

danilashtefan updated this revision to Diff 385526. danilashtefan marked 8 inline comments as done. danilashtefan added a comment. All of the requested changes are done. Please, let me know if any other corrections are needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D113299: [NFC] Inclusive Language: change master to main for .chm files

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3b15b71ce00: [NFC] Inclusive Language: change master to main for .chm files (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113299/new/

[Lldb-commits] [PATCH] D113186: [NFC] Inclusive language: Remove instances of master in URLs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc71fbdd87b35: [NFC] Inclusive language: Remove instances of master in URLs (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D113299: [NFC] Inclusive Language: change master to main for .chm files

quinnp created this revision. Herald added a reviewer: bollu. Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, r

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Scopes can have an optional hint for how to present this scope in the UI: https://microsoft.github.io/debug-adapter-protocol/specification#Types_Scope The I

[Lldb-commits] [lldb] c3b15b7 - [NFC] Inclusive Language: change master to main for .chm files

Author: Quinn Pham Date: 2021-11-08T08:23:04-06:00 New Revision: c3b15b71ce009b3dff9fb3bd664d087057b8376e URL: https://github.com/llvm/llvm-project/commit/c3b15b71ce009b3dff9fb3bd664d087057b8376e DIFF: https://github.com/llvm/llvm-project/commit/c3b15b71ce009b3dff9fb3bd664d087057b8376e.diff LO

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:70 +static llvm::Error make_invalid_range_err(lldb::addr_t addr, + lldb::addr_t end_addr) { I think this fun