[Lldb-commits] [lldb] d531e5c - [LLDB] [NFC] Typo fix in usage text for "type filter" command

Author: Daniel Jalkut Date: 2021-10-21T12:22:52+05:30 New Revision: d531e5cf58413e34dc006a580d2c109863bddaa1 URL: https://github.com/llvm/llvm-project/commit/d531e5cf58413e34dc006a580d2c109863bddaa1 DIFF: https://github.com/llvm/llvm-project/commit/d531e5cf58413e34dc006a580d2c109863bddaa1.diff

[Lldb-commits] [PATCH] D112199: [LLDB] [NFC] Typo fix in usage text for "type filter" command

This revision was automatically updated to reflect the committed changes. Closed by commit rGd531e5cf5841: [LLDB] [NFC] Typo fix in usage text for "type filter" command (authored by Daniel Jalkut , committed by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D112199: [LLDB] [NFC] Typo fix in usage text for "type filter" command

xgupta created this revision. xgupta added reviewers: labath, teemperor. xgupta requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When you invoke "help type filter" the resulting help shows: Syntax: type synthetic [] This patch fixes the he

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

clayborg updated this revision to Diff 381106. clayborg added a comment. Rename GlobalStats to DebuggerStats. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111686/new/ https://reviews.llvm.org/D111686 Files: lldb/include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

clayborg added inline comments. Comment at: lldb/include/lldb/Target/Statistics.h:96 +}; + +class GlobalStats { JDevlieghere wrote: > Do we expect there to be something like `DebuggerStats`? I think it would be > nice from a hierarchy perspective that Global Sta

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This look great. Thanks for doing the legit fix. @mgorny This is something you might wanna implement/test on BSD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D112167: [lldb/Plugins] Refactor ScriptedThread register context creation

mib updated this revision to Diff 381091. mib added a comment. Address @shafik comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112167/new/ https://reviews.llvm.org/D112167 Files: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp

[Lldb-commits] [PATCH] D112167: [lldb/Plugins] Refactor ScriptedThread register context creation

shafik added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:99 ScriptedThread::CreateRegisterContextForFrame(StackFrame *frame) { uint32_t concrete_frame_idx = frame ? frame->GetConcreteFrameIndex() : 0; `const` Repos

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

danilashtefan created this revision. Herald added a subscriber: mgorny. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112180 Files: lldb/source/Plugins/Lang

[Lldb-commits] [PATCH] D112167: [lldb/Plugins] Refactor ScriptedThread register context creation

shafik added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:186 void ScriptedThread::RefreshStateAfterStop() { - // TODO: Implement - if (m_reg_context_sp) -m_reg_context_sp->InvalidateAllRegisters(); + GetRegisterContext()->Invalidat

[Lldb-commits] [PATCH] D112169: [lldb] [Communication] Add a WriteAll() method that resumes writing

mgorny updated this revision to Diff 381063. mgorny added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112169/new/ https://reviews.llvm.org/D112169 Files: lldb/include/lldb/Core/Communication.h lldb/source/Core/Communication.cpp lldb/source/Plugins/Proces

[Lldb-commits] [PATCH] D112169: [lldb] [Communication] Add a WriteAll() method that resumes writing

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, teemperor. mgorny requested review of this revision. Add a Communication::WriteAll() that resumes Write() if the initial call did not write all data. Use it in GDBRemoteCommunication when sending packets in order t

[Lldb-commits] [lldb] 207998c - [lldb] Remove variable "any" which is set but not used

Author: Jonas Devlieghere Date: 2021-10-20T12:08:35-07:00 New Revision: 207998c242c8c8a270ff22a5136da87338546725 URL: https://github.com/llvm/llvm-project/commit/207998c242c8c8a270ff22a5136da87338546725 DIFF: https://github.com/llvm/llvm-project/commit/207998c242c8c8a270ff22a5136da87338546725.d

[Lldb-commits] [PATCH] D112167: [lldb/Plugins] Refactor ScriptedThread register context creation

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the ScriptedThread class to create the register context when Process::RefreshStateAfterStop is called rather

[Lldb-commits] [PATCH] D112107: [lldb/Plugins] Make `ScriptedInterface::CreatePluginObject` more generic

JDevlieghere added a comment. This LGTM but it would be nice if the commit message could be a bit more specific about the motivation and explain the relationship between an ObjectSP and DictionarySP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/Statistics.h:96 +}; + +class GlobalStats { Do we expect there to be something like `DebuggerStats`? I think it would be nice from a hierarchy perspective that Global Stats have a map of deb

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

dblaikie created this revision. dblaikie added a reviewer: aprantl. dblaikie requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Hopefully these were also fixed bi r343545 / 7fd4513920d2fed533ad420976529ef43eb42a35 Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

dblaikie added a comment. Herald added a subscriber: JDevlieghere. Looks like this test, when it was introduced/substantially refactored in D9426 - what was missing compared to all the other tests updated to run on linux, was the Makefile change to use libc++, so

[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

dblaikie created this revision. dblaikie added reviewers: teemperor, labath. dblaikie requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112163 Files: lldb/test/API/functiona

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

mib updated this revision to Diff 381020. mib added a comment. Add `self` argument to scripted_process base class methods. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112047/new/ https://reviews.llvm.org/D112047 Files: lldb/examples/python/scr

[Lldb-commits] [PATCH] D112058: [lldb/DWARF] Ignore debug info pointing to the low addresses

clayborg added a comment. In D112058#3074618 , @labath wrote: > In D112058#3073451 , @clayborg > wrote: > >> Looks good. Do we need a follow up patch to avoid creating functions that >> should have been stripped

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

mgorny added a comment. In D110535#3075563 , @lattner wrote: > Do you have commit access? If not, please read the llvm developer policy and > follow the instructions, thanks! That's not the problem. The problem is that @labath and @joerg seem not to a

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-server] Allow any protocol supported by lldb

mgorny updated this revision to Diff 380998. mgorny added a comment. Add a PoC for testing lldb-server over a pty. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111964/new/ https://reviews.llvm.org/D111964 Files: lldb/test/API/tools/lldb-server/TestPtyServer.py lldb/tools/lldb-serv

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

lattner added a comment. Do you have commit access? If not, please read the llvm developer policy and follow the instructions, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110535/new/ https://reviews.llvm.org/D110535 ___ lldb-commi

[Lldb-commits] [PATCH] D111355: [lldb] Add serial:// protocol for connecting to serial port

mgorny marked 3 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:772-774 + llvm::Error error = llvm::Error::success(); + m_io_sp = std::make_shared(fd, File::eOpenOptionReadWrite, +

[Lldb-commits] [PATCH] D111355: [lldb] Add serial:// protocol for connecting to serial port

mgorny updated this revision to Diff 380985. mgorny added a comment. Use unique_ptr. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111355/new/ https://reviews.llvm.org/D111355 Files: lldb/include/lldb/Host/File.h lldb/include/lldb/Host/posix/ConnectionFileDescriptorPosix.h lldb/s

[Lldb-commits] [PATCH] D112147: [lldb] Fix lookup for global constants in namespaces

tonkosi created this revision. tonkosi added reviewers: werat, teemperor. tonkosi requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB uses mangled name to construct a fully qualified name for global variables. Sometimes DW_TAG_linkage_name

[Lldb-commits] [PATCH] D111355: [lldb] Add serial:// protocol for connecting to serial port

labath added inline comments. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:772-774 + llvm::Error error = llvm::Error::success(); + m_io_sp = std::make_shared(fd, File::eOpenOptionReadWrite, + serial_options.get(),

[Lldb-commits] [PATCH] D111355: [lldb] Add serial:// protocol for connecting to serial port

mgorny updated this revision to Diff 380954. mgorny added a comment. Use a fallible ctor approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111355/new/ https://reviews.llvm.org/D111355 Files: lldb/include/lldb/Host/File.h lldb/include/lldb/Host/posix/ConnectionFileDescriptorPo

[Lldb-commits] [PATCH] D111355: [lldb] Add serial:// protocol for connecting to serial port

mgorny added inline comments. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:772-774 + llvm::Error error = llvm::Error::success(); + m_io_sp = std::make_shared(fd, File::eOpenOptionReadWrite, + serial_options.get(),

[Lldb-commits] [PATCH] D111030: [lldb] [Host] Add setters for common teletype properties to Terminal

mgorny added inline comments. Comment at: lldb/source/Host/common/Terminal.cpp:316-347 + bool parity_bit = true; + bool odd_bit = false; + bool stick_bit = false; + + switch (parity) { + case Parity::No: +parity_bit = false; labath wrote: > I am wonderin

[Lldb-commits] [PATCH] D111030: [lldb] [Host] Add setters for common teletype properties to Terminal

mgorny updated this revision to Diff 380943. mgorny added a comment. Make `SetParity()` simpler. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111030/new/ https://reviews.llvm.org/D111030 Files: lldb/include/lldb/Host/Terminal.h lldb/source/Host/common/Terminal.cpp lldb/unittests

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

mgorny added a comment. So how should I proceed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110535/new/ https://reviews.llvm.org/D110535 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [PATCH] D112131: [lldb] [Process/Linux] Support arbitrarily-sized FPR writes on ARM

This revision was automatically updated to reflect the committed changes. Closed by commit rG192331b890e2: [lldb] [Process/Linux] Support arbitrarily-sized FPR writes on ARM (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [lldb] f290efc - [lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm*

Author: Michał Górny Date: 2021-10-20T15:06:45+02:00 New Revision: f290efc32622cc59566ec7ac13e74a039b6047c2 URL: https://github.com/llvm/llvm-project/commit/f290efc32622cc59566ec7ac13e74a039b6047c2 DIFF: https://github.com/llvm/llvm-project/commit/f290efc32622cc59566ec7ac13e74a039b6047c2.diff

[Lldb-commits] [lldb] 99277a8 - [lldb] [Process/Utility] Fix value_regs/invalidate_regs for ARM

Author: Michał Górny Date: 2021-10-20T15:06:45+02:00 New Revision: 99277a81f807e6f4c63ececdb6974d6d5f1f3562 URL: https://github.com/llvm/llvm-project/commit/99277a81f807e6f4c63ececdb6974d6d5f1f3562 DIFF: https://github.com/llvm/llvm-project/commit/99277a81f807e6f4c63ececdb6974d6d5f1f3562.diff

[Lldb-commits] [lldb] 192331b - [lldb] [Process/Linux] Support arbitrarily-sized FPR writes on ARM

Author: Michał Górny Date: 2021-10-20T15:06:44+02:00 New Revision: 192331b890e238a8ede4e61e6c5294e7eaa365fd URL: https://github.com/llvm/llvm-project/commit/192331b890e238a8ede4e61e6c5294e7eaa365fd DIFF: https://github.com/llvm/llvm-project/commit/192331b890e238a8ede4e61e6c5294e7eaa365fd.diff

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

georgiev updated this revision to Diff 380922. georgiev added a comment. Diff update CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111899/new/ https://reviews.llvm.org/D111899 Files: lldb/packages/Python/lldbsuite/test/lldbutil.py lldb/test/API/commands/apropos/with-process/TestApr

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

georgiev updated this revision to Diff 380919. georgiev added a comment. Added breakpoint resolved check. Addressed some of the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111899/new/ https://reviews.llvm.org/D111899 Files: lldb/packages/Python/lldbsuite/test/lldbutil.py

[Lldb-commits] [PATCH] D112131: [lldb] [Process/Linux] Support arbitrarily-sized FPR writes on ARM

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, teemperor. Herald added a subscriber: kristof.beyls. mgorny requested review of this revision. Support arbitrarily-sized FPR writes on ARM in order to fix writing qN registers directly. Currently, writing them work

[Lldb-commits] [PATCH] D111030: [lldb] [Host] Add setters for common teletype properties to Terminal

labath added inline comments. Comment at: lldb/source/Host/common/Terminal.cpp:316-347 + bool parity_bit = true; + bool odd_bit = false; + bool stick_bit = false; + + switch (parity) { + case Parity::No: +parity_bit = false; I am wondering if we can avoi

[Lldb-commits] [PATCH] D111355: [lldb] Add serial:// protocol for connecting to serial port

labath added inline comments. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:772-774 + llvm::Error error = llvm::Error::success(); + m_io_sp = std::make_shared(fd, File::eOpenOptionReadWrite, + serial_options.get(),

[Lldb-commits] [PATCH] D111355: [lldb] Add serial:// protocol for connecting to serial port

mgorny added inline comments. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:772-774 + llvm::Error error = llvm::Error::success(); + m_io_sp = std::make_shared(fd, File::eOpenOptionReadWrite, + serial_options.get(),

[Lldb-commits] [lldb] 6561c07 - [lldb] [Process/Utility] Define qN regs on ARM via helper macro

Author: Michał Górny Date: 2021-10-20T13:08:17+02:00 New Revision: 6561c074c072beb6c8e400a62bd5943a1f26a72a URL: https://github.com/llvm/llvm-project/commit/6561c074c072beb6c8e400a62bd5943a1f26a72a DIFF: https://github.com/llvm/llvm-project/commit/6561c074c072beb6c8e400a62bd5943a1f26a72a.diff

[Lldb-commits] [PATCH] D111355: [lldb] Add serial:// protocol for connecting to serial port

labath added inline comments. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:772-774 + llvm::Error error = llvm::Error::success(); + m_io_sp = std::make_shared(fd, File::eOpenOptionReadWrite, + serial_options.get(),

[Lldb-commits] [lldb] 956df6f - [lldb] Improve assert message in TestCPPAccelerator

Author: Raphael Isemann Date: 2021-10-20T12:04:28+02:00 New Revision: 956df6fa620a0ca75fd6e62b5318fb4d14304a4f URL: https://github.com/llvm/llvm-project/commit/956df6fa620a0ca75fd6e62b5318fb4d14304a4f DIFF: https://github.com/llvm/llvm-project/commit/956df6fa620a0ca75fd6e62b5318fb4d14304a4f.dif

[Lldb-commits] [PATCH] D112061: [lldb] Remove ConstString from GetPluginNameStatic of some plugins

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112061/new/ https://reviews.llvm.org/D112061 _

[Lldb-commits] [PATCH] D111990: [lldb/test] Remove quote/unquote steps from the make invocations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG551d118805c8: [lldb/test] Remove quote/unquote steps from the make invocations (authored by labath). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 551d118 - [lldb/test] Remove quote/unquote steps from the make invocations

Author: Pavel Labath Date: 2021-10-20T11:35:28+02:00 New Revision: 551d118805c808936956e464dc21e05acb478f78 URL: https://github.com/llvm/llvm-project/commit/551d118805c808936956e464dc21e05acb478f78 DIFF: https://github.com/llvm/llvm-project/commit/551d118805c808936956e464dc21e05acb478f78.diff

[Lldb-commits] [PATCH] D112058: [lldb/DWARF] Ignore debug info pointing to the low addresses

This revision was automatically updated to reflect the committed changes. Closed by commit rGffbff6c511ba: [lldb/DWARF] Ignore debug info pointing to the low addresses (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112058/new/ h

[Lldb-commits] [lldb] ffbff6c - [lldb/DWARF] Ignore debug info pointing to the low addresses

Author: Pavel Labath Date: 2021-10-20T11:19:30+02:00 New Revision: ffbff6c511ba230954013eca8d824a66f6b4f9a5 URL: https://github.com/llvm/llvm-project/commit/ffbff6c511ba230954013eca8d824a66f6b4f9a5 DIFF: https://github.com/llvm/llvm-project/commit/ffbff6c511ba230954013eca8d824a66f6b4f9a5.diff

[Lldb-commits] [PATCH] D112058: [lldb/DWARF] Ignore debug info pointing to the low addresses

labath added a comment. In D112058#3073451 , @clayborg wrote: > Looks good. Do we need a follow up patch to avoid creating functions that > should have been stripped? I'm not entirely sure what you mean by that. Are you referring to the fact that `Symb

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

tatyana-krasnukha added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py:269 self.expect(side_effect.bp_loc, exe=False, -patterns=["1.* where = .*main .* resolved, hit count = 1"]) +