[Lldb-commits] [lldb] c26e53e - [lldb/test] Disable 'TestScriptedProcess.py' on macOS

2021-10-09 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2021-10-10T03:28:36+02:00 New Revision: c26e53e129085b64f66f0b4cbc5fd4bfdf6575e6 URL: https://github.com/llvm/llvm-project/commit/c26e53e129085b64f66f0b4cbc5fd4bfdf6575e6 DIFF: https://github.com/llvm/llvm-project/commit/c26e53e129085b64f66f0b4cbc5fd4bfdf6575e6.

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add pseudo-regs if missing

2021-10-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 378474. mgorny added a comment. Arrays need explicit initialization. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109876/new/ https://reviews.llvm.org/D109876 Files: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp lldb/test/API/functionalities/g

[Lldb-commits] [PATCH] D111498: [lldb] [DynamicRegisterInfo] Remove AddRegister() and make Finalize() protected

2021-10-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. mgorny requested review of this revision. (note that this assumes parent diffs are merged) Now that AddRegister() is no longer used, remove it. While at it, we can also make Finalize() protected as all

[Lldb-commits] [PATCH] D108050: [wip] [trace] Hierarchical Trace Representation (HTR) redesign and "call stack trace" visualization

2021-10-09 Thread Jakob Johnson via Phabricator via lldb-commits
jj10306 updated this revision to Diff 378464. jj10306 added a comment. Herald added a subscriber: dang. Pulling in the request stitching changes so I can see what modifications were made to the "call stack trace" visualization along the way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D111496: [lldb] [test] Rewrite g/p/G/P tests not to rely on hardcoded ARM regs

2021-10-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, teemperor, jasonmolenda, krytarowski, emaste. Herald added subscribers: omjavaid, pengfei, kristof.beyls. mgorny requested review of this revision. Rewrite the register reading/writing tests to use explicit qRegisterInfo packets rather

[Lldb-commits] [PATCH] D111491: [lldb] [gdb-remote] Remove HardcodeARMRegisters() hack

2021-10-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. Ehh, it seems that we have 4 tests that abuse this to avoid having to pass the register infos: FAIL: LLDB (/home/mgorny/git/llvm-project/build/bin/clang-x86_64) :: test_read_registers_using_g_packets (TestGDBRemoteClient.TestGDBRemoteClient) FAIL: LLDB (/home/mgorny/

[Lldb-commits] [PATCH] D111491: [lldb] [gdb-remote] Remove HardcodeARMRegisters() hack

2021-10-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, teemperor, jasonmolenda, krytarowski, emaste. Herald added a subscriber: kristof.beyls. mgorny requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. HardcodeARMRegisters() is a hack

[Lldb-commits] [PATCH] D111489: [lldb] [DynamicRegisterInfo] Support value_regs with offset

2021-10-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. Herald added a subscriber: pengfei. mgorny requested review of this revision. Support specifying an offset for value_regs[0], and add the offset to the computed derived register offset. This makes it pos

[Lldb-commits] [lldb] fefd0ca - [lldb] [DynamicRegisterInfo] Remove obsolete dwarf typedefs (NFC)

2021-10-09 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-09T15:42:34+02:00 New Revision: fefd0ca31d37e0dc5863a69b064cf2d3645ed4d6 URL: https://github.com/llvm/llvm-project/commit/fefd0ca31d37e0dc5863a69b064cf2d3645ed4d6 DIFF: https://github.com/llvm/llvm-project/commit/fefd0ca31d37e0dc5863a69b064cf2d3645ed4d6.diff

[Lldb-commits] [PATCH] D111435: [lldb] [DynamicRegisterInfo] Support setting from vector

2021-10-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 378443. mgorny added a comment. Add a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111435/new/ https://reviews.llvm.org/D111435 Files: lldb/include/lldb/Target/DynamicRegisterInfo.h lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.

[Lldb-commits] [PATCH] D111295: [lldb] [Target] Make addSupplementaryRegister() work on Register vector

2021-10-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 378442. mgorny added a comment. Make `AssertRegisterInfo()` args non-optional. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111295/new/ https://reviews.llvm.org/D111295 Files: lldb/include/lldb/Target/DynamicRegisterInfo.h lldb/source/Target/Dy

[Lldb-commits] [lldb] b5ff511 - [lldb][NFC] Early-exit in DWARFASTParserClang::ParseSingleMember

2021-10-09 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-10-09T14:40:39+02:00 New Revision: b5ff51104810d09071a5e6ac4c33a0c070f996ca URL: https://github.com/llvm/llvm-project/commit/b5ff51104810d09071a5e6ac4c33a0c070f996ca DIFF: https://github.com/llvm/llvm-project/commit/b5ff51104810d09071a5e6ac4c33a0c070f996ca.dif

[Lldb-commits] [PATCH] D111295: [lldb] [Target] Make addSupplementaryRegister() work on Register vector

2021-10-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 378438. mgorny added a comment. Add `m_` prefix to vars in `DynamicRegisterInfoRegisterTest` class. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111295/new/ https://reviews.llvm.org/D111295 Files: lldb/include/lldb/Target/DynamicRegisterInfo.h