[Lldb-commits] [lldb] a2e1d68 - Add pragma to make it easier to find "image list" impl

2021-09-24 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2021-09-24T17:13:03-07:00 New Revision: a2e1d68fa97de9fe1d8eaf6e03e65c225dfbc52c URL: https://github.com/llvm/llvm-project/commit/a2e1d68fa97de9fe1d8eaf6e03e65c225dfbc52c DIFF: https://github.com/llvm/llvm-project/commit/a2e1d68fa97de9fe1d8eaf6e03e65c225dfbc52c.diff

[Lldb-commits] [lldb] c628875 - [lldb] Copy the system debugserver in LLDB.framework

2021-09-24 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-09-24T15:07:22-07:00 New Revision: c6288759296f808a2f7304bbd1bd5b18974e4ccc URL: https://github.com/llvm/llvm-project/commit/c6288759296f808a2f7304bbd1bd5b18974e4ccc DIFF: https://github.com/llvm/llvm-project/commit/c6288759296f808a2f7304bbd1bd5b18974e4ccc.d

[Lldb-commits] [PATCH] D110447: [lldb] Convert misc. StringConvert uses

2021-09-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, JDevlieghere. mgorny requested review of this revision. Replace misc. StringConvert uses with llvm::to_integer() and llvm::to_float(), except for cases where further refactoring is planned. The purpose of this chan

[Lldb-commits] [PATCH] D110410: [lldb] [Host] Refactor XML converting getters

2021-09-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 374829. mgorny added a comment. Remove obsolete includes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110410/new/ https://reviews.llvm.org/D110410 Files: lldb/source/Host/common/XML.cpp lldb/unittests/Host/CMakeLists.txt lldb/unittests/Host/

[Lldb-commits] [PATCH] D110410: [lldb] [Host] Refactor XML converting getters

2021-09-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, JDevlieghere. mgorny requested review of this revision. Refactor the XML converting attribute and text getters to use LLVM API. While at it, remove some redundant error and missing XML support handling, as the calle

[Lldb-commits] [lldb] 5f1c8d8 - [lldb] [Host] Refactor Socket::DecodeHostAndPort() to use LLVM API

2021-09-24 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-09-24T14:58:02+02:00 New Revision: 5f1c8d8a432deacfeada5e5a3794d0c938171c37 URL: https://github.com/llvm/llvm-project/commit/5f1c8d8a432deacfeada5e5a3794d0c938171c37 DIFF: https://github.com/llvm/llvm-project/commit/5f1c8d8a432deacfeada5e5a3794d0c938171c37.diff

[Lldb-commits] [lldb] c1af84c - Revert "[lldb] [Host] Refactor Socket::DecodeHostAndPort() to use LLVM API"

2021-09-24 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-09-24T13:33:51+02:00 New Revision: c1af84ceaf4fafbfa47f871436986c5c69f65a73 URL: https://github.com/llvm/llvm-project/commit/c1af84ceaf4fafbfa47f871436986c5c69f65a73 DIFF: https://github.com/llvm/llvm-project/commit/c1af84ceaf4fafbfa47f871436986c5c69f65a73.diff

[Lldb-commits] [PATCH] D110391: [lldb] [Host] Refactor Socket::DecodeHostAndPort() to use LLVM API

2021-09-24 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. mgorny marked 2 inline comments as done. Closed by commit rGa6daf99228bc: [lldb] [Host] Refactor Socket::DecodeHostAndPort() to use LLVM API (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: htt

[Lldb-commits] [lldb] a6daf99 - [lldb] [Host] Refactor Socket::DecodeHostAndPort() to use LLVM API

2021-09-24 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-09-24T13:24:58+02:00 New Revision: a6daf99228bc16fb7f2596d67a0d00fef327ace5 URL: https://github.com/llvm/llvm-project/commit/a6daf99228bc16fb7f2596d67a0d00fef327ace5 DIFF: https://github.com/llvm/llvm-project/commit/a6daf99228bc16fb7f2596d67a0d00fef327ace5.diff

[Lldb-commits] [PATCH] D110391: [lldb] [Host] Refactor Socket::DecodeHostAndPort() to use LLVM API

2021-09-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Host/common/Socket.cpp:305 - port_str.clear(); - if (to_integer(host_and_port, port, 10) && port < UINT16_MAX) { -port_str = std::string(host_and_port); labath wr

[Lldb-commits] [PATCH] D110404: [nfc] [lldb] DWZ 08/17: Use DIERef for DIEToClangType m_forward_decl_die_to_clang_type and GetForwardDeclDieToClangType()

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. jankratochvil requested review of this revision. After D96236 using

[Lldb-commits] [PATCH] D110403: [nfc] [lldb] DWZ 07/17: Use DIERef for DIEToVariableSP m_die_to_variable_sp and GetDIEToVariable()

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. After D96236 using just `DWARFDebugInfoEntry *` is

[Lldb-commits] [PATCH] D110402: [nfc] [lldb] DWZ 06/17: Use DIERef for DIEToTypePtr m_die_to_type and GetDIEToType()

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. jankratochvil requested review of this revision. After D96236 using

[Lldb-commits] [PATCH] D110401: [nfc] [lldb] DWZ 05/17: Use DIERef for DIEToDeclMap m_die_to_decl

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. jankratochvil requested review of this revision. After D96236 using

[Lldb-commits] [PATCH] D110400: [nfc] [lldb] DWZ 04/17: Use DIERef for DIEToModuleMap m_die_to_module

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. jankratochvil requested review of this revision. After D96236 using

[Lldb-commits] [PATCH] D110399: [nfc] [lldb] DWZ 03/17: Use DIERef for DIEToDeclContextMap m_die_to_decl_ctx

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. jankratochvil requested review of this revision. After D96236 using

[Lldb-commits] [PATCH] D110397: [nfc] [lldb] DWZ 02/17: Refactor DIERef for a key in llvm::DenseMap

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. Next patch XXX will use DIERef as a key in `llvm::DenseMap`, therefore we need to be

[Lldb-commits] [PATCH] D110396: [nfc] [lldb] DWZ 01/17: Remove DWARFDIE from DeclContextToFileDIERefMap m_decl_ctx_to_filedieref

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. jankratochvil requested review of this revision. Replace `DWARFDIE` by `std::pair`. Currently it has

[Lldb-commits] [PATCH] D96243: [lldb] DWZ 17/17: Fix symlinked /usr/lib/debug/.build-id/**.debug files

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 374781. jankratochvil retitled this revision from "[lldb] DWZ 9/9: Fix symlinked /usr/lib/debug/.build-id/**.debug files" to "[lldb] DWZ 17/17: Fix symlinked /usr/lib/debug/.build-id/**.debug files". jankratochvil edited the summary of this revision. ja

[Lldb-commits] [PATCH] D96242: [lldb] DWZ 16/17: New testcases

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 374779. jankratochvil retitled this revision from "[lldb] DWZ 8/9: New testcases" to "[lldb] DWZ 16/17: New testcases". jankratochvil edited the summary of this revision. jankratochvil added a comment. My question about upstreaming of this patchset.

[Lldb-commits] [PATCH] D96241: [lldb] DWZ 15/17: New testsuite category 'dwz'

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 374778. jankratochvil retitled this revision from "[lldb] DWZ 7/9: New testsuite category 'dwz'" to "[lldb] DWZ 15/17: New testsuite category 'dwz'". jankratochvil edited the summary of this revision. jankratochvil added a comment. My question about ups

[Lldb-commits] [PATCH] D98826: [lldb] DWZ 14/17: Workaround DWZ bug dropping DW_TAG_namespace::DW_AT_export_symbols

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 374776. jankratochvil retitled this revision from "[lldb] DWZ 6/9: Workaround DWZ bug dropping DW_TAG_namespace::DW_AT_export_symbols" to "[lldb] DWZ 14/17: Workaround DWZ bug dropping DW_TAG_namespace::DW_AT_export_symbols". jankratochvil edited the su

[Lldb-commits] [PATCH] D96240: [lldb] DWZ 13/17: Main functionality

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 374775. jankratochvil retitled this revision from "[lldb] DWZ 5/9: Main functionality" to "[lldb] DWZ 13/17: Main functionality". jankratochvil edited the summary of this revision. jankratochvil added a comment. Herald added a reviewer: jdoerfert. Herald

[Lldb-commits] [PATCH] D96239: [lldb] DWZ 12/17: DIERef support

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 374774. jankratochvil retitled this revision from "[lldb] DWZ 4/9: DIERef support" to "[lldb] DWZ 12/17: DIERef support". jankratochvil edited the summary of this revision. jankratochvil added a comment. My question about upstreaming of this patchset.

[Lldb-commits] [PATCH] D96238: [lldb] [nfc] DWZ 11/17: rename TypeUnitSupportFiles -> SharedUnitSupportFiles

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 374773. jankratochvil retitled this revision from "[lldb] [nfc] DWZ 3/9: rename TypeUnitSupportFiles -> SharedUnitSupportFiles" to "[lldb] [nfc] DWZ 11/17: rename TypeUnitSupportFiles -> SharedUnitSupportFiles". jankratochvil edited the summary of this

[Lldb-commits] [PATCH] D96237: [lldb] DWZ 10/17: More support for .gnu_debugaltlink

2021-09-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 374772. jankratochvil retitled this revision from "[lldb] DWZ 2/9: More support for .gnu_debugaltlink" to "[lldb] DWZ 10/17: More support for .gnu_debugaltlink". jankratochvil edited the summary of this revision. jankratochvil added a comment. My questi

[Lldb-commits] [PATCH] D110391: [lldb] [Host] Refactor Socket::DecodeHostAndPort() to use LLVM API

2021-09-24 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Host/common/Socket.cpp:305 - port_str.clear(); - if (to_integer(host_and_port, port, 10) && port < UINT16_MAX) { -port_str = std::string(hos

[Lldb-commits] [PATCH] D110391: [lldb] [Host] Refactor Socket::DecodeHostAndPort() to use LLVM API

2021-09-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 374762. mgorny edited the summary of this revision. mgorny added a comment. Change the return type to `llvm::Error`, replacing duplicate `bool`+`Status`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110391/new/ https://reviews.llvm.org/D110391 File

[Lldb-commits] [PATCH] D110391: [lldb] [Host] Refactor Socket::DecodeHostAndPort() to use LLVM API

2021-09-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, JDevlieghere. mgorny requested review of this revision. Refactor Socket::DecodeHostAndPort() to use LLVM API over redundant LLDB API. In particular, this means llvm::Regex and llvm::StringRef.getAsInteger(). While

[Lldb-commits] [lldb] cd6893a - [lldb] Fix target-symbols-add-unwind.test for clang 7647a841

2021-09-24 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2021-09-24T09:06:44+02:00 New Revision: cd6893a5a346d1b9c34ba621adad5f881e250695 URL: https://github.com/llvm/llvm-project/commit/cd6893a5a346d1b9c34ba621adad5f881e250695 DIFF: https://github.com/llvm/llvm-project/commit/cd6893a5a346d1b9c34ba621adad5f881e250695.diff