[Lldb-commits] [PATCH] D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yeah, on macOS we'll always have a UUID so this is a good change. The only time an arch is really important is if we don't have a UUID and we have a universal binary (aka fat file

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

tammela added a comment. Hi Siger, We are almost there. I encourage you to continue working on this patch. I have been busy the past weeks, but I will try to review ASAP once you address my comments. Comment at: lldb/bindings/lua/lua-typemaps.swig:219-221 +%typecheck(SWIG_TY

[Lldb-commits] [PATCH] D110011: [lldb] Add --stack option to `target symbols add` command

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4300-4301 + current_frame_flush)) +symbols_found = true; + flush |= current_frame_flush; +

[Lldb-commits] [PATCH] D110011: [lldb] Add --stack option to `target symbols add` command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4300 + bool current_frame_flush = false; + if (DownloadObjectAndSymbolFile(module_spec, target, result, + current_frame_flush)) -

[Lldb-commits] [PATCH] D110011: [lldb] Add --stack option to `target symbols add` command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4300-4301 + current_frame_flush)) +symbols_found = true; + flush |= current_frame_flush; +} JDevlieghere wrote: > kas

[Lldb-commits] [lldb] 3b14d80 - [MachCore] Report arm64 thread exception state

Author: Vedant Kumar Date: 2021-09-17T16:45:03-07:00 New Revision: 3b14d80ad4af303c9f7df189b8b7eee528d0ec8d URL: https://github.com/llvm/llvm-project/commit/3b14d80ad4af303c9f7df189b8b7eee528d0ec8d DIFF: https://github.com/llvm/llvm-project/commit/3b14d80ad4af303c9f7df189b8b7eee528d0ec8d.diff

[Lldb-commits] [PATCH] D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present

vsk created this revision. vsk added reviewers: jasonmolenda, jingham, JDevlieghere. Herald added subscribers: pengfei, kristof.beyls. vsk requested review of this revision. Herald added a project: LLDB. When adding an image to a target for crashlog purposes, avoid specifying the architecture of t

[Lldb-commits] [PATCH] D110011: [lldb] Add --stack option to `target symbols add` command

JDevlieghere updated this revision to Diff 373364. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110011/new/ https://reviews.llvm.org/D110011 Files: lldb/source/Commands/CommandObjectTarget.cpp Index: lldb/source/Commands/CommandObjectTar

[Lldb-commits] [PATCH] D110011: [lldb] Add --stack option to `target symbols add` command

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4267-4270 +if (!StateIsStoppedState(process_state, true)) { + result.AppendErrorWithFormat("process is not stopped: %s", +

[Lldb-commits] [PATCH] D110011: [lldb] Add --stack option to `target symbols add` command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4300-4301 + current_frame_flush)) +symbols_found = true; + flush |= current_frame_flush; +} do you need the separate

[Lldb-commits] [PATCH] D110011: [lldb] Add --stack option to `target symbols add` command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4267-4270 +if (!StateIsStoppedState(process_state, true)) { + result.AppendErrorWithFormat("process is not stopped: %s", + StateAsCString(process

[Lldb-commits] [PATCH] D110011: [lldb] Add --stack option to `target symbols add` command

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, labath, jingham. JDevlieghere requested review of this revision. Currently you can ask the `target symbols add` command to locate the debug symbols for the current frame. This patch add an options to do that for the who

[Lldb-commits] [PATCH] D110010: [lldb] Extract adding symbols for UUID/File/Frame (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, labath, jingham. JDevlieghere requested review of this revision. This moves the logic for adding symbols based on UUID, file and frame into little helper functions. https://reviews.llvm.org/D110010 Files: lldb/sourc

[Lldb-commits] [lldb] e93bade - [nfc] [lldb] Remove unused DIEPointerSet, DeclToDIEMap and m_decl_to_die

Author: Jan Kratochvil Date: 2021-09-17T21:51:36+02:00 New Revision: e93baded39578d62139656833c9b926d5cf78ba5 URL: https://github.com/llvm/llvm-project/commit/e93baded39578d62139656833c9b926d5cf78ba5 DIFF: https://github.com/llvm/llvm-project/commit/e93baded39578d62139656833c9b926d5cf78ba5.diff

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted added a comment. I've got a test written. It doesn't crash like the debugger in the wild does, but it does give a tid of 0 for each thread I ask about. So I can assert if the threads don't have the correct tid. With the patch, the test passes (gets the tids correctly) Without the patch and

[Lldb-commits] [PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

Quuxplusone added a comment. I was inspired to dig down and find the `LLVM_ENABLE_LIBXML2` option (which is on by default) and turn it off, so now I can build clang with the following commands: cmake -G Ninja -DLLVM_ENABLE_LIBXML2=0 -DDEFAULT_SYSROOT="$(xcrun --show-sdk-path)" -DLLVM_ENABLE_

[Lldb-commits] [PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

zero9178 added a comment. In D109975#3006580 , @Quuxplusone wrote: > Serendipitously, I just yesterday upgraded from OSX 10.14 to 10.15, and have > been unable to build clang because, even with a totally-empty-and-brand-new > build directory, CMake say

[Lldb-commits] [PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

Quuxplusone added a comment. Herald added a subscriber: JDevlieghere. Serendipitously, I just yesterday upgraded from OSX 10.14 to 10.15, and have been unable to build clang because, even with a totally-empty-and-brand-new build directory, CMake says: CMake Error in lib/WindowsManifest/CMakeL

[Lldb-commits] [PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

zero9178 created this revision. zero9178 added reviewers: phosek, hans, MaskRay, compnerd. Herald added subscribers: arphaman, mgorny. zero9178 requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Linking against the LibXml2::L

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted added a comment. I agree about the test. I'll work on one. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2911-2912 +// if ids is empty, this is an error +if (ids.size() == 0) + return {}; +

[Lldb-commits] [PATCH] D109777: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

mstorsjo updated this revision to Diff 373195. mstorsjo added a comment. Refactored to override and use GetSoftwareBreakpointPCOffset in NativeProcessWindows.cpp. Not factorized the implementations to share code, if one of the implementations is bound to be removed at some point. Repository:

[Lldb-commits] [PATCH] D109777: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

mstorsjo added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp:495-514 +int breakpoint_size = 1; +switch (GetArchitecture().GetMachine()) { +case llvm::Triple::aarch64: + breakpoint_size = 4; +

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

labath added a comment. In D109797#3004232 , @emrekultursay wrote: > In D109797#3003265 , @labath wrote: > >> Since the meaning of `m_initial_modules_added` is basically "should I do a >> full scan through the l

[Lldb-commits] [PATCH] D109879: [lldb] [DynamicRegisterInfo] Update RegisterInfo with copy of value_regs/invalidate_regs

labath added a comment. (Though, if we're going to be modifying/expanding these lists in subsequent AddRegister calls, then maybe it does not make that much sense...) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109879/new/ https://reviews.llvm.org/D109879 ___

[Lldb-commits] [PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

labath added a comment. I suppose the meaning is "I can set breakpoints in host binaries", though if the entire symbol file plugin is not functional without the DIA SDK, then "I can parse host debug info" would be more correct, as the breakpoints are only the first thing you'll typically run in

[Lldb-commits] [PATCH] D109879: [lldb] [DynamicRegisterInfo] Update RegisterInfo with copy of value_regs/invalidate_regs

labath added a comment. FWIW, I think that doing this stuff immediately is a actually good idea. It avoids having a time window where info->value_regs is a dangling pointer, and it doesn't save us any work, since this is something we have to do anyway... CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

labath added a reviewer: mgorny. labath added a comment. +1 for the test. It should be fairly easy to rig up a "gdb-remote client" test that sends such a packet. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2909-2917 + if (!pid_