[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

teemperor added inline comments. Comment at: lldb/docs/testsuite/best-practices.rst:53 + +Cleanup after yourself +-- This section here seems very outdated, can we just delete it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D108807: [LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to respective .rst files

xgupta added a comment. I can confirm that it renders correctly, please commit it at your convenience. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108807/new/ https://reviews.llvm.org/D108807

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta added a comment. I can confirm that it renders correctly, please commit it at your convenience. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369254. xgupta added a comment. Herald added a subscriber: arphaman. add best-practices entry to index.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lld

[Lldb-commits] [PATCH] D108807: [LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to respective .rst files

xgupta updated this revision to Diff 369253. xgupta added a comment. Herald added a subscriber: arphaman. add lldb-for-gdb-users entry to index.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108807/new/ https://reviews.llvm.org/D108807 Files:

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks for doing this. Presuming you've verified that it renders correctly, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ htt

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta added inline comments. Comment at: lldb/docs/testsuite/best-practices.rst:19 + +:: + mgorny wrote: > …seems to be a common pattern in LLVM. > > (and similarly for other instances of `::`) Thanks, I missed that. Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta updated this revision to Diff 369252. xgupta added a comment. Fix .. code-block:: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 Files: lldb/docs/testsuite/best-practices.rst lldb/docs/testsui

[Lldb-commits] [PATCH] D108807: [LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to respective .rst files

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Presuming you've verified that it renders correctly, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108807/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D108807: [LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to respective .rst files

xgupta added inline comments. Comment at: lldb/docs/use/lldb-for-gdb-users.rst:40 + +> (lldb) process launch -- -program_arg value mgorny wrote: > This style looks a bit weird. Any reason not to use indentation instead of > `>`? Yes, I mistakenly followed http

[Lldb-commits] [PATCH] D108807: [LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to respective .rst files

xgupta updated this revision to Diff 369251. xgupta added a comment. remove extra ">" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108807/new/ https://reviews.llvm.org/D108807 Files: lldb/docs/lldb-for-gdb-users.txt lldb/docs/use/links.md l

[Lldb-commits] [PATCH] D108807: [LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to respective .rst files

mgorny added inline comments. Comment at: lldb/docs/use/lldb-for-gdb-users.rst:40 + +> (lldb) process launch -- -program_arg value This style looks a bit weird. Any reason not to use indentation instead of `>`? Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

mgorny requested changes to this revision. mgorny added inline comments. This revision now requires changes to proceed. Comment at: lldb/docs/testsuite/best-practices.rst:19 + +:: + …seems to be a common pattern in LLVM. (and similarly for other instances of `::