[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion with using file path.

HirokiImai updated this revision to Diff 369220. HirokiImai added a comment. Apply clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108817/new/ https://reviews.llvm.org/D108817 Files: lldb/source/Host/common/Editline.cpp Index: lldb/

[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

jingham added a comment. I just started reading this but I have to go now. Had one comment about errors from Dispatch. I'll look more later. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp:80 - return static_cast(*should_stop);

[Lldb-commits] [PATCH] D107079: [lldb] Add an option for emitting LLDB logs as JSON

jingham added a comment. I have a few little grammatical nits. The suggestion to use EnumArgs rather than a fresh argument type you can do or not as you see fit. It really seems to me that SBDebugger.EnableLog should provide a way to set the OutputFormat. For humans, the plain text is probabl

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

jankratochvil accepted this revision. jankratochvil added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:556 + " (ranges list base: 0x%" PRIx64 "): %s", + offset, m_ranges_base, to

[Lldb-commits] [PATCH] D107079: [lldb] Add an option for emitting LLDB logs as JSON

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. I think this is a great overall addition, might be good to have at least one other reviewer sign off though. (Summoning @jingham!) Should we add a python script to pretty-print a JSON log f

[Lldb-commits] [PATCH] D101406: Rename human-readable name for DW_LANG_Mips_Assembler

aprantl added a comment. > It doesn't make sense to warn about that. :) Why not? LLDB doesn't have support for assembler as a source language, no assembler expression evaluator, etc.. I don't have much experience debugging assembler sources with LLDB, so I"m not sure about the expectations.

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. No worries on only saving out the minimal for now, but just make sure that you error out if CoreStyle is anything but "eSaveCoreUnspecified" or "eSaveCoreStackOnly". =

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

mgorny added a comment. @jasonmolenda, ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107780/new/ https://reviews.llvm.org/D107780 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [PATCH] D107664: [lldb] [Commands] Remove 'append' from 'platform file open' mode

mgorny added a comment. @jasonmolenda, ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107664/new/ https://reviews.llvm.org/D107664 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [PATCH] D100206: [lldb] [llgs client] Support minimal fork/vfork handling

mgorny added a comment. @JDevlieghere, ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100206/new/ https://reviews.llvm.org/D100206 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

mgorny updated this revision to Diff 369130. mgorny added a comment. Remove unnecessary include. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://reviews.llvm.org/D108831 Files: lldb/source/Plugins/Process/gdb-remote/CMakeLists.txt lldb/source/Plugins/Process/gdb-r

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

mgorny created this revision. mgorny added reviewers: krytarowski, jasonmolenda, JDevlieghere, labath, emaste. Herald added a subscriber: pengfei. mgorny requested review of this revision. Add a pre- and post-finalize hooks to GDBRemoteRegisterContext that add missing pseudo-register on x86_64. T

[Lldb-commits] [PATCH] D107669: [trace] [intel pt] Create a "process trace save" command

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG602497d672ca: [trace] [intel pt] Create a "process trace save" com

[Lldb-commits] [lldb] 602497d - [trace] [intel pt] Create a "process trace save" command

Author: Walter Erquinigo Date: 2021-08-27T09:34:01-07:00 New Revision: 602497d672ca66f3f0e59adca35f00199f266810 URL: https://github.com/llvm/llvm-project/commit/602497d672ca66f3f0e59adca35f00199f266810 DIFF: https://github.com/llvm/llvm-project/commit/602497d672ca66f3f0e59adca35f00199f266810.di

[Lldb-commits] [PATCH] D108816: [lldb] Return all line entries matchign a line if no column is specified

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108816/new/ https://reviews.llvm.org/D108816

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta added a comment. I later realize that we already have https://lldb.llvm.org/resources/test.html which contains some similar instructions to write testcases. So not sure we want to have this document. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

xgupta created this revision. xgupta updated this revision to Diff 369103. xgupta added a comment. xgupta published this revision for review. xgupta added reviewers: teemperor, mgorny, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add ToC This file contain

[Lldb-commits] [PATCH] D108807: [LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to respective .rst files

xgupta created this revision. xgupta updated this revision to Diff 369063. xgupta added a comment. xgupta updated this revision to Diff 369099. xgupta retitled this revision from "[LLDB][Docs] Convert some .txt files to .rst" to "[LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to resp

[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion with using file path.

HirokiImai created this revision. Herald added a subscriber: pengfei. HirokiImai requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When I run a lldb command that uses filename completion, if I enter a string that is not only a filename but

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

kimanh added a comment. Friendly ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107456/new/ https://reviews.llvm.org/D107456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D108816: [lldb] Return all line entries matchign a line if no column is specified

kimanh created this revision. kimanh added reviewers: mib, JDevlieghere. kimanh published this revision for review. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously, if no column was specified, ResolveSymbolContext would take the first match returned by FindLineEnt

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp:519 +lldb_private::Status +MinidumpFileBuilder::AddMemoryList(const lldb::ProcessSP &process_sp) { + Status error; Aj0SK wrote: > clayborg wrote: > > This sh

[Lldb-commits] [PATCH] D108768: [lldb] DynamicRegisterInfo: fix wrong regnos in Dump()

mgorny updated this revision to Diff 369048. mgorny added a comment. Also updated the comments in `struct RegisterInfo` to indicate what kind of numbers go in these arrays. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108768/new/ https://reviews.llvm.org/D108768 Files: lldb/include

[Lldb-commits] [PATCH] D108768: [lldb] DynamicRegisterInfo: fix wrong regnos in Dump()

mgorny updated this revision to Diff 369042. mgorny retitled this revision from "[lldb] [DynamicRegisterInfo] Fix mistaken reg type when calculating offsets" to "[lldb] DynamicRegisterInfo: fix wrong regnos in Dump()". mgorny edited the summary of this revision. mgorny added a comment. So I've g