[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

dblaikie added a comment. Might be worth checking who wrote some of this/nearby code and whether they're still active in the community and see if they can review this - not sure if Pavel is around/has the bandwidth to review this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105732/ne

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

apoos-maximus added a comment. In D106226#2891107 , @teemperor wrote: > Also I wonder how we could make sure we emit this diagnostic in cases where > the ptrace_scope is actually the reason for the failed attach. The proper way > to check this seems to

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

apoos-maximus added a comment. In D106226#2891107 , @teemperor wrote: > Congrats on getting started on your first patch! I improving this error > message really seems like a good idea. Thanks : ) ! > From what I can see the error message here is ident

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

apoos-maximus added a comment. In D106226#2886627 , @DavidSpickett wrote: > It changes whether the output goes to stdout or stderr and whether we set the > return status to failed. So I would merge it into one call to > `AppendErrorWithFormat`. Thanks

[Lldb-commits] [PATCH] D106501: [trace] Add the definition of a TraceExporter plugin

clayborg added a comment. Lets go ahead and and the "thread trace export" command as part of this to show how this API will get used and function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106501/new/ https://reviews.llvm.org/D106501

[Lldb-commits] [PATCH] D106501: [trace] Add the definition of a TraceExporter plugin

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Herald added a subscriber: JDevlieghere. Just switch to unique_ptr and this will be good to go. Comment at: lldb/include/lldb/lldb-forward.h:445 typedef std::s

[Lldb-commits] [PATCH] D106194: Tests for: D100299: Be lazier about loading .dwo files

Eric added a comment. Thank you for helping me with this! Do you want me to merge these changes into my own CL or do you want to check this in yourself? Instead of echoing into .c files, can we write the tests as .c files? It seems to be a common pattern to use a single source as two sources by

[Lldb-commits] [PATCH] D106501: [trace] Add the definition of a TraceExporter plugin

wallace created this revision. wallace added a reviewer: clayborg. Herald added a subscriber: mgorny. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Copying from the inline documentation: Trace exporter plug-ins operate on trace

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

clayborg added a comment. In D106192#2894392 , @OmarEmaraDev wrote: >> Are you going to land the other smaller diffs first and then update this one >> after hey have landed? > > Yes. There is much dependency between patches, so the smaller ones will hav

[Lldb-commits] [PATCH] D106483: [LLDB][GUI] Add Platform Plugin Field

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Actually this doesn't apply cleanly to top of tree right now. Can you resolve the conflicts and update the patch? Two other of your patches recently have been committed. Reposi

[Lldb-commits] [PATCH] D106458: [LLDB][GUI] Add required property to text fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ef7de7c819d: [LLDB][GUI] Add required property to text fields (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Monor

[Lldb-commits] [lldb] 9ef7de7 - [LLDB][GUI] Add required property to text fields

Author: Omar Emara Date: 2021-07-21T14:40:43-07:00 New Revision: 9ef7de7c819d39eaa4176d046083bf585c9274b0 URL: https://github.com/llvm/llvm-project/commit/9ef7de7c819d39eaa4176d046083bf585c9274b0 DIFF: https://github.com/llvm/llvm-project/commit/9ef7de7c819d39eaa4176d046083bf585c9274b0.diff LO

[Lldb-commits] [PATCH] D106467: [LLDB][GUI] Add Process Plugin Field

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc93dc2597a58: [LLDB][GUI] Add Process Plugin Field (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] c93dc25 - [LLDB][GUI] Add Process Plugin Field

Author: Omar Emara Date: 2021-07-21T14:38:29-07:00 New Revision: c93dc2597a587bc4caedc20f3829501f88cca288 URL: https://github.com/llvm/llvm-project/commit/c93dc2597a587bc4caedc20f3829501f88cca288 DIFF: https://github.com/llvm/llvm-project/commit/c93dc2597a587bc4caedc20f3829501f88cca288.diff LO

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

mgorny added a comment. In D100503#2894584 , @vadimcn wrote: > @mgorny Do your changes allow debugging both the parent and child processes > after a fork? No. This patch supports choosing either the parent or the child but it's a step in that directio

[Lldb-commits] [lldb] 29af527 - [intel pt] fix builds

Author: Walter Erquinigo Date: 2021-07-21T14:10:09-07:00 New Revision: 29af527c86825e420a75d66c236f2a04f19eb2fe URL: https://github.com/llvm/llvm-project/commit/29af527c86825e420a75d66c236f2a04f19eb2fe DIFF: https://github.com/llvm/llvm-project/commit/29af527c86825e420a75d66c236f2a04f19eb2fe.di

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

vadimcn added a comment. @mgorny Do your changes allow debugging both the parent and child processes after a fork? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100503/new/ https://reviews.llvm.org/D100503 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:136-140 + /// Updates block_id: block mapping and append `block_id` to the block id + /// trace + void AddNewBlock(size_t block_id, HTRBlock &block); + /// Append `block_id` to the block id trace +

[Lldb-commits] [PATCH] D105649: [LLDB] Move Trace-specific classes into separate library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e6b31c3952b: [LLDB] Move Trace-specific classes into separate library (authored by bulbazord). Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [lldb] 8e6b31c - [LLDB] Move Trace-specific classes into separate library

Author: Alex Langford Date: 2021-07-21T13:28:34-07:00 New Revision: 8e6b31c3952b366fc3fa0da8e3df7fc09fa65b05 URL: https://github.com/llvm/llvm-project/commit/8e6b31c3952b366fc3fa0da8e3df7fc09fa65b05 DIFF: https://github.com/llvm/llvm-project/commit/8e6b31c3952b366fc3fa0da8e3df7fc09fa65b05.diff

[Lldb-commits] [PATCH] D106458: [LLDB][GUI] Add required property to text fields

OmarEmaraDev updated this revision to Diff 360575. OmarEmaraDev added a comment. - Remove default arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106458/new/ https://reviews.llvm.org/D106458 Files: lldb/source/Core/IOHandlerCursesGUI.cpp

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev added a comment. > Are you going to land the other smaller diffs first and then update this one > after hey have landed? Yes. There is much dependency between patches, so the smaller ones will have to land first then we will rebase this one on main. Also, notice that the smaller p

[Lldb-commits] [PATCH] D106483: [LLDB][GUI] Add Platform Plugin Field

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new Platform Plugin Field. It is a choices field

[Lldb-commits] [PATCH] D106458: [LLDB][GUI] Add required property to text fields

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Nice smaller changes! Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1079 + TextFieldDelegate(const char *label, const char *content, +

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

clayborg added a comment. In D106192#2893862 , @OmarEmaraDev wrote: > I am currently breaking this patch into smaller independent viable patches as > suggested. That will make reviews much easier. Are you going to land the other smaller diffs first an

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:136-140 + /// Updates block_id: block mapping and append `block_id` to the block id + /// trace + void AddNewBlock(size_t block_id, HTRBlock &block); + /// Append `block_id` to the block id trace +

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

rdhindsa added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105732/new/ https://reviews.llvm.org/D105732 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D105649: [LLDB] Move Trace-specific classes into separate library

bulbazord updated this revision to Diff 360542. bulbazord added a comment. Updating Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105649/new/ https://reviews.llvm.org/D105649 Files: lldb/include/lldb/Target/ThreadPostMortemTrace.h lldb/include

[Lldb-commits] [PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106266/new/ https://reviews.llvm.org/D106266 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. Much better! We are getting closer. There's documentation missing. Besides, you should use unique_ptrs as mentioned in the comments so that you prevent copying massively large obje

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. Is it really just a microoptimization or can you measure any improvement? That `ManualDWARFIndex::Index` will be called is expected. But there should be `m_units_to_avoid` covering all the units so it will quickly return without indexing anything: if (units_to_

[Lldb-commits] [PATCH] D106467: [LLDB][GUI] Add Process Plugin Field

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new Process Plugin Field. It is a choices field

[Lldb-commits] [PATCH] D106466: [llvm+lldb] 2/2: Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil created this revision. jankratochvil added reviewers: dblaikie, labath, clayborg. jankratochvil added projects: LLDB, LLVM. Herald added subscribers: JDevlieghere, hiraditya. jankratochvil requested review of this revision. Fix D98289 so that it work

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev added a comment. Thanks @DavidSpickett! I will look into this and let you know how it goes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106192/new/ https://reviews.llvm.org/D106192 ___ lld

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev added a comment. I am currently breaking this patch into smaller independent viable patches as suggested. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1309 +FileSpec file_spec(m_content); +FileSystem::Instance().Resolve(file_spec); +return file_

[Lldb-commits] [PATCH] D106459: [LLDB][GUI] Check fields validity in actions

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a virtual method HasError to fields, it can be ove

[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

wallace added a comment. Committed on behalf of @hanbingwang. Commit hash 345ace026b6e5cdbc38d207291e4b399d72e62ee Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105717/new/ htt

[Lldb-commits] [PATCH] D106458: [LLDB][GUI] Add required property to text fields

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a required property to text fields and their deriv

[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG345ace026b6e: [trace] [intel pt] Create a "thread trace dump stats" command (authored by Walter Erquinigo ). Changed prior to commit

[Lldb-commits] [lldb] 345ace0 - [trace] [intel pt] Create a "thread trace dump stats" command

Author: Walter Erquinigo Date: 2021-07-21T09:50:15-07:00 New Revision: 345ace026b6e5cdbc38d207291e4b399d72e62ee URL: https://github.com/llvm/llvm-project/commit/345ace026b6e5cdbc38d207291e4b399d72e62ee DIFF: https://github.com/llvm/llvm-project/commit/345ace026b6e5cdbc38d207291e4b399d72e62ee.di

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 added inline comments. Comment at: lldb/source/Target/TraceHTR.cpp:205-217 + // Why does using `IHTRLayer ¤t_layer = m_instruction_layer;` not work? + HTRInstructionLayer instruction_layer = m_instruction_layer; + HTRBlockLayer current_layer = BasicSuperBlockMerge(inst

[Lldb-commits] [lldb] 278df28 - [nfc] [lldb] Rename GetRnglist() to GetRnglistTable()

Author: Jan Kratochvil Date: 2021-07-21T10:45:37+02:00 New Revision: 278df28557f138481ac852d2d064d4c27626048a URL: https://github.com/llvm/llvm-project/commit/278df28557f138481ac852d2d064d4c27626048a DIFF: https://github.com/llvm/llvm-project/commit/278df28557f138481ac852d2d064d4c27626048a.diff