[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. This looks good. Lets get this in so we can start using it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, jingham, clayborg. Herald added a subscriber: dang. JDevlieghere requested review of this revision. Add the ability to silence `command script import`. The motivation for this change is being able to add `command script

[Lldb-commits] [PATCH] D100261: [lldb] [gdb-remote server] Support selecting process via Hg

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2121 +return SendErrorResponse(llvm::make_error( +inconvertibleErrorCode(), "Malformed thread-id")); + mgorny wrote: > JDevlie

[Lldb-commits] [PATCH] D100262: [lldb] [gdb-remote client] Support switching PID along with TID

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h:337 - llvm::Optional SendSetCurrentThreadPacket(uint64_t tid, char type); + llvm::Optional> + SendSetCurrentThreadPacket(uint64_t tid, uint64_t pid, char type); -

[Lldb-commits] [PATCH] D100459: [lldb] [gdb-remote client] Refactor SetCurrentThread*()

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2613 + packet.PutChar(op); if (tid == UINT64_MAX) +packet.PutCString("-1"); JDevlieghere wrote: > Should this be `LLDB_INVALID_THREAD_ID`?

[Lldb-commits] [PATCH] D100261: [lldb] [gdb-remote server] Support selecting process via Hg

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2121 +return SendErrorResponse(llvm::make_error( +inconvertibleErrorCode(), "Malformed thread-id")); + JDevlieghere wrote: > Would i

[Lldb-commits] [PATCH] D100459: [lldb] [gdb-remote client] Refactor SetCurrentThread*()

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2613 + packet.PutChar(op); if (tid == UINT64_MAX) +packet.PutCSt

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/tools/lldb-vscode/variables/TestVSCode_variables.py:53 if varRef != 0 and varref_dict is not None: -v

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan updated this revision to Diff 355942. yinghuitan marked 13 inline comments as done. yinghuitan added a comment. Address review comments and add testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105166/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

JDevlieghere added a comment. There are a bunch of unrelated changes in this patch. Can you please drop them or split them off into a separate patch? Comment at: lldb/docs/conf.py:180-182 +# Add any extra stylesheets and scripts here. +html_css_files = ['lldb.css'] +html_js_fi

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

DavidSpickett added a comment. For TBI, this looks good as is, I would like to see PAC tested as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101361/new/ https://reviews.llvm.org/D101361 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

mib added a comment. In D105133#2852246 , @jankratochvil wrote: > Thanks for the review. No problem! Thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105133/new/ https://reviews.llv

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

jankratochvil added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105133/new/ https://reviews.llvm.org/D105133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe825c244b606: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64 (authored by jankratochvil). Repository: rG LLVM Github Monore

[Lldb-commits] [lldb] e825c24 - [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

Author: Jan Kratochvil Date: 2021-07-01T09:16:07+02:00 New Revision: e825c244b6063344ae726600d6a1225a05788dfa URL: https://github.com/llvm/llvm-project/commit/e825c244b6063344ae726600d6a1225a05788dfa DIFF: https://github.com/llvm/llvm-project/commit/e825c244b6063344ae726600d6a1225a05788dfa.diff