[Lldb-commits] [PATCH] D104406: Express PathMappingList::FindFile() in terms of PathMappingList.h::RemapPath() (NFC)

shafik added a comment. Looks good but would rather a second eye on this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104406/new/ https://reviews.llvm.org/D104406 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D104405: Change PathMappingList::FindFile to return an optional result (NFC)

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Core/SourceManager.cpp:444 if (!FileSystem::Instance().Exists(m_file_spec)) { -FileSpec new_file_spec; // Check target sp

[Lldb-commits] [PATCH] D104951: [lldb] Use the non-locking variant of objc_copyRealizedClassList

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGffc053385587: [lldb] Use the non-locking variant of objc_copyRealizedClassList (authored by JDevlieghere). Herald added a project: LLDB. Repository:

[Lldb-commits] [lldb] ffc0533 - [lldb] Use the non-locking variant of objc_copyRealizedClassList

Author: Jonas Devlieghere Date: 2021-06-25T15:02:49-07:00 New Revision: ffc0533855871f4c784f6535044ce7c2bd076392 URL: https://github.com/llvm/llvm-project/commit/ffc0533855871f4c784f6535044ce7c2bd076392 DIFF: https://github.com/llvm/llvm-project/commit/ffc0533855871f4c784f6535044ce7c2bd076392.d

[Lldb-commits] [lldb] 4eabb12 - Add support for the NSMutableDictionary variant: "__NSFrozenDictionaryM"

Author: Jim Ingham Date: 2021-06-25T14:59:26-07:00 New Revision: 4eabb12057616f360b2329f63c0379eced3135b4 URL: https://github.com/llvm/llvm-project/commit/4eabb12057616f360b2329f63c0379eced3135b4 DIFF: https://github.com/llvm/llvm-project/commit/4eabb12057616f360b2329f63c0379eced3135b4.diff LO

[Lldb-commits] [PATCH] D104954: Implement AddSymbols method for SymbolFileNativePDB

amccarth created this revision. amccarth added a reviewer: rnk. amccarth requested review of this revision. In theory, this adds symbols from the module's PDB file to the symtab. This implementation was modeled after the one in SymbolFilePDB, so it relies on the same IPDBSession abstraction as

[Lldb-commits] [PATCH] D104724: Modernize Module::RemapFile to return an Optional

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104724/new/ https://reviews.llvm.org/D104724 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D104951: [lldb] Use the non-locking variant of objc_copyRealizedClassList

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That seems fine to me. We already only allow one thread to run when we make this call, and copyRealizedClassList is read only, so at worst this will crash if the list is getting edited, but

[Lldb-commits] [PATCH] D104405: Change PathMappingList::FindFile to return an optional result (NFC)

aprantl added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104405/new/ https://reviews.llvm.org/D104405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104404: Change PathMappingList::RemapPath to return an optional result (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cf7c6c6a44d: Change PathMappingList::RemapPath to return an optional result (NFC) (authored by aprantl). Herald added a project: LLDB. Changed prio

[Lldb-commits] [lldb] 4cf7c6c - Change PathMappingList::RemapPath to return an optional result (NFC)

Author: Adrian Prantl Date: 2021-06-25T14:15:29-07:00 New Revision: 4cf7c6c6a44dba6d7f3c13059f966412df89fe75 URL: https://github.com/llvm/llvm-project/commit/4cf7c6c6a44dba6d7f3c13059f966412df89fe75 DIFF: https://github.com/llvm/llvm-project/commit/4cf7c6c6a44dba6d7f3c13059f966412df89fe75.diff

[Lldb-commits] [PATCH] D104951: [lldb] Use the non-locking variant of objc_copyRealizedClassList

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. JDevlieghere requested review of this revision. Avoid standing the Objective-C runtime lock by calling `objc_copyRealizedClassList_nolock` instead of `objc_copyRealizedClassList`. We already guarantee that no other threa

[Lldb-commits] [PATCH] D104407: Improve path remapping in cross-debugging scenarios

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with a few nits Comment at: lldb/source/Target/PathMappingList.cpp:160 +auto e = llvm::sys::path::end(components); +if (component != e && +ll

[Lldb-commits] [PATCH] D104407: Improve path remapping in cross-debugging scenarios

aprantl added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104407/new/ https://reviews.llvm.org/D104407 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104724: Modernize Module::RemapFile to return an Optional

aprantl added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104724/new/ https://reviews.llvm.org/D104724 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104406: Express PathMappingList::FindFile() in terms of PathMappingList.h::RemapPath() (NFC)

aprantl added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104406/new/ https://reviews.llvm.org/D104406 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

aprantl added inline comments. Comment at: lldb/source/Symbol/Symtab.cpp:642 + Symbol *symbol = FindSymbolByID(uid); + if (symbol == nullptr) +return 0; `if (!symbol)` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D104404: Change PathMappingList::RemapPath to return an optional result (NFC)

aprantl added a comment. > if the return type of the new function is not too awful to type, maybe don't > use auto? It says it's returning a path, which is usually a string, not a > FileSpec... But that's more a matter of taste. I think that's generally advice. In this particular case, the code

[Lldb-commits] [PATCH] D104404: Change PathMappingList::RemapPath to return an optional result (NFC)

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM. If the return type of the new function is not too awful to type, maybe don't use auto? It says it's returning a path, which is usually a string, not a FileSpec... But that's more a

[Lldb-commits] [PATCH] D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe.

jingham added a comment. Huh... I fear you are going to have to debug this further on your end. I can't see anything else suspect in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93479/new/ https://reviews.llvm.org/D93479 __

[Lldb-commits] [PATCH] D104404: Change PathMappingList::RemapPath to return an optional result (NFC)

aprantl added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104404/new/ https://reviews.llvm.org/D104404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4d8156e - [lldb-vscode] Make extension contribute breakpoints use new package.json schema

Author: Chris Bond Date: 2021-06-25T18:21:26+02:00 New Revision: 4d8156ef87f8bc6fdb8ed03b2f87123d02ac7321 URL: https://github.com/llvm/llvm-project/commit/4d8156ef87f8bc6fdb8ed03b2f87123d02ac7321 DIFF: https://github.com/llvm/llvm-project/commit/4d8156ef87f8bc6fdb8ed03b2f87123d02ac7321.diff LO

[Lldb-commits] [PATCH] D104882: makes extension contribute breakpoints using new package.json schema:https://code.visualstudio.com/updates/v1_42#_implement-a-debug-adapter-inside-an-extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d8156ef87f8: [lldb-vscode] Make extension contribute breakpoints use new package.json schema (authored by chrisbond, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D104882: makes extension contribute breakpoints using new package.json schema:https://code.visualstudio.com/updates/v1_42#_implement-a-debug-adapter-inside-an-extension

chrisbond added a comment. Thanks. Since I don't yet have commit access, could you go ahead and commit this change for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104882/new/ https://reviews.llvm.org/D104882

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

thakis added inline comments. Comment at: lldb/lldb/test/Shell/Breakpoint/breakpoint-command.test:1 +# RUN: %build %p/Inputs/dummy-target.c -o %t.out +# RUN: %lldb %t.out -o 'b main' -o 'break command add 1 -o "script print(95000 + 126)"' -o 'r' Did you mean to

[Lldb-commits] [PATCH] D104914: [lldb] Correct format of qMemTags type field

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The type field is a signed integer. (https://sourceware.org/gdb/current/onlinedocs/gdb/General-Quer

[Lldb-commits] [PATCH] D104856: [NFC] Remove unreferenced function ResolveIPV4HostName

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7b1fa6f5ebe: [NFC] remove unreferenced function ResolveIPV4HostName (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104856/ne

[Lldb-commits] [lldb] f7b1fa6 - [NFC] remove unreferenced function ResolveIPV4HostName

Author: serge-sans-paille Date: 2021-06-25T13:45:11+02:00 New Revision: f7b1fa6f5ebec5780e626aa48d582f2519a01632 URL: https://github.com/llvm/llvm-project/commit/f7b1fa6f5ebec5780e626aa48d582f2519a01632 DIFF: https://github.com/llvm/llvm-project/commit/f7b1fa6f5ebec5780e626aa48d582f2519a01632.d

[Lldb-commits] [PATCH] D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe.

aharries-upmem added a comment. In D93479#2840497 , @aharries-upmem wrote: > I'm also a little suspicious of (in `Process::Finalize`): > > if (m_finalizing.exchange(true)) > return; > > rather than > > m_finalize_called = true; I've also tried re

[Lldb-commits] [PATCH] D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe.

aharries-upmem added a comment. In D93479#2839076 , @jingham wrote: > I wonder if instead of doing: > > // Use our target to get a shared pointer to ourselves... > if (m_finalize_called && !PrivateStateThreadIsValid()) > BroadcastEvent(event_sp); >

[Lldb-commits] [lldb] 6e5c4a4 - [lldb] Re-enable GDB server client memory tag read tests

Author: David Spickett Date: 2021-06-25T10:09:52Z New Revision: 6e5c4a443d7e354a37d7dcb82a65216679ab1b40 URL: https://github.com/llvm/llvm-project/commit/6e5c4a443d7e354a37d7dcb82a65216679ab1b40 DIFF: https://github.com/llvm/llvm-project/commit/6e5c4a443d7e354a37d7dcb82a65216679ab1b40.diff LOG

[Lldb-commits] [lldb] c3549d4 - [lldb] Skip TestDataFormatterSynthVal.py with GCC as the test compiler

Author: Raphael Isemann Date: 2021-06-25T11:48:12+02:00 New Revision: c3549d4d7a04d83ff559d2be77a9e74e798fdef4 URL: https://github.com/llvm/llvm-project/commit/c3549d4d7a04d83ff559d2be77a9e74e798fdef4 DIFF: https://github.com/llvm/llvm-project/commit/c3549d4d7a04d83ff559d2be77a9e74e798fdef4.dif

[Lldb-commits] [lldb] 0adc66f - [lldb] Skip libstdc++ tests failing with GCC

Author: Raphael Isemann Date: 2021-06-25T11:45:59+02:00 New Revision: 0adc66ff8377d26d1600fef36c9e2d8a962414d4 URL: https://github.com/llvm/llvm-project/commit/0adc66ff8377d26d1600fef36c9e2d8a962414d4 DIFF: https://github.com/llvm/llvm-project/commit/0adc66ff8377d26d1600fef36c9e2d8a962414d4.dif

[Lldb-commits] [lldb] 487ac0b - [lldb] Skip tests failing with GCC due to LLDB not being able to call constructors

Author: Raphael Isemann Date: 2021-06-25T11:33:09+02:00 New Revision: 487ac0b3eef22ba8f1707779d363ec7f49cc7702 URL: https://github.com/llvm/llvm-project/commit/487ac0b3eef22ba8f1707779d363ec7f49cc7702 DIFF: https://github.com/llvm/llvm-project/commit/487ac0b3eef22ba8f1707779d363ec7f49cc7702.dif

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett added a comment. This was fixed by Omair in https://reviews.llvm.org/rG9ca0171a9ffdef5fdb1511d197a3fd72490362de. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 __

[Lldb-commits] [lldb] 64f98aa - [lldb] Fix memory tag unsupported test

Author: David Spickett Date: 2021-06-25T08:57:05Z New Revision: 64f98aae40894cb0b281723c7f91e73705f551ce URL: https://github.com/llvm/llvm-project/commit/64f98aae40894cb0b281723c7f91e73705f551ce DIFF: https://github.com/llvm/llvm-project/commit/64f98aae40894cb0b281723c7f91e73705f551ce.diff LOG

[Lldb-commits] [PATCH] D104856: [NFC] Remove unreferenced function ResolveIPV4HostName

teemperor accepted this revision. teemperor added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104856/new/ https://reviews.llvm.org/D104856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [PATCH] D104856: [NFC] Remove unreferenced function ResolveIPV4HostName

serge-sans-paille added a comment. What a simpler patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104856/new/ https://reviews.llvm.org/D104856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [PATCH] D104856: [NFC] Remove unreferenced function ResolveIPV4HostName

serge-sans-paille updated this revision to Diff 354443. serge-sans-paille retitled this revision from "[lldb] replace gethostbyname call by getaddrinfo" to "[NFC] Remove unreferenced function ResolveIPV4HostName". serge-sans-paille edited the summary of this revision. serge-sans-paille added a co