wallace created this revision.
wallace added a reviewer: clayborg.
Herald added a subscriber: kristof.beyls.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
We want to start doing some analisis at instruction level, including stack
aprantl created this revision.
aprantl added reviewers: JDevlieghere, dsanders, jroelofs.
Herald added subscribers: dexonsmith, hiraditya.
aprantl requested review of this revision.
Herald added a project: LLVM.
This is more an RFC at this point. I'm curious about feedback!
One nice feature of th
aprantl added inline comments.
Comment at: lldb/include/lldb/Host/FileSystem.h:35
FileSystem()
: m_fs(llvm::vfs::getRealFileSystem()), m_collector(nullptr),
+m_home_directory() {}
why is m_collector not caught? Because it's also explicitly initi
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Impressive. I spot-checked a few instances and this generally looks great.
Let's hope the test suite agrees!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103483/new/
https://revie
shafik added a comment.
Thank you for doing this! This will be a big improvement.
I am not done going through this change but I think it will require a bit more
careful look though to make sure we are getting the maximum benefit from this
refactor.
Comment at: lldb/include/l
wallace updated this revision to Diff 349376.
wallace added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103500/new/
https://reviews.llvm.org/D103500
Files:
lldb/bindings/interface/SBStructuredData.i
lldb/bindings/interface/
Author: Walter Erquinigo
Date: 2021-06-02T14:06:25-07:00
New Revision: e65242e37a7284dc2f24c7f686867da665af3a63
URL:
https://github.com/llvm/llvm-project/commit/e65242e37a7284dc2f24c7f686867da665af3a63
DIFF:
https://github.com/llvm/llvm-project/commit/e65242e37a7284dc2f24c7f686867da665af3a63.di
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb0572abf72fd: Improve performance when parsing symbol tables
in mach-o files. (authored by clayborg).
Changed prior to commit:
https://reviews.llv
Author: Greg Clayton
Date: 2021-06-02T10:31:37-07:00
New Revision: b0572abf72fd4aafbb56bc41350e41bdfd96cdde
URL:
https://github.com/llvm/llvm-project/commit/b0572abf72fd4aafbb56bc41350e41bdfd96cdde
DIFF:
https://github.com/llvm/llvm-project/commit/b0572abf72fd4aafbb56bc41350e41bdfd96cdde.diff
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0ec761c3fc2a: [lldb] Preserve type sugar when using
SBValue::Dereference on C++ references (authored by teemperor).
Herald added a subscriber: lldb-c
Author: Raphael Isemann
Date: 2021-06-02T19:23:11+02:00
New Revision: 0ec761c3fc2a4bf8319c6eb38e46f9a201b79141
URL:
https://github.com/llvm/llvm-project/commit/0ec761c3fc2a4bf8319c6eb38e46f9a201b79141
DIFF:
https://github.com/llvm/llvm-project/commit/0ec761c3fc2a4bf8319c6eb38e46f9a201b79141.dif
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103504/new/
https://reviews.llvm.org/D103504
___
shafik added inline comments.
Comment at: lldb/source/Symbol/ObjectFile.cpp:623
ConstString file_name = GetModule()->GetFileSpec().GetFilename();
- ss.Printf("___lldb_unnamed_symbol%u$$%s", ++m_synthetic_symbol_idx,
-file_name.GetCString());
- return ConstString(
Thanks1 fixed here: https://reviews.llvm.org/D103532
> On 2 Jun 2021, at 18:06, Andy Yankovsky wrote:
>
> I think the problem is specific to references, at least that's the case I ran
> into in lldb-eval --
> https://github.com/google/lldb-eval/blob/master/docs/lldb-bugs.md#dereferencing-a-val
I assume your bug is for dereferencing references? In your test taking the ref
variable and then dereferencing it via the SB API reproduces that I think
you're running into:
>>> lldb.frame.FindVariable("p_ref").GetType().GetName()
'TPair &'
>>> lldb.frame.FindVariable("p_ref").Dereference().GetT
Hi Raphael,
I have a very similar test for a tool that integrates with lldb which
failed without the patch.
I thought the test in the patch would behave the same which is apparently
not the case.
Thanks for pointing that out. I will need to take another look and will get
back to you once I figure
Hi Lasse,
the test from the patch passes for me even without your non-test changes. Not
sure if you attached the wrong diff or it needs to be applied on a specific
commit that is not ToT? Can you maybe try pushing your code to some git repo?
Your change to TypeSystemClang (which I assume remove
werat added a comment.
Is this code used for auto-generated docs? Could be have this documentation in
C++ definitions (lldb/API/SBType.h) as well? I usually just read the C++ source
code, but I can imagine having the same docs in two places might be not the
best idea...
Repository:
rG LLVM
Hi lldb devs,
I prepared a small patch to improve the type consistency when dereferencing
values in lldb.
The problem I'm trying to solve is that the type of a value is canonized
(in clang) when the value is dereferenced.
Without the patch the test I added would return the type TTuple instead of
19 matches
Mail list logo
