[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

mstorsjo added a comment. Just for the record, the issue seems to be this: $ cat cpp-ret-c.cpp template class MyClass { public: T a; }; extern "C" MyClass unmangledFunction(); $ cl -c cpp-ret-c.cpp cpp-ret-c.cpp cpp-ret-c.cpp(5): error C2526: 'unmangledFunction': C linkage

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

mstorsjo added a comment. In D70830#2742960 , @aganea wrote: > Hello @mstorsjo! I've reverted the patch locally, I'm at this commit: > > F:\aganea\llvm-project>git log > commit a3a8a1a15b524d91b5308db68e9d293b34cd88dd (HEAD -> main, origin/main) > > Us

[Lldb-commits] [PATCH] D101933: If an interrupt fails, don't try to fetch any more packets from the server

jingham added a comment. I moved the eStateExited test as Greg suggested on commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101933/new/ https://reviews.llvm.org/D101933 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D101933: If an interrupt fails, don't try to fetch any more packets from the server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72ba78c29e92: When SendContinuePacketAndWaitForResponse returns eStateInvalid, don't fetch… (authored by jingham). Changed prior to commit: https:

[Lldb-commits] [lldb] 72ba78c - When SendContinuePacketAndWaitForResponse returns eStateInvalid, don't fetch more packets.

Author: Jim Ingham Date: 2021-05-06T14:11:42-07:00 New Revision: 72ba78c29e923cb6e5d89eb5ea8180bf723188be URL: https://github.com/llvm/llvm-project/commit/72ba78c29e923cb6e5d89eb5ea8180bf723188be DIFF: https://github.com/llvm/llvm-project/commit/72ba78c29e923cb6e5d89eb5ea8180bf723188be.diff LO

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

aganea added a comment. Hello @mstorsjo! I've reverted the patch locally, I'm at this commit: F:\aganea\llvm-project>git log commit a3a8a1a15b524d91b5308db68e9d293b34cd88dd (HEAD -> main, origin/main) Using: F:\aganea\llvm-project>cl Microsoft (R) C/C++ Optimizing Compiler Version 19.28

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

mstorsjo added a comment. Hi @aganea, I'm a but curious about this change - how did you manage to make this work with MSVC? In my experience, this construct doesn't produce warning C4190 (which this silences) with MSVC, but produces error C2526 (which I don't think can be silenced). See e.g. h

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil reclaimed this revision. jankratochvil added a comment. Reopening as D101950 may take some time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101237/new/ https://reviews.llvm.org/D101237 __

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil abandoned this revision. jankratochvil added a comment. IIUC it will get replaced by D101950 . I will just provide some testcase for this case if not already contained therein. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [lldb] 3026f75 - [lldb][NFC] Make assert in TestStaticVariables more expressive

Author: Raphael Isemann Date: 2021-05-06T16:00:24+02:00 New Revision: 3026f75ed0f520f9be7ac354406687a549155ded URL: https://github.com/llvm/llvm-project/commit/3026f75ed0f520f9be7ac354406687a549155ded DIFF: https://github.com/llvm/llvm-project/commit/3026f75ed0f520f9be7ac354406687a549155ded.dif

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/main.c:53 + // smoke test in case something didn't account for them. + buf = (char *)((size_t)buf | ((size_t)0xAA << 56)); + return print_result(buf); omjavaid wrot