[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

omjavaid accepted this revision. omjavaid added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/linux/aarch64/mte_memory_region/TestAArch64LinuxMTEMemoryRegion.py:42 if self.process().GetState() == lldb.eStateExited:

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

shafik added inline comments. Comment at: lldb/source/Target/Target.cpp:1778 +else if (file_cache_bytes_read > 0) { + file_cache_read_buffer.reset(malloc(file_cache_bytes_read)); + std::memcpy(file_cache_read_buffer.get(), dst, file_cache_bytes_read); -

[Lldb-commits] [PATCH] D101198: [lldb-vscode] Read requests asynchronously

wallace abandoned this revision. wallace added a comment. i'll rather focus on parallelizing symbol preloading Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101198/new/ https://reviews.llvm.org/D101198 _

[Lldb-commits] [PATCH] D101406: Rename human-readable name for DW_LANG_Mips_Assembler

clayborg accepted this revision. clayborg added a comment. If other architectures are emitting this language for assembly files, then this LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101406/new/ https://reviews.llvm.org/D101406 ___ l

[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

jingham added a comment. In D100965#2722149 , @teemperor wrote: > In D100965#2720235 , @jingham wrote: > >> In D100965#2716239 , @teemperor >> wrote: >> >>> I am wonderin

[Lldb-commits] [PATCH] D101406: Rename human-readable name for DW_LANG_Mips_Assembler

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101406/new/ https://reviews.llvm.org/D101406 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

shafik added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:925 lldb::SBDeclaration declaration = v.GetDeclaration(); -std::string file_name(declaration.GetFileSpec().GetFilename()); const uint32_t line = declaration.GetLine(); wa

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

augusto2112 added inline comments. Comment at: lldb/source/Target/Target.cpp:1778 +else if (file_cache_bytes_read > 0) { + file_cache_read_buffer.reset(malloc(file_cache_bytes_read)); + std::memcpy(file_cache_read_buffer.get(), dst, file_cache_bytes_rea

[Lldb-commits] [PATCH] D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested.

shafik added inline comments. Comment at: lldb/source/Target/Target.cpp:1778 +else if (file_cache_bytes_read > 0) { + file_cache_read_buffer.reset(malloc(file_cache_bytes_read)); + std::memcpy(file_cache_read_buffer.get(), dst, file_cache_bytes_read); -

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 341232. DavidSpickett added a comment. - Add comment to explain reading auxv. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llvm.org/D97282 Files: lldb/include/lldb/Host/comm

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:297 + if ((getauxval(AT_HWCAP2) & HWCAP2_MTE)) +supported |= Extension::memory_tagging; + DavidSpickett wrote: > There is a mechanism to get auvx from a proces

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

mgorny added a comment. In D97282#2722937 , @DavidSpickett wrote: > @mgorny Can you take a quick look and see if I'm adding this new feature > correctly? Everything looks good from my perspective. > And thanks for working on qSupported. I skipped check

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett added a subscriber: mgorny. DavidSpickett added a comment. @mgorny Can you take a quick look and see if I'm adding this new feature correctly? And thanks for working on qSupported. I skipped checking HWCAP in my first revision because the features were added in generic code, now I

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 341216. DavidSpickett added a comment. - Rebase onto new qSupported functions - Check AUXV for enabling feature, instead of enabling for all AArch64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/

[Lldb-commits] [PATCH] D101453: [lldb] Add tests for DumpDataExtractor formats

DavidSpickett added reviewers: LLDB, zturner. DavidSpickett added a comment. I'm looking into printing memory tags and "memory read" uses this code a lot so I thought I'd add tests before I attempt to extend it. If this is useful then I'll add some more covering some other key bits like splitti

[Lldb-commits] [PATCH] D101453: [lldb] Add tests for DumpDataExtractor formats

DavidSpickett updated this revision to Diff 341184. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. - Remove unused cfloat include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101453/new/ https://reviews.llvm.org/D101453

[Lldb-commits] [PATCH] D101453: [lldb] Add tests for DumpDataExtractor formats

DavidSpickett created this revision. Herald added a subscriber: mgorny. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Covering basic cases where you have 1 item on 1 line. Apart from eFormatCharArray, where using multiple l

[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

DavidSpickett added a comment. @omjavaid ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100493/new/ https://reviews.llvm.org/D100493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [lldb] d0c521d - [lldb] Correct format enum comment (NFC)

Author: David Spickett Date: 2021-04-28T12:17:03+01:00 New Revision: d0c521da3f0cfd1bd01696773349f1b723d8b057 URL: https://github.com/llvm/llvm-project/commit/d0c521da3f0cfd1bd01696773349f1b723d8b057 DIFF: https://github.com/llvm/llvm-project/commit/d0c521da3f0cfd1bd01696773349f1b723d8b057.diff

[Lldb-commits] [PATCH] D101285: [lldb] [llgs server] Support creating core dumps on NetBSD

mgorny updated this revision to Diff 341138. mgorny added a comment. Use a temporary file if `path-hint` is not writable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101285/new/ https://reviews.llvm.org/D101285 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h lldb/inc

[Lldb-commits] [PATCH] D101329: [lldb] Support SaveCore() from gdb-remote client [WIP]

mgorny updated this revision to Diff 341132. mgorny added a comment. Send `path-hint` to the server. Add a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101329/new/ https://reviews.llvm.org/D101329 Files: lldb/include/lldb/Target/Process.h lldb/source/Core/PluginManager.cpp

[Lldb-commits] [PATCH] D100261: [lldb] [gdb-remote server] Support selecting process via Hg

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2130 +return SendErrorResponse(llvm::make_error( +inconvertibleErrorCode(), "No current process and no PID provided")); + rovka wrot

[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

teemperor added a comment. In D100965#2720235 , @jingham wrote: > In D100965#2716239 , @teemperor > wrote: > >> I am wondering how SourceLocationSpec is related to lldb's Declaration class >> (which is FileSpec

[Lldb-commits] [PATCH] D100261: [lldb] [gdb-remote server] Support selecting process via Hg

rovka added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2130 +return SendErrorResponse(llvm::make_error( +inconvertibleErrorCode(), "No current process and no PID provided")); + Just a driv

[Lldb-commits] [PATCH] D100459: [lldb] [gdb-remote client] Refactor SetCurrentThread*()

mgorny updated this revision to Diff 341112. mgorny marked an inline comment as done. mgorny added a comment. `type` → `op`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100459/new/ https://reviews.llvm.org/D100459 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication

[Lldb-commits] [PATCH] D100459: [lldb] [gdb-remote client] Refactor SetCurrentThread*()

mgorny marked an inline comment as done. mgorny added a comment. In D100459#2721989 , @rovka wrote: > This looks good to me, but I'll let others comment on whether or not we want > to send extra leading zeroes for the thread ID. In my opinion it would be

[Lldb-commits] [PATCH] D100459: [lldb] [gdb-remote client] Refactor SetCurrentThread*()

rovka added a comment. This looks good to me, but I'll let others comment on whether or not we want to send extra leading zeroes for the thread ID. In my opinion it would be nice to 1) be consistent between all packages that deal with thread ids, and 2) send as little clutter as possible. But t

[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

rovka added a comment. This is awesome, thanks for writing this up! Comment at: lldb/docs/resources/test.rst:224 +tests the `SBProcess`, `SBThread`, and `SBFrame` classes. The same is true +for tests that exercise to breakpoints, watchpoints and sanitizers. +Languag