[Lldb-commits] [lldb] 1200f85 - [lldb] Remove duplicated ThreadPlanStepOverBreakpoint comment

Author: Dave Lee Date: 2021-03-08T22:34:56-08:00 New Revision: 1200f85818d16e4f0a57c503e186df7a8ad92435 URL: https://github.com/llvm/llvm-project/commit/1200f85818d16e4f0a57c503e186df7a8ad92435 DIFF: https://github.com/llvm/llvm-project/commit/1200f85818d16e4f0a57c503e186df7a8ad92435.diff LOG:

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid added a comment. Thanks - all the comments sound good. I'll upload a new patch. It seems like the pre-merge check failures are because I incorrectly set the project repo when I first created the revision. I noticed in the build commands here: https://buildkite.com/llvm-project/premer

[Lldb-commits] [PATCH] D98219: [lldb] Update crashlog script for JSON changes

JDevlieghere created this revision. JDevlieghere added a reviewer: teemperor. JDevlieghere requested review of this revision. Update the crashlog script for changes to the JSON schema. https://reviews.llvm.org/D98219 Files: lldb/examples/python/crashlog.py lldb/test/Shell/ScriptInterpreter/

[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

jankratochvil updated this revision to Diff 329064. jankratochvil added a comment. Update after rGfe7333174f54 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98197/new/ https://

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

jingham added a comment. I bet gdb uses the debugger's CWD because that's the practice working ON gdb (at least back in the day when I worked on it). You built gdb, cd'ed into the gdb build directory and ran the debugger on it from there. gdb's build also produced a debugging-gdb specific .gd

[Lldb-commits] [lldb] fe73331 - [nfc] [lldb] Removed unused operator== for DWARFAbbreviationDeclaration and DWARFAttribute

Author: Jan Kratochvil Date: 2021-03-08T19:18:48+01:00 New Revision: fe7333174f54149c00cd32383bf5f6f05455de93 URL: https://github.com/llvm/llvm-project/commit/fe7333174f54149c00cd32383bf5f6f05455de93 DIFF: https://github.com/llvm/llvm-project/commit/fe7333174f54149c00cd32383bf5f6f05455de93.diff

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

jingham added a comment. In D97739#2610521 , @clayborg wrote: > In D97739#2608510 , @friss wrote: > >> In D97739#2607961 , @clayborg wrote: >> >>> In D97739#2607869

[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.cpp:30 + dw_offset_t attr_die_offset, dw_attr_t attr) { + AttributeValue attr_value = {const_cast(form_value.GetUnit()), +

[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

jankratochvil created this revision. jankratochvil added reviewers: labath, grimar. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Repository:

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

teemperor added a comment. re-adding debugserver deps here: https://reviews.llvm.org/D98196 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96202/new/ https://reviews.llvm.org/D96202 ___ lldb-commits maili

[Lldb-commits] [lldb] 63abbeb - [nfc] [lldb] [testsuite] Cleanup of recently added dwarf5-line-strp.s

Author: Jan Kratochvil Date: 2021-03-08T17:41:56+01:00 New Revision: 63abbeb6a8b7dbc57ff90a13c73ac2b41486ee70 URL: https://github.com/llvm/llvm-project/commit/63abbeb6a8b7dbc57ff90a13c73ac2b41486ee70 DIFF: https://github.com/llvm/llvm-project/commit/63abbeb6a8b7dbc57ff90a13c73ac2b41486ee70.diff

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 329031. DavidSpickett added a comment. - RemoveNonAddressBits over RemoveLogicalTag - Set bits 63-60 of test file pointers to check we remove the top byte now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D97284: [lldb][AArch64] Add MTE CPU feature test predicate

DavidSpickett updated this revision to Diff 329030. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97284/new/ https://reviews.llvm.org/D97284 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py Index: ll

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 329029. DavidSpickett added a comment. - Use RemoveNonAddressBits instead of RemoveLogicalTag Note that the tests don't have any changes because the client doesn't have any requirement to remove tags. Only the commands need to do that. The parts of thi

[Lldb-commits] [lldb] dc4ca9b - [lldb][NFC] Code style fixes for ClangModulesDeclVendor

Author: Raphael Isemann Date: 2021-03-08T17:28:05+01:00 New Revision: dc4ca9b0d43a27bdf638799b4c4f4c64452bea7a URL: https://github.com/llvm/llvm-project/commit/dc4ca9b0d43a27bdf638799b4c4f4c64452bea7a DIFF: https://github.com/llvm/llvm-project/commit/dc4ca9b0d43a27bdf638799b4c4f4c64452bea7a.dif

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

teemperor added inline comments. Comment at: lldb/test/API/CMakeLists.txt:115 -set(LLDB_TEST_SERVER ${debugserver_path}) -add_lldb_test_dependency(debugserver) - elseif(TARGET lldb-server) labath wrote: > teemperor wrote: > > I believe this removed line

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h:66 + virtual llvm::Expected + GetMemoryTaggingDetails(int32_t type) { +return llvm::createStringError( ---

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

labath added inline comments. Comment at: lldb/test/API/CMakeLists.txt:115 -set(LLDB_TEST_SERVER ${debugserver_path}) -add_lldb_test_dependency(debugserver) - elseif(TARGET lldb-server) teemperor wrote: > I believe this removed line is causing us to have

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 329027. DavidSpickett added a comment. - Comments for the MemoryTaggingDetails struct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 Files: lldb/include/lldb/H

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; DavidSpickett wrote: > DavidSpickett wrote: > > omjavaid wrote

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 329024. DavidSpickett added a comment. - Use RemoveNonAddressBits instead of RemoveLogicalTag - Make the top byte of test buffer pointer non zero. As noted, setting the top byte doesn't prove much but it means if a future kernel gets more strict we're a

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 329023. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llvm.org/D97282 Files: lldb/include/lldb/Target/Process.h lldb/source/Plugins/Pr

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett updated this revision to Diff 329022. DavidSpickett added a comment. - Add RemoveNonAddressBits which will remove the entire top byte not just tags - Remove SetLogicalTag/RemoveLogicalTag/CopyLogicalTag which are now unused in the proceeding patches Repository: rG LLVM Github Mo

[Lldb-commits] [lldb] addbc9b - [nfc] [lldb] Remove unused function DWARFAttribute::set

Author: Jan Kratochvil Date: 2021-03-08T17:04:35+01:00 New Revision: addbc9b34d6fc4757ea1582bd3dd4d9da1cfaf5c URL: https://github.com/llvm/llvm-project/commit/addbc9b34d6fc4757ea1582bd3dd4d9da1cfaf5c DIFF: https://github.com/llvm/llvm-project/commit/addbc9b34d6fc4757ea1582bd3dd4d9da1cfaf5c.diff

[Lldb-commits] [PATCH] D98170: [lldb] Fix error message in IRInterpreter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b7e5d461aee: [lldb] Fix error message in IRInterpreter (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [lldb] 1b7e5d4 - [lldb] Fix error message in IRInterpreter

Author: Andy Yankovsky Date: 2021-03-08T16:46:38+01:00 New Revision: 1b7e5d461aee80cd3031b4854ab71f6721b71e31 URL: https://github.com/llvm/llvm-project/commit/1b7e5d461aee80cd3031b4854ab71f6721b71e31 DIFF: https://github.com/llvm/llvm-project/commit/1b7e5d461aee80cd3031b4854ab71f6721b71e31.diff

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for cleaning this up! Are the `if (!sc) ...` stuff are missing nullptr checks that affect a normal LLDB session (not sure if we can ever have no SymbolContext) or is thi

[Lldb-commits] [PATCH] D98170: [lldb] Fix error message in IRInterpreter

werat added a comment. I was looking into the issue with `SBValue::Persist` (https://discord.com/channels/636084430946959380/636732809708306432/817370459284832297) and the logs and errors eventually led me here to `IRInterpreter`. And the incorrect error message I noticed just by accident :)

[Lldb-commits] [PATCH] D98170: [lldb] Fix error message in IRInterpreter

teemperor added a comment. I would be curious how you found that bug? I believe a lot of these errors are kinda impossible to reach in a normal test setup (I remember I tried writing some tests for this but can't remember finding a good way to get into all the different error branches in IRInte

[Lldb-commits] [PATCH] D98170: [lldb] Fix error message in IRInterpreter

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. LGTM. I think the Read/Write methods should return a Status instead of some out parameter, but that seems like a NFC follow-up refactoring (I can

[Lldb-commits] [PATCH] D98170: [lldb] Fix error message in IRInterpreter

werat created this revision. werat added reviewers: teemperor, spyffe. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `memory_read_error` -> `memory_write_error` Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D9817

[Lldb-commits] [lldb] 6f3778d - [lldb][NFC] std::set -> DenseSet in ClangModulesDeclVendor

Author: Raphael Isemann Date: 2021-03-08T13:13:35+01:00 New Revision: 6f3778d31a9accdcb5a910506d3ff6debf7b92bc URL: https://github.com/llvm/llvm-project/commit/6f3778d31a9accdcb5a910506d3ff6debf7b92bc DIFF: https://github.com/llvm/llvm-project/commit/6f3778d31a9accdcb5a910506d3ff6debf7b92bc.dif

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

teemperor added inline comments. Comment at: lldb/test/API/CMakeLists.txt:115 -set(LLDB_TEST_SERVER ${debugserver_path}) -add_lldb_test_dependency(debugserver) - elseif(TARGET lldb-server) I believe this removed line is causing us to have missing depende

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:81 + Status error = ReadSVEHeader(); + uint32_t opt_regset = RegisterInfoPOSIX_arm64::eRegsetEnableDefault; + if (error.Success()) { rovka wrote