[Lldb-commits] [PATCH] D50299: Migrate to llvm::unique_function instead of static member functions for callbacks

nealsid added a comment. In D50299#2589289 , @JDevlieghere wrote: > Thanks Neal. Can you run clang-format again and upload the diff with context > (`git diff -U`). Overall this looks pretty good. Thanks for the review. I have run clang-format and a

[Lldb-commits] [PATCH] D85770: Build a flat LLDB.framework for embedded Darwin targets

vsk added inline comments. Comment at: lldb/cmake/modules/LLDBFramework.cmake:142-147 + add_custom_command(TARGET liblldb POST_BUILD +COMMAND ${CMAKE_COMMAND} -E create_symlink +Versions/Current/XPCServices +${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LLDB.f

[Lldb-commits] [PATCH] D85770: Build a flat LLDB.framework for embedded Darwin targets

smeenai added inline comments. Comment at: lldb/cmake/modules/LLDBFramework.cmake:142-147 + add_custom_command(TARGET liblldb POST_BUILD +COMMAND ${CMAKE_COMMAND} -E create_symlink +Versions/Current/XPCServices +${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LL

[Lldb-commits] [PATCH] D97524: [lldb] Add deref support to libc++ unique_ptr synthetic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a677b29a3b3: [lldb] Add deref support to libc++ unique_ptr synthetic (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [lldb] 3a677b2 - [lldb] Add deref support to libc++ unique_ptr synthetic

Author: Dave Lee Date: 2021-02-26T07:39:01-08:00 New Revision: 3a677b29a3b3f6a2539843db4d56ba59689fc0a0 URL: https://github.com/llvm/llvm-project/commit/3a677b29a3b3f6a2539843db4d56ba59689fc0a0 DIFF: https://github.com/llvm/llvm-project/commit/3a677b29a3b3f6a2539843db4d56ba59689fc0a0.diff LOG:

[Lldb-commits] [PATCH] D97284: [lldb][AArch64] Add MTE CPU feature test predicate

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This is accepted with a caveat above. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1288 +for line in f.readlines(): +if line.st