[Lldb-commits] [PATCH] D97450: [lldb] [test] Skip AVX lldb-server test on non-x86 architectures

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: pengfei. mgorny requested review of this revision. Skip the AVX-related lldb-server test on non-x86 architectures, as they do not support AVX. While technically the test worked on Linux b

[Lldb-commits] [PATCH] D97441: [debugserver] Fix logic to extract app bundle from file path

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG011a8e218ea3: [debugserver] Fix logic to extract app bundle from file path (authored by JDevlieghere). Herald added a project: LLDB. Changed prior t

[Lldb-commits] [lldb] 011a8e2 - [debugserver] Fix logic to extract app bundle from file path

Author: Jonas Devlieghere Date: 2021-02-24T23:08:42-08:00 New Revision: 011a8e218ea32e1c8bbbeb5925def894ac6513a4 URL: https://github.com/llvm/llvm-project/commit/011a8e218ea32e1c8bbbeb5925def894ac6513a4 DIFF: https://github.com/llvm/llvm-project/commit/011a8e218ea32e1c8bbbeb5925def894ac6513a4.d

[Lldb-commits] [PATCH] D97441: [debugserver] Fix logic to extract app bundle from file path

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Nice, LGTM. Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:3174 +DNBLogThreadedIf(LOG_PROCESS, "Failed to launch '%s' with FBS", +

[Lldb-commits] [PATCH] D97441: [debugserver] Fix logic to extract app bundle from file path

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. JDevlieghere requested review of this revision. Fix the logic to find the app bundle in a path by correctly accounting for paths containing multiple occurrences of `.app`. The new logic will correctly extract `com.

[Lldb-commits] [PATCH] D97249: [lldb] Support debugging utility functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG38dfb235db19: [lldb] Support debugging utility functions (authored by JDevlieghere). Herald added a pr

[Lldb-commits] [lldb] 38dfb23 - [lldb] Support debugging utility functions

Author: Jonas Devlieghere Date: 2021-02-24T11:36:01-08:00 New Revision: 38dfb235db19caa1aaa58c1c8153a7464b932087 URL: https://github.com/llvm/llvm-project/commit/38dfb235db19caa1aaa58c1c8153a7464b932087 DIFF: https://github.com/llvm/llvm-project/commit/38dfb235db19caa1aaa58c1c8153a7464b932087.d

[Lldb-commits] [PATCH] D97230: [lldb] [test] Workaround symlink-related test failures

emaste added a comment. OK; I think this change is reasonable, I just want to make sure we don't completely lose the underlying issue. Let's make sure that we at least have a bug report to track it (i.e., let's not close llvm.org/pr48376 and llvm.org/pr48421 with "no longer fails" without havi

[Lldb-commits] [PATCH] D97210: [lldb] Rename NativeRegisterContext{Watchpoint => DBReg}_x86

emaste added a comment. No objection from me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97210/new/ https://reviews.llvm.org/D97210 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

emaste added a comment. > I don't think it's very likely. @emaste, any opinion on this? I think it is fine to make this conditional on version. We are working on bringing arm64 to Tier-1 status in FreeBSD 13 (which will have the referenced kernel changes) and we can assume that as a minimum ver

[Lldb-commits] [PATCH] D97249: [lldb] Support debugging utility functions

jingham added a comment. I am pretty sure other Unix-es share the code to dlopen images that backs "Process::LoadImage". It is trivial compared to the ObjC ones, but is does have a couple of lines of code, 'cause it tries the dlopen and then if that fails, calls dlerror to fetch the error. Th

[Lldb-commits] [PATCH] D97249: [lldb] Support debugging utility functions

teemperor accepted this revision. teemperor added a comment. Some small nitpicks about comments, otherwise LGTM I was kinda thinking how we could test this, but all our utility functions are anyway only on macOS and very Obj-C runtime related, so that sounds like a pain to do right... (PS: Als

[Lldb-commits] [PATCH] D97230: [lldb] [test] Workaround symlink-related test failures

mgorny added a comment. In D97230#2585139 , @emaste wrote: > I think it's valuable to avoid testing this (symlink issue) as a side effect > of these test cases, but we should have an explicit test for this; it is an > issue users could hit. > > Do you kn

[Lldb-commits] [PATCH] D97230: [lldb] [test] Workaround symlink-related test failures

emaste added a comment. I think it's valuable to avoid testing this (symlink issue) as a side effect of these test cases, but we should have an explicit test for this; it is an issue users could hit. Do you know if this is a bug specific to lldb's FreeBSD code (or do we just have a default sym

[Lldb-commits] [PATCH] D96947: [lldb] Prevent double new lines behind errors/warning/messages from LLDB commands

teemperor added inline comments. Comment at: lldb/source/Interpreter/CommandReturnObject.cpp:93 return; - GetOutputStream() << in_string << "\n"; + GetOutputStream() << in_string; + if (!in_string.endswith("\n")) JDevlieghere wrote: > How about rstripping

[Lldb-commits] [PATCH] D96947: [lldb] Prevent double new lines behind errors/warning/messages from LLDB commands

This revision was automatically updated to reflect the committed changes. Closed by commit rG6201017d541f: [lldb] Prevent double new lines behind errors/warning/messages from LLDB… (authored by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.llvm.or

[Lldb-commits] [lldb] 6201017 - [lldb] Prevent double new lines behind errors/warning/messages from LLDB commands

Author: Raphael Isemann Date: 2021-02-24T14:42:01+01:00 New Revision: 6201017d541fb024dfcbe135576d38a97f88b1a3 URL: https://github.com/llvm/llvm-project/commit/6201017d541fb024dfcbe135576d38a97f88b1a3 DIFF: https://github.com/llvm/llvm-project/commit/6201017d541fb024dfcbe135576d38a97f88b1a3.dif

[Lldb-commits] [PATCH] D97298: [lldb][NFC] Move trivial ValueObject getters/setters to the header

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0512b01ebede: [lldb][NFC] Move trivial ValueObject getters/setters to the header (authored by teemperor). Herald added a subscriber: lldb-commits. R

[Lldb-commits] [lldb] 0512b01 - [lldb][NFC] Move trivial ValueObject getters/setters to the header

Author: Raphael Isemann Date: 2021-02-24T14:04:01+01:00 New Revision: 0512b01ebede34fe5f6244d5ec8dde552fa4b375 URL: https://github.com/llvm/llvm-project/commit/0512b01ebede34fe5f6244d5ec8dde552fa4b375 DIFF: https://github.com/llvm/llvm-project/commit/0512b01ebede34fe5f6244d5ec8dde552fa4b375.dif

[Lldb-commits] [PATCH] D97298: [lldb][NFC] Move trivial ValueObject getters/setters to the header

teemperor updated this revision to Diff 326052. teemperor added a comment. - Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97298/new/ https://reviews.llvm.org/D97298 Files: lldb/include/lldb/Core/ValueObject.h lldb/source/Core/ValueObject.cpp Index: lldb/source/Core/ValueO

[Lldb-commits] [PATCH] D97287: [lldb][NFC] Rename the second ValueObjectManager to ValueObjectUpdater and remove the dead code

This revision was automatically updated to reflect the committed changes. Closed by commit rG4631afdeb3c4: [lldb][NFC] Rename the second ValueObjectManager to ValueObjectUpdater and… (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [lldb] 4631afd - [lldb][NFC] Rename the second ValueObjectManager to ValueObjectUpdater and remove the dead code

Author: Raphael Isemann Date: 2021-02-24T13:58:01+01:00 New Revision: 4631afdeb3c48f63688d3b097643d61de8e48e2b URL: https://github.com/llvm/llvm-project/commit/4631afdeb3c48f63688d3b097643d61de8e48e2b DIFF: https://github.com/llvm/llvm-project/commit/4631afdeb3c48f63688d3b097643d61de8e48e2b.dif

[Lldb-commits] [PATCH] D97300: [lldb] Add asserts that prevent construction of cycles in the decl origin tracking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2105912ee0b8: [lldb] Add asserts that prevent construction of cycles in the decl origin… (authored by teemperor). Herald added a subscriber: lldb-com

[Lldb-commits] [lldb] 2105912 - [lldb] Add asserts that prevent construction of cycles in the decl origin tracking

Author: Raphael Isemann Date: 2021-02-24T13:25:49+01:00 New Revision: 2105912ee0b831d5141146b7700c1934c4185bd6 URL: https://github.com/llvm/llvm-project/commit/2105912ee0b831d5141146b7700c1934c4185bd6 DIFF: https://github.com/llvm/llvm-project/commit/2105912ee0b831d5141146b7700c1934c4185bd6.dif