[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:410-433 -if (!m_count_sp) { - ValueObjectSP shared_owners_sp(m_cntrl->GetChildMemberWithName( - ConstString("__shared_owners_"), true)); - if (!shared_owners_sp

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione created this revision. kastiglione added reviewers: jingham, JDevlieghere, teemperor. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add `frame variable` dereference suppport to libc++ `std::shared_ptr`. This chang

[Lldb-commits] [lldb] 878d82c - Revert "[lldb-vscode] Emit the breakpoint changed event on location resolved"

Author: António Afonso Date: 2021-02-21T13:08:06-08:00 New Revision: 878d82c4f2b308f35394a6339e74e7e20434146a URL: https://github.com/llvm/llvm-project/commit/878d82c4f2b308f35394a6339e74e7e20434146a DIFF: https://github.com/llvm/llvm-project/commit/878d82c4f2b308f35394a6339e74e7e20434146a.diff

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

jankratochvil added a comment. This new testcase broke buildbots as it is failing after a revert of D96637 : http://lab.llvm.org:8014/#/workers/29 http://lab.llvm.org:8011/#/workers/1 They are now failing on: ` lldb-api :: tools/lldb-vscode/breakpoint-events/Tes

[Lldb-commits] [PATCH] D97114: [lldb] [docs] Update platform support status

This revision was automatically updated to reflect the committed changes. Closed by commit rG7850bb5f2a59: [lldb] [docs] Update platform support status (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D97114?vs=325172&id=325335#toc Repositor

[Lldb-commits] [lldb] 7850bb5 - [lldb] [docs] Update platform support status

Author: Michał Górny Date: 2021-02-21T21:47:48+01:00 New Revision: 7850bb5f2a595a5dc0edf7f9be3d2250281aabe8 URL: https://github.com/llvm/llvm-project/commit/7850bb5f2a595a5dc0edf7f9be3d2250281aabe8 DIFF: https://github.com/llvm/llvm-project/commit/7850bb5f2a595a5dc0edf7f9be3d2250281aabe8.diff

[Lldb-commits] [lldb] ae14f3f - [LLDB] [docs] Update the list of supported architectures on Windows

Author: Martin Storsjö Date: 2021-02-21T22:23:55+02:00 New Revision: ae14f3fdbfa85c92d64f5f38f883a6db4266ca80 URL: https://github.com/llvm/llvm-project/commit/ae14f3fdbfa85c92d64f5f38f883a6db4266ca80 DIFF: https://github.com/llvm/llvm-project/commit/ae14f3fdbfa85c92d64f5f38f883a6db4266ca80.diff

[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGae14f3fdbfa8: [LLDB] [docs] Update the list of supported architectures on Windows (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96840

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

labath added a comment. In D96548#2574437 , @mgorny wrote: > In D96548#2571489 , @mhorne wrote: > >> I should also note that it is my intention to merge the FreeBSD watchpoint >> patches into the 13.0 branch, in ab

[Lldb-commits] [PATCH] D96840: [LLDB] [docs] Update the list of supported architectures on Windows

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds reasonable. I'm sure x86_64 is in at least as good as shape as i386. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96840/new/ https://reviews.llvm.org/D96840 _

[Lldb-commits] [lldb] 3ca7b2d - Reapply "[lldb/test] Automatically find debug servers to test"

Author: Pavel Labath Date: 2021-02-21T20:47:47+01:00 New Revision: 3ca7b2d03cce16aebfbacc33bd351c8272c38f50 URL: https://github.com/llvm/llvm-project/commit/3ca7b2d03cce16aebfbacc33bd351c8272c38f50 DIFF: https://github.com/llvm/llvm-project/commit/3ca7b2d03cce16aebfbacc33bd351c8272c38f50.diff

[Lldb-commits] [PATCH] D97114: [lldb] [docs] Update platform support status

labath accepted this revision. labath added inline comments. Comment at: lldb/docs/index.rst:75-76 * iOS, tvOS, and watchOS device debugging on ARM and AArch64 -* Linux user-space debugging for i386, x86_64 and PPC64le -* FreeBSD user-space debugging for i386 and x86_64 +* Linux

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

labath added a comment. In D96778#2576881 , @dblaikie wrote: > In D96778#2573076 , @jankratochvil > wrote: > >> In D96778#2572816 , @dblaikie wrote: >> >>> rolls this into o

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

labath added a comment. I have some improvements to the test suite -- it would be great if you could incorporate them into the next version of the patch. BTW, it would be nice if the revert commit message included a (brief) explanation of why the patch is being reverted. Com

[Lldb-commits] [lldb] b19d3b0 - Revert "Make sure the interpreter module was loaded before making checks against it"

Author: António Afonso Date: 2021-02-21T10:38:25-08:00 New Revision: b19d3b092d4ea019dfc52501bb96b0008d4e01d2 URL: https://github.com/llvm/llvm-project/commit/b19d3b092d4ea019dfc52501bb96b0008d4e01d2 DIFF: https://github.com/llvm/llvm-project/commit/b19d3b092d4ea019dfc52501bb96b0008d4e01d2.diff

[Lldb-commits] [lldb] 1f21d48 - [lldb-vscode] Emit the breakpoint changed event on location resolved

Author: António Afonso Date: 2021-02-21T09:46:29-08:00 New Revision: 1f21d488bd79a06c9cf405cc5db985fcd71c4f70 URL: https://github.com/llvm/llvm-project/commit/1f21d488bd79a06c9cf405cc5db985fcd71c4f70 DIFF: https://github.com/llvm/llvm-project/commit/1f21d488bd79a06c9cf405cc5db985fcd71c4f70.diff

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f21d488bd79: [lldb-vscode] Emit the breakpoint changed event on location resolved (authored by aadsm). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm added a comment. oh no, I picked the wrong commit to land :(. I think this is fine because I already addressed the comments, but if there's still something I should work on here, I'll put another diff up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa83a825e9902: Make sure the interpreter module was loaded before m

[Lldb-commits] [lldb] a83a825 - Make sure the interpreter module was loaded before making checks against it

Author: António Afonso Date: 2021-02-21T09:28:04-08:00 New Revision: a83a825e9902b54b315870e9ed85723525208f09 URL: https://github.com/llvm/llvm-project/commit/a83a825e9902b54b315870e9ed85723525208f09 DIFF: https://github.com/llvm/llvm-project/commit/a83a825e9902b54b315870e9ed85723525208f09.diff