[Lldb-commits] [PATCH] D96096: [lldb] Emit type annotation in SWIG generated Python code.

labath accepted this revision. labath added a comment. cool CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96096/new/ https://reviews.llvm.org/D96096 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [PATCH] D96096: [lldb] Emit type annotation in SWIG generated Python code.

kastiglione added a comment. This will be nice! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96096/new/ https://reviews.llvm.org/D96096 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [PATCH] D95710: [lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch

mib updated this revision to Diff 321647. mib marked 2 inline comments as done. mib edited the summary of this revision. mib added a comment. Address @jingham and @vsk comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95710/new/ https://revie

[Lldb-commits] [PATCH] D96095: [lldb] Use assertIn/NotIn over assertTrue/False (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96095/new/ https://reviews.llvm.org/D96095 _

[Lldb-commits] [PATCH] D96096: [lldb] Emit type annotation in SWIG generated Python code.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, lanza, LLDB. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. The Python code generated by SWIG is compatible with both Python 2 and Python 3. The -py3 option enables Python 2 incompatible

[Lldb-commits] [PATCH] D96095: [lldb] Use assertIn/NotIn over assertTrue/False (NFC)

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, teemperor. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. For improved failure messages, use `assertIn` over `assertTrue`. Repository: rG LLVM Gi

Re: [Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

I don't feel knowledgeable enough to backport the commit, so if you can do it, it would be great :) Il giorno gio 4 feb 2021 alle ore 13:04 Martin Storsjö via Phabricator < revi...@reviews.llvm.org> ha scritto: > mstorsjo added a comment. > > In D96060#2542890

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

mstorsjo added inline comments. Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:9 + +#if !defined(WIN32) +#include stella.stamenova wrote: > Also, this is no good. It works if you are targeting windows on windows, but > not if you are targeting something else

[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

mstorsjo added a comment. In D96060#2542890 , @mstorsjo wrote: > I can test build it in a couple hours It still built fine for me now - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96060/new/ http

[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

mstorsjo added a comment. The change looks ok to me. In my environments, the main branch does build correctly, but this should be good for consistency in any case. (The 12.x release branch does need a cherrypick though - but it'd be good to settle this first.) I can test build it in a couple h

[Lldb-commits] [lldb] 644ef58 - Print the "no plugin" warning only when there is no plugin

Author: Adrian Prantl Date: 2021-02-04T11:06:10-08:00 New Revision: 644ef580735c9fe4808de89c86a3e476ef1c4fad URL: https://github.com/llvm/llvm-project/commit/644ef580735c9fe4808de89c86a3e476ef1c4fad DIFF: https://github.com/llvm/llvm-project/commit/644ef580735c9fe4808de89c86a3e476ef1c4fad.diff

[Lldb-commits] [PATCH] D95992: Print the "no plugin" warning only when there is no plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rG644ef580735c: Print the "no plugin" warning only when there is no plugin (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D95992: Print the "no plugin" warning only when there is no plugin

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Perfect, then this LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95992/new/ https://reviews.llvm.org/D95992 ___ lldb-com

[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36496cc2992d: [lldb-vscode] correctly use Windows macros (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [lldb] 36496cc - [lldb-vscode] correctly use Windows macros

Author: Walter Erquinigo Date: 2021-02-04T11:03:33-08:00 New Revision: 36496cc2992d6fa26e6024971efcfc7d15f69888 URL: https://github.com/llvm/llvm-project/commit/36496cc2992d6fa26e6024971efcfc7d15f69888 DIFF: https://github.com/llvm/llvm-project/commit/36496cc2992d6fa26e6024971efcfc7d15f69888.di

[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

lanza accepted this revision. lanza added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. LGTM, I had to do this to fix it locally and can confirm it works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

wallace created this revision. wallace added reviewers: mstorsjo, stella.stamenova. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. @mstorsjo found a mistake that I made when trying to fix some Windows compilation errors encountered

[Lldb-commits] [PATCH] D96034: [lldb/cmake] Reduce duplication in generation lldb-dotest

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Yay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96034/new/ https://reviews.llvm.org/D96034 _

[Lldb-commits] [PATCH] D95995: [lldb] Simplify the logic to detect compiler flag support

This revision was automatically updated to reflect the committed changes. Closed by commit rG727bd89b605b: [lldb] Simplify the logic to detect compiler flag support (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [lldb] 727bd89 - [lldb] Simplify the logic to detect compiler flag support

Author: Jonas Devlieghere Date: 2021-02-04T08:52:56-08:00 New Revision: 727bd89b605b39659c793f338ce1e18dafc3581e URL: https://github.com/llvm/llvm-project/commit/727bd89b605b39659c793f338ce1e18dafc3581e DIFF: https://github.com/llvm/llvm-project/commit/727bd89b605b39659c793f338ce1e18dafc3581e.d

[Lldb-commits] [PATCH] D95992: Print the "no plugin" warning only when there is no plugin

aprantl added a comment. The feature itself is already being tested by `lldb/test/Shell/Process/UnsupportedLanguage.test`. In order to test this change we would have to force TypeSystemClang to fail to initialize somehow. The only way to do this would be to pass in an invalid arch, but if we do

[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I think you missed one `LLVM_TOOLS_DIR_CONFIGURED` but other than that this LGTM. Comment at: lldb/utils/lldb-dotest/CMakeLists.txt:29 string(REPLACE ${LLVM

[Lldb-commits] [PATCH] D95802: [lldb] [Process/FreeBSDRemote] Introduce mips64 support

mgorny updated this revision to Diff 321446. mgorny edited the summary of this revision. mgorny added a comment. @labath, how does this look like? I've managed to make it into a mixin class without any virtual inheritance. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95802/new/ https:

[Lldb-commits] [PATCH] D96034: [lldb/cmake] Reduce duplication in generation lldb-dotest

labath created this revision. labath added reviewers: JDevlieghere, stella.stamenova. Herald added a subscriber: mgorny. labath requested review of this revision. Herald added a project: LLDB. Use indirection to avoid duplicated long lists of variables. Depends on D95261

[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

labath updated this revision to Diff 321412. labath added a comment. Add back dsymutil in one more place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95261/new/ https://reviews.llvm.org/D95261 Files: lldb/packages/Python/lldbsuite/test/dotest.p

[Lldb-commits] [PATCH] D95995: [lldb] Simplify the logic to detect compiler flag support

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This seems to improve things CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95995/new/ https://reviews.llvm.org/D95995 ___ lldb-commits mai

Re: [Lldb-commits] [lldb] 0bca9a7 - Fix lldb-vscode builds on Windows targeting POSIX

This is great to know. Til. I'll change all of those macros to _WIN32 for consistency then Il Gio 4 Feb 2021, 3:25 AM Martin Storsjö ha scritto: > On Thu, 28 Jan 2021, Walter Erquinigo via lldb-commits wrote: > > > > > Author: Walter Erquinigo > > Date: 2021-01-28T09:36:13-08:00 > > New Revision

[Lldb-commits] [PATCH] D93939: [elf-core] Improve reading memory from core file

djtodoro added a comment. @labath Thanks for the review! I'll land this tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93939/new/ https://reviews.llvm.org/D93939 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [PATCH] D95802: [lldb] [Process/FreeBSDRemote] Introduce mips64 support

labath added a comment. In D95802#2541796 , @mgorny wrote: > Same way I did x86 watchpoints? I suppose I could try that. Possibly. Depends on the implementation, I guess. I was thinking we could just shove this into the NativeProcessProtocol class. Thoug

[Lldb-commits] [PATCH] D95802: [lldb] [Process/FreeBSDRemote] Introduce mips64 support

krytarowski added a comment. Merging is a good idea as NetBSD might duplicate these code chunks too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95802/new/ https://reviews.llvm.org/D95802 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D95802: [lldb] [Process/FreeBSDRemote] Introduce mips64 support

mgorny added a comment. Same way I did x86 watchpoints? I suppose I could try that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95802/new/ https://reviews.llvm.org/D95802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D95802: [lldb] [Process/FreeBSDRemote] Introduce mips64 support

labath added a comment. The software single stepping code looks very similar to the linux version. Have you considered merging the two implementations? The code looks generic enough to be placed into the base class, if needed... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95802/new/

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu added a comment. The failure is wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

Re: [Lldb-commits] [lldb] 0bca9a7 - Fix lldb-vscode builds on Windows targeting POSIX

On Thu, 28 Jan 2021, Walter Erquinigo via lldb-commits wrote: Author: Walter Erquinigo Date: 2021-01-28T09:36:13-08:00 New Revision: 0bca9a7ce2eeaa9f1d732ffbc17769560a2b236e URL: https://github.com/llvm/llvm-project/commit/0bca9a7ce2eeaa9f1d732ffbc17769560a2b236e DIFF: https://github.com/llv

[Lldb-commits] [lldb] aa56b30 - [lldb] Make TestLocalVariables.py compatible with the new pass manager

Author: Pavel Labath Date: 2021-02-04T11:27:08+01:00 New Revision: aa56b30014d96700b2fc945be11866789f341d38 URL: https://github.com/llvm/llvm-project/commit/aa56b30014d96700b2fc945be11866789f341d38 DIFF: https://github.com/llvm/llvm-project/commit/aa56b30014d96700b2fc945be11866789f341d38.diff

[Lldb-commits] [PATCH] D93939: [elf-core] Improve reading memory from core file

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93939/new/ https://reviews.llvm.org/D93939 ___ lldb-commits mailing list lldb-commits@l