[Lldb-commits] [PATCH] D95899: [lldb] Convert more assertTrue to assertEqual (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ed758b26041: [lldb] Convert more assertTrue to assertEqual (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95899/new/ https:

[Lldb-commits] [PATCH] D95899: [lldb] Convert more assertTrue to assertEqual (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95899/new/ https://reviews.llvm.org/D95899 _

[Lldb-commits] [PATCH] D95992: Print the "no plugin" warning only when there is no plugin

JDevlieghere added a comment. In D95992#2540921 , @shafik wrote: > Can we test this? If you can bypass the check for a valid module on line 5682, you might be able to write a unit test by setting the `function` in the SymbolContext to return an unsuppor

[Lldb-commits] [PATCH] D95995: [lldb] Simplify the logic to detect compiler flag support

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, kastiglione, labath. JDevlieghere requested review of this revision. This patch effectively does these things: - Centralize the logic to figure out if a compiler flag is supported. - Stop sanity checking whether the compil

[Lldb-commits] [PATCH] D95992: Print the "no plugin" warning only when there is no plugin

shafik added a comment. Can we test this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95992/new/ https://reviews.llvm.org/D95992 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [PATCH] D95992: Print the "no plugin" warning only when there is no plugin

aprantl created this revision. aprantl added reviewers: JDevlieghere, jingham. aprantl requested review of this revision. Print the "no plugin" warning only when there is no plugin and not when the typesystem failed to initialize. rdar://72562341 https://reviews.llvm.org/D95992 Files: lldb/

[Lldb-commits] [lldb] e3bb1c8 - [lldb] Rollback to using i386 for the watch simulator

Author: Jonas Devlieghere Date: 2021-02-03T16:32:55-08:00 New Revision: e3bb1c80fe68110f6362af0413c04cd77a05fbac URL: https://github.com/llvm/llvm-project/commit/e3bb1c80fe68110f6362af0413c04cd77a05fbac DIFF: https://github.com/llvm/llvm-project/commit/e3bb1c80fe68110f6362af0413c04cd77a05fbac.d

[Lldb-commits] [lldb] b3901ef - [lldb] Check for both Lua 5.3 and 5.4 error messages in the tests.

Author: Jonas Devlieghere Date: 2021-02-03T13:46:00-08:00 New Revision: b3901ef09c74443c7d9deeb1c140ce6b0ea3f13c URL: https://github.com/llvm/llvm-project/commit/b3901ef09c74443c7d9deeb1c140ce6b0ea3f13c DIFF: https://github.com/llvm/llvm-project/commit/b3901ef09c74443c7d9deeb1c140ce6b0ea3f13c.d

[Lldb-commits] [PATCH] D95922: [lldb] Honor the CPU type & subtype on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG98e50a7d4c12: [lldb] Honor the CPU type & subtype when launching on macOS (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D95922?vs=321116&id=

[Lldb-commits] [lldb] 98e50a7 - [lldb] Honor the CPU type & subtype when launching on macOS

Author: Jonas Devlieghere Date: 2021-02-03T13:42:00-08:00 New Revision: 98e50a7d4c12d2c32eb15e55cbb2e1f89a802e28 URL: https://github.com/llvm/llvm-project/commit/98e50a7d4c12d2c32eb15e55cbb2e1f89a802e28 DIFF: https://github.com/llvm/llvm-project/commit/98e50a7d4c12d2c32eb15e55cbb2e1f89a802e28.d

[Lldb-commits] [PATCH] D95922: [lldb] Honor the CPU type & subtype on macOS

jasonmolenda accepted this revision. jasonmolenda added a comment. Yep, looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95922/new/ https://reviews.llvm.org/D95922 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/CMakeLists.txt:16 endif() +add_subdirectory(Scripted) add_subdirectory(gdb-remote) nit: I'd make this lowercase for consistency with the other plugins (and keep Utility the exception a

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:534 + virtual StructuredData::GenericSP + ScriptedProcess_CreatePluginObject(const char *class_name, + lldb::TargetSP target_sp, ---

[Lldb-commits] [lldb] 5580fa1 - [lldb] Fix debugserver-entitlements.plist path

Author: Jonas Devlieghere Date: 2021-02-03T10:42:36-08:00 New Revision: 5580fa10dbda49199ddc553294c0d18e0d21373a URL: https://github.com/llvm/llvm-project/commit/5580fa10dbda49199ddc553294c0d18e0d21373a DIFF: https://github.com/llvm/llvm-project/commit/5580fa10dbda49199ddc553294c0d18e0d21373a.d

[Lldb-commits] [PATCH] D95922: [lldb] Honor the CPU type & subtype on macOS

JDevlieghere updated this revision to Diff 321116. JDevlieghere added a comment. - Fix test on Apple silicon by making sure we pick the right debugserver CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95922/new/ https://reviews.llvm.org/D95922 Files: lldb/source/Host/macosx/objcxx/Hos

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu updated this revision to Diff 321104. Abpostelnicu added a comment. rebased on 11.1rc2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 Files: lldb/source/Plugins/Platform/MacOSX/PlatformApple

[Lldb-commits] [PATCH] D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added subscribers: steven.zhang, shchenz, nemanjai. mgorny requested review of this revision. Introduce a minimal support for the 32-bit powerpc platform. The code is untested due to lack of a working testin

[Lldb-commits] [PATCH] D95922: [lldb] Honor the CPU type & subtype on macOS

JDevlieghere updated this revision to Diff 321031. JDevlieghere added a comment. - Improve the tests - Make sure we prefer `CPU_SUBTYPE_ARM64_ALL` over `CPU_SUBTYPE_ARM64_V8` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95922/new/ https://reviews.llvm.org/D95922 Files: lldb/source/H