Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

If you set a breakpoint on source lines with no line table entries, lldb slides the actual match forward to the nearest line table entry to the given line number. That's necessary for instance because if you lay out your function definitions over multiple lines they won't all get line table ent

[Lldb-commits] [lldb] 999f5da - [debugserver] Fix inverted if block that resulted in us using the private entitlements

Author: Jonas Devlieghere Date: 2021-01-15T17:41:07-08:00 New Revision: 999f5da6b3088fa4c0bb9d05b358d015ca74c71f URL: https://github.com/llvm/llvm-project/commit/999f5da6b3088fa4c0bb9d05b358d015ca74c71f DIFF: https://github.com/llvm/llvm-project/commit/999f5da6b3088fa4c0bb9d05b358d015ca74c71f.d

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

"But because their source lines are outside the function source range" Not sure I understand that - the DWARF doesn't describe a function source range, right? Only the line a function starts on. And a function can have code from source lines in many files/offsets that are unrelated to the function

[Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

jingham created this revision. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The inline initializers contribute code to the constructor(s). You will step onto them in the source view as you step through the constructor, for inst

[Lldb-commits] [PATCH] D94811: [lldb] Fix fallthrough with strictly virtual working directory.

dexonsmith added a comment. In D94811#2502504 , @JDevlieghere wrote: > Personally I'd just like to get rid of `ExternalFSValidWD` inside of > `shouldUseExternalFS` and let the underlying FS take care of it, which I > believe would better fit the abstrac

[Lldb-commits] [PATCH] D94811: [lldb] Fix fallthrough with strictly virtual working directory.

JDevlieghere added a comment. Personally I'd just like to get rid of the `shouldUseExternalFS` and let the underlying FS take care of it, which I believe would better fit the abstraction but would be a change in behavior (as pointed out in https://reviews.llvm.org/D65677#inline-604694). CHANG

[Lldb-commits] [PATCH] D94754: skip g packet tests on darwin systems

This revision was automatically updated to reflect the committed changes. Closed by commit rG10ac9b29a4ca: Skip 'g' packet tests when running on darwin; debugserver doesn't impl (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] 10ac9b2 - Skip 'g' packet tests when running on darwin; debugserver doesn't impl

Author: Jason Molenda Date: 2021-01-15T13:57:59-08:00 New Revision: 10ac9b29a4ca9e75bcbfa9576e3d8ee83cc9cd78 URL: https://github.com/llvm/llvm-project/commit/10ac9b29a4ca9e75bcbfa9576e3d8ee83cc9cd78 DIFF: https://github.com/llvm/llvm-project/commit/10ac9b29a4ca9e75bcbfa9576e3d8ee83cc9cd78.diff

[Lldb-commits] [PATCH] D94811: [lldb] Fix fallthrough with strictly virtual working directory.

dexonsmith added a comment. I missed a few words: In D94811#2502192 , @dexonsmith wrote: > What if someone does `setWorkingDirectory()` for `/a/b/c/d.c` followed by "changing directory to" > `/x`, and then looks up the relative path `d.c`? Or changes di

[Lldb-commits] [PATCH] D94811: [lldb] Fix fallthrough with strictly virtual working directory.

dexonsmith added a comment. I'm wondering about this: > Currently, calling setCurrentWorkingDirectory on RedirectingFileSystem > will attempt to change the working directory for the external FS and if > that fails, it will set ExternalFSValidWD to false which prevents > fallthrough. I'm worried

[Lldb-commits] [PATCH] D77043: Use remote regnums in expedited list, value regs and invalidate regs

omjavaid updated this revision to Diff 317049. omjavaid added a comment. @labath addresses your review comments in current diff. Any further changes or this is ok ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77043/new/ https://reviews.llvm.org/D77043 Files: lldb/source/Plugins/Pr

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 317036. omjavaid added a comment. @labath incorporated your suggestion. Good for commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinu

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM. Pavel? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94672/new/ https://reviews.llvm.org/D94672 _

[Lldb-commits] [PATCH] D94754: skip g packet tests on darwin systems

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yeah, this is fine. I remember running this on darwin and noticing that debugserver only supports `G` (and lldb-server, amusingly, only supports `g`). I must have forgotten to add the decorato

[Lldb-commits] [lldb] 4017c6f - [lldb][docs] Translate ASCII art to restructured text formatting

Author: Raphael Isemann Date: 2021-01-15T14:43:27+01:00 New Revision: 4017c6fe7f11db5f266306bcd504690be586620a URL: https://github.com/llvm/llvm-project/commit/4017c6fe7f11db5f266306bcd504690be586620a DIFF: https://github.com/llvm/llvm-project/commit/4017c6fe7f11db5f266306bcd504690be586620a.dif

[Lldb-commits] [PATCH] D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference

This revision was automatically updated to reflect the committed changes. Closed by commit rGbab121a1b66e: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [lldb] bab121a - [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference

Author: Raphael Isemann Date: 2021-01-15T13:26:42+01:00 New Revision: bab121a1b66e85390cad019ec921febcba35519d URL: https://github.com/llvm/llvm-project/commit/bab121a1b66e85390cad019ec921febcba35519d DIFF: https://github.com/llvm/llvm-project/commit/bab121a1b66e85390cad019ec921febcba35519d.dif

[Lldb-commits] [PATCH] D94008: [LLDB] DynamicRegisterInfo calculate offsets in separate function

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9993fcbf53a: DynamicRegisterInfo calculate offsets in separate function (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D94008?vs=314326&id=31689

[Lldb-commits] [lldb] b9993fc - DynamicRegisterInfo calculate offsets in separate function

Author: Muhammad Omair Javaid Date: 2021-01-15T16:21:18+05:00 New Revision: b9993fcbf53aa28ca2e7696a1855affeb558b51c URL: https://github.com/llvm/llvm-project/commit/b9993fcbf53aa28ca2e7696a1855affeb558b51c DIFF: https://github.com/llvm/llvm-project/commit/b9993fcbf53aa28ca2e7696a1855affeb558b5

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fd77668b2cc: [LLDB] Add per-thread register infos shared pointer in gdb-remote (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [lldb] 4fd7766 - [LLDB] Add per-thread register infos shared pointer in gdb-remote

Author: Muhammad Omair Javaid Date: 2021-01-15T16:11:17+05:00 New Revision: 4fd77668b2cc215f0605fe20bb989b90b29f4346 URL: https://github.com/llvm/llvm-project/commit/4fd77668b2cc215f0605fe20bb989b90b29f4346 DIFF: https://github.com/llvm/llvm-project/commit/4fd77668b2cc215f0605fe20bb989b90b29f43

[Lldb-commits] [PATCH] D94754: skip g packet tests on darwin systems

jasonmolenda updated this revision to Diff 316880. jasonmolenda added a comment. Ah, Pavel's change was correct to run the first test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94754/new/ https://reviews.llvm.org/D94754 Files: lldb/test/API/

[Lldb-commits] [PATCH] D94754: skip g packet tests on darwin systems

jasonmolenda added a comment. Ah, part of my confusion is mine - the alignas() requires c++11 and I wasn't building with that mode when I did it by hand. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94754/new/ https://reviews.llvm.org/D94754 ___

[Lldb-commits] [PATCH] D94754: skip g packet tests on darwin systems

jasonmolenda created this revision. jasonmolenda added a reviewer: labath. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. debugserver doesn't support the g packet. I don't understand how this test runs in the first pla