augusto2112 added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:344
+ // TODO: Make the polling interval configurable.
+ std::chrono::milliseconds polling_interval = std::chrono::seconds(1);
+
clayborg
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94033/new/
https://reviews.llvm.org/D94033
_
wallace added inline comments.
Comment at: lldb/test/API/functionalities/exec/TestExec.py:96
# Run and we should stop due to exec
process.Continue()
clayborg wrote:
> Do we need this continue if we did the step above? How does this test still
clayborg added a comment.
Patch looks good, just a question of what timeout to use by default and
possible adding an option to lldb-server in case users want faster or slower
polling.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:344
wallace created this revision.
wallace added reviewers: clayborg, kusmour, aadsm.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
lldb-vsdode was communicating the list of modules to the IDE with events, which
in practice ended up
clayborg added a comment.
Walter and I identified this at work, definitely want Jim to chime in on this.
Comment at:
lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:2614-2616
m_thread_list_real.Clear();
m_thread_list.Clear();
+m_thread_plans.Clear();
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Great stuff! See inline comments.
A few new tests need to be added:
- test running lldb-vscode with invalid "--launch-target" executable path so
things fail to exec and verify w
wallace added inline comments.
Comment at: lldb/test/API/functionalities/exec/TestExec.py:91-93
+# Single step to create a thread plan. We have to make sure that after
exec
+# we clear all existing thread plans.
+thread.StepInstruction(False)
tammela added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93649/new/
https://reviews.llvm.org/D93649
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
tammela added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93481/new/
https://reviews.llvm.org/D93481
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
omjavaid updated this revision to Diff 314328.
omjavaid added a comment.
Added separate thread functions for both threads.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82866/new/
https://reviews.llvm.org/D82866
Files:
lldb/test/API/commands/register/register/aarch64_sve_registers/r
omjavaid updated this revision to Diff 314327.
omjavaid added a comment.
@labath I have incorporated your suggestions in this update. Invalidate all
registers as SVE size update is not a high frequency occurrence. Also using
same logic for offset calculation as we did DynamicRegisterInfo::Final
omjavaid created this revision.
omjavaid added a reviewer: labath.
omjavaid requested review of this revision.
This patch pull offset calculation logic out of DynamicRegisterInfo::Finalize
into a separate function. We are going to call this function whenever we update
SVE register sizes.
https
omjavaid updated this revision to Diff 314325.
omjavaid added a comment.
Rebased
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82857/new/
https://reviews.llvm.org/D82857
Files:
lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp
lldb/source/Plugins/Process/Utility/DynamicRe
14 matches
Mail list logo
