[Lldb-commits] [PATCH] D93444: Make DWARFUnit use the dwo_id from the DWARF5 CU header.

2020-12-16 Thread Jorge Gorbe Moya via Phabricator via lldb-commits
jgorbe created this revision. jgorbe requested review of this revision. Herald added a project: LLDB. In split DWARF v5 files, the DWO id is no longer in the DW_AT_GNU_dwo_id attribute. It's in the CU header instead. This change makes lldb look in both places. Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D93438: ObjectFileELF: Test whether reloc_header is non-null instead of asserting.

2020-12-16 Thread Peter Collingbourne via Phabricator via lldb-commits
pcc created this revision. pcc added a reviewer: labath. Herald added a subscriber: emaste. Herald added a reviewer: espindola. pcc requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: LLDB. It is possible for the GetSectionHeaderByIndex lookup to fail bec

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

2020-12-16 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. I am not sure if I need to worry about `ValueObject::IsLogicalTrue(...)` as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93421/new/ https://reviews.llvm.org/D93421 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [lldb] 869f836 - [lldb][NFC] Apply performance-faster-string-find (`str.find("X")` -> `str.find('x')`)

2020-12-16 Thread Jordan Rupprecht via lldb-commits
Author: Jordan Rupprecht Date: 2020-12-16T10:53:18-08:00 New Revision: 869f8363c424592e5f8c258492f46d5fcbc90c83 URL: https://github.com/llvm/llvm-project/commit/869f8363c424592e5f8c258492f46d5fcbc90c83 DIFF: https://github.com/llvm/llvm-project/commit/869f8363c424592e5f8c258492f46d5fcbc90c83.di

[Lldb-commits] [PATCH] D93396: [lldb] [Process/FreeBSDRemote] Replace GetRegisterSetCount()

2020-12-16 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Replace the wrong code in GetRegisterSetCount() with a constant return. The original code passed register index in place of register set index, effectively getting always tr

[Lldb-commits] [lldb] 9322e57 - [LLDB] Skip TestGuiBasicDebug.py on Arm and AArch64/Linux

2020-12-16 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2020-12-16T17:16:03+05:00 New Revision: 9322e571d7356a9a0e86aab954c3a916f0f07855 URL: https://github.com/llvm/llvm-project/commit/9322e571d7356a9a0e86aab954c3a916f0f07855 DIFF: https://github.com/llvm/llvm-project/commit/9322e571d7356a9a0e86aab954c3a916f0f078

[Lldb-commits] [lldb] 9f80ab1 - Revert "[LLDB] Remove AArch64/Linux xfail decorator from TestGuiBasicDebug"

2020-12-16 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2020-12-16T16:03:32+05:00 New Revision: 9f80ab1213e9f28b1b86f133fa7edf9a61c6f8fd URL: https://github.com/llvm/llvm-project/commit/9f80ab1213e9f28b1b86f133fa7edf9a61c6f8fd DIFF: https://github.com/llvm/llvm-project/commit/9f80ab1213e9f28b1b86f133fa7edf9a61c6f8