[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha updated this revision to Diff 31. tatyana-krasnukha added a comment. Thanks for pointing to the nested command problem! Replaced pointer to the execution context with the stack of contexts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92164/new/ https://reviews.l

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

jingham added a comment. This all looks fine except I'm not sure you can have a single override context. The lldb command line is only a bit recursive, but you can have sequences like: (lldb) command source file_that_contains_a_step >>> Step hits a breakpoint which has commands One of those

[Lldb-commits] [PATCH] D93052: "target create" shouldn't save target if the command failed

jingham added a comment. It's a little awkward that you have the "do_select" parameter with a default argument of "true" but then you explicitly pass "true" every time you use it... It seems reasonable that the Debugger might want to create targets w/o selecting them. For instance, suppose we

[Lldb-commits] [lldb] 1eee246 - [lldb] Remove single-case switch statement (NFC)

Author: Jonas Devlieghere Date: 2020-12-10T10:58:30-08:00 New Revision: 1eee24677bb61a83bcb2f091d7e3e722f782cb25 URL: https://github.com/llvm/llvm-project/commit/1eee24677bb61a83bcb2f091d7e3e722f782cb25 DIFF: https://github.com/llvm/llvm-project/commit/1eee24677bb61a83bcb2f091d7e3e722f782cb25.d

[Lldb-commits] [PATCH] D92759: [lldb] Introduce separate scratch ASTs for debug info types and types imported from C++ modules.

This revision was automatically updated to reflect the committed changes. Closed by commit rG47e7ecdd7d36: [lldb] Introduce separate scratch ASTs for debug info types and types imported… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior

[Lldb-commits] [lldb] 47e7ecd - [lldb] Introduce separate scratch ASTs for debug info types and types imported from C++ modules.

Author: Raphael Isemann Date: 2020-12-10T19:28:01+01:00 New Revision: 47e7ecdd7d36ca0924aa89c0fb2d956a6345a8f5 URL: https://github.com/llvm/llvm-project/commit/47e7ecdd7d36ca0924aa89c0fb2d956a6345a8f5 DIFF: https://github.com/llvm/llvm-project/commit/47e7ecdd7d36ca0924aa89c0fb2d956a6345a8f5.dif

[Lldb-commits] [PATCH] D93052: "target create" shouldn't save target if the command failed

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, JDevlieghere, jingham, teemperor. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: emaste. tatyana-krasnukha requested review of this revision. Herald added a subscriber: lldb-commits. TargetLi

[Lldb-commits] [PATCH] D92820: [lldb] Deal gracefully with concurrency in the API instrumentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGac25e8628c44: [lldb] Deal gracefully with concurrency in the API instrumentation. (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D92820?vs=31

[Lldb-commits] [lldb] ac25e86 - [lldb] Deal gracefully with concurrency in the API instrumentation.

Author: Jonas Devlieghere Date: 2020-12-10T09:37:49-08:00 New Revision: ac25e8628c443cddd841c6c91d1c9e23e88969e5 URL: https://github.com/llvm/llvm-project/commit/ac25e8628c443cddd841c6c91d1c9e23e88969e5 DIFF: https://github.com/llvm/llvm-project/commit/ac25e8628c443cddd841c6c91d1c9e23e88969e5.d

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha updated this revision to Diff 310927. tatyana-krasnukha retitled this revision from "Make SBDebugger internal variable getter and setter not use CommandInterpreter's context" to "Make CommandInterpreter's execution context the same as debugger's one.". tatyana-krasnukha edited t

[Lldb-commits] [PATCH] D92820: [lldb] Deal gracefully with concurrency in the API instrumentation.

JDevlieghere added a comment. In D92820#2446091 , @friss wrote: > This LGTM. > There is one thing that you might want to address, but I'll leave it up to > you (and even if you do it can be a different commit): with the introduction > of `idx` variables,

[Lldb-commits] [PATCH] D92820: [lldb] Deal gracefully with concurrency in the API instrumentation.

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. This LGTM. There is one thing that you might want to address, but I'll leave it up to you (and even if you do it can be a different commit): with the introduction of `idx` variables, it becomes

[Lldb-commits] [PATCH] D92757: [lldb] Remove assumption from Clang-based data formatters that their types are in the scratch AST

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG839e84527789: [lldb] Remove assumption from Clang-based data formatters that their types are… (authored by teemperor). Her

[Lldb-commits] [lldb] 839e845 - [lldb] Remove assumption from Clang-based data formatters that their types are in the scratch AST

Author: Raphael Isemann Date: 2020-12-10T17:35:03+01:00 New Revision: 839e845277894ad37fbca8063cbf1955331fbeff URL: https://github.com/llvm/llvm-project/commit/839e845277894ad37fbca8063cbf1955331fbeff DIFF: https://github.com/llvm/llvm-project/commit/839e845277894ad37fbca8063cbf1955331fbeff.dif

[Lldb-commits] [lldb] b505142 - [lldb/test] Change base class of lldb-server tests

Author: Pavel Labath Date: 2020-12-10T16:21:28+01:00 New Revision: b505142fa5d301238796318d2d092d6fb3bd2d31 URL: https://github.com/llvm/llvm-project/commit/b505142fa5d301238796318d2d092d6fb3bd2d31 DIFF: https://github.com/llvm/llvm-project/commit/b505142fa5d301238796318d2d092d6fb3bd2d31.diff

[Lldb-commits] [lldb] db84208 - [lldb/test] Replace ad-hoc server test choice with test categories

Author: Pavel Labath Date: 2020-12-10T16:21:28+01:00 New Revision: db8420825073371ddc077b020634e71e315e38a1 URL: https://github.com/llvm/llvm-project/commit/db8420825073371ddc077b020634e71e315e38a1 DIFF: https://github.com/llvm/llvm-project/commit/db8420825073371ddc077b020634e71e315e38a1.diff

[Lldb-commits] [PATCH] D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit

mgorny updated this revision to Diff 310877. mgorny added a comment. Avoid adding duplicate entry for ld-linux. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92187/new/ https://reviews.llvm.org/D92187 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp ll

[Lldb-commits] [PATCH] D92872: [lldb] [docs] Add a manpage for lldb-server

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rG25c40a45999e: [lldb] [docs] Add a manpage for lldb-server (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [lldb] 25c40a4 - [lldb] [docs] Add a manpage for lldb-server

Author: Michał Górny Date: 2020-12-10T15:02:25+01:00 New Revision: 25c40a45999e59e3b2902cd91373cd47e7a93488 URL: https://github.com/llvm/llvm-project/commit/25c40a45999e59e3b2902cd91373cd47e7a93488 DIFF: https://github.com/llvm/llvm-project/commit/25c40a45999e59e3b2902cd91373cd47e7a93488.diff

[Lldb-commits] [PATCH] D92872: [lldb] [docs] Add a manpage for lldb-server

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/docs/man/lldb-server.rst:108 +If neither of target options are used, :program:`lldb-server` is started +without a specific target. It can be afterwards instructedb the client +to launch or att

[Lldb-commits] [PATCH] D92872: [lldb] [docs] Add a manpage for lldb-server

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for writing this. Comment at: lldb/docs/man/lldb-server.rst:108 +If neither of target options are used, :program:`lldb-server` is started +without a specific target. I

[Lldb-commits] [lldb] b9f0713 - [lldb/Docs] Fix lldb-x86_64-fedora URL as it is still a silent bot

Author: Jan Kratochvil Date: 2020-12-10T13:52:10+01:00 New Revision: b9f0713f73a5aae97262f3cf07d74a96cbef8aa8 URL: https://github.com/llvm/llvm-project/commit/b9f0713f73a5aae97262f3cf07d74a96cbef8aa8 DIFF: https://github.com/llvm/llvm-project/commit/b9f0713f73a5aae97262f3cf07d74a96cbef8aa8.diff

[Lldb-commits] [PATCH] D92772: [lldb] Fix that symbols.clang-modules-cache-path is never initialized

This revision was automatically updated to reflect the committed changes. Closed by commit rG208e3f5d9b6c: [lldb] Fix that symbols.clang-modules-cache-path is never initialized (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Gi

[Lldb-commits] [lldb] 208e3f5 - [lldb] Fix that symbols.clang-modules-cache-path is never initialized

Author: Raphael Isemann Date: 2020-12-10T13:37:40+01:00 New Revision: 208e3f5d9b6c172f65dbb9cdbc9354c81c6d8911 URL: https://github.com/llvm/llvm-project/commit/208e3f5d9b6c172f65dbb9cdbc9354c81c6d8911 DIFF: https://github.com/llvm/llvm-project/commit/208e3f5d9b6c172f65dbb9cdbc9354c81c6d8911.dif

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat added a comment. Thanks for your review! If there are no objections to this patch, can you accept and land it for me? :) In D92643#2445146 , @labath wrote: > On a higher level, I am also worried about what this (the fact that we have > to do this

[Lldb-commits] [PATCH] D92784: [lldb] Allow LLDB to automatically retry a failed expression with an import std C++ module

This revision was automatically updated to reflect the committed changes. Closed by commit rG958608285eb4: [lldb] Allow LLDB to automatically retry a failed expression with an imported… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: r

[Lldb-commits] [lldb] 9586082 - [lldb] Allow LLDB to automatically retry a failed expression with an imported std C++ module

Author: Raphael Isemann Date: 2020-12-10T12:29:17+01:00 New Revision: 958608285eb4d04c6e3dc7071fa429b43597585b URL: https://github.com/llvm/llvm-project/commit/958608285eb4d04c6e3dc7071fa429b43597585b DIFF: https://github.com/llvm/llvm-project/commit/958608285eb4d04c6e3dc7071fa429b43597585b.dif

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

labath added a comment. It looks like the Type interface does not expose the static members (I guess it was never meant to do that), although, the underlying clang type obviously does contain them. After more consideration, I think parsing these straight from DWARF is fine, and consistent with

[Lldb-commits] [lldb] 4df4edb - [lldb][NFC] Fix a typo in TestCppMultipleInheritance

Author: Raphael Isemann Date: 2020-12-10T10:56:46+01:00 New Revision: 4df4edb6ad14c7748acda8670944cde19d537621 URL: https://github.com/llvm/llvm-project/commit/4df4edb6ad14c7748acda8670944cde19d537621 DIFF: https://github.com/llvm/llvm-project/commit/4df4edb6ad14c7748acda8670944cde19d537621.dif

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:792-793 + } + reg.byte_offset = end_reg_offset; + end_reg_offset += reg.byte_size; +} We already have a mostly generic algorithm for

[Lldb-commits] [PATCH] D82866: [LLDB] Test SVE dynamic resize with multiple threads

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/commands/register/register/aarch64_sve_registers/rw_access_dynamic_resize/main.c:58 +void *thread_func(void *x_void_ptr) { + if (*((int *)x_vo

[Lldb-commits] [PATCH] D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit

mgorny added a comment. One possible hackaround would be to do this only if 1st breakpoint hit is consistent (vs add on Linux), or just make the whole logic `#if defined(__FreeBSD__)`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92187/new/ https://reviews.llvm.org/D92187 __

[Lldb-commits] [PATCH] D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit

mgorny added a comment. Actually, I can still reproduce the double symbol problem with Arch's `ld-2.32.so`. I can't figure out what's wrong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92187/new/ https://reviews.llvm.org/D92187 ___ lldb-co

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D92264: [lldb] [POSIX-DYLD] Update the cached exe path after attach

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D92264#2436839 , @mgorny wrote: > Rewritten the test wrt comments, that is: > > 1. Added a breakpoint-continue to ensure that the program is past all