[Lldb-commits] [PATCH] D92712: [debugserver] Honor the cpu sub type if specified

This revision was automatically updated to reflect the committed changes. Closed by commit rG0db37576c1dd: [debugserver] Honor the cpu sub type if specified (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D92712?vs=309710&id=309713#toc

[Lldb-commits] [lldb] 0db3757 - [debugserver] Honor the cpu sub type if specified

Author: Jonas Devlieghere Date: 2020-12-04T20:37:41-08:00 New Revision: 0db37576c1dddbec1021b50320ae84a9d838742c URL: https://github.com/llvm/llvm-project/commit/0db37576c1dddbec1021b50320ae84a9d838742c DIFF: https://github.com/llvm/llvm-project/commit/0db37576c1dddbec1021b50320ae84a9d838742c.d

[Lldb-commits] [lldb] 315fab4 - [lldb] Remove unused argument to expectedFailure

Author: Jonas Devlieghere Date: 2020-12-04T20:37:41-08:00 New Revision: 315fab428d6084b09f82468740df5697ab3bb93b URL: https://github.com/llvm/llvm-project/commit/315fab428d6084b09f82468740df5697ab3bb93b DIFF: https://github.com/llvm/llvm-project/commit/315fab428d6084b09f82468740df5697ab3bb93b.d

[Lldb-commits] [PATCH] D92712: [debugserver] Honor the cpu sub type if specified

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ah very cool, I didn't realize we had a new posix_spawn attr setter that could set the cpu subtype. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92712/new/ https://revie

[Lldb-commits] [PATCH] D92712: [debugserver] Honor the cpu sub type if specified

JDevlieghere updated this revision to Diff 309710. JDevlieghere added a comment. - Fix bug that would not fall back to `posix_spawnattr_setarchpref_np` when the availability check failed. - Add subtypes for `arm64e` and `armv8` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92712/new/ h

[Lldb-commits] [PATCH] D92712: [debugserver] Honor the cpu sub type if specified

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a subscriber: pengfei. JDevlieghere requested review of this revision. Use the newly added spawnattr API, `posix_spawnattr_setarchpref_np`, to select a slice preferences per cpu and subcpu types, instead

[Lldb-commits] [PATCH] D92667: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. Ah, of course. SGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92667/new/ https://reviews.llvm.org/D92667 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D92264: [lldb] [POSIX-DYLD] Update the cached exe path after attach

mgorny updated this revision to Diff 309684. mgorny added a comment. With D92667 , I've finally found a way to reproduce this without running lldb-server explicitly — we need to spawn the program via relative path though. I've added a test that does that, and co

[Lldb-commits] [PATCH] D92667: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching

mgorny added a comment. In D92667#2434223 , @emaste wrote: > No objection here. I'm curious why the two modified tests work on Linux or > NetBSD today though? What Kamil said. We're still having two plugins, while these other platforms have only a remot

[Lldb-commits] [PATCH] D92692: Ignore DBGArchitecture from DebugSymbols DBGShellCommands outputs

jasonmolenda added a comment. Ah, I forgot to add. I added a test by having an existing corefile test (which loads an x86_64 binary) have a plist that claims it is i386. It's close to the same thing, and results in the same kind of erroring if lldb trusts the arch from the plist. Repository

[Lldb-commits] [PATCH] D92692: Ignore DBGArchitecture from DebugSymbols DBGShellCommands outputs

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added subscribers: JDevlieghere, kristof.beyls. jasonmolenda requested review of this revision. The plist returned by a DBGShellCommands program (dsymForUUID etc) may include an

[Lldb-commits] [PATCH] D92667: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching

krytarowski added a comment. In D92667#2434223 , @emaste wrote: > No objection here. I'm curious why the two modified tests work on Linux or > NetBSD today though? This is a debt of having 2 process plugins. NetBSD and Linux ship with a single one only.

[Lldb-commits] [PATCH] D92187: [lldb] [POSIX-DYLD] Add libraries from initial eTakeSnapshot action

mgorny updated this revision to Diff 309587. mgorny retitled this revision from "[lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld" to "[lldb] [POSIX-DYLD] Add libraries from initial eTakeSnapshot action". mgorny edited the summary of this revision. mgorny added a comment. Updated

[Lldb-commits] [PATCH] D92667: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching

emaste added a comment. No objection here. I'm curious why the two modified tests work on Linux or NetBSD today though? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92667/new/ https://reviews.llvm.org/D92667 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat added a comment. In D92643#2434050 , @jingham wrote: > I couldn't tell what you meant by this... I would expect that a Type would > tell you that static members exist, and their type, etc. But I wouldn't > expect a Type to be able to get a value

[Lldb-commits] [PATCH] D92667: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. Force gdb-remote plugin when attaching using the derivatives of PlatformPOSIX class. This is consistent with the behavior for launch

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

jingham added a comment. In D92643#2433441 , @werat wrote: > In D92643#2433428 , @labath wrote: > >> Are the static members included in the (SB)Type object that gets created >> when parsing the enclosing type? If y

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

rovka added a comment. Sorry, I had one more comment :) I think that should be all from my side. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:403 + m_register_info_sp = std::make_shared(); + m_register_info_sp->Clear(); Is it stil

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat added a comment. In D92643#2433428 , @labath wrote: > Are the static members included in the (SB)Type object that gets created when > parsing the enclosing type? If yes, we might be able to retrieve them that > way. Whether that would be cleaner --

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

labath added a comment. In D92643#2433365 , @werat wrote: > This approach feels a little bit "adhoc" (i.e. manually going through the DIE > entries for const members), but it works :) Please, let me know if there's a > better way to do this! Are the sta

[Lldb-commits] [PATCH] D92498: [lldb] Remove LLDB session dir and just store test traces in the respective test build directory

This revision was automatically updated to reflect the committed changes. Closed by commit rGe97b991eef63: [lldb] Remove LLDB session dir and just store test traces in the respective… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [lldb] e97b991 - [lldb] Remove LLDB session dir and just store test traces in the respective test build directory

Author: Raphael Isemann Date: 2020-12-04T11:43:10+01:00 New Revision: e97b991eef63663d1f635813fe375354edb7b51a URL: https://github.com/llvm/llvm-project/commit/e97b991eef63663d1f635813fe375354edb7b51a DIFF: https://github.com/llvm/llvm-project/commit/e97b991eef63663d1f635813fe375354edb7b51a.dif

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

labath added inline comments. Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.h:29 + DynamicRegisterInfo(DynamicRegisterInfo &) = default; void operator=(DynamicRegisterInfo &) = delete; rovka wrote: > I think operator= should be default

[Lldb-commits] [lldb] 594308c - [lldb][NFC] Rename TypeSystemClang::GetScratch to ScratchTypeSystemClang::GetForTarget

Author: Raphael Isemann Date: 2020-12-04T11:29:08+01:00 New Revision: 594308c7ad07b4cea20f41d915aa81794e909654 URL: https://github.com/llvm/llvm-project/commit/594308c7ad07b4cea20f41d915aa81794e909654 DIFF: https://github.com/llvm/llvm-project/commit/594308c7ad07b4cea20f41d915aa81794e909654.dif

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat edited reviewers, added: labath, jarin, teemperor, jankratochvil; removed: jdoerfert. werat added a subscriber: labath. werat added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: JDevlieghere. Hi, please, take a look at this patch! This is an approach suggested b

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat created this revision. werat requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Static const members initialized inside a class definition might not have a corresponding DW_TAG_variable, so t

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

rovka added inline comments. Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.h:29 + DynamicRegisterInfo(DynamicRegisterInfo &) = default; void operator=(DynamicRegisterInfo &) = delete; I think operator= should be default too if the copy

[Lldb-commits] [lldb] 973f390 - [lldb][NFC] Rename TypeSystemClangForExpressions to ScratchTypeSystemClang

Author: Raphael Isemann Date: 2020-12-04T09:41:42+01:00 New Revision: 973f3907a471eee85c35f7d283fe2de91ce953e2 URL: https://github.com/llvm/llvm-project/commit/973f3907a471eee85c35f7d283fe2de91ce953e2 DIFF: https://github.com/llvm/llvm-project/commit/973f3907a471eee85c35f7d283fe2de91ce953e2.dif

Re: [Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

> On Dec 3, 2020, at 5:43 PM, Robinson, Paul wrote: > > > >> -Original Message- >> From: Jim Ingham mailto:jing...@apple.com>> >> Sent: Thursday, December 3, 2020 5:51 PM >> To: David Blaikie >> > >; David >> Blaikie >>

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

dblaikie added a comment. Also, FWIW, the other gdb test suite failures we saw were: FAIL: gdb.base/foll-exec.exp: step through execlp call FAIL: gdb.base/foll-exec.exp: step after execlp call FAIL: gdb.base/foll-exec.exp: print execd-program/global_i (after execlp) FAIL: gdb.base/foll-ex

Re: [Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

> -Original Message- > From: Jim Ingham > Sent: Thursday, December 3, 2020 5:51 PM > To: David Blaikie > ; David Blaikie > via Phabricator > Cc: Robinson, Paul ; r...@google.com; > echri...@gmail.com; sontuan.vu...@gmail.com; mcros...@codeaurora.org; > nikola.te...@syrmia.com; lldb-comm

[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

dblaikie added a comment. In D91734#2432188 , @probinson wrote: > See D92606 for a front-end patch to improve > locations in the IR. > That, plus reapplying this patch, should help out GDB. I haven't had a > chance to r

Re: [Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

Note, lldb has a bunch of special handling for line 0 code. For instance, when we are pushing a breakpoint past the prologue we will keep pushing it forward over line number 0 lines. Those are compiler generated and in general people don't want to stop there. Similarly, if you are stepping th