[Lldb-commits] [PATCH] D91130: [crashlog] Implement parser for JSON encoded crashlogs

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda, clayborg. JDevlieghere requested review of this revision. Add a parser for JSON crashlogs. The `CrashLogParser` now defers to either the `JSONCrashLogParser` or the `TextCrashLogParser`. It first tries to int

[Lldb-commits] [PATCH] D91118: Fix handling of bit-fields in a union

shafik created this revision. shafik added reviewers: teemperor, aprantl. shafik requested review of this revision. When laying out bit-fields we don't properly take into account when they are in a union, they will all have a zero offset. https://reviews.llvm.org/D91118 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D90840: [lldb/DWARF] Fix sizes of DW_OP_const[1248][us] and DW_OP_litN results

dblaikie accepted this revision. dblaikie added a comment. Sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90840/new/ https://reviews.llvm.org/D90840 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] 0ca90eb - [lldb] Don't use ::exit but instead return from the driver loop (NFC)

Author: Jonas Devlieghere Date: 2020-11-09T16:47:30-08:00 New Revision: 0ca90eb3350b9e8c606fdf1ca0496e0bf3e330ec URL: https://github.com/llvm/llvm-project/commit/0ca90eb3350b9e8c606fdf1ca0496e0bf3e330ec DIFF: https://github.com/llvm/llvm-project/commit/0ca90eb3350b9e8c606fdf1ca0496e0bf3e330ec.d

[Lldb-commits] [lldb] 6ac12b5 - [lldb] Destory the debugger in the Driver dtor (NFC)

Author: Jonas Devlieghere Date: 2020-11-09T16:47:30-08:00 New Revision: 6ac12b5b6c5dc2c705f6e638cf6f5d50118abe92 URL: https://github.com/llvm/llvm-project/commit/6ac12b5b6c5dc2c705f6e638cf6f5d50118abe92 DIFF: https://github.com/llvm/llvm-project/commit/6ac12b5b6c5dc2c705f6e638cf6f5d50118abe92.d

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So I am not sure I like the caching that we are doing in TracePluginCommandDelegate in the CommandObjectTraceStart class. See inline comments, but it might be better to cache the

[Lldb-commits] [lldb] b2fa3b9 - [lldb] Make GetSelectedOrDummyTarget return the target by reference (NFC)

Author: Jonas Devlieghere Date: 2020-11-09T15:42:27-08:00 New Revision: b2fa3b922ecb219429ec7b839d15a06aedbc955a URL: https://github.com/llvm/llvm-project/commit/b2fa3b922ecb219429ec7b839d15a06aedbc955a DIFF: https://github.com/llvm/llvm-project/commit/b2fa3b922ecb219429ec7b839d15a06aedbc955a.d

[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

clayborg added a comment. So down to just one question about the packet definition about if we should have an error code in JSON or if an error code even makes sense. Other than that this LGTM Comment at: lldb/docs/lldb-gdb-remote.txt:262 +send packet: jLLDBTraceSupportedType

[Lldb-commits] [PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 added a comment. In D91103#2384048 , @jingham wrote: > IIUC, the expression parser part of this change suppresses any Fixits that > are clang-tidy type rewrites, is that right? If so that is indeed the > correct behavior. But the fact that thi

[Lldb-commits] [PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

jingham added a comment. IIUC, the expression parser part of this change suppresses any Fixits that are clang-tidy type rewrites, is that right? If so that is indeed the correct behavior. But that fact that this change implements that behavior is entirely non-obvious at the call site. Could

[Lldb-commits] [PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 created this revision. njames93 added reviewers: rsmith, aaron.ballman, klimek, alexfh. Herald added subscribers: lldb-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLDB. njames93 requested review of this revision. Herald added a subscriber: JDevlieghere. Implementing a

[Lldb-commits] [PATCH] D90840: [lldb/DWARF] Fix sizes of DW_OP_const[1248][us] and DW_OP_litN results

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. It fixes the issue at hand and gets us closer to conforming to the standard. Comment at: lldb/source/Expression/DWARFExpression.cpp:948 + // there. + aut

[Lldb-commits] [PATCH] D91090: [lldb] [Process/NetBSD] Correct DS/ES/FS/GS register sizes

This revision was automatically updated to reflect the committed changes. Closed by commit rGed3ac6c110a5: [lldb] [Process/NetBSD] Correct DS/ES/FS/GS register sizes (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [lldb] ed3ac6c - [lldb] [Process/NetBSD] Correct DS/ES/FS/GS register sizes

Author: Michał Górny Date: 2020-11-09T22:14:58+01:00 New Revision: ed3ac6c110a53b332f490f1c5ddcd2b7c30d5189 URL: https://github.com/llvm/llvm-project/commit/ed3ac6c110a53b332f490f1c5ddcd2b7c30d5189 DIFF: https://github.com/llvm/llvm-project/commit/ed3ac6c110a53b332f490f1c5ddcd2b7c30d5189.diff

[Lldb-commits] [PATCH] D91032: [lldb] [Process/FreeBSDRemote] Explicitly copy dbregs to new threads

mgorny updated this revision to Diff 303957. mgorny added a comment. This revision is now accepted and ready to land. Added a verbose comment why we're doing that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91032/new/ https://reviews.llvm.org/D91032 Files: lldb/source/Plugins/Proc

[Lldb-commits] [lldb] d7be9a4 - Revert "Check if debug line sequences are starting after the first code segment"

Author: António Afonso Date: 2020-11-09T11:45:35-08:00 New Revision: d7be9a46475fb4b74d337d3615c36024ffe8379f URL: https://github.com/llvm/llvm-project/commit/d7be9a46475fb4b74d337d3615c36024ffe8379f DIFF: https://github.com/llvm/llvm-project/commit/d7be9a46475fb4b74d337d3615c36024ffe8379f.diff

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

aadsm added a comment. reverting because I'm not able to repro the fails, so need more time to figure it out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87172/new/ https://reviews.llvm.org/D87172 ___

[Lldb-commits] [PATCH] D91090: [lldb] [Process/NetBSD] Correct DS/ES/FS/GS register sizes

mgorny created this revision. mgorny added a reviewer: krytarowski. mgorny requested review of this revision. Fix DS/ES/FS/GS register sizes in getter/setter for NetBSD. Apparently only CS and SS registers are specified as 64/32-bit in LLDB, while the others are specified as 16-bit. https://rev

[Lldb-commits] [lldb] a9dcd15 - Revert "Ignores functions that have a range starting outside of a code section"

Author: António Afonso Date: 2020-11-09T09:07:48-08:00 New Revision: a9dcd15f50dc27ca3ed4aa98b8832923db7dfb61 URL: https://github.com/llvm/llvm-project/commit/a9dcd15f50dc27ca3ed4aa98b8832923db7dfb61 DIFF: https://github.com/llvm/llvm-project/commit/a9dcd15f50dc27ca3ed4aa98b8832923db7dfb61.diff

[Lldb-commits] [PATCH] D90987: [lldb] Avoid confusing crashes during reproducer replay when initialization failed

JDevlieghere added a comment. In D90987#2381853 , @labath wrote: > I wonder if there's a way to add some consistency checks into the (active) > replay machinery. Like, maybe we could, for each function that returns an > SBError, record a flag saying whet

[Lldb-commits] [lldb] b31d787 - [lldb] Avoid confusing reproducer crashes when initialization failed

Author: Jonas Devlieghere Date: 2020-11-09T08:50:10-08:00 New Revision: b31d78794998d313efe80472670602d0388fdbfa URL: https://github.com/llvm/llvm-project/commit/b31d78794998d313efe80472670602d0388fdbfa DIFF: https://github.com/llvm/llvm-project/commit/b31d78794998d313efe80472670602d0388fdbfa.d

[Lldb-commits] [PATCH] D90987: [lldb] Avoid confusing crashes during reproducer replay when initialization failed

This revision was automatically updated to reflect the committed changes. Closed by commit rGb31d78794998: [lldb] Avoid confusing reproducer crashes when initialization failed (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D90987?vs=3

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG265a38fbc547: Check if debug line sequences are starting after the first code segment (authored by aadsm). Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf30bc0168d2: Ignores functions that have a range starting outside of a code section (authored by aadsm). Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [lldb] df30bc0 - Ignores functions that have a range starting outside of a code section

Author: António Afonso Date: 2020-11-09T08:26:08-08:00 New Revision: df30bc0168d236e5575d815030d6fe4cd8626f34 URL: https://github.com/llvm/llvm-project/commit/df30bc0168d236e5575d815030d6fe4cd8626f34 DIFF: https://github.com/llvm/llvm-project/commit/df30bc0168d236e5575d815030d6fe4cd8626f34.diff

[Lldb-commits] [lldb] 265a38f - Check if debug line sequences are starting after the first code segment

Author: António Afonso Date: 2020-11-09T08:26:00-08:00 New Revision: 265a38fbc547adc0e2b71a98dac4d0a60b0dd63c URL: https://github.com/llvm/llvm-project/commit/265a38fbc547adc0e2b71a98dac4d0a60b0dd63c DIFF: https://github.com/llvm/llvm-project/commit/265a38fbc547adc0e2b71a98dac4d0a60b0dd63c.diff

[Lldb-commits] [PATCH] D91065: [lldb] [test] Rename '.categories' to 'categories'

teemperor accepted this revision. teemperor added a subscriber: JDevlieghere. teemperor added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91065/new/ https://reviews.llvm.org/D91065 _

[Lldb-commits] [PATCH] D91065: [lldb] [test] Rename '.categories' to 'categories'

emaste added a comment. No objection from me but I haven't been sufficiently involved in lldb's tests to approve. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91065/new/ https://reviews.llvm.org/D91065 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D91076: [lldb] [Process/FreeBSDRemote] Correct DS/ES/FS/GS register sizes

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. Agree that even if refactoring is needed correcting these makes sense. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91076/new/ https://reviews.llvm.org/D91076 __

[Lldb-commits] [PATCH] D91076: [lldb] [Process/FreeBSDRemote] Correct DS/ES/FS/GS register sizes

mgorny added a comment. @labath, yes, I'm convinced already that we need to abstract this away into something more fancy like Linux does. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91076/new/ https://reviews.llvm.org/D91076 ___ lldb-commi

[Lldb-commits] [PATCH] D91076: [lldb] [Process/FreeBSDRemote] Correct DS/ES/FS/GS register sizes

mgorny created this revision. mgorny added reviewers: emaste, krytarowski, labath. Herald added a subscriber: arichardson. mgorny requested review of this revision. Fix DS/ES/FS/GS register sizes in getter/setter for FreeBSD. Apparently only CS and SS registers are specified as 64/32-bit in LLDB,

[Lldb-commits] [PATCH] D90840: [lldb/DWARF] Fix sizes of DW_OP_const[1248][us] and DW_OP_litN results

labath added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:945 + auto to_generic = [addr_size = opcodes.GetAddressByteSize()](auto v) { +bool is_signed = std::is_signed::value; +return Scalar( labath wrote: > dblaikie wrote: > >

[Lldb-commits] [PATCH] D90840: [lldb/DWARF] Fix sizes of DW_OP_const[1248][us] and DW_OP_litN results

labath added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:944 Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_EXPRESSIONS)); + auto to_generic = [addr_size = opcodes.GetAddressByteSize()](auto v) { +bool is_signed = std::is_signed::v

[Lldb-commits] [PATCH] D90840: [lldb/DWARF] Fix sizes of DW_OP_const[1248][us] and DW_OP_litN results

labath updated this revision to Diff 303842. labath added a comment. Go back to using the signedness of the operand. Implementing the generic type correctly would be a (much) larger undertaking, so stick to the existing semantics as much as possible. Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D90840: [lldb/DWARF] Fix sizes of DW_OP_const[1248][us] and DW_OP_litN results

labath updated this revision to Diff 303825. labath marked an inline comment as done. labath added a comment. - use push_back - use default & capture - use fix signedness (unsigned) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90840/new/ https://r

[Lldb-commits] [PATCH] D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP

mgorny updated this revision to Diff 303817. mgorny edited the summary of this revision. mgorny added a comment. This revision is now accepted and ready to land. Pass unknown SIGTRAPs to the user too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91007/new/ https://reviews.llvm.org/D910

[Lldb-commits] [lldb] 57f8797 - [LLDB][test] - Update one more test after the yaml2obj change.

Author: Georgii Rymar Date: 2020-11-09T14:56:07+03:00 New Revision: 57f87977f53fd1c06fee669511520f33cdc85a20 URL: https://github.com/llvm/llvm-project/commit/57f87977f53fd1c06fee669511520f33cdc85a20 DIFF: https://github.com/llvm/llvm-project/commit/57f87977f53fd1c06fee669511520f33cdc85a20.diff

[Lldb-commits] [PATCH] D91065: [lldb] [test] Rename '.categories' to 'categories'

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. mgorny requested review of this revision. Make category-specifying files visible. There is really no good reason to keep them hidden, and having them visible increases the chances that someone will actua

[Lldb-commits] [lldb] 2384c4f - Revert "[lldb] [Host/freebsd] Set Arg0 for 'platform process list -v'"

Author: Michał Górny Date: 2020-11-09T12:09:12+01:00 New Revision: 2384c4f9713a19874821c0f290227680a7bcf283 URL: https://github.com/llvm/llvm-project/commit/2384c4f9713a19874821c0f290227680a7bcf283 DIFF: https://github.com/llvm/llvm-project/commit/2384c4f9713a19874821c0f290227680a7bcf283.diff

[Lldb-commits] [PATCH] D91026: [lldb] [Host/freebsd] Set Arg0 for 'platform process list -v'

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc125665c5e6: [lldb] [Host/freebsd] Set Arg0 for 'platform process list -v' (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [lldb] bc12566 - [lldb] [Host/freebsd] Set Arg0 for 'platform process list -v'

Author: Michał Górny Date: 2020-11-09T12:09:12+01:00 New Revision: bc125665c5e633df103d3a41d8f46afd781ea304 URL: https://github.com/llvm/llvm-project/commit/bc125665c5e633df103d3a41d8f46afd781ea304 DIFF: https://github.com/llvm/llvm-project/commit/bc125665c5e633df103d3a41d8f46afd781ea304.diff

[Lldb-commits] [lldb] 62e3b2e - [lldb][test] - Update test cases after yaml2obj change.

Author: Georgii Rymar Date: 2020-11-09T13:53:40+03:00 New Revision: 62e3b2ec1d8e54d2b377623c485d5399bc94521f URL: https://github.com/llvm/llvm-project/commit/62e3b2ec1d8e54d2b377623c485d5399bc94521f DIFF: https://github.com/llvm/llvm-project/commit/62e3b2ec1d8e54d2b377623c485d5399bc94521f.diff

[Lldb-commits] [PATCH] D91056: [lldb] [test] Skip ObjC-based tests via 'objc' category

mgorny updated this revision to Diff 303800. mgorny added a comment. Failed to `git add` one of the `.categories` files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91056/new/ https://reviews.llvm.org/D91056 Files: lldb/packages/Python/lldbsuite/test/dotest.py lldb/test/API/comma

[Lldb-commits] [PATCH] D91030: [lldb] [test] Extend watchpoint test to wait for thread to start

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e2ef84fe723: [lldb] [test] Extend watchpoint test to wait for thread to start (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [lldb] fce8e75 - [lldb] [Host/freebsd] Set Arg0 for 'platform process list -v'

Author: Michał Górny Date: 2020-11-09T11:35:11+01:00 New Revision: fce8e758892f0b650762513680adc06cea53d6e3 URL: https://github.com/llvm/llvm-project/commit/fce8e758892f0b650762513680adc06cea53d6e3 DIFF: https://github.com/llvm/llvm-project/commit/fce8e758892f0b650762513680adc06cea53d6e3.diff

[Lldb-commits] [lldb] 7e2ef84 - [lldb] [test] Extend watchpoint test to wait for thread to start

Author: Michał Górny Date: 2020-11-09T11:35:11+01:00 New Revision: 7e2ef84fe7232368f92ec0835c3eda869c85a445 URL: https://github.com/llvm/llvm-project/commit/7e2ef84fe7232368f92ec0835c3eda869c85a445 DIFF: https://github.com/llvm/llvm-project/commit/7e2ef84fe7232368f92ec0835c3eda869c85a445.diff

[Lldb-commits] [lldb] 9e1409a - [lldb] [Process/FreeBSDRemote] Handle exec() from inferior

Author: Michał Górny Date: 2020-11-09T11:35:11+01:00 New Revision: 9e1409aa1e0bb1963757941cf4db539147614fbf URL: https://github.com/llvm/llvm-project/commit/9e1409aa1e0bb1963757941cf4db539147614fbf DIFF: https://github.com/llvm/llvm-project/commit/9e1409aa1e0bb1963757941cf4db539147614fbf.diff

[Lldb-commits] [PATCH] D91012: [llvm] [Support] Fix segv if argv0 is null in getMainExecutable()

This revision was automatically updated to reflect the committed changes. Closed by commit rGfce8e758892f: [lldb] [Host/freebsd] Set Arg0 for 'platform process list -v' (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D91012?vs=303666&id=3037

[Lldb-commits] [PATCH] D90938: [lldb] [Process/FreeBSDRemote] Handle exec() from inferior

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e1409aa1e0b: [lldb] [Process/FreeBSDRemote] Handle exec() from inferior (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [lldb] afcdd43 - [llvm] [Support] Fix segv if argv0 is null in getMainExecutable()

Author: Michał Górny Date: 2020-11-09T11:35:11+01:00 New Revision: afcdd43bf71d9503dbd2b700710818daafa0cb00 URL: https://github.com/llvm/llvm-project/commit/afcdd43bf71d9503dbd2b700710818daafa0cb00 DIFF: https://github.com/llvm/llvm-project/commit/afcdd43bf71d9503dbd2b700710818daafa0cb00.diff

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 303786. omjavaid added a comment. This updates after remove invalidate_regs from primary registers D91057 . Currently only SVE Z registers had invalidate_reg list populated which has been removed to send less information ac

[Lldb-commits] [PATCH] D91057: [LLDB] Update SVE Z reg info to remove invalidate regs

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: tschuett. Herald added a reviewer: rengolin. omjavaid requested review of this revision. In our recent discussion we are aiming to make LLDB registers exchange minimum possible information in qRegisterIn

[Lldb-commits] [PATCH] D91056: [lldb] [test] Skip ObjC-based tests via 'objc' category

mgorny added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCExpr.py:17 -@skipUnlessDarwin def test_expr_with_run_command(self): (this whole category has objc in `.categories`) =

[Lldb-commits] [lldb] 24f0753 - [lldb] Fix DW_AT_decl_file from DW_AT_specification from a different CU

Author: Jan Kratochvil Date: 2020-11-09T10:52:48+01:00 New Revision: 24f07531a34e141257f6616611e6430aed6f60a1 URL: https://github.com/llvm/llvm-project/commit/24f07531a34e141257f6616611e6430aed6f60a1 DIFF: https://github.com/llvm/llvm-project/commit/24f07531a34e141257f6616611e6430aed6f60a1.diff

[Lldb-commits] [PATCH] D91014: [lldb] Fix `DW_AT_decl_file` from `DW_AT_specification` from a different CU

jankratochvil marked 2 inline comments as done. jankratochvil added a comment. Thanks; I see you check very every line even in testcases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91014/new/ https://reviews.llvm.org/D91014

[Lldb-commits] [PATCH] D91056: [lldb] [test] Skip ObjC-based tests via 'objc' category

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. Herald added a reviewer: espindola. mgorny requested review of this revision. Replace the plethora of ObjC-implied 'skipUnlessDarwin' decorators with marking tests as 'objc' category (whenever missing), a

[Lldb-commits] [PATCH] D91014: [lldb] Fix `DW_AT_decl_file` from `DW_AT_specification` from a different CU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24f07531a34e: [lldb] Fix DW_AT_decl_file from DW_AT_specification from a different CU (authored by jankratochvil). Changed prior to commit: https:

[Lldb-commits] [PATCH] D91032: [lldb] [Process/FreeBSDRemote] Explicitly copy dbregs to new threads

mgorny planned changes to this revision. mgorny added a comment. Yeah, I'm not going to proceed until I get more feedback from FreeBSD end. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91032/new/ https://reviews.llvm.org/D91032 ___ lldb-comm

[Lldb-commits] [PATCH] D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests

labath added a subscriber: amccarth. labath added a comment. Zach is pretty much inactive. @amccarth is a better windows contact these days. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90876/new/ https://reviews.llvm.org/D90876 ___ lldb-com

[Lldb-commits] [PATCH] D91032: [lldb] [Process/FreeBSDRemote] Explicitly copy dbregs to new threads

labath added a comment. Interesting. It would still probably be useful to mention the uncertain state of this approach in the code somewhere... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91032/new/ https://reviews.llvm.org/D91032 ___ lldb

[Lldb-commits] [PATCH] D91012: [llvm] [Support] Fix segv if argv0 is null in getMainExecutable()

labath accepted this revision. labath added a comment. Ok, I understand what's happening now. The problem is calling PrintStackTrace without a previous PrintStackTraceOnErrorSignal. That seems reasonable. It would be nice to have a llvm test for this, but that would be quite tricky, as all gtes

[Lldb-commits] [PATCH] D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP

labath added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:287 +// probably a unknown event-generated SIGTRAP. +return; } mgorny wrote: > labath wrote: > > What will happen in case this returns? Will t

[Lldb-commits] [PATCH] D91032: [lldb] [Process/FreeBSDRemote] Explicitly copy dbregs to new threads

mgorny added a comment. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250954 I'm still trying to figure out whether it's a real bug or just we're relying on too many variables. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91032/new/ https://reviews.llvm.org/D91032 __

[Lldb-commits] [PATCH] D91032: [lldb] [Process/FreeBSDRemote] Explicitly copy dbregs to new threads

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. So, is this like a kernel bug that we're working around here? Would it make sense to file a bug on the freebsd tracker and reference it from here? CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D91012: [llvm] [Support] Fix segv if argv0 is null in getMainExecutable()

mgorny added a comment. In D91012#2381884 , @labath wrote: > Are you sure that's the right level at which to fix this? Can you explain how > that particular test manages to pass a nullptr to this function? I'm not. However, it's a smaller change that che

[Lldb-commits] [PATCH] D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:287 +// probably a unknown event-generated SIGTRAP. +return; } labath wrote: > What will happen in case this returns? Will the process auto-re

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

labath added a comment. In D91003#2381892 , @teemperor wrote: > In D91003#2381885 , @mgorny wrote: > >> In D91003#2381881 , @labath wrote: >> >>> If we put all of the objc te

[Lldb-commits] [PATCH] D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP

labath added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:287 +// probably a unknown event-generated SIGTRAP. +return; } What will happen in case this returns? Will the process auto-resume or just ha

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

teemperor added a comment. Actually that might not work for testing remote platforms that support Obj-C from non-ObjC hosts, so I guess we have to check if we're on Darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91003/new/ https://reviews.l

[Lldb-commits] [PATCH] D91014: [lldb] Fix `DW_AT_decl_file` from `DW_AT_specification` from a different CU

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Thanks for catching that. I am particularly happy that we now have an explicit DW_FORM_ref_addr test. It's a very interesting/tricky case, but it does not happen all that often in

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

teemperor added a comment. In D91003#2381885 , @mgorny wrote: > In D91003#2381881 , @labath wrote: > >> If we put all of the objc tests into objc-specific directories (it looks >> like most of them are there alread

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

mgorny added a comment. In D91003#2381881 , @labath wrote: > If we put all of the objc tests into objc-specific directories (it looks like > most of them are there already, but I spotted two outliers in this patch), > then we could mark those directories

[Lldb-commits] [PATCH] D91012: [llvm] [Support] Fix segv if argv0 is null in getMainExecutable()

labath added a comment. Are you sure that's the right level at which to fix this? Can you explain how that particular test manages to pass a nullptr to this function? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91012/new/ https://reviews.llvm.org/D91012 _

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

labath added a comment. If we put all of the objc tests into objc-specific directories (it looks like most of them are there already, but I spotted two outliers in this patch), then we could mark those directories with the existing "objc" category, and use the existing category-based skipping m

[Lldb-commits] [PATCH] D90987: [lldb] Avoid confusing crashes during reproducer replay when initialization failed

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I wonder if there's a way to add some consistency checks into the (active) replay machinery. Like, maybe we could, for each function that returns an SBError, record a flag saying whether that