[Lldb-commits] [PATCH] D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP

mgorny updated this revision to Diff 303676. mgorny added a comment. Updated to treat generic SIGTRAP as a fallback as requested by @krytarowski. This happens either if `si_code >= SI_USER`, or there is no siginfo and no other flag is set. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP

krytarowski added a comment. I propose to filter all user induced signals at once and check `& 0x1` and SI_USER. http://src.illumos.org/source/xref/freebsd-head/sys/sys/signal.h#406 This way we will avoid all future fallout and crashing the debugger on unknown signal. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D91014: [lldb] Fix `DW_AT_decl_file` from `DW_AT_specification` from a different CU

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. jankratochvil requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber:

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

emaste added a comment. > In theory Obj-C is available on other systems Yes, in particular it should be possible on FreeBSD. I agree that an Obj-C-specific decorator would be best but it's a very low priority. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D91012: [llvm] [Support] Fix segv if argv0 is null in getMainExecutable()

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, espindola. Herald added subscribers: dexonsmith, hiraditya, arichardson. Herald added a project: LLVM. mgorny requested review of this revision. When LLDB Python bindings are used and stack backtraces are enabled fo

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rG93c9110c980c: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [lldb] 1ba9ced - [lldb] [test] Un-skip one of TestRaise signals on fbsd

Author: Michał Górny Date: 2020-11-07T19:26:42+01:00 New Revision: 1ba9cedd0af241ed515ecd4eed3c1a241bd4813d URL: https://github.com/llvm/llvm-project/commit/1ba9cedd0af241ed515ecd4eed3c1a241bd4813d DIFF: https://github.com/llvm/llvm-project/commit/1ba9cedd0af241ed515ecd4eed3c1a241bd4813d.diff

[Lldb-commits] [lldb] 93c9110 - [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

Author: Michał Górny Date: 2020-11-07T19:26:42+01:00 New Revision: 93c9110c980c9fc4bd72fb307c18f79afa0381e3 URL: https://github.com/llvm/llvm-project/commit/93c9110c980c9fc4bd72fb307c18f79afa0381e3 DIFF: https://github.com/llvm/llvm-project/commit/93c9110c980c9fc4bd72fb307c18f79afa0381e3.diff

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

teemperor added a comment. In D91003#2380921 , @mgorny wrote: > In D91003#2380907 , @teemperor wrote: > >> Given that these are all Objective-C tests, this LGTM. >> >> (Out of scope for this patch, but it would prob

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

mgorny added a comment. In D91003#2380907 , @teemperor wrote: > Given that these are all Objective-C tests, this LGTM. > > (Out of scope for this patch, but it would probably be cleaner if we replace > all the skipUnlessDarwin uses because of Obj-C with a

[Lldb-commits] [PATCH] D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Update the SIGTRAP handler to account for the possibility of SIGTRAP being generated by the user, i.e. not having any specific debugging event associated with it. These ins

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Given that these are all Objective-C tests, this LGTM. (Out of scope for this patch, but it would probably be cleaner if we replace all the skipUnlessDarwin uses because of Obj-C with a

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

mgorny created this revision. mgorny added reviewers: labath, JDevlieghere, zturner, krytarowski, emaste. mgorny requested review of this revision. Use skipUnlessDarwin decorator for tests that are specific to Darwin, instead of skipIf... for all other platforms. This should make it clear that th

[Lldb-commits] [PATCH] D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests

mgorny added a reviewer: zturner. mgorny added a subscriber: zturner. mgorny added a comment. @zturner, could you tell us what is the expected behavior on Windows? Is it the same as Darwin (i.e. as expected by this test), or do you consider it incidental and would prefer skipping the test on Win