[Lldb-commits] [lldb] 136d067 - [lldb] Fix XcodeSDKModuleTests

Author: Jonas Devlieghere Date: 2020-10-30T23:08:35-07:00 New Revision: 136d06749b91f5051485983a2d4de82c31d25975 URL: https://github.com/llvm/llvm-project/commit/136d06749b91f5051485983a2d4de82c31d25975 DIFF: https://github.com/llvm/llvm-project/commit/136d06749b91f5051485983a2d4de82c31d25975.d

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 302000. wallace added a comment. Address changes. - Made IntelPTError and IntelPTInstruction non-copyable, which simplified the code. - I still keep IntelPTError as a lightweight way to create Error objects on demand when traversing the trace. Notice that E

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:116 + pt_insn m_pt_insn; + std::shared_ptr m_error; +}; wallace wrote: > vsk wrote: > > Still doesn't feel like this is aligning with the design of llvm::Error - > >

[Lldb-commits] [lldb] d20aa7c - [lldb] Report old modules from ModuleList::ReplaceEquivalent

Author: Joseph Tremoulet Date: 2020-10-30T15:14:32-04:00 New Revision: d20aa7ca422145fb4d07e16c1d0aa7de9e3554ea URL: https://github.com/llvm/llvm-project/commit/d20aa7ca422145fb4d07e16c1d0aa7de9e3554ea DIFF: https://github.com/llvm/llvm-project/commit/d20aa7ca422145fb4d07e16c1d0aa7de9e3554ea.di

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61bfc703c3d3: [lldb] GetSharedModule: Collect old modules in SmallVector (authored by JosephTremoulet). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd20aa7ca4221: [lldb] Report old modules from ModuleList::ReplaceEquivalent (authored by JosephTremoulet). Changed prior to commit: https://reviews

[Lldb-commits] [lldb] 61bfc70 - [lldb] GetSharedModule: Collect old modules in SmallVector

Author: Joseph Tremoulet Date: 2020-10-30T15:14:31-04:00 New Revision: 61bfc703c3d36fbefc476cd3829065d983c1c792 URL: https://github.com/llvm/llvm-project/commit/61bfc703c3d36fbefc476cd3829065d983c1c792 DIFF: https://github.com/llvm/llvm-project/commit/61bfc703c3d36fbefc476cd3829065d983c1c792.di

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:26 +public: + IntelPTError() = default; + vsk wrote: > Do we need a default constructor for this pure-virtual class? The compiler forces me to do it because I declare b

[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

wallace created this revision. wallace added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace requested review of this revision. Herald added a subscriber: JDevlieghere. Depends on D89283 . The goal of this packe

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89156/new/ https://reviews.llvm.org/D89156 ___

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

vsk added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:26 +public: + IntelPTError() = default; + Do we need a default constructor for this pure-virtual class? Comment at: lldb/source/Plugins/Trace/intel-pt/De

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

JosephTremoulet added a comment. OK, I believe this is correct now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89156/new/ https://reviews.llvm.org/D89156 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

JosephTremoulet updated this revision to Diff 301964. JosephTremoulet added a comment. - Ignore old modules not in target list Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89156/new/ https://reviews.llvm.org/D89156 Files: lldb/include/lldb/Core

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace added a comment. friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89283/new/ https://reviews.llvm.org/D89283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] 4348e0e - [lldb][NFC] Refactor getUUID functionality

Author: Zequan Wu Date: 2020-10-30T10:44:37-07:00 New Revision: 4348e0eee4dd49623cbf315c52d11f413ed438be URL: https://github.com/llvm/llvm-project/commit/4348e0eee4dd49623cbf315c52d11f413ed438be DIFF: https://github.com/llvm/llvm-project/commit/4348e0eee4dd49623cbf315c52d11f413ed438be.diff LOG

[Lldb-commits] [PATCH] D90325: [lldb][NFC] Refactor getUUID functionality

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4348e0eee4dd: [lldb][NFC] Refactor getUUID functionality (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D90325: [lldb][NFC] Refactor getUUID functionality

zequanwu updated this revision to Diff 301957. zequanwu marked 2 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90325/new/ https://reviews.llvm.org/D90325 Files: lldb/include/ll

[Lldb-commits] [PATCH] D90454: [lldb] [Host/{free, net}bsd] Fix process matching by name

mgorny added a comment. Actually, this is tested already with the old plugin. It's just the new plugin that's suffering the issue, probably inherited from the original NetBSD code :-(. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90454/new/ https://reviews.llvm.org/D90454 __

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

JosephTremoulet added inline comments. Comment at: lldb/source/Target/Target.cpp:2131-2132 +for (ModuleSP &old_module_sp : old_modules) { + if (m_images.GetIndexForModule(old_module_sp.get()) != + LLDB_INVALID_INDEX32) { +if (!did_replace

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

JosephTremoulet updated this revision to Diff 301935. JosephTremoulet added a comment. - Expand logging as suggested in D89157 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89156/new/ https://reviews.llvm.org/D8915

[Lldb-commits] [PATCH] D90414: [lldb] Ignore binary data in crashlog

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b17b6d924d2: [lldb] Ignore binary data in crashlog (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90414/new/ https://reviews.llv

[Lldb-commits] [lldb] 5b17b6d - [lldb] Ignore binary data in crashlog

Author: Jonas Devlieghere Date: 2020-10-30T09:17:45-07:00 New Revision: 5b17b6d924d25bb98332462bdbd4b59333864c0b URL: https://github.com/llvm/llvm-project/commit/5b17b6d924d25bb98332462bdbd4b59333864c0b DIFF: https://github.com/llvm/llvm-project/commit/5b17b6d924d25bb98332462bdbd4b59333864c0b.d

[Lldb-commits] [PATCH] D90414: [lldb] Ignore binary data in crashlog

JDevlieghere added a comment. In D90414#2364816 , @aprantl wrote: > Just FYI, we do have unit tests for the crashlog parser now, but I don't know > how well this fits in there. I see a test that generates one and that checks some regexes, but no test tha

[Lldb-commits] [PATCH] D90414: [lldb] Ignore binary data in crashlog

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Just FYI, we do have unit tests for the crashlog parser now, but I don't know how well this fits in there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90414/new/ https://reviews.

[Lldb-commits] [lldb] 1d1d916 - Fix an embarrasing use-after-free from a895a446bcde

Author: Pavel Labath Date: 2020-10-30T16:54:24+01:00 New Revision: 1d1d916f960e1ab059d4223abf91bea91780a7e9 URL: https://github.com/llvm/llvm-project/commit/1d1d916f960e1ab059d4223abf91bea91780a7e9 DIFF: https://github.com/llvm/llvm-project/commit/1d1d916f960e1ab059d4223abf91bea91780a7e9.diff

[Lldb-commits] [lldb] a136699 - [nfc] [lldb] Align `user_id_t` format to the current `DIERef` format

Author: Jan Kratochvil Date: 2020-10-30T16:50:52+01:00 New Revision: a136699b2a989631f4fd84aa099fc1e731b493c2 URL: https://github.com/llvm/llvm-project/commit/a136699b2a989631f4fd84aa099fc1e731b493c2 DIFF: https://github.com/llvm/llvm-project/commit/a136699b2a989631f4fd84aa099fc1e731b493c2.diff

[Lldb-commits] [PATCH] D90413: [nfc] [lldb] Align `user_id_t` format to the current `DIERef` format

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa136699b2a98: [nfc] [lldb] Align `user_id_t` format to the current `DIERef` format (authored by jankratochvil). Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D90325: [lldb][NFC] Refactor getUUID functionality

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm, modulo the comment. Comment at: lldb/source/Plugins/Process/minidump/MinidumpParser.cpp:75 } -if (pdb70_uuid->Age != 0) - return UUID::fromOptionalData(pd

[Lldb-commits] [PATCH] D90464: [nfc] [lldb] Refactor out DWARFUnit::ContainsDIERef

jankratochvil created this revision. jankratochvil added reviewers: labath, JDevlieghere. jankratochvil added a project: LLDB. jankratochvil requested review of this revision. There is just a difference of comparing `DIERef::die_offset()` with originally `GetOffset()` while now with `GetFirstDIEO

[Lldb-commits] [PATCH] D90454: [lldb] [Host/{free, net}bsd] Fix process matching by name

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ok, so it will be tested once the remaining issue is fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90454/new/ https://reviews.llvm.org/D90454 _

[Lldb-commits] [PATCH] D90413: [nfc] [lldb] Align `user_id_t` format to the current `DIERef` format

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds good. I like how this makes the user ids small for the common case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90413/new/ https://revi

[Lldb-commits] [PATCH] D90454: [lldb] [Host/{free, net}bsd] Fix process matching by name

mgorny added a comment. In D90454#2364322 , @labath wrote: > There's a test that this fixes, right? The attaching tests still fail for me, I'm trying to investigate why. However, it does fix `process attach -n ...` in LLDB session. CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

labath added a comment. It looks like the test has found an actual bug in handling of the dwo format. 8485ee781f fixes that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483

[Lldb-commits] [lldb] 8485ee7 - [lldb/DWARF] Fix dwo flavour of TestTypeGetModule

Author: Pavel Labath Date: 2020-10-30T15:20:27+01:00 New Revision: 8485ee781fcfcc2e8335093ece985d8366d3906b URL: https://github.com/llvm/llvm-project/commit/8485ee781fcfcc2e8335093ece985d8366d3906b DIFF: https://github.com/llvm/llvm-project/commit/8485ee781fcfcc2e8335093ece985d8366d3906b.diff

[Lldb-commits] [PATCH] D90454: [lldb] [Host/{free, net}bsd] Fix process matching by name

emaste added a comment. There is TestProcessAttach.py that has an @expectedFailureNetBSD but no FreeBSD annotation, as well as TestCompletion.py, but I don't see these in the failing list. `process attach -n foo` does fail for me on FreeBSD CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] 62286c5 - [lldb/test] Remove a double debugserver launch in TestGdbRemoteGPacket

Author: Pavel Labath Date: 2020-10-30T14:27:50+01:00 New Revision: 62286c569d84c81236522c386a67e60f8f333f63 URL: https://github.com/llvm/llvm-project/commit/62286c569d84c81236522c386a67e60f8f333f63 DIFF: https://github.com/llvm/llvm-project/commit/62286c569d84c81236522c386a67e60f8f333f63.diff

[Lldb-commits] [lldb] a895a44 - [lldb/test] Simplify/generalize YAMLModuleTester

Author: Pavel Labath Date: 2020-10-30T14:27:50+01:00 New Revision: a895a446bcde4d78572ced8ff0b559f476aa4274 URL: https://github.com/llvm/llvm-project/commit/a895a446bcde4d78572ced8ff0b559f476aa4274 DIFF: https://github.com/llvm/llvm-project/commit/a895a446bcde4d78572ced8ff0b559f476aa4274.diff

[Lldb-commits] [PATCH] D90393: [lldb/test] Simplify/generalize YAMLModuleTester

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa895a446bcde: [lldb/test] Simplify/generalize YAMLModuleTester (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D90454: [lldb] [Host/{free, net}bsd] Fix process matching by name

labath added a comment. There's a test that this fixes, right? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90454/new/ https://reviews.llvm.org/D90454 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D90454: [lldb] [Host/{free, net}bsd] Fix process matching by name

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. mgorny requested review of this revision. Fix process matching by name to make 'process attach -n ...' work. The process finding code has an optimization that defers getting