[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 300864. wallace marked 2 inline comments as done. wallace added a comment. Address issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89283/new/ https://reviews.llvm.org/D89283 Files: lldb/include/lldb/Core/Disassembler.h lldb/include/lldb/S

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace marked 7 inline comments as done. wallace added a comment. > That makes me sad, but I am not going to hold this patch over that. I would > encourage you to find and implement the missing bits in yaml2obj though... I'll do that later as a way to learn yaml2obj. Comment

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu added a comment. In D89812#2354862 , @stella.stamenova wrote: > load-pdb is still failing on the Windows bot. Can you please commit a fix > soon or revert the change? It's slash vs back slash thing. Put a fix at https://reviews.llvm.org/rG779d

[Lldb-commits] [lldb] 779deb9 - [lldb][NativePDB] fix test load-pdb.cpp

Author: Zequan Wu Date: 2020-10-26T17:12:51-07:00 New Revision: 779deb9750a4853485ac7beca86f518b067ad6d6 URL: https://github.com/llvm/llvm-project/commit/779deb9750a4853485ac7beca86f518b067ad6d6 DIFF: https://github.com/llvm/llvm-project/commit/779deb9750a4853485ac7beca86f518b067ad6d6.diff LOG

[Lldb-commits] [PATCH] D90102: [lldb] [Process/FreeBSDRemote] Enable watchpoint support

mgorny updated this revision to Diff 300806. mgorny added a comment. Included a fix to respect `LLDB_REMOTE_PLUGIN` in API tests, and reenabled more tests. FWICS these tests also pass with the old plugin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90102/new/ https://reviews.llvm.org

[Lldb-commits] [lldb] 7611c5b - [nfc] [lldb] Refactor DWARFUnit::GetDIE

Author: Jan Kratochvil Date: 2020-10-26T23:18:19+01:00 New Revision: 7611c5bb42a96c13d0e53ade546633bf9ed56f0c URL: https://github.com/llvm/llvm-project/commit/7611c5bb42a96c13d0e53ade546633bf9ed56f0c DIFF: https://github.com/llvm/llvm-project/commit/7611c5bb42a96c13d0e53ade546633bf9ed56f0c.diff

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

JDevlieghere updated this revision to Diff 300803. JDevlieghere added a comment. Herald added a subscriber: dang. Briefly discussed this with Pavel on IRC. The latest revision implements what I think you suggested: - Make the new logic conditional on a new flag (`-c`). - Add the "command search

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu added a comment. In D89812#2354862 , @stella.stamenova wrote: > load-pdb is still failing on the Windows bot. Can you please commit a fix > soon or revert the change? Okay, I'm looking at it now Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

stella.stamenova added a comment. load-pdb is still failing on the Windows bot. Can you please commit a fix soon or revert the change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89812/new/ https://reviews.llvm.org/D89812 __

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Just remove the braces as suggested in inline comments. Pavel? Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:503-505 + if (section_list) { +In

[Lldb-commits] [PATCH] D90081: Test lldb backtraces with machine function splitter

This revision was automatically updated to reflect the committed changes. Closed by commit rG9aa7a721ce3d: Test to check backtraces with machine function splitting. (authored by tmsriram). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 9aa7a72 - Test to check backtraces with machine function splitting.

Author: Sriraman Tallam Date: 2020-10-26T14:08:42-07:00 New Revision: 9aa7a721ce3dc84d0ad2d987af72cf14ff76d8a7 URL: https://github.com/llvm/llvm-project/commit/9aa7a721ce3dc84d0ad2d987af72cf14ff76d8a7 DIFF: https://github.com/llvm/llvm-project/commit/9aa7a721ce3dc84d0ad2d987af72cf14ff76d8a7.dif

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu added a comment. In D89812#2354320 , @jankratochvil wrote: > It has regressed buildbots: > > SymbolFile/NativePDB/load-pdb.cpp > lldb-x86_64-fedora: http://lab.llvm.org:8014/#/builders/14/builds/1006 > lldb-x86_64-debian: http://lab.llvm.or

[Lldb-commits] [lldb] 4b83747 - [lldb][NativePDB] fix test load-pdb.cpp

Author: Zequan Wu Date: 2020-10-26T11:38:12-07:00 New Revision: 4b83747ab1577b7899116b0ddb75f05de2471694 URL: https://github.com/llvm/llvm-project/commit/4b83747ab1577b7899116b0ddb75f05de2471694 DIFF: https://github.com/llvm/llvm-project/commit/4b83747ab1577b7899116b0ddb75f05de2471694.diff LOG

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

jankratochvil added a comment. It has regressed buildbots: SymbolFile/NativePDB/load-pdb.cpp lldb-x86_64-fedora: http://lab.llvm.org:8014/#/builders/14/builds/1006 lldb-x86_64-debian: http://lab.llvm.org:8011/#/builders/68/builds/782 Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D90102: [lldb] [Process/FreeBSDRemote] Enable watchpoint support

mgorny updated this revision to Diff 300741. mgorny edited the summary of this revision. mgorny added a comment. Ok, should be fixed now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90102/new/ https://reviews.llvm.org/D90102 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativePr

[Lldb-commits] [PATCH] D90034: [lldb] [Process/NetBSD] Use XStateRegSet for all FPU registers

labath added a comment. In D90034#2353873 , @mgorny wrote: > I wonder if 'register sets' shouldn't become shared LLVM concept rather than > per-plugin. I'm totally down with that. In fact there's been some movement on that front recently, with the intro

[Lldb-commits] [lldb] 242e1e9 - [lldb][PDB] Add ObjectFile PDB plugin

Author: Zequan Wu Date: 2020-10-26T10:28:48-07:00 New Revision: 242e1e9910441ad00118e580e4cbd5743c77ea5e URL: https://github.com/llvm/llvm-project/commit/242e1e9910441ad00118e580e4cbd5743c77ea5e DIFF: https://github.com/llvm/llvm-project/commit/242e1e9910441ad00118e580e4cbd5743c77ea5e.diff LOG

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG242e1e991044: [lldb][PDB] Add ObjectFile PDB plugin (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu updated this revision to Diff 300720. zequanwu marked 4 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89812/new/ https://reviews.llvm.org/D89812 Files: lldb/source/Plu

[Lldb-commits] [PATCH] D90034: [lldb] [Process/NetBSD] Use XStateRegSet for all FPU registers

mgorny added a comment. I wonder if 'register sets' shouldn't become shared LLVM concept rather than per-plugin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90034/new/ https://reviews.llvm.org/D90034

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

labath added a comment. In D89334#2344765 , @JDevlieghere wrote: > For paths relative to the CWD we add both already: > > 1. We add "." to the sys path once: > https://github.com/llvm/llvm-project/blob/5d796645d6c8cadeb003715c33e231a8ba05b6de/lldb/source

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

labath added a comment. I'm not sure if I'll have time to go through this again, but it seems ok. One question inline, though. In D89283#2348815 , @wallace wrote: > The diff is the now ready for review. There are a few updates, including some > design d

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

labath added a comment. Right -- I can understand that. I'm not sure whether this is a real issue -- I'd expect that these compiler-internal symbols would normally have private (not "internal") linkage (and hence be caught by line 330) -- but I'm not insisting on exposing all of the internal li

[Lldb-commits] [PATCH] D90034: [lldb] [Process/NetBSD] Use XStateRegSet for all FPU registers

labath added a comment. I'm not sure I agree with that. Given the ever-growing number of registers (which are likely going to all end up in the "xstate" block), I think it is important to be able to add some structure to the list of registers. Also, having the ability to group registers which c

[Lldb-commits] [PATCH] D90114: [lldb] [test/Register] Use initial state for write tests

mgorny added a comment. I've discovered this by accident when I was figuring why fp-write tests started failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90114/new/ https://reviews.llvm.org/D90114

[Lldb-commits] [lldb] 206e8d8 - Fix SBError::SetErrorToGenericError

Author: Andy Yankovsky Date: 2020-10-26T15:44:38+01:00 New Revision: 206e8d8905035f6e9049b97c9cd8af0eaa5aa118 URL: https://github.com/llvm/llvm-project/commit/206e8d8905035f6e9049b97c9cd8af0eaa5aa118 DIFF: https://github.com/llvm/llvm-project/commit/206e8d8905035f6e9049b97c9cd8af0eaa5aa118.diff

[Lldb-commits] [PATCH] D90151: Fix SBError::SetErrorToGenericError

This revision was automatically updated to reflect the committed changes. Closed by commit rG206e8d890503: Fix SBError::SetErrorToGenericError (authored by werat, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90151/new/ http

[Lldb-commits] [PATCH] D90114: [lldb] [test/Register] Use initial state for write tests

labath added a comment. Herald added a subscriber: JDevlieghere. In D90114#2353155 , @mgorny wrote: > Well, NetBSD passes whatever value is in the XSAVE Area, and (according to > the Intel manual) XSAVE indicates whether the values match the defaults. It

[Lldb-commits] [lldb] d0ee1d8 - [lldb][NFC] Make GetShellSafeArgument simpler and faster

Author: Raphael Isemann Date: 2020-10-26T15:29:13+01:00 New Revision: d0ee1d8efe804b3184b1073cd367a307867f1372 URL: https://github.com/llvm/llvm-project/commit/d0ee1d8efe804b3184b1073cd367a307867f1372 DIFF: https://github.com/llvm/llvm-project/commit/d0ee1d8efe804b3184b1073cd367a307867f1372.dif

[Lldb-commits] [PATCH] D90151: Fix SBError::SetErrorToGenericError

werat added a comment. Thanks! Yeah, I don't have commit access, thanks for landing it for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90151/new/ https://reviews.llvm.org/D90151 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D90151: Fix SBError::SetErrorToGenericError

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks! I assume you don't have commit access, so I'll land this for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90151/new/ https://reviews.llvm.org/D90151 _

[Lldb-commits] [PATCH] D90151: Fix SBError::SetErrorToGenericError

werat updated this revision to Diff 300652. werat added a comment. Add a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90151/new/ https://reviews.llvm.org/D90151 Files: lldb/source/API/SBError.cpp lldb/test/API/python_api/sberror/TestSBError.py Index: lldb/test/API/pyt

[Lldb-commits] [PATCH] D90151: Fix SBError::SetErrorToGenericError

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Could you add a test for this? This should be enough: diff --git a/lldb/test/API/python_api/sberror/TestSBError.py b/lldb/test/API/python_api/sberror/TestSBError.py new fil

[Lldb-commits] [PATCH] D90151: Fix SBError::SetErrorToGenericError

werat created this revision. werat added a reviewer: JDevlieghere. werat added a project: LLDB. Herald added a subscriber: lldb-commits. werat requested review of this revision. `SBError::SetErrorToGenericError` should call `Status::SetErrorToGenericError`, not `Status::SetErrorToErrno`. Reposi

[Lldb-commits] [lldb] 97ca9ca - [lldb] Fix bitfield "frame var" for pointers (pr47743)

Author: Pavel Labath Date: 2020-10-26T12:01:20+01:00 New Revision: 97ca9ca180f0810adcc1637d1a6dd32a04f63cfe URL: https://github.com/llvm/llvm-project/commit/97ca9ca180f0810adcc1637d1a6dd32a04f63cfe DIFF: https://github.com/llvm/llvm-project/commit/97ca9ca180f0810adcc1637d1a6dd32a04f63cfe.diff

[Lldb-commits] [lldb] e4cc6e9 - [lldb] Modernize PseudoTerminal::Fork

Author: Pavel Labath Date: 2020-10-26T12:01:20+01:00 New Revision: e4cc6e9bcdff5fe979ab72025cb803d723cd9c31 URL: https://github.com/llvm/llvm-project/commit/e4cc6e9bcdff5fe979ab72025cb803d723cd9c31 DIFF: https://github.com/llvm/llvm-project/commit/e4cc6e9bcdff5fe979ab72025cb803d723cd9c31.diff

[Lldb-commits] [PATCH] D89236: [lldb] Fix bitfield "frame var" for pointers (pr47743)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97ca9ca180f0: [lldb] Fix bitfield "frame var" for pointers (pr47743) (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D90119: [lldb] [Process/Linux] Reuse NativeRegisterContextWatchpoint_x86

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5ca27569eac: [lldb] [Process/Linux] Reuse NativeRegisterContextWatchpoint_x86 (authored by mgorny). Herald added a subscriber: jrtc27. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D90114: [lldb] [test/Register] Use initial state for write tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG37d4d3bb4daf: [lldb] [test/Register] Use initial state for write tests (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D90128: [lldb] [Process/FreeBSDRemote] Fix #include for i386 compat

This revision was automatically updated to reflect the committed changes. Closed by commit rG7acf2e2e1e8f: [lldb] [Process/FreeBSDRemote] Fix #include for i386 compat (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [lldb] 7acf2e2 - [lldb] [Process/FreeBSDRemote] Fix #include for i386 compat

Author: Michał Górny Date: 2020-10-26T11:53:26+01:00 New Revision: 7acf2e2e1e8f7e2eac2dd5bbf7d752ba7ad4e79c URL: https://github.com/llvm/llvm-project/commit/7acf2e2e1e8f7e2eac2dd5bbf7d752ba7ad4e79c DIFF: https://github.com/llvm/llvm-project/commit/7acf2e2e1e8f7e2eac2dd5bbf7d752ba7ad4e79c.diff

[Lldb-commits] [lldb] f5ca275 - [lldb] [Process/Linux] Reuse NativeRegisterContextWatchpoint_x86

Author: Michał Górny Date: 2020-10-26T11:55:22+01:00 New Revision: f5ca27569eacc398f0e4fc63a9b55cafac398c04 URL: https://github.com/llvm/llvm-project/commit/f5ca27569eacc398f0e4fc63a9b55cafac398c04 DIFF: https://github.com/llvm/llvm-project/commit/f5ca27569eacc398f0e4fc63a9b55cafac398c04.diff

[Lldb-commits] [lldb] 37d4d3b - [lldb] [test/Register] Use initial state for write tests

Author: Michał Górny Date: 2020-10-26T11:54:00+01:00 New Revision: 37d4d3bb4daf409102237132ae8e1db250da83be URL: https://github.com/llvm/llvm-project/commit/37d4d3bb4daf409102237132ae8e1db250da83be DIFF: https://github.com/llvm/llvm-project/commit/37d4d3bb4daf409102237132ae8e1db250da83be.diff

[Lldb-commits] [PATCH] D90105: [lldb] [Process/NetBSD] Set xs_xstate_bv correctly when setting regs

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8902376651a: [lldb] [Process/NetBSD] Set xs_xstate_bv correctly when setting regs (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [lldb] a890237 - [lldb] [Process/NetBSD] Set xs_xstate_bv correctly when setting regs

Author: Michał Górny Date: 2020-10-26T11:54:40+01:00 New Revision: a8902376651a7adbacd0c1934d9f70bdb9fad7f0 URL: https://github.com/llvm/llvm-project/commit/a8902376651a7adbacd0c1934d9f70bdb9fad7f0 DIFF: https://github.com/llvm/llvm-project/commit/a8902376651a7adbacd0c1934d9f70bdb9fad7f0.diff

[Lldb-commits] [PATCH] D90114: [lldb] [test/Register] Use initial state for write tests

mgorny added a comment. Well, NetBSD passes whatever value is in the XSAVE Area, and (according to the Intel manual) XSAVE indicates whether the values match the defaults. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90114/new/ https://reviews.llvm.org/D90114

[Lldb-commits] [PATCH] D90034: [lldb] [Process/NetBSD] Use XStateRegSet for all FPU registers

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:994-995 !(m_xstate.xs_rfbm & XCR0_YMM_Hi128)) { - error.SetErrorStringWithFormat("register \"%s\" not supported by CPU/kernel", -

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm Comment at: lldb/source/Plugins/ObjectFile/PDB/CMakeLists.txt:6 +lldbCore +lldbHost +lldbSymbol I don't see this using any Host functionalit

[Lldb-commits] [PATCH] D89236: [lldb] Fix bitfield "frame var" for pointers (pr47743)

teemperor accepted this revision. teemperor added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89236/new/ https://reviews.llvm.org/D89236 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D90119: [lldb] [Process/Linux] Reuse NativeRegisterContextWatchpoint_x86

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. We arm bots, at least. Other arches will have to fix any build issues post commit ("if you like it, then you shoulda put a bot on it") CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90

[Lldb-commits] [PATCH] D90105: [lldb] [Process/NetBSD] Set xs_xstate_bv correctly when setting regs

labath accepted this revision. labath added a comment. Linux has this factored into a separate function (UpdateXSTATEforWrite), but this isn't too bad either. Could be another candidate for factoring... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90105/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D90114: [lldb] [test/Register] Use initial state for write tests

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I am somewhat surprised that this is sufficient. IIRC (from the time when I was fixing the same bug on linux) linux will set this bit on ANY modification of these registers, regardless of the

[Lldb-commits] [PATCH] D90034: [lldb] [Process/NetBSD] Use XStateRegSet for all FPU registers

labath added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:994-995 !(m_xstate.xs_rfbm & XCR0_YMM_Hi128)) { - error.SetErrorStringWithFormat("register \"%s\" not suppor

[Lldb-commits] [PATCH] D90102: [lldb] [Process/FreeBSDRemote] Enable watchpoint support

mgorny planned changes to this revision. mgorny added a comment. This patch breaks multithreaded register tests, so I need to look into threading more. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90102/new/ https://reviews.llvm.org/D90102

[Lldb-commits] [PATCH] D89236: [lldb] Fix bitfield "frame var" for pointers (pr47743)

labath added a comment. @shafik, @teemperor, any thoughts on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89236/new/ https://reviews.llvm.org/D89236 ___ lldb-commits mailing list lldb-commits@list