[Lldb-commits] [PATCH] D87345: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Fix references to LLDB_ENABLE_TESTS. Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

JDevlieghere added a comment. In D87333#2262260 , @rupprecht wrote: > In D87333#2262241 , @clayborg wrote: > >> In D87333#2262236 , @rupprecht >> wrote: >> >>> In D87333#226

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

clayborg accepted this revision. clayborg added a comment. This looks good to me. We will need to wait until the JSON changes from https://reviews.llvm.org/D87335 to make it in though in case there are any modifications to that patch. Walter will put up the RFC for trace plug-ins and if that di

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht added a comment. In D87333#2262241 , @clayborg wrote: > In D87333#2262236 , @rupprecht wrote: > >> In D87333#2262229 , @clayborg wrote: >> >>> FYI: we switched away

[Lldb-commits] [PATCH] D86670: [intel-pt] Add a basic implementation of the dump command

wallace updated this revision to Diff 290607. wallace added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86670/new/ https://reviews.llvm.org/D86670 Files: lldb/include/lldb/Target/Target.h lldb/include/lldb/Target/Trace.h

[Lldb-commits] [PATCH] D86670: [intel-pt] Add a basic implementation of the dump command

wallace updated this revision to Diff 290605. wallace added a comment. Addresses Greg's comments. As a side note, I'll work on a RFC for the LLDB mailing list to get feedback on the overall design of the feature, as @labath suggested. However, Greg and I want to get these patches in, as we need

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

clayborg added a comment. In D87333#2262236 , @rupprecht wrote: > In D87333#2262229 , @clayborg wrote: > >> FYI: we switched away from "localhost" a long time ago due to issues with >> people having a "localhost" e

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht added a comment. In D87333#2262229 , @clayborg wrote: > FYI: we switched away from "localhost" a long time ago due to issues with > people having a "localhost" entry in their /etc/hosts folder. I assume you mean people *not* having a "localhost

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

wallace updated this revision to Diff 290603. wallace added a comment. - Moved the JSON changes to another diff. - Addressed all the comments so far. As a side note, I'll work on a RFC for the LLDB mailing list to get feedback on the overall design of the feature, as @labath suggested. However,

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

clayborg added a comment. FYI: we switched away from "localhost" a long time ago due to issues with people having a "localhost" entry in their /etc/hosts folder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87333/new/ https://reviews.llvm.org/D87

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

JDevlieghere updated this revision to Diff 290596. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86996/new/ https://reviews.llvm.org/D86996 Files: lldb/source/Commands/CommandObjectScript.cpp lldb/source/Commands/CommandObjectScript.h lldb/source/Commands/Options.td lldb/test/She

[Lldb-commits] [PATCH] D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment.

rupprecht created this revision. rupprecht added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Herald added a subscriber: JDevlieghere. When running in an ipv6-only environment where `AF_INET` socket

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

kastiglione updated this revision to Diff 290581. kastiglione added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87327/new/ https://reviews.llvm.org/D87327 Files: lldb/tools/debugserver/source/debugserver.cpp Index: lld

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

kastiglione added a comment. Follow up to 8aeb212887024a615ca02437cd12fa055bd54b6f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87327/new/ https://reviews.llvm.org/D87327

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

kastiglione created this revision. kastiglione added reviewers: jasonmolenda, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Extract a function for turning `eLaunchFlavorDefau

[Lldb-commits] [lldb] 5c463d1 - Revert "Retry of D84974"

Author: Walter Erquinigo Date: 2020-09-08T13:41:11-07:00 New Revision: 5c463d107d3c26fc5573f31b838a8a3a1e4b5065 URL: https://github.com/llvm/llvm-project/commit/5c463d107d3c26fc5573f31b838a8a3a1e4b5065 DIFF: https://github.com/llvm/llvm-project/commit/5c463d107d3c26fc5573f31b838a8a3a1e4b5065.di

[Lldb-commits] [lldb] 5b2b4f3 - Retry of D84974

Author: Walter Erquinigo Date: 2020-09-08T11:50:09-07:00 New Revision: 5b2b4f331d78f326e5e29166bec5ad92c864343d URL: https://github.com/llvm/llvm-project/commit/5b2b4f331d78f326e5e29166bec5ad92c864343d DIFF: https://github.com/llvm/llvm-project/commit/5b2b4f331d78f326e5e29166bec5ad92c864343d.di

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Sounds reasonable to me. I'll split it up in two patches. I'll update this one to use the double dashes so we can land the functionality and keep things consistent with the rest of LLDB. I'll create another patch to do

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

krytarowski added a comment. Please note that ncurses is not the only supported curses library. NetBSD uses its original BSD curses for LLVM projects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85820/new/ https://reviews.llvm.org/D85820 __