[Lldb-commits] [PATCH] D86402: Avoid creating lldb-python-scripts target more than once

2020-08-22 Thread António Afonso via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG52381938bcc8: Create ${swig_target}-scripts target instead of lldb-python-scripts (authored by aadsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86402/ne

[Lldb-commits] [lldb] 5238193 - Create ${swig_target}-scripts target instead of lldb-python-scripts

2020-08-22 Thread António Afonso via lldb-commits
Author: António Afonso Date: 2020-08-22T19:36:37-07:00 New Revision: 52381938bcc8547316d79a4721281da7f934d9b8 URL: https://github.com/llvm/llvm-project/commit/52381938bcc8547316d79a4721281da7f934d9b8 DIFF: https://github.com/llvm/llvm-project/commit/52381938bcc8547316d79a4721281da7f934d9b8.diff

[Lldb-commits] [PATCH] D86402: Avoid creating lldb-python-scripts target more than once

2020-08-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86402/new/ https://reviews.llvm.org/D86402 __

[Lldb-commits] [PATCH] D86402: Avoid creating lldb-python-scripts target more than once

2020-08-22 Thread António Afonso via Phabricator via lldb-commits
aadsm updated this revision to Diff 287211. aadsm added a comment. Update to create 2 separate install targets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86402/new/ https://reviews.llvm.org/D86402 Files: lldb/CMakeLists.txt lldb/bindings/py

[Lldb-commits] [PATCH] D86402: Avoid creating lldb-python-scripts target more than once

2020-08-22 Thread António Afonso via Phabricator via lldb-commits
aadsm added a comment. Sounds good, will update. In my mind it would be easier to just install all configured python scripts by specifying a single distribution component. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86402/new/ https://reviews.ll

[Lldb-commits] [lldb] 5d8eede - Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

2020-08-22 Thread António Afonso via lldb-commits
Author: António Afonso Date: 2020-08-22T10:43:50-07:00 New Revision: 5d8eedee917de2d39d1c485d07a30f8649bc6866 URL: https://github.com/llvm/llvm-project/commit/5d8eedee917de2d39d1c485d07a30f8649bc6866 DIFF: https://github.com/llvm/llvm-project/commit/5d8eedee917de2d39d1c485d07a30f8649bc6866.diff

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

2020-08-22 Thread António Afonso via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d8eedee917d: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it (authored by aadsm). Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D86402: Avoid creating lldb-python-scripts target more than once

2020-08-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. The target should be created for everyone calling the `finish_swig_python` function. Let's say (not so) hypothetically I want to create bindings for Python 2 and Python 3

[Lldb-commits] [PATCH] D86402: Avoid creating lldb-python-scripts target more than once

2020-08-22 Thread António Afonso via Phabricator via lldb-commits
aadsm created this revision. aadsm added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. aadsm requested review of this revision. This addresses the issue raised here https://reviews.llvm.org/rG02bf5632a94da6c3570df002804f8d3f79c11bfc The `f

[Lldb-commits] [PATCH] D86292: [LLDB][RISCV] Distinguish between riscv32 and riscv64 based on ELF class

2020-08-22 Thread Greg Clayton via Phabricator via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Patch looks good. Just need to test 32 bit RISC as well with a "lldb/test/Shell/ObjectFile/ELF/riscv32-arch.yaml" to verify 32 bit is working. Comment at: lldb

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-08-22 Thread Mateusz Mikuła via Phabricator via lldb-commits
mati865 added a comment. @phosek in MSYS2 (targeting x86_64-w64-windows-gnu) Zlib works properly for LLVM 10 but with master I'm now seeing: -- Constructing LLVMBuild project information -- DEBUG zlib_library=D:/msys64/mingw64/lib/libz.dll.a CMake Error at lib/Support/CMakeLists.txt:9 (str

[Lldb-commits] [PATCH] D86292: [LLDB][RISCV] Distinguish between riscv32 and riscv64 based on ELF class

2020-08-22 Thread Luís Marques via Phabricator via lldb-commits
luismarques updated this revision to Diff 286994. luismarques added a comment. Add riscv32 test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86292/new/ https://reviews.llvm.org/D86292 Files: lldb/include/lldb/Utility/ArchSpec.h lldb/source/P

[Lldb-commits] [lldb] bb894b9 - [lldb] Extract reproducer providers & co into their own header.

2020-08-22 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-08-22T10:04:27-07:00 New Revision: bb894b97821a1c970ce0c3243aaebbfa94add15c URL: https://github.com/llvm/llvm-project/commit/bb894b97821a1c970ce0c3243aaebbfa94add15c DIFF: https://github.com/llvm/llvm-project/commit/bb894b97821a1c970ce0c3243aaebbfa94add15c.d

[Lldb-commits] [lldb] 1ce07cd - Instantiate Error in Target::GetEntryPointAddress() only when necessary

2020-08-22 Thread Dimitry Andric via lldb-commits
Author: Dimitry Andric Date: 2020-08-22T12:47:13+02:00 New Revision: 1ce07cd614beab5150a5440c7faf195009f99e2c URL: https://github.com/llvm/llvm-project/commit/1ce07cd614beab5150a5440c7faf195009f99e2c DIFF: https://github.com/llvm/llvm-project/commit/1ce07cd614beab5150a5440c7faf195009f99e2c.diff

[Lldb-commits] [PATCH] D86355: Instantiate Error in Target::GetEntryPointAddress() only when necessary

2020-08-22 Thread Dimitry Andric via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ce07cd614be: Instantiate Error in Target::GetEntryPointAddress() only when necessary (authored by dim). Repository: rG LLVM Github Monorepo CHAN