Author: Jonas Devlieghere
Date: 2020-08-20T22:59:13-07:00
New Revision: 6ad3de350c462399a02adccab7fc70de8ecd6224
URL:
https://github.com/llvm/llvm-project/commit/6ad3de350c462399a02adccab7fc70de8ecd6224
DIFF:
https://github.com/llvm/llvm-project/commit/6ad3de350c462399a02adccab7fc70de8ecd6224.d
Author: Jonas Devlieghere
Date: 2020-08-20T22:41:49-07:00
New Revision: e0b220d22eed75b2a2a783ac45b832e961e77a9e
URL:
https://github.com/llvm/llvm-project/commit/e0b220d22eed75b2a2a783ac45b832e961e77a9e
DIFF:
https://github.com/llvm/llvm-project/commit/e0b220d22eed75b2a2a783ac45b832e961e77a9e.d
Author: Jonas Devlieghere
Date: 2020-08-20T22:35:31-07:00
New Revision: c1bc4fb95e37ade1256da8ea8db1030ae84705bd
URL:
https://github.com/llvm/llvm-project/commit/c1bc4fb95e37ade1256da8ea8db1030ae84705bd
DIFF:
https://github.com/llvm/llvm-project/commit/c1bc4fb95e37ade1256da8ea8db1030ae84705bd.d
Higuoxing reopened this revision.
Higuoxing added a comment.
This revision is now accepted and ready to land.
This change is causing build failure, I'm going to revise this change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83116/new/
https://re
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf7ff0ace96db: [DWARFYAML] Add support for referencing
different abbrev tables. (authored by Higuoxing).
Repository:
rG LLVM Github Monorepo
CHANG
Higuoxing updated this revision to Diff 286945.
Higuoxing added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83116/new/
https://reviews.llvm.org/D83116
Files:
llvm/include/llvm/ObjectYAML/DWARFYAML.h
llvm/lib/ObjectYAML/DWA
Author: Jonas Devlieghere
Date: 2020-08-20T18:08:59-07:00
New Revision: c90ca0c8e4956e051e2f29cff0c38f9f03b32f87
URL:
https://github.com/llvm/llvm-project/commit/c90ca0c8e4956e051e2f29cff0c38f9f03b32f87
DIFF:
https://github.com/llvm/llvm-project/commit/c90ca0c8e4956e051e2f29cff0c38f9f03b32f87.d
Author: Jonas Devlieghere
Date: 2020-08-20T18:08:59-07:00
New Revision: 73af341beb8435c7da1dd5e7a8abacb2de6a236d
URL:
https://github.com/llvm/llvm-project/commit/73af341beb8435c7da1dd5e7a8abacb2de6a236d
DIFF:
https://github.com/llvm/llvm-project/commit/73af341beb8435c7da1dd5e7a8abacb2de6a236d.d
Hello Jonas, Harmen,
This commit broke one of our builders:
http://lab.llvm.org:8011/builders/lld-perf-testsuite/builds/30809
. . .
FAILED: bin/llvm-tblgen
: && /usr/bin/c++ -fvisibility-inlines-hidden -Werror=date-time
-Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter
-Wwri
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4e266eaf132f: Make DWARFExpression::GetLocationExpression
public (authored by Eric, committed by dschuff).
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Repository:
rG LLVM Gith
Author: Eric Leese
Date: 2020-08-20T15:12:28-07:00
New Revision: 4e266eaf132fa7e16eb6593dcfe4f4b9f55ea092
URL:
https://github.com/llvm/llvm-project/commit/4e266eaf132fa7e16eb6593dcfe4f4b9f55ea092
DIFF:
https://github.com/llvm/llvm-project/commit/4e266eaf132fa7e16eb6593dcfe4f4b9f55ea092.diff
LO
Author: Jonas Devlieghere
Date: 2020-08-20T15:10:38-07:00
New Revision: ed17b6f6308f81273919532d422e3858d9a7c1da
URL:
https://github.com/llvm/llvm-project/commit/ed17b6f6308f81273919532d422e3858d9a7c1da
DIFF:
https://github.com/llvm/llvm-project/commit/ed17b6f6308f81273919532d422e3858d9a7c1da.d
clayborg added a comment.
Hopefully this should be good to go, let me know if anyone has any issues.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86261/new/
https://reviews.llvm.org/D86261
___
lldb-comm
clayborg updated this revision to Diff 286901.
clayborg added a comment.
Fixed:
- Use a safer method to read the data we need for the .text section in case we
need and extra 15 bytes.
- Rephrase confusing comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://review
clayborg added inline comments.
Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:174
+ // end of the .text section if the .text section is less than a page size in
+ // length.
+ const uint8_t *ptr = text_data.GetDataStart();
clayborg wrote
clayborg added inline comments.
Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:174
+ // end of the .text section if the .text section is less than a page size in
+ // length.
+ const uint8_t *ptr = text_data.GetDataStart();
I will try and
Author: Jonas Devlieghere
Date: 2020-08-20T14:07:05-07:00
New Revision: 921c1b7df37d6f5353ed5fdffa117dcda0c941ba
URL:
https://github.com/llvm/llvm-project/commit/921c1b7df37d6f5353ed5fdffa117dcda0c941ba
DIFF:
https://github.com/llvm/llvm-project/commit/921c1b7df37d6f5353ed5fdffa117dcda0c941ba.d
wallace commandeered this revision.
wallace edited reviewers, added: aelitashen; removed: wallace.
wallace added a comment.
We found a very strange issue with lldb not stopping at any breakpoint after
attaching. I'll figure that out
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
aelitashen updated this revision to Diff 286885.
aelitashen added a comment.
@Walter Please help me fix the tests. Looks like in the new added runInTerminal
tests, it cannot hit the breakpoint and capture the local variable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
htt
aprantl added a comment.
The code looks fine, I think the test needs an extra REQUIRES.
Comment at: lldb/source/Core/ValueObjectVariable.cpp:137
+ if (m_data.GetDataStart() && m_data.GetByteSize())
+m_value.SetBytes(m_data.GetDataStart(), m_data.GetByteSize());
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG22e63cba17e5: [lldb] tab completion for breakpoint names
(authored by MrHate, committed by teemperor).
Herald added a subs
Author: Gongyu Deng
Date: 2020-08-20T20:56:34+02:00
New Revision: 22e63cba17e5e6266b9251e3fb7032b793143d09
URL:
https://github.com/llvm/llvm-project/commit/22e63cba17e5e6266b9251e3fb7032b793143d09
DIFF:
https://github.com/llvm/llvm-project/commit/22e63cba17e5e6266b9251e3fb7032b793143d09.diff
L
shafik created this revision.
shafik added reviewers: aprantl, friss, labath, jingham, vsk.
shafik requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.
In some cases when we have a `DW_AT_const_value` and the data can be found in
the `DWARFEx
Author: Jordan Rupprecht
Date: 2020-08-20T09:21:33-07:00
New Revision: 0de3d0c61266675cd5e688a09e02124518e01935
URL:
https://github.com/llvm/llvm-project/commit/0de3d0c61266675cd5e688a09e02124518e01935
DIFF:
https://github.com/llvm/llvm-project/commit/0de3d0c61266675cd5e688a09e02124518e01935.di
luismarques created this revision.
luismarques added reviewers: asb, lenary, clayborg, jasonmolenda, simoncook.
Herald added subscribers: lldb-commits, evandro, apazos, sameer.abuasal,
pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,
MartinMosbeck, rogfer01, atanasyan, edw
simoncook updated this revision to Diff 286749.
simoncook added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62732/new/
https://reviews.llvm.org/D62732
Files:
lldb/include/lldb/Utility/ArchSpec.h
lldb/source/Plugins/ABI/CMak
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rG8a8a2dd3165e: [lldb/Utility] Simplify Scalar handling of
float types (authored by labath).
Changed prior to
Author: Pavel Labath
Date: 2020-08-20T16:26:02+02:00
New Revision: 8a8a2dd3165e63b29e725526745427c6434f0654
URL:
https://github.com/llvm/llvm-project/commit/8a8a2dd3165e63b29e725526745427c6434f0654
DIFF:
https://github.com/llvm/llvm-project/commit/8a8a2dd3165e63b29e725526745427c6434f0654.diff
labath marked an inline comment as done.
labath added inline comments.
Comment at: lldb/source/Utility/Scalar.cpp:68
+Scalar::PromotionKey Scalar::GetFloatPromoKey(const llvm::fltSemantics &sem) {
+ static const llvm::fltSemantics *order[] = {&APFloat::IEEEsingle(),
+
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9109311356cc: [lldb] Forcefully complete a type when adding
typedefs (authored by labath).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
Author: Pavel Labath
Date: 2020-08-20T15:19:10+02:00
New Revision: 9109311356cc9e74818dd7450020d9b85d2f8125
URL:
https://github.com/llvm/llvm-project/commit/9109311356cc9e74818dd7450020d9b85d2f8125
DIFF:
https://github.com/llvm/llvm-project/commit/9109311356cc9e74818dd7450020d9b85d2f8125.diff
labath added a subscriber: markmentovai.
labath added a comment.
Also, +@markmentovai, in case he has any thoughts on this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86261/new/
https://reviews.llvm.org/D86261
__
labath added a comment.
This has been a feature we've been missing for a while. Thanks for implementing
it.
Just two quick requests on the implementation.
Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:171-174
+ // This code carefully duplicates how the
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml:658
+
+# NOTABLE: yaml2obj: error: abbrev table index must be less than or equal to
the
Higuoxing added inline comments.
Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:306-313
+ Optional AbbrevTableIndex =
+ DS.getAbbrevTableIndexByID(AbbrevTableID);
+ if (!AbbrevTableIndex)
+return createStringError(errc::invalid_argument,
+
Higuoxing updated this revision to Diff 286780.
Higuoxing marked 11 inline comments as done.
Higuoxing added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83116/new/
https://reviews.llvm.org/D83116
Files:
llvm/includ
jhenderson added a comment.
I'm not sure if my test comments have been looked at. Could you mark them as
Done if you think you have addressed them, please?
Comment at: llvm/include/llvm/ObjectYAML/DWARFYAML.h:234-237
+ Expected getAbbrevTableIndexByID(uint64_t ID);
+
+private
Higuoxing added inline comments.
Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_abbrev.yaml:426
#CHECK: Form:DW_FORM_ref4
+
+
I will remove this blank line later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
Higuoxing added inline comments.
Comment at: llvm/include/llvm/ObjectYAML/DWARFEmitter.h:34
+private:
+ Data &DWARF;
+ std::map AbbrevID2Index;
jhenderson wrote:
> Higuoxing wrote:
> > labath wrote:
> > > jhenderson wrote:
> > > > Would it make any sense to mer
Higuoxing updated this revision to Diff 286755.
Higuoxing marked 10 inline comments as done.
Higuoxing added a comment.
Merge `DWARFYAML::Data` and `DWARFYAML::DWARFState`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83116/new/
https://reviews.ll
jhenderson added inline comments.
Comment at: llvm/include/llvm/ObjectYAML/DWARFEmitter.h:34
+private:
+ Data &DWARF;
+ std::map AbbrevID2Index;
Higuoxing wrote:
> labath wrote:
> > jhenderson wrote:
> > > Would it make any sense to merge the `DWARFYAML::Data`
wallace accepted this revision.
wallace added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:559-560
if (!match) {
+ // Breakpad might put a hash of the up to the first page
jhenderson resigned from this revision.
jhenderson added a comment.
I'm not an LLDB developer, so probably not the right person to review this,
sorry.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86261/new/
https://reviews.llvm.org/D86261
__
43 matches
Mail list logo
