[Lldb-commits] [lldb] dbf44b8 - [LLDB] Mark test_launch_simple as a no-debug-info test

Author: Jonas Devlieghere Date: 2020-08-06T23:18:37-07:00 New Revision: dbf44b833067cfe59056d07130e7afcb8fc149c7 URL: https://github.com/llvm/llvm-project/commit/dbf44b833067cfe59056d07130e7afcb8fc149c7 DIFF: https://github.com/llvm/llvm-project/commit/dbf44b833067cfe59056d07130e7afcb8fc149c7.d

[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

jingham updated this revision to Diff 283769. jingham added a comment. Remove a file that got inadvertently included from another commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85265/new/ https://reviews.llvm.org/D85265 Files: lldb/bindin

[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

jingham updated this revision to Diff 283767. jingham added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85265/new/ https://reviews.llvm.org/D85265 Files: lldb/bindings/interface/SBThreadPlan.i lldb/include/lldb/API/SB

[Lldb-commits] [lldb] 243903f - Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

Author: Adrian Prantl Date: 2020-08-06T16:36:58-07:00 New Revision: 243903f3262d0e1727fe7d473da741c4a742a937 URL: https://github.com/llvm/llvm-project/commit/243903f3262d0e1727fe7d473da741c4a742a937 DIFF: https://github.com/llvm/llvm-project/commit/243903f3262d0e1727fe7d473da741c4a742a937.diff

[Lldb-commits] [PATCH] D85243: Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG243903f3262d: Factor out common code from the iPhone/AppleTV/WatchOS simulator platform… (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D85243: Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. Ship it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85243/new/ https://reviews.llvm.org/D85243 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D85243: Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85243/new/ https://reviews.llvm.org/D85243 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D85243: Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

aprantl updated this revision to Diff 283730. aprantl marked 2 inline comments as done. aprantl added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85243/new/ https://reviews.llvm.org/D85243 Files: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt lldb/sour

[Lldb-commits] [PATCH] D85243: Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

aprantl updated this revision to Diff 283729. aprantl added a comment. Address feedback from @JDevlieghere CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85243/new/ https://reviews.llvm.org/D85243 Files: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt lldb/source/Plugins/Platform

[Lldb-commits] [PATCH] D85243: Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

aprantl added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h:96 protected: + const char *m_class_name; + const char *m_description; JDevlieghere wrote: > aprantl wrote: > > JDevlieghere wrote: > > > "While you are her

[Lldb-commits] [PATCH] D85243: Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

aprantl added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:558 + "arm64e-apple-ios-simulator", "arm64-apple-ios-simulator", + "x86_64-apple-ios-simulator", "x86_64h-apple-ios-simulator", +#else

[Lldb-commits] [lldb] 0fa520a - Unify the code that updates the ArchSpec after finding a fat binary

Author: Adrian Prantl Date: 2020-08-06T13:30:17-07:00 New Revision: 0fa520af6734c5f1fab80629337e3f08fd8770db URL: https://github.com/llvm/llvm-project/commit/0fa520af6734c5f1fab80629337e3f08fd8770db DIFF: https://github.com/llvm/llvm-project/commit/0fa520af6734c5f1fab80629337e3f08fd8770db.diff

[Lldb-commits] [PATCH] D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fa520af6734: Unify the code that updates the ArchSpec after finding a fat binary (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D85049?vs=283669&

[Lldb-commits] [PATCH] D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary

aprantl added inline comments. Comment at: lldb/source/Target/TargetList.cpp:144 prefer_platform_arch = true; platform_arch = matching_module_spec.GetArchitecture(); } jasonmolenda wrote: > Should this conditional

[Lldb-commits] [PATCH] D85243: Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

vsk added a comment. I gave this another look-over, and while I didn't spot anything troubling, I'm not terribly familiar with this code. I'll give this a third pass later today if review is still needed. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.

[Lldb-commits] [PATCH] D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM, it's hard to keep all the supported behaviors in my head but I think this is right. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85049/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary

jasonmolenda added inline comments. Comment at: lldb/source/Target/TargetList.cpp:144 prefer_platform_arch = true; platform_arch = matching_module_spec.GetArchitecture(); } Should this conditional be replaced with

[Lldb-commits] [lldb] f406a90 - Add missing override to Makefile

Author: Adrian Prantl Date: 2020-08-06T13:07:16-07:00 New Revision: f406a90a08c3993cd5bfd5e6a546165e55fec9b4 URL: https://github.com/llvm/llvm-project/commit/f406a90a08c3993cd5bfd5e6a546165e55fec9b4 DIFF: https://github.com/llvm/llvm-project/commit/f406a90a08c3993cd5bfd5e6a546165e55fec9b4.diff

[Lldb-commits] [lldb] ba37b14 - [LLDB] Skip test_launch_simple from TestTargetAPI.py when remote

Author: Jonas Devlieghere Date: 2020-08-06T13:03:18-07:00 New Revision: ba37b144e6cf7ecaa7e6eb5bb34c02aeaa8a9e3c URL: https://github.com/llvm/llvm-project/commit/ba37b144e6cf7ecaa7e6eb5bb34c02aeaa8a9e3c DIFF: https://github.com/llvm/llvm-project/commit/ba37b144e6cf7ecaa7e6eb5bb34c02aeaa8a9e3c.d

[Lldb-commits] [PATCH] D85243: Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h:96 protected: + const char *m_class_name; + const char *m_description; aprantl wrote: > JDevlieghere wrote: > > "While you are here" could we make thes

[Lldb-commits] [PATCH] D85243: Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

aprantl added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:85 + if (!m_sdk.empty()) +strm.Printf(" SDK Path: \"%s\"\n", m_sdk.str().c_str()); + else JDevlieghere wrote: > If you use `<<` you could drop the `.s

[Lldb-commits] [PATCH] D85243: Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:85 + if (!m_sdk.empty()) +strm.Printf(" SDK Path: \"%s\"\n", m_sdk.str().c_str()); + else If you use `<<` you could drop the `.str().c_str()`. Al

[Lldb-commits] [PATCH] D85358: Correctly detect legacy iOS simulator Mach-O objectfiles

This revision was automatically updated to reflect the committed changes. Closed by commit rG05df9cc70367: Correctly detect legacy iOS simulator Mach-O objectfiles (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [lldb] 05df9cc - Correctly detect legacy iOS simulator Mach-O objectfiles

Author: Adrian Prantl Date: 2020-08-06T12:40:45-07:00 New Revision: 05df9cc70367a60cb34bee773389ab2522984f8b URL: https://github.com/llvm/llvm-project/commit/05df9cc70367a60cb34bee773389ab2522984f8b DIFF: https://github.com/llvm/llvm-project/commit/05df9cc70367a60cb34bee773389ab2522984f8b.diff

[Lldb-commits] [PATCH] D85358: Correctly detect legacy iOS simulator Mach-O objectfiles

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85358/new/ https://reviews.llvm.org/D85358 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

aprantl added a comment. Do we have an end-to-end (with source code instead of assembler) test for ObjC bitfields, too? If not, it might still be a good a idea to add one even if it doesn't add coverage for this particular change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85376/new

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

aprantl accepted this revision. aprantl added a comment. The test LGTM now! Please be sure to address Fred's comment before committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85376/new/ https://reviews.llvm.org/D85376 ___ lldb-commits

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

shafik updated this revision to Diff 283703. shafik added a comment. - Add more tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85376/new/ https://reviews.llvm.org/D85376 Files: lldb/source/Core/ValueObjectChild.cpp lldb/test/API/functionalities/data-formatter/valueobj-pass-by-

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

shafik added inline comments. Comment at: lldb/source/Core/ValueObjectChild.cpp:202-205 -if (m_bitfield_bit_size) - scalar.ExtractBitfield(m_bitfield_bit_size, - m_bitfield_bit_offset); -else ---

[Lldb-commits] [PATCH] D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary

aprantl added inline comments. Comment at: lldb/source/Target/TargetList.cpp:110-111 +// architecture so that the platform matching can be more accurate. +if (!platform_arch.TripleOSWasSpecified() || +!platform_arch.TripleVendorWasSpecified()) { + prefer_plat

[Lldb-commits] [lldb] 86aa8e6 - [lldb] Use target.GetLaunchInfo() instead of creating an empty one.

Author: Jonas Devlieghere Date: 2020-08-06T11:51:26-07:00 New Revision: 86aa8e6363c7e00f211de62ccb3236556e9841df URL: https://github.com/llvm/llvm-project/commit/86aa8e6363c7e00f211de62ccb3236556e9841df DIFF: https://github.com/llvm/llvm-project/commit/86aa8e6363c7e00f211de62ccb3236556e9841df.d

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 updated this revision to Diff 283686. gedatsu217 added a comment. add comments. revise a test(add self.quit()). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81001/new/ https://reviews.llvm.org/D81001 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/IOHan

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

shafik added inline comments. Comment at: lldb/source/Core/ValueObjectChild.cpp:202-205 -if (m_bitfield_bit_size) - scalar.ExtractBitfield(m_bitfield_bit_size, - m_bitfield_bit_offset); -else ---

[Lldb-commits] [PATCH] D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary

aprantl updated this revision to Diff 283669. aprantl added a comment. Address review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85049/new/ https://reviews.llvm.org/D85049 Files: lldb/source/Target/TargetList.cpp lldb/test/API/macosx/universal/Makefile lldb/test/API/

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

friss added inline comments. Comment at: lldb/source/Core/ValueObjectChild.cpp:202-205 -if (m_bitfield_bit_size) - scalar.ExtractBitfield(m_bitfield_bit_size, - m_bitfield_bit_offset); -else

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

shafik updated this revision to Diff 283658. shafik added a comment. - Refactored the Makefile and test based on offline comments from Adrian. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85376/new/ https://reviews.llvm.org/D85376 Files: lldb/source/Core/ValueObjectChild.cpp lldb/

[Lldb-commits] [lldb] 99298c7 - [lldb/testsuite] Change get_debugserver_exe to support Rosetta

Author: Fred Riss Date: 2020-08-06T10:38:30-07:00 New Revision: 99298c7fc540c74c89c92f0e5d617e00cb87cf19 URL: https://github.com/llvm/llvm-project/commit/99298c7fc540c74c89c92f0e5d617e00cb87cf19 DIFF: https://github.com/llvm/llvm-project/commit/99298c7fc540c74c89c92f0e5d617e00cb87cf19.diff LOG

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

saugustine added a comment. This change has a subtle isse with wattr_get and friends: saved_opts isn't actually used, and the documentation for them says to always pass a nullptr. "The parameter opts is reserved for future use, applications must supply a null pointer." I fixed it in 9dbdaea9a0

[Lldb-commits] [lldb] 9dbdaea - Remove unused variable "saved_opts".

Author: Sterling Augustine Date: 2020-08-06T10:20:21-07:00 New Revision: 9dbdaea9a0e6f58417b5bd8980e7ea6723fd1783 URL: https://github.com/llvm/llvm-project/commit/9dbdaea9a0e6f58417b5bd8980e7ea6723fd1783 DIFF: https://github.com/llvm/llvm-project/commit/9dbdaea9a0e6f58417b5bd8980e7ea6723fd1783.

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

shafik updated this revision to Diff 283647. shafik added a comment. Removing use of `-O1` from Makefile. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85376/new/ https://reviews.llvm.org/D85376 Files: lldb/source/Core/ValueObjectChild.cpp lldb/test/API/functionalities/data-formatt

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

shafik added a subscriber: JDevlieghere. shafik added inline comments. Comment at: lldb/source/Core/ValueObjectChild.cpp:202-205 -if (m_bitfield_bit_size) - scalar.ExtractBitfield(m_bitfield_bit_size, - m_bitfield_bit_o

[Lldb-commits] [PATCH] D85388: [lldb] Fix bug in skipIfRosetta decorator

aprantl added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85388/new/ https://reviews.llvm.org/D85388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [lldb] f6913e7 - [lldb][NFC] Document and encapsulate OriginMap in ASTContextMetadata

Author: Raphael Isemann Date: 2020-08-06T17:37:29+02:00 New Revision: f6913e74400aa932b3edc7cc765495247799fcb0 URL: https://github.com/llvm/llvm-project/commit/f6913e74400aa932b3edc7cc765495247799fcb0 DIFF: https://github.com/llvm/llvm-project/commit/f6913e74400aa932b3edc7cc765495247799fcb0.dif

[Lldb-commits] [PATCH] D85100: [ELF] Allow sections after a non-SHF_ALLOC section to be covered by PT_LOAD

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rGa6db64ef4a99: [ELF] Allow sections after a non-SHF_ALLOC section to be covered by PT_LOAD (authored by MaskRay). Herald

[Lldb-commits] [lldb] a6db64e - [ELF] Allow sections after a non-SHF_ALLOC section to be covered by PT_LOAD

Author: Fangrui Song Date: 2020-08-06T08:27:15-07:00 New Revision: a6db64ef4a9906c96ef5652739ac15aefaa7827c URL: https://github.com/llvm/llvm-project/commit/a6db64ef4a9906c96ef5652739ac15aefaa7827c DIFF: https://github.com/llvm/llvm-project/commit/a6db64ef4a9906c96ef5652739ac15aefaa7827c.diff

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. Alright, let's see if the others see any other issues, otherwise I think this is finally good to go. Comment at: lldb/source/Host/common/Editline.cpp:1011 el_insertstr(m_editline, to_add.c_str()); - break; + if (to_add == " ") +

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 updated this revision to Diff 283590. gedatsu217 added a comment. Simplify the code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81001/new/ https://reviews.llvm.org/D81001 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/IOHandler.h lldb/include/lldb/H

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added a comment. > Are there any other problems with the current state of the patch that haven't > been resolved? (I went over the comments, but it's hard to say what has and > hasn't been fixed until now). Yes, I have solved all the problems. CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [lldb] e82866d - [lldb][AArch64] Correct compile options for Neon corefile

Author: David Spickett Date: 2020-08-06T13:39:09+01:00 New Revision: e82866d5d9eef913252833789acda04ef8389e52 URL: https://github.com/llvm/llvm-project/commit/e82866d5d9eef913252833789acda04ef8389e52 DIFF: https://github.com/llvm/llvm-project/commit/e82866d5d9eef913252833789acda04ef8389e52.diff

[Lldb-commits] [PATCH] D85134: [lldb][AArch64] Correct compile options for Neon corefile

This revision was automatically updated to reflect the committed changes. Closed by commit rGe82866d5d9ee: [lldb][AArch64] Correct compile options for Neon corefile (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85134/new/

[Lldb-commits] [lldb] 94a5919 - [LLDB] Skip test_launch_simple from TestTargetAPI.py on Arm/AArch64 Linux

Author: Muhammad Omair Javaid Date: 2020-08-06T17:38:20+05:00 New Revision: 94a5919946a0a6b87720d9d1dfd15071ae3a5a49 URL: https://github.com/llvm/llvm-project/commit/94a5919946a0a6b87720d9d1dfd15071ae3a5a49 DIFF: https://github.com/llvm/llvm-project/commit/94a5919946a0a6b87720d9d1dfd15071ae3a5a

[Lldb-commits] [PATCH] D85134: [lldb][AArch64] Correct compile options for Neon corefile

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Thanks for fixing this. SVE was just a typo orignal core files were generated without SVE flag on a aarch64-linux target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. In D81001#2199450 , @gedatsu217 wrote: >> So, if I would type "b" and then press tab, the autosuggestion would briefly >> disappear until I type the next character? > > Yes. Indeed, it may not be good. I'll think of other ways.

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added a comment. > So, if I would type "b" and then press tab, the autosuggestion would briefly > disappear until I type the next character? Yes. Indeed, it may not be good. I'll think of other ways. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81001/new/ https://reviews.

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. In D81001#2199205 , @gedatsu217 wrote: >> So the way the issue with the single space is now solved is by doing >> CC_REDISPLAY when we're only adding the single space? Isn't that also >> deleting the whole autosuggestion? > > Y

[Lldb-commits] [PATCH] D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

omjavaid added subscribers: max-kudr, omjavaid. omjavaid added a comment. In D85235#2198062 , @JDevlieghere wrote: > In D85235#2198013 , @max-kudr wrote: > >> @JDevlieghere This change is is failing LLDB Windows bu

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added a comment. > So the way the issue with the single space is now solved is by doing > CC_REDISPLAY when we're only adding the single space? Isn't that also > deleting the whole autosuggestion? Yes. CC_REDISPLAY can delete all the gray characters left. Comment

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

mstorsjo added a comment. In D85145#2199045 , @teemperor wrote: > Same on Arch Linux. Should be fixed in > 45f9fc890705a8272e5253602f5506fdef4586e2 (I just removed the scope operator). Indeed it is, thanks! Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

teemperor added a comment. Same on Arch Linux. Should be fixed in 45f9fc890705a8272e5253602f5506fdef4586e2 (I just removed the scope operator). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85145/new/ https://reviews.llvm.org/D85145 _

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

mstorsjo added a comment. Herald added a subscriber: JDevlieghere. This broke compilation on Ubuntu 18.04: In file included from ../tools/lldb/source/Core/IOHandlerCursesGUI.cpp:17:0: ../tools/lldb/source/Core/IOHandlerCursesGUI.cpp: In member function ‘void curses::Window::OutputColoredStri

[Lldb-commits] [lldb] d40c44e - [lldb] Fix LLDB compilation with ncurses 6.2 due to wattr_set/get being a macro

Author: Raphael Isemann Date: 2020-08-06T10:52:57+02:00 New Revision: d40c44e89e11659439072a4b57d2c0c191d5cae5 URL: https://github.com/llvm/llvm-project/commit/d40c44e89e11659439072a4b57d2c0c191d5cae5 DIFF: https://github.com/llvm/llvm-project/commit/d40c44e89e11659439072a4b57d2c0c191d5cae5.dif

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. So the way the issue with the single space is now solved is by doing CC_REDISPLAY when we're only adding the single space? Isn't that also deleting the whole autosuggestion? In D81001#2190864 , @gedatsu217 wrote: I don't

[Lldb-commits] [PATCH] D85289: [DWARFYAML][debug_info] Rename some mapping keys. NFC.

Higuoxing added a subscriber: jankratochvil. Higuoxing added a comment. CC @jankratochvil who might also have thoughts on this topic :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85289/new/ https://reviews.llvm.org/D85289 _

[Lldb-commits] [lldb] 4a8e4b5 - [lldb][gui] use names for color pairs, instead of magic numbers

Author: Luboš Luňák Date: 2020-08-06T08:58:29+02:00 New Revision: 4a8e4b5c744791da629ec4a282acdf536f4471dd URL: https://github.com/llvm/llvm-project/commit/4a8e4b5c744791da629ec4a282acdf536f4471dd DIFF: https://github.com/llvm/llvm-project/commit/4a8e4b5c744791da629ec4a282acdf536f4471dd.diff L

[Lldb-commits] [lldb] 14406ca - [lldb][gui] use syntax highlighting also in gui mode

Author: Luboš Luňák Date: 2020-08-06T08:57:53+02:00 New Revision: 14406ca01fd3f401742b0f78f3780f62f3934468 URL: https://github.com/llvm/llvm-project/commit/14406ca01fd3f401742b0f78f3780f62f3934468 DIFF: https://github.com/llvm/llvm-project/commit/14406ca01fd3f401742b0f78f3780f62f3934468.diff L

[Lldb-commits] [PATCH] D85286: [lldb][gui] use names for color pairs, instead of magic numbers

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a8e4b5c7447: [lldb][gui] use names for color pairs, instead of magic numbers (authored by llunak). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG14406ca01fd3: [lldb][gui] use syntax highlighting also in gui mode (authored by llunak). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D85145?vs=282865&id=283498#toc R