[Lldb-commits] [PATCH] D85068: [intel-pt] Refactor 1: rename the namespace

wallace created this revision. wallace added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace requested review of this revision. Herald added a subscriber: JDevlieghere. Depends on D84810 . The existing namespace

[Lldb-commits] [PATCH] D84716: [lldb/ArchSpec] Always match simulator environment in IsEqualTo

aprantl added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/unittests/Utility/ArchSpecTest.cpp:315 +ASSERT_FALSE(B.IsCompatibleMatch(A)); +ASSERT_FALSE(B.IsCompatibleMatch(A)); + } We want to be *really* sure of this? :-) R

[Lldb-commits] [PATCH] D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary

aprantl created this revision. aprantl added reviewers: jasonmolenda, jingham, friss. aprantl requested review of this revision. In particular this affects how `target create --arch` is handled — it allowed us to override the deployment target (a useful feature for the expression evaluator), but

[Lldb-commits] [lldb] 5110fd0 - Convert to early exit (NFC)

Author: Adrian Prantl Date: 2020-07-31T14:55:09-07:00 New Revision: 5110fd0343c2d06c8ae538741fbef13ece5e68de URL: https://github.com/llvm/llvm-project/commit/5110fd0343c2d06c8ae538741fbef13ece5e68de DIFF: https://github.com/llvm/llvm-project/commit/5110fd0343c2d06c8ae538741fbef13ece5e68de.diff

[Lldb-commits] [PATCH] D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. LGTM. Some changes for grammar to the title -- "[lldb/Process/Windows] Attempting to kill an exited/detached process is not an error" A little more description would be helpful for others. He

[Lldb-commits] [PATCH] D84576: Fix debugserver's qProcessInfo reporting of maccatalyst binaries

aprantl added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84576/new/ https://reviews.llvm.org/D84576 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D84972: Force full gui redraw on Ctrl+L

This revision was automatically updated to reflect the committed changes. Closed by commit rG8739445e3221: [lldb] force full gui redraw on Ctrl+L (authored by llunak). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] 77d5a63 - [lldb] report an error if a CLI option lacks an argument

Author: Luboš Luňák Date: 2020-07-31T22:02:40+02:00 New Revision: 77d5a63c191ca791f081ff153276170bbfb10cee URL: https://github.com/llvm/llvm-project/commit/77d5a63c191ca791f081ff153276170bbfb10cee DIFF: https://github.com/llvm/llvm-project/commit/77d5a63c191ca791f081ff153276170bbfb10cee.diff L

[Lldb-commits] [PATCH] D84955: Report an error if a CLI option lacks an argument

This revision was automatically updated to reflect the committed changes. Closed by commit rG77d5a63c191c: [lldb] report an error if a CLI option lacks an argument (authored by llunak). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [lldb] 8739445 - [lldb] force full gui redraw on Ctrl+L

Author: Luboš Luňák Date: 2020-07-31T22:02:40+02:00 New Revision: 8739445e3221ea05bc71a592f4114e10510b0b34 URL: https://github.com/llvm/llvm-project/commit/8739445e3221ea05bc71a592f4114e10510b0b34 DIFF: https://github.com/llvm/llvm-project/commit/8739445e3221ea05bc71a592f4114e10510b0b34.diff L

[Lldb-commits] [lldb] 162e9f7 - [lldb/Test] Reduce code duplication by importing subprocess globally

Author: Jonas Devlieghere Date: 2020-07-31T10:56:13-07:00 New Revision: 162e9f72ac57342a0ea12036576d6212720cc93f URL: https://github.com/llvm/llvm-project/commit/162e9f72ac57342a0ea12036576d6212720cc93f DIFF: https://github.com/llvm/llvm-project/commit/162e9f72ac57342a0ea12036576d6212720cc93f.d

[Lldb-commits] [PATCH] D84955: Report an error if a CLI option lacks an argument

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84955/new/ https://reviews.llvm.org/D84955 __

[Lldb-commits] [PATCH] D84955: Report an error if a CLI option lacks an argument

llunak updated this revision to Diff 282208. llunak added a comment. Adjusted according to the comments. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84955/new/ https://reviews.llvm.org/D84955 Files: lldb/test/Shell/Driver/TestError.test lldb/tools/driver