[Lldb-commits] [PATCH] D80724: [lldb] Only set the executable module for a target once

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG16926115ed28: [lldb] Only set the executable module for a target once (authored by teemperor). Herald added a project: LLD

[Lldb-commits] [lldb] 1692611 - [lldb] Only set the executable module for a target once

Author: Raphael Isemann Date: 2020-07-17T08:35:38+02:00 New Revision: 16926115ed28d1370bca1085dfb1b20c842b0ffb URL: https://github.com/llvm/llvm-project/commit/16926115ed28d1370bca1085dfb1b20c842b0ffb DIFF: https://github.com/llvm/llvm-project/commit/16926115ed28d1370bca1085dfb1b20c842b0ffb.dif

[Lldb-commits] [PATCH] D83957: [lldb/DWARF] Don't get confused by line sequences with tombstone values

MaskRay added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1040 std::unique_ptr sequence = LineTable::CreateLineSequenceContainer(); std::vector> sequences; While here, delete the initialization and move `sequ

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

wallace added a comment. @clayborg, the tests will fail on linux because the Makefile is expecting a .dsym file. I think it's okay if she does it just for Darwin and then I update the test to cover also linux, as I have my linux already well set up. Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So you should revert any clang format changes that are not in modified lines of source, mostly revert a lot of lines in lldb-vscode.cpp. Comment at: lldb/test/

[Lldb-commits] [PATCH] D83975: Add an option to "break set" and "source list" that takes a line spec in the form file:line:column

jingham marked 2 inline comments as done. jingham added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionValueFileColonLine.h:43 +m_line_number = LLDB_INVALID_LINE_NUMBER; +m_column_number = 0; + } JDevlieghere wrote: > This should be `LL

[Lldb-commits] [PATCH] D83975: Add an option to "break set" and "source list" that takes a line spec in the form file:line:column

jingham marked 8 inline comments as done. jingham added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionValueFileColonLine.h:26 + + // Virtual subclass pure virtual overrides + JDevlieghere wrote: > I think these comments add very little, if any

[Lldb-commits] [PATCH] D83957: [lldb/DWARF] Don't get confused by line sequences with tombstone values

MaskRay added a comment. > Recently, lld has started debug info resolving relocations to > garbage-collected symbols as -1 Just mention D81784 :) > (instead of 0). This is not accurate. It resolves the relocation to `r_addend`. In many cases, r_addend is 0. Ho

[Lldb-commits] [PATCH] D83975: Add an option to "break set" and "source list" that takes a line spec in the form file:line:column

jingham updated this revision to Diff 278642. jingham added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83975/new/ https://reviews.llvm.org/D83975 Files: lldb/include/lldb/Interpreter/OptionValue.h lldb/in

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:333-335 + if (section_name.startswith(".debug") || section_name.startswith("__debug")) +debug_info_size += section.GetFileByteSize(); + if (section_name.startswith(".apple") || section_name.star

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278631. aelitashen added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. The tests added are only for macOS, Walter will help me write tests on Linux. This update optimize the code and apply git clang format. Repository:

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid marked an inline comment as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:63-66 +m_sve_note_payload.resize(m_sveregset.GetByteSize()); +::memcpy(GetSVEBuffer(), m_sveregset.GetDataStart(

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 278617. omjavaid added a comment. This update plugs the holes susceptible to bugs by endianity variations. I have used DataExtractor GetU16 to read flags and vl from user_sve_header. Also removed the memset and replaced it with SetFromMemoryData function.

[Lldb-commits] [lldb] 2f99059 - [lldb/Test] Skip TestMacABImacOSFramework.py with reproducers

Author: Jonas Devlieghere Date: 2020-07-16T15:50:35-07:00 New Revision: 2f99059aa09247c4c904f55be52fc5e84a4ece60 URL: https://github.com/llvm/llvm-project/commit/2f99059aa09247c4c904f55be52fc5e84a4ece60 DIFF: https://github.com/llvm/llvm-project/commit/2f99059aa09247c4c904f55be52fc5e84a4ece60.d

[Lldb-commits] [lldb] 72958c9 - [lldb] Eliminated unused local variable

Author: Adrian McCarthy Date: 2020-07-16T14:44:24-07:00 New Revision: 72958c9ab1cdf18c447778b836f13694a7e4e9e1 URL: https://github.com/llvm/llvm-project/commit/72958c9ab1cdf18c447778b836f13694a7e4e9e1 DIFF: https://github.com/llvm/llvm-project/commit/72958c9ab1cdf18c447778b836f13694a7e4e9e1.dif

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:40-41 self.assertEqual('Symbols not found.', program_module['symbolStatus']

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278591. aelitashen added a comment. Add Test for Debug Info Size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: lldb/packages/Python/lldbsuite/test/tools/l

[Lldb-commits] [PATCH] D83975: Add an option to "break set" and "source list" that takes a line spec in the form file:line:column

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionValueFileColonLine.h:1 +//===-- OptionValueFileColonLine.h ---*- C++ -*-===// +// This actually looks like a legit issue. Comme

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 updated this revision to Diff 278580. gedatsu217 added a comment. Remove extra parts in Editline::TabCommand in Editline.cpp. Add a test for the autosuggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81001/new/ https://reviews.llvm.org/D81001 Files: lldb/include/ll

[Lldb-commits] [PATCH] D83900: [intel-pt] Fix building due to CMake + python changes

wallace closed this revision. wallace added a comment. Committed as 4c5d52397e8c8015046ff5541fd0abc738953870 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83900/new/ https://rev

[Lldb-commits] [lldb] 4c5d523 - [intel-pt] Fix building due to CMake + python changes

Author: Walter Erquinigo Date: 2020-07-16T12:18:59-07:00 New Revision: 4c5d52397e8c8015046ff5541fd0abc738953870 URL: https://github.com/llvm/llvm-project/commit/4c5d52397e8c8015046ff5541fd0abc738953870 DIFF: https://github.com/llvm/llvm-project/commit/4c5d52397e8c8015046ff5541fd0abc738953870.di

[Lldb-commits] [PATCH] D83876: [lldb] Add SBModule::ClearCachedModules and clear modules after each test run

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/bindings/interface/SBModule.i:365 +static void +ClearCachedModules(); + JDevlieghere wrote: > teemperor wrote: > > JDevlieghere wrote: > > > Maybe we should call

[Lldb-commits] [PATCH] D83975: Add an option to "break set" and "source list" that takes a line spec in the form file:line:column

jingham created this revision. jingham added reviewers: JDevlieghere, teemperor. Herald added subscribers: lldb-commits, dang, mgorny. Herald added a project: LLDB. I think it is important to have separate the file & line specifiers in "break set" because that way no matter what you've named your

[Lldb-commits] [PATCH] D83881: [lldb/COFF] Remove strtab zeroing hack

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Thanks @mstorsjo for clarifying for me. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:642 DataExtractor symtab_data = ReadI

[Lldb-commits] [PATCH] D83972: Modify ImportDefiniton for ObjCInterfaceDecl so that we always the ImportDeclContext one we start the definition

shafik created this revision. shafik added reviewers: teemperor, martong. Herald added a subscriber: rnkovacs. Once we start the definition of an `ObjCInterfaceDecl` we won't attempt to `ImportDeclContext` later on. Unlike `RecordDecl` case which uses `DefinitionCompleter` to force `completeDefi

[Lldb-commits] [PATCH] D83876: [lldb] Add SBModule::ClearCachedModules and clear modules after each test run

JDevlieghere added inline comments. Comment at: lldb/bindings/interface/SBModule.i:365 +static void +ClearCachedModules(); + teemperor wrote: > JDevlieghere wrote: > > Maybe we should call this `ClearAllocatedModules` for consistency with the > > other A

[Lldb-commits] [PATCH] D83876: [lldb] Add SBModule::ClearCachedModules and clear modules after each test run

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/bindings/interface/SBModule.i:365 +static void +ClearCachedModules(); + JDevlieghere wrote: > Maybe we should call this `ClearAllocatedModules` for consistency w

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

This revision was automatically updated to reflect the committed changes. Closed by commit rG8113a8bb7934: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache (authored by friss). Changed prior to commit: https://reviews.llvm.org/D83023?vs=278495&id=278537#toc Repository

[Lldb-commits] [lldb] 8113a8b - [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

Author: Fred Riss Date: 2020-07-16T10:37:37-07:00 New Revision: 8113a8bb793453832301e2684dc2b8cebec331b0 URL: https://github.com/llvm/llvm-project/commit/8113a8bb793453832301e2684dc2b8cebec331b0 DIFF: https://github.com/llvm/llvm-project/commit/8113a8bb793453832301e2684dc2b8cebec331b0.diff LOG

[Lldb-commits] [PATCH] D83957: [lldb/DWARF] Don't get confused by line sequences with tombstone values

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing that! Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1043 + for (const llvm::DWARFDebugLine::Sequence &seq : line_t

[Lldb-commits] [PATCH] D83840: [lldb][test] Prevent infinite loop while looking for use_lldb_suite_root.py.

JDevlieghere added a comment. In D83840#2155308 , @labath wrote: > In D83840#2154263 , @shafik wrote: > > > @labath why do we need two copies of `use_lldb_suite.py`? > > > This script is responsible for setting up a

[Lldb-commits] [PATCH] D83876: [lldb] Add SBModule::ClearCachedModules and clear modules after each test run

JDevlieghere added inline comments. Comment at: lldb/bindings/interface/SBModule.i:365 +static void +ClearCachedModules(); + Maybe we should call this `ClearAllocatedModules` for consistency with the other APIs? CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D83957: [lldb/DWARF] Don't get confused by line sequences with tombstone values

labath created this revision. labath added reviewers: JDevlieghere, MaskRay. Herald added a subscriber: aprantl. Herald added a project: LLDB. Recently, lld has started debug info resolving relocations to garbage-collected symbols as -1 (instead of 0). For an unaware consumer this generated sequen

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

friss added a comment. I'll commit after I've re-built top of tree and fully retested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83023/new/ https://reviews.llvm.org/D83023 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

labath accepted this revision. labath added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:474-481 +typedef struct dyld_shared_cache_dylib_text_info +dyld_shared_cache_dylib_text_info; + +extern "C" int dyld_shared_cache_iterate_text( +const

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

friss updated this revision to Diff 278495. friss marked an inline comment as done. friss added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83023/new/ https://reviews.llvm.org/D83023 Files: lldb/include/lldb/

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

labath added a comment. In D83425#2154593 , @bbli wrote: > Ok, I have revised the patch with the code from the first pic. I also moved > the `decode` back to the `format_build_error` since it was there to begin > with(not sure how much of a difference it

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

labath added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:63-66 +m_sve_note_payload.resize(m_sveregset.GetByteSize()); +::memcpy(GetSVEBuffer(), m_sveregset.GetDataStart(), + m_sveregset.GetByteSize());

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

labath added a comment. I like how this has turned out. Some small requests inline. Comment at: lldb/include/lldb/Host/HostInfoBase.h:107 + static SharedCacheImageInfo + GetSharedCacheImageInfo(llvm::StringRef image_name) { Some doxygen here? "Try to find a

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 278435. omjavaid added a comment. In this update I have addressed issues highlighted in last review iteration. @labath Does this now look LGTM? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047 Files: lldb

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid marked 9 inline comments as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm64.cpp:289 + +lldb_private::RegisterInfo *new_reg_info_p = reg_info_ref.data(); + labath wrote: > I think all uses

[Lldb-commits] [PATCH] D83840: [lldb][test] Prevent infinite loop while looking for use_lldb_suite_root.py.

labath added a comment. In D83840#2154263 , @shafik wrote: > @labath why do we need two copies of `use_lldb_suite.py`? This script is responsible for setting up an appropriate python import path. Before we can import any code in lldb/third_party/Python/

[Lldb-commits] [PATCH] D83876: [lldb] Add SBModule::ClearCachedModules and clear modules after each test run

teemperor updated this revision to Diff 278407. teemperor retitled this revision from "[lldb] Clean orphaned modules in Debugger::Destroy" to "[lldb] Add SBModule::ClearCachedModules and clear modules after each test run". teemperor edited the summary of this revision. teemperor added a comment.

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

This revision was automatically updated to reflect the committed changes. Closed by commit rG93ec6cd68426: [lldb] Desugar template specializations (authored by jarin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83858/new/ https://reviews.llvm.org

[Lldb-commits] [lldb] 93ec6cd - [lldb] Desugar template specializations

Author: Jaroslav Sevcik Date: 2020-07-16T09:01:01+02:00 New Revision: 93ec6cd684265161623b4ea67836f022cd18c224 URL: https://github.com/llvm/llvm-project/commit/93ec6cd684265161623b4ea67836f022cd18c224 DIFF: https://github.com/llvm/llvm-project/commit/93ec6cd684265161623b4ea67836f022cd18c224.dif