[Lldb-commits] [lldb] 2bb16f9 - [lldb/Test] Skip TestPositionalArgs with lldb-repro

Author: Jonas Devlieghere Date: 2020-05-18T22:59:55-07:00 New Revision: 2bb16f94128ecd4cfcbbb8fe2db57490043a805f URL: https://github.com/llvm/llvm-project/commit/2bb16f94128ecd4cfcbbb8fe2db57490043a805f DIFF: https://github.com/llvm/llvm-project/commit/2bb16f94128ecd4cfcbbb8fe2db57490043a805f.d

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG82093e8fb7d6: [lldb/Driver] Fix handling on positional arguments (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [lldb] 82093e8 - [lldb/Driver] Fix handling on positional arguments

Author: Jonas Devlieghere Date: 2020-05-18T18:52:18-07:00 New Revision: 82093e8fb7d65486ff450d33bf386aabd0d194f7 URL: https://github.com/llvm/llvm-project/commit/82093e8fb7d65486ff450d33bf386aabd0d194f7 DIFF: https://github.com/llvm/llvm-project/commit/82093e8fb7d65486ff450d33bf386aabd0d194f7.d

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

clayborg accepted this revision. clayborg added a comment. Much better! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80165/new/ https://reviews.llvm.org/D80165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] 47cc6db - Re-land [Debug][CodeView] Emit fully qualified names for globals

Author: Reid Kleckner Date: 2020-05-18T17:31:00-07:00 New Revision: 47cc6db928d063d96e11e70c196bd5601b2bdd06 URL: https://github.com/llvm/llvm-project/commit/47cc6db928d063d96e11e70c196bd5601b2bdd06 DIFF: https://github.com/llvm/llvm-project/commit/47cc6db928d063d96e11e70c196bd5601b2bdd06.diff

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM. These were useful behaviors, thanks for restoring them! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80165/new/ https://reviews.llvm.org/D80165 __

[Lldb-commits] [lldb] e3aa4cd - [lldb/test] Disable NSDate format check under _WIN32

Author: Vedant Kumar Date: 2020-05-18T16:51:47-07:00 New Revision: e3aa4cd9dbcee6441f51102e3958c35321698c67 URL: https://github.com/llvm/llvm-project/commit/e3aa4cd9dbcee6441f51102e3958c35321698c67 DIFF: https://github.com/llvm/llvm-project/commit/e3aa4cd9dbcee6441f51102e3958c35321698c67.diff

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

JDevlieghere updated this revision to Diff 264753. JDevlieghere added a comment. Document the behavior in the help and man page. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80165/new/ https://reviews.llvm.org/D80165 Files: lldb/docs/man/lldb.rst lldb/test/Shell/Driver/TestNoUseCo

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

JDevlieghere updated this revision to Diff 264745. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. Apparently I misremembered the old behavior. Jim refreshed my memory about what he expects the behavior to be link. I've reworked the patch to match that. The result

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

JDevlieghere updated this revision to Diff 264747. JDevlieghere added a comment. Add test for `lldb inferior -b inferior-arg -- inferior-arg2` as Greg pointed out. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80165/new/ https://reviews.llvm.org/D80165 Files: lldb/test/Shell/Driver/

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

JDevlieghere updated this revision to Diff 264746. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80165/new/ https://reviews.llvm.org/D80165 Files: lldb/test/Shell/Driver/TestNoUseColor.test lldb/test/Shell/Driver/TestPositionalArgs.test lldb/tools/driver/Driver.cpp Index: lldb/to

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

jingham added a comment. Not sure why you need to track "beginning and end". Does libOption not pull out all the options (and their option values if they have them) before handing you the command line? If not, then this probably is not worth doing. But if it does, this should be straightforw

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

clayborg added a comment. So when talking about "prior to libOption", are we talking getopt()? I believe that getopt would have an issue with: $ lldb inferior --inferior-arg As it would not understand the argument. Or was there an intermediate llvm option parser we were using after getopt()

[Lldb-commits] [lldb] fff3a84 - [lldb/test] Relax NSDate mock test for non-Apple platforms

Author: Vedant Kumar Date: 2020-05-18T16:00:10-07:00 New Revision: fff3a8464d4d518c7086c928fba967908eb294d7 URL: https://github.com/llvm/llvm-project/commit/fff3a8464d4d518c7086c928fba967908eb294d7 DIFF: https://github.com/llvm/llvm-project/commit/fff3a8464d4d518c7086c928fba967908eb294d7.diff

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

JDevlieghere added a comment. One thing the current approach allows is `foo bar -o 'run' baz` which will `set target.run-args` to ` "bar" "baz" `. I guess that's not really desirable, but I'm not sure it outweighs the added complexity of tracking the beginning and thee end. Repository: rLLD

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, labath, clayborg. Herald added a subscriber: teemperor. Before the transition to `libOption` it was possible to specify arguments for the inferior without `--`. For instance, the next two invocations behaved the same.

[Lldb-commits] [PATCH] D80159: [lldb/Properties] Move OSPluginReportsAllThreads from Target to Process

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. This is what Jim wanted originally. rdar://problem/61236293 Repository: rLLDB LLDB https://reviews.llvm.org/D80159 Files: lldb/include/lldb/Target/Process.h lldb/include/lldb/Target/Target.h lldb/source/Target

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

This revision was automatically updated to reflect the committed changes. vsk marked an inline comment as done. Closed by commit rGb783f70a4257: [lldb/DataFormatter] Check for overflow when finding NSDate epoch (authored by vsk). Changed prior to commit: https://reviews.llvm.org/D80150?vs=26469

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

vsk marked 2 inline comments as done. vsk added a comment. Thanks! Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:801-804 + // this snippet of code assumes that time_t == seconds since Jan-1-1970 this + // is generally true and POSIXly happy, but might break if a lib

[Lldb-commits] [lldb] b783f70 - [lldb/DataFormatter] Check for overflow when finding NSDate epoch

Author: Vedant Kumar Date: 2020-05-18T13:12:00-07:00 New Revision: b783f70a42575a5d9147bea1ac97e872370fe55b URL: https://github.com/llvm/llvm-project/commit/b783f70a42575a5d9147bea1ac97e872370fe55b DIFF: https://github.com/llvm/llvm-project/commit/b783f70a42575a5d9147bea1ac97e872370fe55b.diff

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

JDevlieghere added a comment. Davide already covered what I was going to say :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80150/new/ https://reviews.llvm.org/D80150 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

davide accepted this revision. davide added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/DataFormatters/Mock.h:1-8 +//===-- Mock.h --*- C++ -*-===// +// +// Part of the LLVM Projec

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

davide added a comment. Looking, as I touched `NSDate` last year. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80150/new/ https://reviews.llvm.org/D80150 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

vsk created this revision. vsk added reviewers: JDevlieghere, mib, teemperor. Herald added a subscriber: mgorny. Herald added a project: LLDB. Fixes UBSan-reported issues where the date value inside of an uninitialized NSDate overflows the 64-bit epoch. rdar://61774575 Repository: rG LLVM Git

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

rnk added a comment. I will take a look and try to reland this, since I requested the assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79447/new/ https://reviews.llvm.org/D79447 ___ lldb-commits m

[Lldb-commits] [PATCH] D78603: remove unused function LLDBSwigPython_GetIndexOfChildWithName

lawrence_danna abandoned this revision. lawrence_danna added a comment. despite there being no references to this function, it is not actually unused. This change causes `TestFormattersSBAPI.py` to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

emrekultursay added a comment. I admit I don't fully understand the details of that CL and how it may interact with this one. However, I can say that I verified this CL with an Android device connected over IPv6. So, I think this CL is ready to be submitted. (I don't have commit access). Repo

[Lldb-commits] [lldb] 2084330 - [lldb/Reproducers] Add skipIfReproducer to more tests

Author: Jonas Devlieghere Date: 2020-05-18T10:13:01-07:00 New Revision: 2084330e41d301cf9eaa3495d8968bff70846c7b URL: https://github.com/llvm/llvm-project/commit/2084330e41d301cf9eaa3495d8968bff70846c7b DIFF: https://github.com/llvm/llvm-project/commit/2084330e41d301cf9eaa3495d8968bff70846c7b.d

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

labath added a comment. Sorry, about the delay. I had to find some time to dig into the code again, to understand all of the interactions. It seems that we (lldb) have painted ourselves in the corner somewhat. The thing I did not realize until now is that the "lldb" scheme is documented to be

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

labath added a comment. I don't think we need to have different behavior for repl and --top-level. I'm mainly just confused about what is the right behavior to aim for. So, assuming we want these to behave as if everything was in a single TU, my next question is: What is the purpose of the `ext

[Lldb-commits] [PATCH] D80104: [LLDB] Remove code duplication from RegisterContextPOSIX_*

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wuzish. Looks good. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80104/new/ https://reviews.llvm.org/D80104

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

hans added a comment. In D79447#2041250 , @hans wrote: > > - Added assert in `emitDebugInfoForUDTs` to ensure no lowering can occur > > during UDT emission, as suggested by @rnk > > It seems we hit the assert in Chromium. Here's a reproducer: > https://b

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum updated this revision to Diff 264576. fallkrum added a reviewer: LLDB. fallkrum removed a subscriber: lldb-commits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 Files: lldb/source/Target/Thread.cpp Index: lldb/source/Target/Thread.

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum created this revision. fallkrum added reviewers: clayborg, jingham. fallkrum added a project: LLDB. Encountered the following situation: Let we started thread T1 and it hit breakpoint on B1 location. We suspended T1 and continued the process. Then we start

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

hans added a comment. > - Added assert in `emitDebugInfoForUDTs` to ensure no lowering can occur > during UDT emission, as suggested by @rnk It seems we hit the assert in Chromium. Here's a reproducer: https://bugs.chromium.org/p/chromium/issues/detail?id=1083877#c3 (I'll try to create a short

[Lldb-commits] [lldb] 525a591 - Revert 76c5f277f2 "Re-land [Debug][CodeView] Emit fully qualified names for globals"

Author: Hans Wennborg Date: 2020-05-18T11:26:30+02:00 New Revision: 525a591f0f48b9d54018bf5245f2abee09c9c1c8 URL: https://github.com/llvm/llvm-project/commit/525a591f0f48b9d54018bf5245f2abee09c9c1c8 DIFF: https://github.com/llvm/llvm-project/commit/525a591f0f48b9d54018bf5245f2abee09c9c1c8.diff