[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

jarin added a comment. Jim, do you think this is good to go? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

mib created this revision. mib added reviewers: friss, davide, jingham. mib added a project: LLDB. Herald added a subscriber: lldb-commits. This patch improves data formatting for CFDictionaryRef and CFSetRef. It uses the same data-formatter as NSCFDictionaries and NSCFSets introduced previously (

[Lldb-commits] [lldb] f058d39 - [lldb/test] Reformat Objective-C data-formatter source file (NFC)

Author: Med Ismail Bennani Date: 2020-05-07T05:51:52+02:00 New Revision: f058d397ff8e5a42bc7dd195cf7234d4d438a9f4 URL: https://github.com/llvm/llvm-project/commit/f058d397ff8e5a42bc7dd195cf7234d4d438a9f4 DIFF: https://github.com/llvm/llvm-project/commit/f058d397ff8e5a42bc7dd195cf7234d4d438a9f4.

[Lldb-commits] [PATCH] D79538: Add an XcodeSDK::GetSDKTypeForTriple function

aprantl created this revision. aprantl added reviewers: JDevlieghere, friss. This is something used in swift-lldb, but of general usefulness. https://reviews.llvm.org/D79538 Files: lldb/include/lldb/Utility/XcodeSDK.h lldb/source/Utility/XcodeSDK.cpp lldb/unittests/Utility/XcodeSDKTest.cp

[Lldb-commits] [PATCH] D79533: Reuse existing functionality in XcodeSDK::SDKSupportsModules (NFC)

aprantl created this revision. aprantl added a reviewer: JDevlieghere. https://reviews.llvm.org/D79533 Files: lldb/source/Utility/XcodeSDK.cpp Index: lldb/source/Utility/XcodeSDK.cpp === --- lldb/source/Utility/XcodeSDK.cpp +++ l

[Lldb-commits] [PATCH] D79384: Explicitly pass a module to register Xcode SDKs with to ParseXcodeSDK. Was: Add an API that allows iterating over a debug map's OSO's Modules

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG01fc85dc9618: ParseXcodeSDK: Register both the CU module and the SymbolFile module. (authored by aprantl). Herald added a

[Lldb-commits] [PATCH] D79384: Explicitly pass a module to register Xcode SDKs with to ParseXcodeSDK. Was: Add an API that allows iterating over a debug map's OSO's Modules

aprantl added a comment. Thanks, Pavel that was really helpful! Using cu->GetModule() indeed works, and is of course much cleaner. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79384/new/ https://reviews.llvm.org/D79384 ___ lldb-commits ma

[Lldb-commits] [lldb] 01fc85d - ParseXcodeSDK: Register both the CU module and the SymbolFile module.

Author: Adrian Prantl Date: 2020-05-06T16:46:22-07:00 New Revision: 01fc85dc9618394868b795c5087d9da03df9c58b URL: https://github.com/llvm/llvm-project/commit/01fc85dc9618394868b795c5087d9da03df9c58b DIFF: https://github.com/llvm/llvm-project/commit/01fc85dc9618394868b795c5087d9da03df9c58b.diff

[Lldb-commits] [PATCH] D79519: [lldb/Test] Run dotest.py with the Python LLDB was built with

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c6420e43178: [lldb/Test] Run dotest.py with the Python LLDB was built with. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [lldb] 7c6420e - [lldb/Test] Run dotest.py with the Python LLDB was built with.

Author: Jonas Devlieghere Date: 2020-05-06T14:57:44-07:00 New Revision: 7c6420e43178b0c03618f445fd008606a8b2c95e URL: https://github.com/llvm/llvm-project/commit/7c6420e43178b0c03618f445fd008606a8b2c95e DIFF: https://github.com/llvm/llvm-project/commit/7c6420e43178b0c03618f445fd008606a8b2c95e.d

[Lldb-commits] [PATCH] D79519: [lldb/Test] Run dotest.py with the Python LLDB was built with

aprantl accepted this revision. aprantl added a comment. That makes sense to me. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79519/new/ https://reviews.llvm.org/D79519 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D79519: [lldb/Test] Run dotest.py with the Python LLDB was built with

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79519/new/ https://reviews.llvm.org/D79519 ___ lldb-commits mail

[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0c08b7eac16: Move the Xcode SDK path caching to HostInfo (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D79364?vs=262184&id=262471#toc Repositor

[Lldb-commits] [PATCH] D79519: [lldb/Test] Run dotest.py with the Python LLDB was built with

JDevlieghere created this revision. JDevlieghere added reviewers: labath, aprantl, teemperor, mib. Herald added a subscriber: abidh. The Python used to run lit can be different from the Python LLDB was build with. One scenario where this happens is when LLVM can find the Python 3 interpreter, bu

[Lldb-commits] [lldb] f0c08b7 - Move the Xcode SDK path caching to HostInfo

Author: Adrian Prantl Date: 2020-05-06T13:43:50-07:00 New Revision: f0c08b7eac16cd380b0932cd8c0377f7daea2b4c URL: https://github.com/llvm/llvm-project/commit/f0c08b7eac16cd380b0932cd8c0377f7daea2b4c DIFF: https://github.com/llvm/llvm-project/commit/f0c08b7eac16cd380b0932cd8c0377f7daea2b4c.diff

[Lldb-commits] [PATCH] D79273: Add an explicit API to read the Xcode SDK DWARF attribute from compile units

aprantl closed this revision. aprantl added a comment. 5935227e11f5b8e7111ee4a076c10a62d0648689 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79273/new/ https://reviews.llvm.org/D79273

[Lldb-commits] [lldb] 5935227 - Add an explicit API to read the Xcode SDK DWARF attribute from compile units

Author: Adrian Prantl Date: 2020-05-06T13:16:16-07:00 New Revision: 5935227e11f5b8e7111ee4a076c10a62d0648689 URL: https://github.com/llvm/llvm-project/commit/5935227e11f5b8e7111ee4a076c10a62d0648689 DIFF: https://github.com/llvm/llvm-project/commit/5935227e11f5b8e7111ee4a076c10a62d0648689.diff

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

vsk added a comment. Thanks for working on this! Comment at: lldb/test/API/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp:21-22 + ++global; //% self.filecheck("image lookup -va $pc", "main.cpp", "-check-prefix=FUNC1-DESC") // FUNC1-DESC: name = "si

[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

labath added a comment. I forgot I wanted to respond to this part. In D78801#2014515 , @paolosev wrote: > The fact that the code address space is separated from the memory address > space is really what makes things complicated. However, we know for sure

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

labath marked 2 inline comments as done. labath added a comment. I should note that I did look into making an assembly file out of this, but that turned out to be more complicated than I expected and then David convinced me that it should be possible to write this in a way that prevents the opt

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

labath created this revision. labath added reviewers: vsk, djtodoro, dblaikie. Herald added a project: LLDB. This function rewrites the test to be (hopefully) less susceptible to codegen changes and re-enables it. The most interesting changes are: - use an __attribute__((optnone)) function inste

[Lldb-commits] [lldb] dee4cbc - [lldb][NFC] Remove some redundant comment containing just the file name

Author: Raphael Isemann Date: 2020-05-06T13:58:25+02:00 New Revision: dee4cbcd479f075ae33a8d3841fedde388c45782 URL: https://github.com/llvm/llvm-project/commit/dee4cbcd479f075ae33a8d3841fedde388c45782 DIFF: https://github.com/llvm/llvm-project/commit/dee4cbcd479f075ae33a8d3841fedde388c45782.dif

[Lldb-commits] [PATCH] D78809: [lldb] Warn the user about starting the --func-regex parameter with an asterisk

This revision was automatically updated to reflect the committed changes. Closed by commit rGaaf68cd9ce2f: [lldb] Warn the user about starting the --func-regex parameter with an asterisk (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [lldb] aaf68cd - [lldb] Warn the user about starting the --func-regex parameter with an asterisk

Author: Raphael Isemann Date: 2020-05-06T12:37:52+02:00 New Revision: aaf68cd9ce2fda224e02fd0f860e6372b4b00e47 URL: https://github.com/llvm/llvm-project/commit/aaf68cd9ce2fda224e02fd0f860e6372b4b00e47 DIFF: https://github.com/llvm/llvm-project/commit/aaf68cd9ce2fda224e02fd0f860e6372b4b00e47.dif

[Lldb-commits] [PATCH] D79404: Fix error handling after [] in 'frame variable'

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf5ed6dc59ec: Fix error handling after [] in 'frame variable' (authored by jarin, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [lldb] cf5ed6d - Fix error handling after [] in 'frame variable'

Author: Jaroslav Sevcik Date: 2020-05-06T11:03:46+02:00 New Revision: cf5ed6dc59ec8e416cca91c8145b1f09d891f130 URL: https://github.com/llvm/llvm-project/commit/cf5ed6dc59ec8e416cca91c8145b1f09d891f130 DIFF: https://github.com/llvm/llvm-project/commit/cf5ed6dc59ec8e416cca91c8145b1f09d891f130.dif

[Lldb-commits] [PATCH] D79384: Explicitly pass a module to register Xcode SDKs with to ParseXcodeSDK. Was: Add an API that allows iterating over a debug map's OSO's Modules

labath added a comment. Well... this is closer, but we should get rid of the Module argument. It's not consistent with the other SymbolFile functions, and also not necessary... Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:784-793 +// Register th

[Lldb-commits] [PATCH] D79364: Move the Xcode SDK path caching to HostInfo

labath added a comment. I think this is right, but it looks like you uploaded a diff based on the previous version of the patch instead of the master. In D79364#2020728 , @aprantl wrote: > Good point! The reason why I went with `Platform::GetHostPlatform