[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

clayborg added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py:353-354 'target create "%s"' % (program), -'br s -f main.c -l %d' % first_line, -'br s -f main.c -l %d' % second_lin

[Lldb-commits] [PATCH] D79209: [lldb/CommandInterpreter] Add CommandInterpreterRunResult (NFC)

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/lldb-enumerations.h:1084 }; + +enum CommandInterpreterResult { Add some header doc for these to explain a bit maybe si

[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

lanza added a comment. Sorry for bump to this old diff, but I agree with both Jim and Greg -- we shouldn't be importing your `~/.lldbinit`, but tests shouldn't depend on there never being another `br s`. This change should land as `breakpoint set`. Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

vsk updated this revision to Diff 261387. vsk added a comment. - Avoid heap memory management in "StringPrinterBufferPointer" entirely. - Rename "StringPrinterBufferPointer" to "DecodedCharBuffer", as that seems to more accurately reflect what the class is for. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D78712: [lldb/Host] Improve error messages on unowned read files

mib updated this revision to Diff 261384. mib added a comment. Removed redundant test. Refactored PlatformPOSIX following Jonas and Pavel's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78712/new/ https://reviews.llvm.org/D78712 Files:

[Lldb-commits] [PATCH] D79120: [lldb/API] Add RunCommandInterpreter overload that returns SBCommandInterpreterRunResults (NFC)

JDevlieghere updated this revision to Diff 261382. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79120/new/ https://reviews.llvm.org/D79120 Files: lldb/include/lldb/API/SBCommandInterpreterRunOptions.h lldb/include/lldb/API/SBDebugger.h

[Lldb-commits] [PATCH] D79209: [lldb/CommandInterpreter] Add CommandInterpreterRunResult (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, labath. JDevlieghere edited the summary of this revision. This patch adds a new class `CommandInterpreterRunResult` which will be backing the `SBCommandInterpreterRunResult`. It keeps track of the number of errors as wel

[Lldb-commits] [lldb] c286665 - [lldb] Remove lldb/lldb subdirectory

Author: Jonas Devlieghere Date: 2020-04-30T14:55:24-07:00 New Revision: c286665af337091bf749d881de5792f4fb7bd8e2 URL: https://github.com/llvm/llvm-project/commit/c286665af337091bf749d881de5792f4fb7bd8e2 DIFF: https://github.com/llvm/llvm-project/commit/c286665af337091bf749d881de5792f4fb7bd8e2.d

[Lldb-commits] [PATCH] D79115: [lldb/API] Move SBCommandInterpreterRunOption in its own header. (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b354039423f: [lldb/API] Move SBCommandInterpreterRunOption in its own header. (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D79115?vs

[Lldb-commits] [lldb] 4b35403 - [lldb/API] Move SBCommandInterpreterRunOption in its own header. (NFC)

Author: Jonas Devlieghere Date: 2020-04-30T13:41:21-07:00 New Revision: 4b354039423f2a4d50cf70564faf52d8bb8a6fe3 URL: https://github.com/llvm/llvm-project/commit/4b354039423f2a4d50cf70564faf52d8bb8a6fe3 DIFF: https://github.com/llvm/llvm-project/commit/4b354039423f2a4d50cf70564faf52d8bb8a6fe3.d

[Lldb-commits] [PATCH] D79108: [lldb/CommandInterpreter] Move AutoHandleEvents and SpawnThread into CommandInterpreterRunOptions (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG32c3224612d8: [lldb/CommandInterpreter] Move everything into CommandInterpreterRunOptions (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D791

[Lldb-commits] [lldb] 21afedd - [lldb/CMake] Use INSTALL_RPATH for tools and BUILD_RPATH for unittests.

Author: Jonas Devlieghere Date: 2020-04-30T13:20:06-07:00 New Revision: 21afeddfb25fbde260f84ee6ceaa61e761c1e48c URL: https://github.com/llvm/llvm-project/commit/21afeddfb25fbde260f84ee6ceaa61e761c1e48c DIFF: https://github.com/llvm/llvm-project/commit/21afeddfb25fbde260f84ee6ceaa61e761c1e48c.d

[Lldb-commits] [lldb] 32c3224 - [lldb/CommandInterpreter] Move everything into CommandInterpreterRunOptions

Author: Jonas Devlieghere Date: 2020-04-30T13:20:06-07:00 New Revision: 32c3224612d84ee7e65907795eaba505f5c90e7c URL: https://github.com/llvm/llvm-project/commit/32c3224612d84ee7e65907795eaba505f5c90e7c DIFF: https://github.com/llvm/llvm-project/commit/32c3224612d84ee7e65907795eaba505f5c90e7c.d

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

jingham added a comment. In D78972#2012796 , @labath wrote: > In D78972#2011571 , @jingham wrote: > > > That one does work all the way, including calling the function. That > > should be surprising. It shouldn't

[Lldb-commits] [PATCH] D79108: [lldb/CommandInterpreter] Move AutoHandleEvents and SpawnThread into CommandInterpreterRunOptions (NFC)

clayborg added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:1190 +options.SetAutoHandleEvents(auto_handle_events); +options.SetSpawnThread(spawn_thread); CommandInterpreter &interp = m_opaque_sp->GetCommandInterpreter(); I agree this i

[Lldb-commits] [PATCH] D79168: [lldb] Also set owning module for template specializations

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e9fb845fcc4: [lldb] Also set owning module for template specializations (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monore

[Lldb-commits] [lldb] 8e9fb84 - [lldb] Also set owning module for template specializations

Author: Raphael Isemann Date: 2020-04-30T20:40:13+02:00 New Revision: 8e9fb845fcc42648ffa8c0c5f331f9f2f298bc89 URL: https://github.com/llvm/llvm-project/commit/8e9fb845fcc42648ffa8c0c5f331f9f2f298bc89 DIFF: https://github.com/llvm/llvm-project/commit/8e9fb845fcc42648ffa8c0c5f331f9f2f298bc89.dif

[Lldb-commits] [lldb] 8539588 - [lldb/CMake] Set the PYTHON_RPATH for the unit tests

Author: Jonas Devlieghere Date: 2020-04-30T11:05:50-07:00 New Revision: 85395887837bd99689001404adcb08cd1e594cc0 URL: https://github.com/llvm/llvm-project/commit/85395887837bd99689001404adcb08cd1e594cc0 DIFF: https://github.com/llvm/llvm-project/commit/85395887837bd99689001404adcb08cd1e594cc0.d

[Lldb-commits] [lldb] 397e69d - [lldb/CMake] Don't make PYTHON_RPATH a required variable.

Author: Jonas Devlieghere Date: 2020-04-30T10:54:47-07:00 New Revision: 397e69dbcb49f89f12afbebf55bfe9db91bb612a URL: https://github.com/llvm/llvm-project/commit/397e69dbcb49f89f12afbebf55bfe9db91bb612a DIFF: https://github.com/llvm/llvm-project/commit/397e69dbcb49f89f12afbebf55bfe9db91bb612a.d

[Lldb-commits] [lldb] ae6d2ff - [lldb] fix RPATH when linking against Python3.framework

Author: Jonas Devlieghere Date: 2020-04-30T10:42:03-07:00 New Revision: ae6d2ff633a07a04aad62a0870afe28950472938 URL: https://github.com/llvm/llvm-project/commit/ae6d2ff633a07a04aad62a0870afe28950472938 DIFF: https://github.com/llvm/llvm-project/commit/ae6d2ff633a07a04aad62a0870afe28950472938.d

[Lldb-commits] [lldb] b3180d6 - [lldb] Re-add deleted RUN line in module-ownership.mm

Author: Raphael Isemann Date: 2020-04-30T19:29:50+02:00 New Revision: b3180d6a1ad24e890dfe7d97407edc1b3e74b755 URL: https://github.com/llvm/llvm-project/commit/b3180d6a1ad24e890dfe7d97407edc1b3e74b755 DIFF: https://github.com/llvm/llvm-project/commit/b3180d6a1ad24e890dfe7d97407edc1b3e74b755.dif

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

labath added a comment. In D78972#2011571 , @jingham wrote: > That one does work all the way, including calling the function. That should > be surprising. It shouldn't with an unpatched lldb, right? Yep, I realized that is not the best example after

[Lldb-commits] [PATCH] D79174: [LLDB] Initialize "ThreadPlanTracer::m_thread" to avoid undefined behavior

vangelists created this revision. vangelists added a reviewer: jingham. vangelists added a project: LLDB. Herald added a subscriber: lldb-commits. The `m_thread` field of `ThreadPlanTracer` is not initialized by the constructor leading to undefined behavior in `ThreadPlanTracer::GetThread()`. R

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

labath added a comment. Sorry for the overly long post. I tried to reply to all messages from last night. I don't claim that all of my comments are consistent with one another -- that's a reflection of the fact that I really don't know what is the right solution... In D78801#2010713

[Lldb-commits] [PATCH] D79120: [lldb/API] Add RunCommandInterpreter overload that returns SBCommandInterpreterRunResults (NFC)

labath added a comment. Here I would be interested to know whether the "stop reasons" are mutually exclusive? It sounds like they should be... And if they are, it seems that a better way to express this would be via something like `GetRunResult` which returns `Success`, or `InferiorCrash`, or

[Lldb-commits] [PATCH] D79108: [lldb/CommandInterpreter] Move AutoHandleEvents and SpawnThread into CommandInterpreterRunOptions (NFC)

labath accepted this revision. labath added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:1189-1190 if (m_opaque_sp) { +options.SetAutoHandleEvents(auto_handle_events); +options.SetSpawnThread(spawn_thread); CommandInterpreter &interp = m_opaque_sp->