[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

clayborg added a comment. In D78825#2002598 , @vsk wrote: > Can we delete an override of SBDebugger::RunCommandInterpreter, or are they > all part of the stable API? If we can, it'd be nice to get rid of the one > with 6 args. We can't remove any exist

[Lldb-commits] [lldb] a58b62b - [IR] Replace all uses of CallBase::getCalledValue() with getCalledOperand().

Author: Craig Topper Date: 2020-04-27T22:17:03-07:00 New Revision: a58b62b4a2b96c31b49338b262b609db746449e8 URL: https://github.com/llvm/llvm-project/commit/a58b62b4a2b96c31b49338b262b609db746449e8 DIFF: https://github.com/llvm/llvm-project/commit/a58b62b4a2b96c31b49338b262b609db746449e8.diff

[Lldb-commits] [PATCH] D75607: [lldb] Use llvm::MC for register numbers in AArch64 ABIs

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Looks good to me. Tested on AArch64/Linux with no regressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75607/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

davide added a comment. Saleem is the right person to review this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78972/new/ https://reviews.llvm.org/D78972 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

davide added a comment. I'm really worried about this change -- and we should think about it very carefully because it might cause the LLVM verifier to freak out -- or even worse, causing random crashes when executing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

davide added a comment. Weak functions can actually be overridden -- I'm really wondering whether this causes issues here. Do you have an example [even if it's in swift] of a symbol that's not exported correctly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

paolosev added a comment. Thanks for your comments! I have refactored this code in a separate patch, https://reviews.llvm.org/D78978, removing WasmProcessGDBRemote, moving part of the logic into ProcessGDBRemote but still keeping class UnwindWasm. Let me know what you think... Repository: rG

[Lldb-commits] [PATCH] D78978: [LLDB] Add support for WebAssembly debugging

paolosev created this revision. paolosev added reviewers: labath, clayborg. paolosev added a project: LLDB. Herald added subscribers: lldb-commits, sunfish, aheejin, jgravelle-google, sbc100, aprantl, mgorny, dschuff. paolosev edited the summary of this revision. This patch is a refactoring of h

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

jingham created this revision. jingham added a reviewer: JDevlieghere. jingham added a project: LLDB. Herald added a subscriber: lldb-commits. The way both the REPL and the --top-level mode of the expression parser work is that they compile and JIT the code the user provided, and then look throug

[Lldb-commits] [PATCH] D78839: [lldb-vscode] Add an option for loading core files

wallace updated this revision to Diff 260501. wallace added a comment. Added a test, which was easier than I thought! I tested it on mac as well, so I hope it'll work well on the buildbots. I also removed that bad use of auto. It seems that all StringRefs gotten from the JSON object are null-ter

[Lldb-commits] [lldb] 4d40d66 - Fix up a clang-tidy nit about using empty rather than size == 0.

Author: Eric Christopher Date: 2020-04-27T15:22:44-07:00 New Revision: 4d40d6640238a8d304c39603a4938de85301fcba URL: https://github.com/llvm/llvm-project/commit/4d40d6640238a8d304c39603a4938de85301fcba DIFF: https://github.com/llvm/llvm-project/commit/4d40d6640238a8d304c39603a4938de85301fcba.di

[Lldb-commits] [PATCH] D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f5beb4c4b11: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets. (authored by mib). Changed prior to commit: https://reviews.llvm.org/D78396?vs=260012&id=260447#toc Repository:

[Lldb-commits] [lldb] 8f5beb4 - [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets.

Author: Med Ismail Bennani Date: 2020-04-27T22:10:11+02:00 New Revision: 8f5beb4c4b114f2cd827b10b5358f0d79d8bb691 URL: https://github.com/llvm/llvm-project/commit/8f5beb4c4b114f2cd827b10b5358f0d79d8bb691 DIFF: https://github.com/llvm/llvm-project/commit/8f5beb4c4b114f2cd827b10b5358f0d79d8bb691.

[Lldb-commits] [lldb] 58435f6 - [lldb] Fix windows build break from 18e96a31

Author: Pavel Labath Date: 2020-04-27T19:22:44+02:00 New Revision: 58435f69cb0db54e7a76d47101bbc5e74cb5c31c URL: https://github.com/llvm/llvm-project/commit/58435f69cb0db54e7a76d47101bbc5e74cb5c31c DIFF: https://github.com/llvm/llvm-project/commit/58435f69cb0db54e7a76d47101bbc5e74cb5c31c.diff

[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:1205-1209 options.ref()); num_errors = interp.GetNumErrors(); quit_requested = interp.GetQuitRequested();

[Lldb-commits] [lldb] 18e96a3 - [lldb/unittests] Skip IPv6 test on systems which don't have IPv6 configured

Author: Pavel Labath Date: 2020-04-27T17:33:20+02:00 New Revision: 18e96a31fe0214eb435e131e6ff585a899694576 URL: https://github.com/llvm/llvm-project/commit/18e96a31fe0214eb435e131e6ff585a899694576 DIFF: https://github.com/llvm/llvm-project/commit/18e96a31fe0214eb435e131e6ff585a899694576.diff

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

labath added a comment. Thanks for elaborating. Responses inline. In D77043#1998621 , @omjavaid wrote: > In D77043#1996983 , @labath wrote: > > > Where does the option which I proposed fit in? It sounds like it wou

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

labath added a comment. Yes, having main_unit come first seems reasonably hierarchical. I'm still unsure as to whether lldb_private::CompileUnit would not be better, but let's have a look at this first... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] ff5264f - [lldb][cmake] Move the remove_module_flags call to the right place in debugserver's CMakeLists

Author: Raphael Isemann Date: 2020-04-27T16:04:19+02:00 New Revision: ff5264f0c6f026b25e2d91d0f5d5377a156c1f40 URL: https://github.com/llvm/llvm-project/commit/ff5264f0c6f026b25e2d91d0f5d5377a156c1f40 DIFF: https://github.com/llvm/llvm-project/commit/ff5264f0c6f026b25e2d91d0f5d5377a156c1f40.dif

[Lldb-commits] [PATCH] D75241: [lldb] Adjust TestExec code to be closer to real world code

This revision was automatically updated to reflect the committed changes. Closed by commit rGd00eaa082b7c: [lldb] Adjust TestExec code to be closer to real world code (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D75241?vs=246911&id=260303#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

labath added a comment. In D78801#2004501 , @paolosev wrote: > My initial idea was to keep all the Wasm-related code as much as possible > isolated in plugin classes. While I would definitely like to see that happen, I don't think the current approach

[Lldb-commits] [lldb] d00eaa0 - [lldb] Adjust TestExec code to be closer to real world code

Author: Raphael Isemann Date: 2020-04-27T14:57:12+02:00 New Revision: d00eaa082b7cd6ada106ed01751abce65abd6dd8 URL: https://github.com/llvm/llvm-project/commit/d00eaa082b7cd6ada106ed01751abce65abd6dd8 DIFF: https://github.com/llvm/llvm-project/commit/d00eaa082b7cd6ada106ed01751abce65abd6dd8.dif

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

labath added a comment. In D78801#2004248 , @clayborg wrote: > So a few things here. It doesn't seem like it is necessary to create the > WasmProcessGDBRemote and IWasmProcess. It would be fine to extend the current > ProcessGDBRemote and ThreadGDBRemote

[Lldb-commits] [PATCH] D78839: [lldb-vscode] Add an option for loading core files

labath added a comment. In D78839#2004278 , @clayborg wrote: > You might look around for a core file in another test location and be able to > use that. Yep, there's plenty to choose from in `test/API/functionalities/postmortem/elf-core/`. =

[Lldb-commits] [PATCH] D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets

labath added a comment. That seems acceptable (though definitely not ideal), given that this is objc code, and probably no big endian machine will ever be running or debugging objc code... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78396/new/

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Thanks for getting this fixed. Looks good now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462

[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

labath added a comment. In D78825#2002598 , @vsk wrote: > Can we delete an override of SBDebugger::RunCommandInterpreter, or are they > all part of the stable API? They are. The way that has been handled so far is that once a function starts to get too

[Lldb-commits] [PATCH] D78882: [IR] Replace all uses of CallBase::getCalledValue() with getCalledOperand().

craig.topper created this revision. craig.topper added a reviewer: dblaikie. Herald added subscribers: lldb-commits, cfe-commits, Kayjukh, frgossen, grosul1, dantrushin, Joonsoo, kerbowa, liufengdb, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilache, antiagainst, shauheen, jpienaar, rriddl

[Lldb-commits] [PATCH] D78882: [IR] Replace all uses of CallBase::getCalledValue() with getCalledOperand().

ftynse accepted this revision. ftynse added a comment. This revision is now accepted and ready to land. LGTM for MLIR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78882/new/ https://reviews.llvm.org/D78882 __

[Lldb-commits] [PATCH] D78825: [lldb/Driver] Exit with a non-zero exit code in batch mode when stopping because of an error.

labath added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:1205-1209 options.ref()); num_errors = interp.GetNumErrors(); quit_requested = interp.GetQuitRequested(); stopped_for_crash = interp.GetStoppedForCrash(); +

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

This revision was automatically updated to reflect the committed changes. Closed by commit rG84c398d375d9: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a… (authored by aleksandr.urakov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

aleksandr.urakov updated this revision to Diff 260235. aleksandr.urakov added a comment. Exactly! Removed unneeded wrapper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78697/new/ https://reviews.llvm.org/D78697 Files: lldb/source/Plugins/TypeS

[Lldb-commits] [lldb] 84c398d - [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

Author: Aleksandr Urakov Date: 2020-04-27T11:08:19+03:00 New Revision: 84c398d375d9f3b0c2ce2a755dbaa57500e3f8ec URL: https://github.com/llvm/llvm-project/commit/84c398d375d9f3b0c2ce2a755dbaa57500e3f8ec DIFF: https://github.com/llvm/llvm-project/commit/84c398d375d9f3b0c2ce2a755dbaa57500e3f8ec.di

[Lldb-commits] [PATCH] D78808: [lldb] Improve error message when --func-regex parameter for the breakpoint command is invalid

This revision was automatically updated to reflect the committed changes. Closed by commit rGb58af8d254ee: [lldb] Improve error message when --func-regex parameter for the breakpoint… (authored by teemperor). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] b58af8d - [lldb] Improve error message when --func-regex parameter for the breakpoint command is invalid

Author: Raphael Isemann Date: 2020-04-27T09:55:06+02:00 New Revision: b58af8d254ee1b1a7d2806b1fdfe295df925748a URL: https://github.com/llvm/llvm-project/commit/b58af8d254ee1b1a7d2806b1fdfe295df925748a DIFF: https://github.com/llvm/llvm-project/commit/b58af8d254ee1b1a7d2806b1fdfe295df925748a.dif