[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

2020-04-26 Thread Paolo Severini via Phabricator via lldb-commits
paolosev updated this revision to Diff 260216. paolosev added a comment. I am adding all the pieces to this patch to make the whole picture clearer; I thought to add a piece at the time to simplify reviews, but probably it ended up making things more obscure. I can always split this patch later

[Lldb-commits] [PATCH] D78839: [lldb-vscode] Add an option for loading core files

2020-04-26 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. You might look around for a core file in another test location and be able to use that. Functionality looks good to me. This could have been done with attachCommands before, but it is nice to have a built in and supported way to do this. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D78801: [LLDB] Add class ProcessWasm for WebAssembly debugging

2020-04-26 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. So a few things here. It doesn't seem like it is necessary to create the WasmProcessGDBRemote and IWasmProcess. It would be fine to extend the current ProcessGDBRemote and ThreadGDBRemote classes. The whole reason seems to be that the variables (globals, locals, etc) a